GNU bug report logs - #75626
31.0.50; Dired misses or double-processes files when auto-revert-mode is enabled

Previous Next

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 75626 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, Tassilo Horn <tsdh <at> gnu.org>
Subject: bug#75626: 31.0.50; Dired misses or double-processes files when auto-revert-mode is enabled
Date: Wed, 05 Feb 2025 03:25:44 +0100

Hello Michael,

> Michael Albinus <michael.albinus <at> gmx.de> writes:
>
> Hi Tassilo,
>
> > Thanks. I'll polish the patch, and if nobody objects, I'll push it to
> > master in a couple of days.
>
> Pushed to master.

Sorry for being late, have been a bit distracted.  Allow only one
question please:

| +  (defmacro inhibit-auto-revert (&rest body)
| +    "Deactivate auto-reverting of current buffer temporarily.
| +Run BODY."
| +    (declare (indent 0) (debug ((form body) body)))

What's the purpose of this debug spec - why not just "body"?

| +       (let ((buf (and (not (memq (current-buffer) inhibit-auto-revert-buffers))
| +                       (current-buffer))))
| +         (unwind-protect
| +             (progn
| +               (when buf (add-to-list 'inhibit-auto-revert-buffers buf))
| +               ,@body)

I think at least in this part where body is inserted the variable BUF
should be uninterned for the obvious reason.  Or at least have a more
obscure name.


Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.