GNU bug report logs - #75626
31.0.50; Dired misses or double-processes files when auto-revert-mode is enabled

Previous Next

Full log

Message #304 received at 75626-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, Eli Zaretskii <eliz <at> gnu.org>,
 75626-done <at> debbugs.gnu.org
Subject: Re: bug#75626: 31.0.50; Dired misses or double-processes files when
 auto-revert-mode is enabled
Date: Sun, 02 Feb 2025 18:22:21 +0100

[Message part 1 (text/plain, inline)]

Tassilo Horn <tsdh <at> gnu.org> writes:

Hi Tassilo,

> That's the part I don't understand, yet.  Auto-reverts are skipped by
> auto-revert-handler now for buffers in inhibit-auto-revert-buffers.
> That's what I had expected and did in my previous inhibit-auto-revert
> patch, too.
>
> But my reading of the code is that the polling timer calls
>
>   auto-revert-buffers -> auto-revert-buffer -> auto-revert-handler
>
> where auto-revert-buffer now removes the inhibited buffer from
> auto-revert-buffer-list.  So in addition to skipping it in
> auto-revert-handler this time, the future polling rounds won't see it
> anymore, too, because auto-revert--buffer-candidates uses
> auto-revert--polled-buffers which is basically auto-revert-buffer-list +
> auto-revert-remaining-buffers, at least if global-auto-revert-mode isn't
> used.
>
> So when you say "we disable auto-reverting for a given time" where I
> assume "given time" is not "forever", what am I missing?  If anything, I
> would expect that auto-revert-buffer pushes the inhibited buffer onto
> auto-revert-remaining-buffers to prioritize it for next time.

Below is an updated patch for autorevert.el. I control this now via
auto-revert-active-p; no further need to check in auto-revert-buffer.

Could you, pls, test?

> Bye,
> Tassilo

Best regards, Michael.

[Message part 2 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.