GNU bug report logs - #75626
31.0.50; Dired misses or double-processes files when auto-revert-mode is enabled

Previous Next

Full log

Message #289 received at 75626-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, Eli Zaretskii <eliz <at> gnu.org>,
 75626-done <at> debbugs.gnu.org
Subject: Re: bug#75626: 31.0.50; Dired misses or double-processes files when
 auto-revert-mode is enabled
Date: Sun, 02 Feb 2025 12:39:39 +0100

[Message part 1 (text/plain, inline)]

Tassilo Horn <tsdh <at> gnu.org> writes:

Hi Tassilo,

> It works for me and my original problem, too.  Some questions, though.

Thanks.

> Why is the macro inhibit-auto-revert defined in a progn?  I think, I've
> never seen that before.

This is a trick to bring the defmacro body into loaddefs.el. See also
the declaration of define-short-documentation-group, for example.

> And why does dired-buffer-stale-p check if the current dired buffer is
> member of inhibit-auto-revert-buffers?  Isn't the point to move the
> allowance check from packages' buffer-stale-function to auto-revert
> itself?  In that case, the buffer-read-only check (set by wdired-mode)
> should probably also be rewritten to add the currently edited dired
> buffer to inhibit-auto-revert-buffers and to remove it when wdired-mode
> is deactivated (wdired-finish-edit).

Yes, I've moved the check of a buffer being member of
inhibit-auto-revert-buffers to autorevert.el, see patch below. Thanks
for the heads-up.

> Furthermore, the member check in auto-revert-buffer causes this buffer
> to be removed from auto-revert-buffer-list meaning it will never ever be
> reverted in the future, at least not by polling.

Yes, and this is intended. We disable auto-reverting for a given
time. With consequences.

> Bye,
> Tassilo

Best regards, Michael.

[Message part 2 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.