GNU bug report logs - #75580
30.0.93; statements inside string interpolation for csharp modes are fontified incorrectly

Previous Next

Package: emacs;

Reported by: Sami Batuhan Basmaz Ölmez <sb.basmazolmez <at> gmail.com>

Date: Wed, 15 Jan 2025 14:37:01 UTC

Severity: minor

Found in version 30.0.93

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75580: closed (30.0.93;  statements inside string
 interpolation for csharp modes are fontified incorrectly)
Date: Sat, 08 Feb 2025 10:57:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 08 Feb 2025 12:55:33 +0200
with message-id <86frko3dui.fsf <at> gnu.org>
and subject line Re: bug#75580: 30.0.93; statements inside string interpolation for csharp modes are fontified incorrectly
has caused the debbugs.gnu.org bug report #75580,
regarding 30.0.93;  statements inside string interpolation for csharp modes
 are fontified incorrectly
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75580: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75580
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Sami Batuhan Basmaz Ölmez <sb.basmazolmez <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.93;
  statements inside string interpolation for csharp modes
 are fontified incorrectly
Date: Wed, 15 Jan 2025 08:02:50 +0000
[Message part 3 (text/plain, inline)]
An interpolated string `$"string content {myFunction(myVariable)}
another string content"` are highlighted incorrectly as expressions
inside brackets are also fontified with string face for csharp-mode and
csharp-ts-mode. They should be fontified like statements.
Interpolation occurs inside curly braces.


In GNU Emacs 30.0.93 (build 1, x86_64-w64-mingw32) of 2024-12-23
Repository revision: 68bcabf58afddb377d172857ce7648ad3ff09618
Repository branch: worktree
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.5371)

Configured using:
 'configure --prefix=C:/msys64/mingw64/ --without-compress-install
 --without-dbus --with-tree-sitter --with-rsvg --without-imagemagick
 --without-gsettings --with-mailutils --with-native-compilation
 --with-modules --with-wide-int 'CFLAGS=-O3 -ffast-math
 -frename-registers -funroll-loops -mtune=native -march=native
 -fomit-frame-pointer -fallow-store-data-races
 -fno-semantic-interposition -floop-parallelize-all
 -ftree-parallelize-loops=4 -fno-finite-math-only''

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252

Major mode: C#

Minor modes in effect:
  windmove-mode: t
  tab-bar-echo-area-mode: t
  lsp-diagnostics-mode: t
  lsp-headerline-breadcrumb-mode: t
  lsp-modeline-workspace-status-mode: t
  lsp-modeline-diagnostics-mode: t
  lsp-lens-mode: t
  lsp-ui-mode: t
  lsp-ui-doc-mode: t
  lsp-ui-sideline-mode: t
  flycheck-mode: t
  treemacs-filewatch-mode: t
  treemacs-follow-mode: t
  treemacs-git-mode: t
  treemacs-fringe-indicator-mode: t
  lsp-completion-mode: t
  lsp-semantic-tokens-mode: t
  lsp-inlay-hints-mode: t
  lsp-managed-mode: t
  lsp-mode: t
  display-line-numbers-mode: t
  rainbow-delimiters-mode: t
  colorful-mode: t
  jinx-mode: t
  org-remark-global-tracking-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  vertico-multiform-mode: t
  vertico-mode: t
  global-treesit-auto-mode: t
  treesit-explore-mode: t
  projectile-mode: t
  meow-global-mode: t
  meow-mode: t
  meow-normal-mode: t
  meow-esc-mode: t
  dirvish-override-dired-mode: t
  corfu-popupinfo-mode: t
  corfu-history-mode: t
  global-corfu-mode: t
  corfu-mode: t
  which-key-mode: t
  marginalia-mode: t
  spacious-padding-mode: t
  parrot-mode: t
  nyan-mode: t
  nerd-icons-completion-mode: t
  global-hl-todo-mode: t
  hl-todo-mode: t
  doom-modeline-mode: t
  global-auto-revert-mode: t
  electric-pair-mode: t
  file-painter-global-mode: t
  repeat-mode: t
  savehist-mode: t
  recentf-mode: t
  save-place-mode: t
  global-beacon-fast-mode: t
  beacon-fast-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  minibuffer-regexp-mode: t
  size-indication-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Memory information:
((conses 16 1305305 2175637) (symbols 48 61953 15)
 (strings 32 401939 75182) (string-bytes 1 12092377)
 (vectors 16 96100) (vector-slots 8 1212741 1026826)
 (floats 8 820 15766) (intervals 56 23422 7039) (buffers 992 31))
[Message part 4 (text/html, inline)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: theo <at> thornhill.no, casouri <at> gmail.com, jostein <at> fastmail.fm,
 sb.basmazolmez <at> gmail.com, 75580-done <at> debbugs.gnu.org
Subject: Re: bug#75580: 30.0.93; statements inside string interpolation for
 csharp modes are fontified incorrectly
Date: Sat, 08 Feb 2025 12:55:33 +0200
> Date: Sat, 1 Feb 2025 22:20:54 +0100
> Cc: Yuan Fu <casouri <at> gmail.com>, sb.basmazolmez <at> gmail.com,
>  75580 <at> debbugs.gnu.org, theo <at> thornhill.no, jostein <at> kjonigsen.net
> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> 
> On 2/1/25 13:06, Jostein Kjønigsen wrote:
> > I don’t remember exactly why things ended up the way they did to be honest.
> >
> > I tried tweaking around with the rules to see if I could get better results, but ended up with different kinds of regressions.
> 
> I had time for a little effort. :)
> 
> Attached is a pretty minimal patch which seems to work for me. I've 
> guarded the changes behind a grammar-check, but I must admit I'm not 
> sure if that is needed or not.
> 
> Basically I remove the override, and add more specific rules for the 
> parts which goes "missing" without it.
> 
> Anyone have any opinions on the form of patch? Anyone want to do any 
> additional testing?
> 
> Let me know! If not, I guess Eli you can install this at your own leisure.

Thanks, installed on the master branch, and closing the bug.


This bug report was last modified 160 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.