GNU bug report logs - #75576
[PATCH] Take the tab-line into account when computing the window edges

Previous Next

Full log

Message #11 received at 75576 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: martin rudalics <rudalics <at> gmx.at>, Steven Allen <steven <at> stebalien.com>,
 75576 <at> debbugs.gnu.org
Subject: Re: bug#75576: [PATCH] Take the tab-line into account when
 computing the window edges
Date: Wed, 15 Jan 2025 19:11:58 +0200

> This was causing EXWM to mis-calculate the window height when centaur
> tabs were used. See https://github.com/emacs-exwm/exwm/pull/114.

Eli, is this patch eligible to be installed on the emacs-30 release branch?

Also Cc-ing Martin.

> From e9796ff62f2c561cb2797c3040ef88aa80a95500 Mon Sep 17 00:00:00 2001
> From: Steven Allen <steven <at> stebalien.com>
> Date: Tue, 14 Jan 2025 23:56:08 -0800
> Subject: [PATCH] Take the tab-line into account when computing the window
>  edges
>
> window-body-height correctly subtracts the tab-line's height but
> window-edges did not add this same height to the y-offset.
>
> See https://github.com/emacs-exwm/exwm/pull/114
>
> * lisp/window.el (window-edges): Add the tab-line-height to the y-offet
> of the window body.  (Bug#75576)
> ---
>  lisp/window.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/window.el b/lisp/window.el
> index 886128c7daa..b91c45226a1 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -3828,7 +3828,8 @@ window-edges
>  	 (top-body
>  	  (when body
>  	    (+ (window-pixel-top window) border-width
> -	       (window-header-line-height window))))
> +	       (window-header-line-height window)
> +	       (window-tab-line-height window))))
>  	 (right (+ left (if pixelwise
>  			    (window-pixel-width window)
>  			  (window-total-width window))))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.