From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 03:03:45 2025 Received: (at submit) by debbugs.gnu.org; 15 Jan 2025 08:03:45 +0000 Received: from localhost ([127.0.0.1]:56873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXyNN-00074j-FE for submit@debbugs.gnu.org; Wed, 15 Jan 2025 03:03:45 -0500 Received: from lists.gnu.org ([2001:470:142::17]:40540) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tXyNL-00074S-86 for submit@debbugs.gnu.org; Wed, 15 Jan 2025 03:03:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXyNE-000740-So for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2025 03:03:37 -0500 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXyNC-0002ZG-Vm for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2025 03:03:36 -0500 Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id 781FF13801C4 for ; Wed, 15 Jan 2025 03:03:31 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Wed, 15 Jan 2025 03:03:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1736928211; x=1737014611; bh=BG6Cctlu6pT2vRaJN7tiwI2eFth6TQZs oDow4X+4CHE=; b=Yx+fGqZiDtlq5mx7dcmeQ3rker0OxlOHZKaQ6tE6CqxZw9L7 Wu8bmyK0dv2SXSSMKTEbm5p7b3Q0O/RbuzQ8hytzUQoX0zYnqNZZW5d8piek7ehN jpXHutUJ228iJkKUV8ewBPmkdxO+N2DoXpT7dX35za5cMuBzLMspjJHyzQk9M8R+ kmBpHh4JzJizvoXL4YDm8dHSdzYzc3PWQ++ZKaRJRXxyfDR7YkXK74BN6eFNRqBU e14s+YjvY2gGu3AhFjNQTlIK48cNdLkVr4qQMiCxY3DXemeccPe3w5iZq6H2G2p6 7kQ0KGjfgRvJUyME5xqxlWuxREq7rymv9dvv5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1736928211; x= 1737014611; bh=BG6Cctlu6pT2vRaJN7tiwI2eFth6TQZsoDow4X+4CHE=; b=D /udLHZ4lOhjEN0y1677+0jGyub8BPBuSi0mHubQitslyOEVZwAuoXnotePb+BCw2 R6zXX7WA2AbQiKeEJAyDfu3PKdZjoCCt7i/XDLy5FvHdpDAbSv7hqXSLHuOouPOc gqEgS+Fm52fNv7gyfGAHhMASzHvF75O1pX93skrLP7Yz15tkjeMwl/4+ZKIQjxq+ Qu4W8TZ5th1OQrcwEeTOVXMOk4yGg/5gzobbgivSytKnS8RNNLlLogFDtCV8FKUx Qu3lp1Iik+ag2obzNY7VjeewEyKquWp40u6QmH+THN6JjpbsOYU/0tPzsClExWzB 4nHlkC+CdspvQPFsczzzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudehjedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvuf ffkfggtgesmhdtreertddttdenucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshht vghvvghnsehsthgvsggrlhhivghnrdgtohhmqeenucggtffrrghtthgvrhhnpeetkeeuie dtgffguedvudfhieevgfeltddufeevgedtvddvgedtveekffelffdvveenucffohhmrghi nhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggprhgt phhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqd gvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 15 Jan 2025 03:03:30 -0500 (EST) From: Steven Allen To: bug-gnu-emacs@gnu.org Subject: [PATCH] Take the tab-line into account when computing the window edges X-Debbugs-Cc: Date: Wed, 15 Jan 2025 00:03:29 -0800 Message-ID: <87ikqgtsfi.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=103.168.172.144; envelope-from=steven@stebalien.com; helo=fout-a1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain Tags: patch This was causing EXWM to mis-calculate the window height when centaur tabs were used. See https://github.com/emacs-exwm/exwm/pull/114. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Take-the-tab-line-into-account-when-computing-the-wi.patch >From 00400301d384d4827acc763c7847d8bc2516702f Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Tue, 14 Jan 2025 23:56:08 -0800 Subject: [PATCH] Take the tab-line into account when computing the window edges window-body-height correctly subtracts the tab-line's height but window-edges did not add this same height to the y-offset. See https://github.com/emacs-exwm/exwm/pull/114 * lisp/window.el (window-edges): Add the tab-line-height to the y-offet of the window body. --- lisp/window.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/window.el b/lisp/window.el index 886128c7daa..47c92fdcd42 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -3828,7 +3828,8 @@ window-edges (top-body (when body (+ (window-pixel-top window) border-width - (window-header-line-height window)))) + (window-header-line-height window) + (window-tab-line-height window)))) (right (+ left (if pixelwise (window-pixel-width window) (window-total-width window)))) -- 2.48.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 03:10:37 2025 Received: (at 75576) by debbugs.gnu.org; 15 Jan 2025 08:10:37 +0000 Received: from localhost ([127.0.0.1]:56887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXyU1-0007Sv-BS for submit@debbugs.gnu.org; Wed, 15 Jan 2025 03:10:37 -0500 Received: from fhigh-a5-smtp.messagingengine.com ([103.168.172.156]:33405) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tXyTy-0007Sb-L2 for 75576@debbugs.gnu.org; Wed, 15 Jan 2025 03:10:35 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4070C11401BA for <75576@debbugs.gnu.org>; Wed, 15 Jan 2025 03:10:28 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Wed, 15 Jan 2025 03:10:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1736928628; x=1737015028; bh=MWXwOLd2mC +tdxmxb3Y9ZD5lQ9fgVV5AGNHzRuOLyG0=; b=k2w0PX3RKXbAJph9y+y6nH3vMM Q0Jezy/SiDGigE1mPD1XaU8leyqdtLEZBPZ4h4jgMDukYbwpmcLU/y9C+uNQpckL BGmT7fgyT8UDn2SeKfmmlkZtRX5YiL0cxZvX3hCQUiUADQh6UwOvj8NzLV5Gb7jD Wd0bOJv2Ed3v4GzfafSZwzNxZ7IkXgv6rmMEGeJF9xT+pvQGzqepgMzPpv0/F5wD zV6nmhAtjQFR05S0dMb/3PHIYgc3G4FOyRE+FaW/2/SghSyoZRHEylfx1z9tLEsG s1icPLAfSTEPJy3hXgkWB5WWwVDECzfVTj0U7fRHnPhm4HYGwa5ACmxQoGeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1736928628; x=1737015028; bh=MWXwOLd2mC+tdxmxb3Y9ZD5lQ9fgVV5AGNH zRuOLyG0=; b=QTGTFb3NDsEzr09YQZtPLdM2Hj50aki4xa9s3tm9OzQubnfA9KA 3sAcz1rsMjRvKzkHdP5aaw+e/AhZC+X8Wj+uWnkOKI8lorGWLmZwaSbLNDGZoemT T2LSmuDaLWwzwlntAIkW19yJ6jzBBiUBmH7NgtrayeSklbHDp+nwSNoCifCPmQDq 4Ox6j9oNwEJVwvtBPrCjS8STZPpVCCiXwlSlkbROxubH6aZ5v8LoyS5HClcU/1s3 TeTB0mvBTyRlyfsf4wa/V+TD+jGsuHAfVTwlG8e/3w4mfh8dw4radKdXwRLy75uQ 0fIR5apauXFgIjkr+GUXH9ErjAZUKaztbLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudehjedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvuf gjfhffkfggtgesmhdtreertddttdenucfhrhhomhepufhtvghvvghnucetlhhlvghnuceo shhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmqeenucggtffrrghtthgvrhhnpeduff fghfefheegtdffuedujeekudelkeeiueefgeevhfeufffhhefhfeevvdejgfenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsthgvvhgvnhessh htvggsrghlihgvnhdrtghomhdpnhgspghrtghpthhtohepuddpmhhouggvpehsmhhtphho uhhtpdhrtghpthhtohepjeehheejieesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <75576@debbugs.gnu.org>; Wed, 15 Jan 2025 03:10:27 -0500 (EST) From: Steven Allen To: 75576@debbugs.gnu.org Subject: Re: bug#75576: Acknowledgement ([PATCH] Take the tab-line into account when computing the window edges) In-Reply-To: References: <87ikqgtsfi.fsf@stebalien.com> Date: Wed, 15 Jan 2025 00:10:26 -0800 Message-ID: <87frlkts3x.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75576 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Fixed whitespace and referenced the bug report. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Take-the-tab-line-into-account-when-computing-the-wi.patch >From e9796ff62f2c561cb2797c3040ef88aa80a95500 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Tue, 14 Jan 2025 23:56:08 -0800 Subject: [PATCH] Take the tab-line into account when computing the window edges window-body-height correctly subtracts the tab-line's height but window-edges did not add this same height to the y-offset. See https://github.com/emacs-exwm/exwm/pull/114 * lisp/window.el (window-edges): Add the tab-line-height to the y-offet of the window body. (Bug#75576) --- lisp/window.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/window.el b/lisp/window.el index 886128c7daa..b91c45226a1 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -3828,7 +3828,8 @@ window-edges (top-body (when body (+ (window-pixel-top window) border-width - (window-header-line-height window)))) + (window-header-line-height window) + (window-tab-line-height window)))) (right (+ left (if pixelwise (window-pixel-width window) (window-total-width window)))) -- 2.48.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 12:16:03 2025 Received: (at 75576) by debbugs.gnu.org; 15 Jan 2025 17:16:03 +0000 Received: from localhost ([127.0.0.1]:58584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tY6zr-00033R-4n for submit@debbugs.gnu.org; Wed, 15 Jan 2025 12:16:03 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:36939) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tY6zp-00032a-4C for 75576@debbugs.gnu.org; Wed, 15 Jan 2025 12:16:01 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 44F63E0003; Wed, 15 Jan 2025 17:15:50 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#75576: [PATCH] Take the tab-line into account when computing the window edges In-Reply-To: <87frlkts3x.fsf@stebalien.com> (Steven Allen via's message of "Wed, 15 Jan 2025 00:10:26 -0800") Organization: LINKOV.NET References: <87ikqgtsfi.fsf@stebalien.com> <87frlkts3x.fsf@stebalien.com> Date: Wed, 15 Jan 2025 19:11:58 +0200 Message-ID: <87jzaw2e8x.fsf_-_@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75576 Cc: martin rudalics , Steven Allen , 75576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > This was causing EXWM to mis-calculate the window height when centaur > tabs were used. See https://github.com/emacs-exwm/exwm/pull/114. Eli, is this patch eligible to be installed on the emacs-30 release branch? Also Cc-ing Martin. > From e9796ff62f2c561cb2797c3040ef88aa80a95500 Mon Sep 17 00:00:00 2001 > From: Steven Allen > Date: Tue, 14 Jan 2025 23:56:08 -0800 > Subject: [PATCH] Take the tab-line into account when computing the window > edges > > window-body-height correctly subtracts the tab-line's height but > window-edges did not add this same height to the y-offset. > > See https://github.com/emacs-exwm/exwm/pull/114 > > * lisp/window.el (window-edges): Add the tab-line-height to the y-offet > of the window body. (Bug#75576) > --- > lisp/window.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/window.el b/lisp/window.el > index 886128c7daa..b91c45226a1 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -3828,7 +3828,8 @@ window-edges > (top-body > (when body > (+ (window-pixel-top window) border-width > - (window-header-line-height window)))) > + (window-header-line-height window) > + (window-tab-line-height window)))) > (right (+ left (if pixelwise > (window-pixel-width window) > (window-total-width window)))) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 15:09:46 2025 Received: (at 75576) by debbugs.gnu.org; 15 Jan 2025 20:09:46 +0000 Received: from localhost ([127.0.0.1]:58814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tY9hx-0002Gs-PJ for submit@debbugs.gnu.org; Wed, 15 Jan 2025 15:09:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34940) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tY9hv-0002Gb-C8 for 75576@debbugs.gnu.org; Wed, 15 Jan 2025 15:09:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tY9ho-0006DR-DL; Wed, 15 Jan 2025 15:09:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=huJ1Y1VLCCiEtIno/dxbwt3gMG6z2iyJkrnF2aeItBw=; b=oYfi16fg1qzv NcWTBNYeCjV+6gjfO8Bk2mqiAvdfHChK3aAQcFBJS081efONzr1HqzuHFfHyNpXQw5vSSmiEzJ0lF 3ZRFjkJ6+1rOpmg6yys5QRfEwgwRFGzsqONkRvKpgCUdUxxhViKTf7WynOrCDvW9EzHNjT9fjlUL/ tJ8RaYEjAAQ8QlKcBmT5sTlvP9g6z7mUmULjFvhDGEIeLWMZYkM6edgOBzzTOgdglTfeCDreqkxRy u0BUKi3BVl+riXVpoLDtdBNHKD4iEjeH/2omYYwn4YFM3jlQh4tK1S0oGM/ahv2nxysEfZmwLKf32 SL9DaUX59VseqyKyic4CWA==; Date: Wed, 15 Jan 2025 22:09:33 +0200 Message-Id: <86bjw7kfeq.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87jzaw2e8x.fsf_-_@mail.linkov.net> (message from Juri Linkov on Wed, 15 Jan 2025 19:11:58 +0200) Subject: Re: bug#75576: [PATCH] Take the tab-line into account when computing the window edges References: <87ikqgtsfi.fsf@stebalien.com> <87frlkts3x.fsf@stebalien.com> <87jzaw2e8x.fsf_-_@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75576 Cc: rudalics@gmx.at, steven@stebalien.com, 75576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: martin rudalics , Steven Allen , > 75576@debbugs.gnu.org > Date: Wed, 15 Jan 2025 19:11:58 +0200 > > > This was causing EXWM to mis-calculate the window height when centaur > > tabs were used. See https://github.com/emacs-exwm/exwm/pull/114. > > Eli, is this patch eligible to be installed on the emacs-30 release branch? Is that really urgent? We've lived with this since Emacs 27, I guess? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 15:57:38 2025 Received: (at 75576) by debbugs.gnu.org; 15 Jan 2025 20:57:39 +0000 Received: from localhost ([127.0.0.1]:58945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYASI-0007Zu-Jf for submit@debbugs.gnu.org; Wed, 15 Jan 2025 15:57:38 -0500 Received: from fout-b5-smtp.messagingengine.com ([202.12.124.148]:40379) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYASF-0007Zd-L3 for 75576@debbugs.gnu.org; Wed, 15 Jan 2025 15:57:36 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id B392A11401B9; Wed, 15 Jan 2025 15:57:28 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Wed, 15 Jan 2025 15:57:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1736974648; x= 1737061048; bh=fpLlpUyTg8cLpPY5iNZej8H0G8sEgEiJFE1vqsmssD8=; b=G JNYSAUlMtgst/h14Bq6KhJ8XNgK3u0yIvH9aiyC0vr4ncpbT28C99v7Tu14BLK0E Ie8wjr8zxJnXxWe9OPO9C4FNvcn9cunXecqiDRXkX/cZ2+cS/7iQ7C9mjuPbtq4j tevs0D52gZHHFXDxXUWBKq+Y01D4DmhBiL+ouQu7pckr9a9O+HfnveweVZHdMucF CNWeBjBAIbt6OivYQDAgEOvAaEW1MMkskawuBW/Gpkc/mO71XY5vAZk7bM1zlVy/ UzDt8aMGx8CdJ9W0Md8nbrF6yQwEzb8WjF+/uHlP5u53l3DYF2JzqVBrxCkJvJac R6QIhlWDZJEkrjFkePK4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1736974648; x=1737061048; bh=fpLlpUyTg8cLpPY5iNZej8H0G8sEgEiJFE1 vqsmssD8=; b=JxNTO3++2pP+LCARL+cmnUNcLJ3bP6E9u8Xdf2B/a0tUpovpMRj szdn290XRCXROJC1WmGtMFNG0NedFoQmSONrPoXAH+iv+/kYfKVzKbzh8D1vHBUQ Zxu6IEBRxP/diMXpc6SzjK8PsfWzxmBm0R14OUdmIkUgyopgHJYkWBS5ET6Rc3Ks ac6dHe/mcXWvjWntlqqoo+sxLBcDsQEccgE+BiT+JsUAiyTOWGmIfqeqCKebnDdi HFmcMc18zLqmcOE7+B1KnvNlG59E5l3Zrf862VLrZEXUnKqwVadbarqfdd4bBm0X BNBebEtYZZhu+yPRdVEkFA/9WWD73mnpKyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudehledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttden ucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivg hnrdgtohhmqeenucggtffrrghtthgvrhhnpeejgfeuueeutdeikeffueevffejueffgeek tefhhedvfffhgedtvdegieehgeejveenucffohhmrghinhepghhithhhuhgsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhtvghv vghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgepsh hmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehj uhhriheslhhinhhkohhvrdhnvghtpdhrtghpthhtoheprhhuuggrlhhitghssehgmhigrd grthdprhgtphhtthhopeejheehjeeiseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Jan 2025 15:57:27 -0500 (EST) From: Steven Allen To: Eli Zaretskii , Juri Linkov Subject: Re: bug#75576: [PATCH] Take the tab-line into account when computing the window edges In-Reply-To: <86bjw7kfeq.fsf@gnu.org> References: <87ikqgtsfi.fsf@stebalien.com> <87frlkts3x.fsf@stebalien.com> <87jzaw2e8x.fsf_-_@mail.linkov.net> <86bjw7kfeq.fsf@gnu.org> Date: Wed, 15 Jan 2025 12:57:26 -0800 Message-ID: <878qrbssll.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75576 Cc: rudalics@gmx.at, 75576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Juri Linkov >> Cc: martin rudalics , Steven Allen , >> 75576@debbugs.gnu.org >> Date: Wed, 15 Jan 2025 19:11:58 +0200 >> >> > This was causing EXWM to mis-calculate the window height when centaur >> > tabs were used. See https://github.com/emacs-exwm/exwm/pull/114. >> >> Eli, is this patch eligible to be installed on the emacs-30 release branch? > > Is that really urgent? We've lived with this since Emacs 27, I guess? It's a nice to have but not urgent. I plan on adding a workaround to EXWM anyways and I doubt many others are impacted. The only question is which version to check in that workaround. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 00:57:01 2025 Received: (at 75576) by debbugs.gnu.org; 16 Jan 2025 05:57:01 +0000 Received: from localhost ([127.0.0.1]:59664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYIsG-0007p0-Pz for submit@debbugs.gnu.org; Thu, 16 Jan 2025 00:57:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52876) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYIsD-0007og-1U for 75576@debbugs.gnu.org; Thu, 16 Jan 2025 00:56:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYIs5-0008DC-Vr; Thu, 16 Jan 2025 00:56:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kZH7bVh7ZRnXSFo346w+bJ2PuC/a/XN3rQBZG39g4l4=; b=a6xKth5wSL7V v6ha1xcC9mJRq0WbO41PVcV7yqYOzi++iaJdHZl+IPzb2mo8EuSxLOjNQjg1jt0UyQ7l0LcRZZNgY up29EwO4bkok/ViCje0xKu52XIa6PmzVjPleC1j1BRVvmM2zDvqgR69Cgn2osknaVd4XE1NWlqq/R 8IY8BMNwzwv4hvskyRLenf0p8bSLLQ4wnl6meNE5SCY++v3XtOLIs+hngZAoqBvIhLDeMEVOzqA8w aJGdlFnICPZyBR5AqKkqPJ4Y5V7s483/JORnl+VhU0KosOrBns6eF/5oU9668KithoOAMTK4jIYw9 1+JhdmmS6J9PpBbY0hKFmw==; Date: Thu, 16 Jan 2025 07:56:48 +0200 Message-Id: <86zfjri9nj.fsf@gnu.org> From: Eli Zaretskii To: Steven Allen In-Reply-To: <878qrbssll.fsf@stebalien.com> (message from Steven Allen on Wed, 15 Jan 2025 12:57:26 -0800) Subject: Re: bug#75576: [PATCH] Take the tab-line into account when computing the window edges References: <87ikqgtsfi.fsf@stebalien.com> <87frlkts3x.fsf@stebalien.com> <87jzaw2e8x.fsf_-_@mail.linkov.net> <86bjw7kfeq.fsf@gnu.org> <878qrbssll.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75576 Cc: 75576@debbugs.gnu.org, rudalics@gmx.at, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Cc: rudalics@gmx.at, 75576@debbugs.gnu.org > Date: Wed, 15 Jan 2025 12:57:26 -0800 > > > Eli Zaretskii writes: > > >> From: Juri Linkov > >> Cc: martin rudalics , Steven Allen , > >> 75576@debbugs.gnu.org > >> Date: Wed, 15 Jan 2025 19:11:58 +0200 > >> > >> > This was causing EXWM to mis-calculate the window height when centaur > >> > tabs were used. See https://github.com/emacs-exwm/exwm/pull/114. > >> > >> Eli, is this patch eligible to be installed on the emacs-30 release branch? > > > > Is that really urgent? We've lived with this since Emacs 27, I guess? > > It's a nice to have but not urgent. I plan on adding a workaround to > EXWM anyways and I doubt many others are impacted. The only question is > which version to check in that workaround. Then I prefer to install this on master. We can consider backporting it after Emacs 30.1 is released, if no problems are reported for the change on master. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 02:52:08 2025 Received: (at 75576) by debbugs.gnu.org; 16 Jan 2025 07:52:08 +0000 Received: from localhost ([127.0.0.1]:59849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYKff-0005E6-V8 for submit@debbugs.gnu.org; Thu, 16 Jan 2025 02:52:08 -0500 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:36603) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYKfd-0005DG-GI; Thu, 16 Jan 2025 02:52:06 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2AEDE1C0003; Thu, 16 Jan 2025 07:51:54 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#75576: [PATCH] Take the tab-line into account when computing the window edges In-Reply-To: <86zfjri9nj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Jan 2025 07:56:48 +0200") Organization: LINKOV.NET References: <87ikqgtsfi.fsf@stebalien.com> <87frlkts3x.fsf@stebalien.com> <87jzaw2e8x.fsf_-_@mail.linkov.net> <86bjw7kfeq.fsf@gnu.org> <878qrbssll.fsf@stebalien.com> <86zfjri9nj.fsf@gnu.org> Date: Thu, 16 Jan 2025 09:50:50 +0200 Message-ID: <87plknurhh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75576 Cc: rudalics@gmx.at, Steven Allen , 75576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 75576 31.0.50 thanks >> >> > This was causing EXWM to mis-calculate the window height when centaur >> >> > tabs were used. See https://github.com/emacs-exwm/exwm/pull/114. >> >> >> >> Eli, is this patch eligible to be installed on the emacs-30 release branch? >> > >> > Is that really urgent? We've lived with this since Emacs 27, I guess? >> >> It's a nice to have but not urgent. I plan on adding a workaround to >> EXWM anyways and I doubt many others are impacted. The only question is >> which version to check in that workaround. > > Then I prefer to install this on master. We can consider backporting > it after Emacs 30.1 is released, if no problems are reported for the > change on master. So now pushed to master. Thanks Steven for the patch. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 12:38:12 2025 Received: (at 75576) by debbugs.gnu.org; 16 Jan 2025 17:38:12 +0000 Received: from localhost ([127.0.0.1]:34537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYTop-0000Wk-Na for submit@debbugs.gnu.org; Thu, 16 Jan 2025 12:38:12 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35981) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYTon-0000WV-Iq for 75576@debbugs.gnu.org; Thu, 16 Jan 2025 12:38:09 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id E33EAC0003; Thu, 16 Jan 2025 17:38:01 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#75576: [PATCH] Take the tab-line into account when computing the window edges In-Reply-To: <87plknurhh.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 16 Jan 2025 09:50:50 +0200") Organization: LINKOV.NET References: <87ikqgtsfi.fsf@stebalien.com> <87frlkts3x.fsf@stebalien.com> <87jzaw2e8x.fsf_-_@mail.linkov.net> <86bjw7kfeq.fsf@gnu.org> <878qrbssll.fsf@stebalien.com> <86zfjri9nj.fsf@gnu.org> <87plknurhh.fsf@mail.linkov.net> Date: Thu, 16 Jan 2025 19:34:40 +0200 Message-ID: <87bjw6vf0v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@linkov.net X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 75576 Cc: rudalics@gmx.at, 75576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) --=-=-= Content-Type: text/plain BTW, I don't know how this slipped through the cracks, but now I checked again, and found more occurrences to fix on master: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=window-tab-line-height.patch diff --git a/lisp/mouse.el b/lisp/mouse.el index 6fe691693b4..dd0a2231c94 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -906,7 +906,9 @@ mouse-drag-line ;; If necessary, add height of header line to `position' (when (memq (posn-area start) '(nil left-fringe right-fringe left-margin right-margin)) - (setq position (+ (window-header-line-height posn-window) position)))) + (setq position (+ (window-header-line-height posn-window) + (window-tab-line-height posn-window) + position)))) ;; When the cursor overshoots after shrinking a window to its ;; minimum size and the dragging direction changes, have the ;; cursor first catch up with the window edge. diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el index 47499262b37..fd7fe01d2d8 100644 --- a/lisp/gnus/gnus-art.el +++ b/lisp/gnus/gnus-art.el @@ -6747,6 +6747,7 @@ gnus-article-beginning-of-window (max 1 (- (window-height) (if mode-line-format 1 0) (if header-line-format 1 0) + (if tab-line-format 1 0) 2)))))) (defvar scroll-in-place) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 12:50:29 2025 Received: (at 75576) by debbugs.gnu.org; 16 Jan 2025 17:50:30 +0000 Received: from localhost ([127.0.0.1]:34566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYU0j-00018e-IA for submit@debbugs.gnu.org; Thu, 16 Jan 2025 12:50:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43214) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYU0g-00018Q-QJ for 75576@debbugs.gnu.org; Thu, 16 Jan 2025 12:50:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYU0b-000519-Ad; Thu, 16 Jan 2025 12:50:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3wTB6QZxSyDH+arE+cyicJaN1fi176aPSl/IizCmmJs=; b=L7ofqwqgD9o4 52m4dB+XXV054EHNUWaiGVbrMEnfBvN6rQAgH2RzdoJpAaW6rkIwFfIqLhrTimEPTm7EP4snYLfXb 9b+T8WLWdn1H4W5cUs5HI22GnA9/YhrOeoFLzfGNtk8M5+Zuzf/+6lVUHnSnOan0M1KD+vVF4qWoV wbcrLuDurKn079M+XqF0KlEt6Jexm7x1h7QyaUUueqdExYXi70FsGO/G7MzQkw8o82XfWN9P1BhMD oyAi+3zOC92uHKKcqYNi9kGvIW50vs+VxGlKRLmiqWp5vniEPoPY4sin1wP7y3aE4ogMUyo+xmvPH XXdkj7X4E95AwRO80R6VGQ==; Date: Thu, 16 Jan 2025 19:50:16 +0200 Message-Id: <861px2hcmf.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87bjw6vf0v.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 16 Jan 2025 19:34:40 +0200) Subject: Re: bug#75576: [PATCH] Take the tab-line into account when computing the window edges References: <87ikqgtsfi.fsf@stebalien.com> <87frlkts3x.fsf@stebalien.com> <87jzaw2e8x.fsf_-_@mail.linkov.net> <86bjw7kfeq.fsf@gnu.org> <878qrbssll.fsf@stebalien.com> <86zfjri9nj.fsf@gnu.org> <87plknurhh.fsf@mail.linkov.net> <87bjw6vf0v.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75576 Cc: rudalics@gmx.at, 75576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: rudalics@gmx.at, 75576@debbugs.gnu.org > Date: Thu, 16 Jan 2025 19:34:40 +0200 > > BTW, I don't know how this slipped through the cracks, > but now I checked again, and found more occurrences > to fix on master: Thanks. I guess people who use tab-line rarely if ever use any callers of these functions, and vice versa. From unknown Sat Jun 21 03:25:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Feb 2025 12:24:18 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator