From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2025 02:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 75551@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs Received: via spool by submit@debbugs.gnu.org id=B.173682188114936 (code B ref -1); Tue, 14 Jan 2025 02:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jan 2025 02:31:21 +0000 Received: from localhost ([127.0.0.1]:53424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXWi9-0003sp-Bo for submit@debbugs.gnu.org; Mon, 13 Jan 2025 21:31:21 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52790) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tXWi6-0003sR-9T for submit@debbugs.gnu.org; Mon, 13 Jan 2025 21:31:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXWhz-0001gZ-UF for bug-gnu-emacs@gnu.org; Mon, 13 Jan 2025 21:31:11 -0500 Received: from sender4-of-o54.zoho.com ([136.143.188.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXWhw-0000xT-1o for bug-gnu-emacs@gnu.org; Mon, 13 Jan 2025 21:31:11 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1736821861; cv=none; d=zohomail.com; s=zohoarc; b=mce6KwXPEpqBjCwx4LCkJvWmbc19h950SsJLgYVxmysBvs0CIwbiyHa4dfQdBX67L1TApxKsNoBXrCvRpLeDPECWjaxejCN+UGXwukRuDyIgPy+qUj0/UuhEyum5ngl3FQMHX/4cAeqK1N1NVjFro5XG80vy+8SNMGDUOA7quow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1736821861; h=Content-Type:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=nT8oiVYjIOnJn9iNqygjXp9mOuf2FaymIEbjeNwErgc=; b=UTdHUGoAg/QbKGevMzqAJE4X5wMsCuIbmJEq8nHi/TYP+NayVG6fRVsaxczdofgCxIKx0Flf+u0+I7mQVmtVH4jc2htf1Op3jqvWMBiJqwZ1N5ffezNG+6WewsiV5tAav1w0nBY3U4U0AH6XUV3D4UMQN1zq7I6d7vaXTOZgTqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=topbug.net; spf=pass smtp.mailfrom=hong@topbug.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1736821861; s=zoho; d=topbug.net; i=hong@topbug.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=nT8oiVYjIOnJn9iNqygjXp9mOuf2FaymIEbjeNwErgc=; b=SXSMvmXqdZyfmn/buKXOvXEnkCRc7aUn+QR2QlOsWCpDYNUdrK80hwm9WtbEjtkp Tm83w0DM3Et0qeMDkowL4fTUp5ONSyfAmmfjF+kXiY0uhymruxmadEH8LnTvBGVBRTr sQx47GGbKTU68LP57Lmm0T9AvftufrmTnVX9xEBQ= Received: by mx.zohomail.com with SMTPS id 1736821859894540.7416289092154; Mon, 13 Jan 2025 18:30:59 -0800 (PST) From: Hong Xu User-Agent: mu4e 1.12.8; emacs 29.4 Date: Mon, 13 Jan 2025 18:30:58 -0800 Message-ID: <87plkq3z4t.fsf@topbug.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.54; envelope-from=hong@topbug.net; helo=sender4-of-o54.zoho.com X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.787, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) lrealloc has a loop that keeps checking alignment by calling laligned: while (true) { p = realloc (p, size); if (laligned (p, size) && (size || p)) return p; size_t bigger = size + LISP_ALIGNMENT; if (size < bigger) size = bigger; } Note that the loop increment size by LISP_ALIGNMENT each time if the conditions are not satisfied. One check in aligned is size % LISP_ALIGNMENT != 0: static bool laligned (void *p, size_t size) { return (MALLOC_IS_LISP_ALIGNED || (intptr_t) p % LISP_ALIGNMENT == 0 || size % LISP_ALIGNMENT != 0); } Consider a host where MALLOC_IS_LISP_ALIGNED is false and p % LISP_ALIGNMENT is frequently nonzero. if lrealloc is called with size being a multiplier of LISP_ALIGNMENT, the loop can take a long time to end until p % LISP_ALIGNMENT == 0, potentially until OOM. Based on my understanding, this part is to address some "oddball" hosts (based on the comment in alloc.c). But this does seem like a bug to me if Emacs is running on such an oddball host... -- Hong From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2025 03:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Hong Xu , Paul Eggert Cc: 75551@debbugs.gnu.org Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173682565525957 (code B ref 75551); Tue, 14 Jan 2025 03:35:01 +0000 Received: (at 75551) by debbugs.gnu.org; 14 Jan 2025 03:34:15 +0000 Received: from localhost ([127.0.0.1]:53504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXXh1-0006kb-F3 for submit@debbugs.gnu.org; Mon, 13 Jan 2025 22:34:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33282) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tXXgz-0006kM-30 for 75551@debbugs.gnu.org; Mon, 13 Jan 2025 22:34:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXXgs-0001un-Hz; Mon, 13 Jan 2025 22:34:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sSUBVxfvu4JIZaDqigzlRjjvRfVpQemLTyAvCN1YaiI=; b=qKSAPpdR9NHO oQ3QFv0AHYd3sDvna56lxBiRdvkRiMMNrzWJFNGWqyySX5MlCnF6AO9p16LzSpLY9lwN3Illl3b5u +udVQRphNVZCFDMOA/oU+6fYyWNkeGsekJgrSCSSjbr+faUvXK5YVpAmmqlnp7vquPRG3c3QkeNpx 8sosNRSr3fDfAi3KKrqj9BJks0EsAkhcEYivmrDPPVnnm7mEE0nPLZ9ChgtTvoxh5Ohi3BGzhbQeS iKUWEXSkULUQ8kduNoghrfGgqkTl9bNZGlBOQbuwWPE6fak57oy++rlpYMgdDIu7NH8rjjk+NTvZ3 3n3d2pFVFq+d5SinVTv0lg==; Date: Tue, 14 Jan 2025 05:34:02 +0200 Message-Id: <86wmeyt6fp.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87plkq3z4t.fsf@topbug.net> (message from Hong Xu on Mon, 13 Jan 2025 18:30:58 -0800) References: <87plkq3z4t.fsf@topbug.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Hong Xu > Date: Mon, 13 Jan 2025 18:30:58 -0800 > > > lrealloc has a loop that keeps checking alignment by calling laligned: > > while (true) > { > p = realloc (p, size); > if (laligned (p, size) && (size || p)) > return p; > size_t bigger = size + LISP_ALIGNMENT; > if (size < bigger) > size = bigger; > } > > Note that the loop increment size by LISP_ALIGNMENT each time if the > conditions are not satisfied. > > One check in aligned is size % LISP_ALIGNMENT != 0: > > static bool > laligned (void *p, size_t size) > { > return (MALLOC_IS_LISP_ALIGNED || (intptr_t) p % LISP_ALIGNMENT == 0 > || size % LISP_ALIGNMENT != 0); > } > > Consider a host where MALLOC_IS_LISP_ALIGNED is false and p % > LISP_ALIGNMENT is frequently nonzero. if lrealloc is called with size > being a multiplier of LISP_ALIGNMENT, the loop can take a long time to > end until p % LISP_ALIGNMENT == 0, potentially until OOM. > > Based on my understanding, this part is to address some "oddball" hosts > (based on the comment in alloc.c). But this does seem like a bug to me > if Emacs is running on such an oddball host... Paul, could you please comment on this? Thanks. From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2025 21:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Hong Xu Cc: 75551@debbugs.gnu.org Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173688870026234 (code B ref 75551); Tue, 14 Jan 2025 21:05:01 +0000 Received: (at 75551) by debbugs.gnu.org; 14 Jan 2025 21:05:00 +0000 Received: from localhost ([127.0.0.1]:55946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXo5r-0006p4-Nx for submit@debbugs.gnu.org; Tue, 14 Jan 2025 16:04:59 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:60984) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tXo5o-0006oj-PW for 75551@debbugs.gnu.org; Tue, 14 Jan 2025 16:04:57 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8348F3C00FAB3; Tue, 14 Jan 2025 13:04:50 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id Aopa3by8WgK9; Tue, 14 Jan 2025 13:04:50 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 38FD23C0275C1; Tue, 14 Jan 2025 13:04:50 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 38FD23C0275C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1736888690; bh=D2harjU2xENxxx05stj53LgxWbhmHZtJdj7IdUglxJc=; h=Message-ID:Date:MIME-Version:To:From; b=FFBT2PZIfJTXHs06El8LDpt/cjSTdSfmyIJaiVM5ZH3WQO5G/rvg+Q7EXQxrAksN2 O3bSC2j102uEI+XleOYTAphzjuZ9BwHDc9SL2Swtkfzjf1eWsAsrZndFI3yzWrkZ+n /kJJWMlXIF9jFN03RGGro/DfbRp/aGcof7N/MM8EqKqCSsE1QNOKmV5+6HM8ApY6BP TlyPFFuz/sJ9Z25N5KhDChOHxPZzEdYVdcdthrlDfrKD69iyz8jHyEvavsrxL2spL/ ICLoyf8OlXR21+A6+XaTyf7QhLRTdtaNhPGvAxEyfJOT3fIQFnbrWh5tlO6gKAx7Vm l6iNOcS2W9f+g== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id YP3uwLYXWtdc; Tue, 14 Jan 2025 13:04:50 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 165313C00FAB3; Tue, 14 Jan 2025 13:04:50 -0800 (PST) Message-ID: <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> Date: Tue, 14 Jan 2025 13:04:49 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <86wmeyt6fp.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-01-13 19:34, Eli Zaretskii wrote: >> Consider a host where MALLOC_IS_LISP_ALIGNED is false and p % >> LISP_ALIGNMENT is frequently nonzero. if lrealloc is called with size >> being a multiplier of LISP_ALIGNMENT, the loop can take a long time to >> end until p % LISP_ALIGNMENT == 0, potentially until OOM. >> >> Based on my understanding, this part is to address some "oddball" hosts >> (based on the comment in alloc.c). But this does seem like a bug to me >> if Emacs is running on such an oddball host... > Paul, could you please comment on this? As far as we know, there are no oddball hosts. If Emacs is ever built on an oddball host, the code will operate correctly albeit possibly very inefficiently (perhaps including unwanted memory exhaustion). Alternatively, the code could simply run emacs_abort() instead of retrying the allocation. There should be no difference on today's platforms so it's no big deal either way. Or we could even remove the runtime test entirely, i.e., remove lrealloc and simply call realloc. That would make Emacs a bit faster in Lisp allocation. From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2025 00:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 75551@debbugs.gnu.org, Eli Zaretskii Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173698628732123 (code B ref 75551); Thu, 16 Jan 2025 00:12:01 +0000 Received: (at 75551) by debbugs.gnu.org; 16 Jan 2025 00:11:27 +0000 Received: from localhost ([127.0.0.1]:59299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYDTq-0008M3-JN for submit@debbugs.gnu.org; Wed, 15 Jan 2025 19:11:26 -0500 Received: from out-176.mta0.migadu.com ([91.218.175.176]:32678) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYDTn-0008Ll-5L for 75551@debbugs.gnu.org; Wed, 15 Jan 2025 19:11:24 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=topbug.net; s=key1; t=1736986271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Noig3f/u7tEZcZLeZNXCD/C4+m/OmGUdxqf+FRcNaMY=; b=gkXiImx1Bx6yeebOAmh5NyeEZAoh5PjOvXf0sGOFKzVrIWmvNR4w1nTpvGCGc0qEd+7xz6 oqmqwqoSoS8lIjWsk07e0MPltFuMZ5TqVcbe+CVTaXVH6QCLfeKnr8mvloB4bVOph2ss1T RM3CLSQh4PWKXIk6U1CS+oRK2C4CfH2NXRePYxUDJmJTpDdeI/CoViZ1hmx7AzC89XkhMi vG9NPV0/9aegMPqTdWAOWou82lUbT2c07AQXJd+t3yR5VlHe8yQKHO4GmvIVcYdNo2LaVo 3BWFmERsblDopC7VcpEFjPCeXofI8xm2K/v351U88TM1oXRoa0AEOLMdzEWVxQ== From: Hong Xu In-Reply-To: <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> (Paul Eggert's message of "Tue, 14 Jan 2025 13:04:49 -0800") References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> Date: Wed, 15 Jan 2025 16:11:07 -0800 Message-ID: <87plknobxg.fsf@topbug.net> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2025-01-14 Tue 13:04 GMT-08, Paul Eggert wrote: > On 2025-01-13 19:34, Eli Zaretskii wrote: >>> Consider a host where MALLOC_IS_LISP_ALIGNED is false and p % >>> LISP_ALIGNMENT is frequently nonzero. if lrealloc is called with size >>> being a multiplier of LISP_ALIGNMENT, the loop can take a long time to >>> end until p % LISP_ALIGNMENT == 0, potentially until OOM. >>> >>> Based on my understanding, this part is to address some "oddball" hosts >>> (based on the comment in alloc.c). But this does seem like a bug to me >>> if Emacs is running on such an oddball host... >> Paul, could you please comment on this? > > As far as we know, there are no oddball hosts. > > If Emacs is ever built on an oddball host, the code will operate correctly > albeit possibly very inefficiently (perhaps including unwanted memory > exhaustion). > > Alternatively, the code could simply run emacs_abort() instead of retrying the > allocation. There should be no difference on today's platforms so it's no big > deal either way. > > Or we could even remove the runtime test entirely, i.e., remove lrealloc and > simply call realloc. That would make Emacs a bit faster in Lisp allocation. It seems like the code is a bit less ideal to me -- on an imaginary oddball host, this memory exhaustion bug is so frequent that I would rather consider Emacs unsupported on such an oddball host. I agree that it may be better to just remove lrealloc -- the memory allocation code is so twisted that it can become a potential hazard of security bugs on a normal host. We can add a compile time check so that Emacs can't compile on an oddball host -- if there is really one. If an odd host indeed exists, I think the it's a simpler and cleaner solution to replace the implementation of realloc with an aligned while inefficient one, while keeping the logic of normal hosts intact. What do you think? -- Hong From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2025 07:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Hong Xu Cc: 75551@debbugs.gnu.org, Eli Zaretskii Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173701331518111 (code B ref 75551); Thu, 16 Jan 2025 07:42:01 +0000 Received: (at 75551) by debbugs.gnu.org; 16 Jan 2025 07:41:55 +0000 Received: from localhost ([127.0.0.1]:59820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYKVm-0004i2-LB for submit@debbugs.gnu.org; Thu, 16 Jan 2025 02:41:55 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:46540) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYKVj-0004hi-Cx for 75551@debbugs.gnu.org; Thu, 16 Jan 2025 02:41:52 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8563F3C03E9F1; Wed, 15 Jan 2025 23:41:45 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id 1Zj-Cpk2KmZ3; Wed, 15 Jan 2025 23:41:44 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id CBD8C3C082EA7; Wed, 15 Jan 2025 23:41:44 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu CBD8C3C082EA7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1737013304; bh=LeqARRxvbdOqJzQ2oloj5ucteQIJ/ae0lZkHQMZdgxk=; h=Message-ID:Date:MIME-Version:To:From; b=kSwsN7Ug6OIiXx31FtpkIiumoGbQqIYNM5tx1tfPEzmxj4Vx3ouoTM/MDYEopqOOq mBom2VmcbQcm6GRES2ykTseiS8dDkHvQ5xUi5wKad5U77pzgh0VD9aKLXU9zCTjxMX wvbyRrtZn5rfYO2VZOl7tykYPb+EIBwhZ511z4cTynfii9wOTH0RU5RDjTsxGbxFpv jSk0OGIi7e6E6QxJ/t7fHamqh0wM5Ouo7JNrYQ5eKW6h1cr7Tf26rzmZfp2LdpuKqA Ur/M0lS3etJISjQsaoeuvo0Q2TeBJ1Pxzj2KoeNMqqHEX8ZTRUva9eXwB5jmgUo/m/ U/ki2oAwYmiDA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id qVZA7MIVHFN3; Wed, 15 Jan 2025 23:41:44 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id AD30A3C03E9F1; Wed, 15 Jan 2025 23:41:44 -0800 (PST) Content-Type: multipart/mixed; boundary="------------IZewYNnB0xJKnM0AGlgL79ez" Message-ID: Date: Wed, 15 Jan 2025 23:41:44 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <87plknobxg.fsf@topbug.net> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------IZewYNnB0xJKnM0AGlgL79ez Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-01-15 16:11, Hong Xu wrote: > It seems like the code is a bit less ideal to me -- on an imaginary > oddball host, this memory exhaustion bug is so frequent that I would > rather consider Emacs unsupported on such an oddball host. > > I agree that it may be better to just remove lrealloc Good points. Attached is a patch to make that change in a safe way. Please take a look at it and give it a try. --------------IZewYNnB0xJKnM0AGlgL79ez Content-Type: text/x-patch; charset=UTF-8; name="0001-Simplify-alloc-by-assuming-MALLOC_IS_LISP_ALIGNED.patch" Content-Disposition: attachment; filename*0="0001-Simplify-alloc-by-assuming-MALLOC_IS_LISP_ALIGNED.patch" Content-Transfer-Encoding: base64 RnJvbSA0ZDE2MDg2NTNlZmQ1ZGMyZDA1MTI2YTU4NTJhMDg4MWI3ZGFmOWE0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDE1IEphbiAyMDI1IDIzOjMyOjQzIC0wODAwClN1YmplY3Q6IFtQQVRD SF0gU2ltcGxpZnkgYWxsb2MgYnkgYXNzdW1pbmcgTUFMTE9DX0lTX0xJU1BfQUxJR05FRAoK UHJvYmxlbSByZXBvcnRlZCBieSBIb25nIFh1IDxodHRwczovL2J1Z3MuZ251Lm9yZy83NTU1 MSMxND4uCiogc3JjL2FsbG9jLmMgKE1BTExPQ19JU19MSVNQX0FMSUdORUQpOiBzdGF0aWNf YXNzZXJ0IGl0LApzaW5jZSBpdCBpcyB0cnVlIG9uIGFsbCBjdXJyZW50IEVtYWNzIHBsYXRm b3Jtcy4KQWxsIHVzZXMgc2ltcGxpZmllZCB0byBhc3N1bWUgaXQgaXMgdHJ1ZS4KKHhtYWxs b2MsIHh6YWxsb2MsIHhyZWFsbG9jLCBsaXNwX21hbGxvYyk6IEp1c3QgdXNlCm1hbGxvYy9j YWxsb2MvcmVhbGxvYy4gIFNpbmNlIHdlIGFyZSB1c2luZyB0aGUgbWFsbG9jLWdudQphbmQg cmVhbGxvYy1wb3NpeCBtb2R1bGVzLCB3ZSBuZWVkIG5vdCB3b3JyeSBhYm91dCB3aGV0aGVy CnRoZXNlIGZ1bmN0aW9ucyByZXR1cm4gYSBudWxsIHBvaW50ZXIgZm9yIHplcm8tc2l6ZSBy ZXF1ZXN0cy4KKHhyZWFsbG9jKTogU3RvcCB3b3JyeWluZyBhYm91dCBuby1sb25nZXItZXhp c3RpbmcgcGxhdGZvcm1zCndoZXJlIHJlYWxsb2MgKG51bGxwdHIsIC4uLikgZGlkIG5vdCB3 b3JrLgoobGFsaWduZWQsIGxtYWxsb2MsIGxyZWFsbG9jKTogUmVtb3ZlLiAgQWxsIHVzZXMg cmVtb3ZlZC4KLS0tCiBzcmMvYWxsb2MuYyB8IDEyOCArKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjYgaW5z ZXJ0aW9ucygrKSwgMTAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9hbGxvYy5j IGIvc3JjL2FsbG9jLmMKaW5kZXggODMwN2M3NGMxMDYuLmU3MjkwYzU1Zjg4IDEwMDY0NAot LS0gYS9zcmMvYWxsb2MuYworKysgYi9zcmMvYWxsb2MuYwpAQCAtNzA0LDIxICs3MDQsMjQg QEAgI2RlZmluZSBDT01NT05fTVVMVElQTEUoYSwgYikgXAogICAoKGEpICUgKGIpID09IDAg PyAoYSkgOiAoYikgJSAoYSkgPT0gMCA/IChiKSA6IChhKSAqIChiKSkKIAogLyogQWxpZ25t ZW50IG5lZWRlZCBmb3IgbWVtb3J5IGJsb2NrcyB0aGF0IGFyZSBhbGxvY2F0ZWQgdmlhIG1h bGxvYwotICAgYW5kIHRoYXQgY29udGFpbiBMaXNwIG9iamVjdHMuICBPbiB0eXBpY2FsIGhv c3RzIG1hbGxvYyBhbHJlYWR5Ci0gICBhbGlnbnMgc3VmZmljaWVudGx5LCBidXQgZXh0cmEg d29yayBpcyBuZWVkZWQgb24gb2RkYmFsbCBob3N0cwotICAgd2hlcmUgRW1hY3Mgd291bGQg Y3Jhc2ggaWYgbWFsbG9jIHJldHVybmVkIGEgbm9uLUdDQUxJR05FRCBwb2ludGVyLiAgKi8K KyAgIGFuZCB0aGF0IGNvbnRhaW4gTGlzcCBvYmplY3RzLiAgKi8KIGVudW0geyBMSVNQX0FM SUdOTUVOVCA9IGFsaWdub2YgKHVuaW9uIHsgdW5pb24gZW1hY3NfYWxpZ25fdHlwZSB4Owog CQkJCQkgR0NBTElHTkVEX1VOSU9OX01FTUJFUiB9KSB9Owogc3RhdGljX2Fzc2VydCAoTElT UF9BTElHTk1FTlQgJSBHQ0FMSUdOTUVOVCA9PSAwKTsKIAotLyogVHJ1ZSBpZiBtYWxsb2Mg KE4pIGlzIGtub3duIHRvIHJldHVybiBzdG9yYWdlIHN1aXRhYmx5IGFsaWduZWQgZm9yCi0g ICBMaXNwIG9iamVjdHMgd2hlbmV2ZXIgTiBpcyBhIG11bHRpcGxlIG9mIExJU1BfQUxJR05N RU5ULiAgSW4KLSAgIHByYWN0aWNlIHRoaXMgaXMgdHJ1ZSB3aGVuZXZlciBhbGlnbm9mICht YXhfYWxpZ25fdCkgaXMgYWxzbyBhCisvKiBWZXJpZnkgRW1hY3MncyBhc3N1bXB0aW9uIHRo YXQgbWFsbG9jIChOKSByZXR1cm5zIHN0b3JhZ2Ugc3VpdGFibHkKKyAgIGFsaWduZWQgZm9y IExpc3Agb2JqZWN0cyB3aGVuZXZlciBOIGlzIGEgbXVsdGlwbGUgb2YgTElTUF9BTElHTk1F TlQuCisgICBUaGlzIGFzc3VtcHRpb24gaG9sZHMgZm9yIGN1cnJlbnQgRW1hY3MgcG9ydGlu ZyB0YXJnZXRzOworICAgaWYgdGhlIGFzc3VtcHRpb24gZmFpbHMgb24gYSBuZXcgcGxhdGZv cm0sIHRoaXMgY2hlY2sgc2hvdWxkCisgICBjYXVzZSBjb21waWxhdGlvbiB0byBmYWlsIGFu ZCBzb21lIHBvcnRpbmcgd29yayB3aWxsIG5lZWQgdG8gYmUgZG9uZS4KKworICAgSW4gcHJh Y3RpY2UgdGhlIGFzc3VtcHRpb24gaG9sZHMgd2hlbiBhbGlnbm9mIChtYXhfYWxpZ25fdCkg aXMgYWxzbyBhCiAgICBtdWx0aXBsZSBvZiBMSVNQX0FMSUdOTUVOVC4gIFRoaXMgd29ya3Mg ZXZlbiBmb3IgYnVnZ3kgcGxhdGZvcm1zCiAgICBsaWtlIE1pbkdXIGNpcmNhIDIwMjAsIHdo ZXJlIGFsaWdub2YgKG1heF9hbGlnbl90KSBpcyAxNiBldmVuIHRob3VnaAogICAgdGhlIG1h bGxvYyBhbGlnbm1lbnQgaXMgb25seSA4LCBhbmQgd2hlcmUgRW1hY3Mgc3RpbGwgd29ya3Mg YmVjYXVzZQogICAgaXQgbmV2ZXIgZG9lcyBhbnl0aGluZyB0aGF0IHJlcXVpcmVzIGFuIGFs aWdubWVudCBvZiAxNi4gICovCiBlbnVtIHsgTUFMTE9DX0lTX0xJU1BfQUxJR05FRCA9IGFs aWdub2YgKG1heF9hbGlnbl90KSAlIExJU1BfQUxJR05NRU5UID09IDAgfTsKK3N0YXRpY19h c3NlcnQgKE1BTExPQ19JU19MSVNQX0FMSUdORUQpOwogCiAvKiBJZiBjb21waWxlZCB3aXRo IFhNQUxMT0NfQkxPQ0tfSU5QVVRfQ0hFQ0ssIGRlZmluZSBhIHN5bWJvbAogICAgQkxPQ0tf SU5QVVRfSU5fTUVNT1JZX0FMTE9DQVRPUlMgdGhhdCBpcyB2aXNpYmxlIHRvIHRoZSBkZWJ1 Z2dlci4KQEAgLTc1OSw5ICs3NjIsNiBAQCAjZGVmaW5lIE1BTExPQ19QUk9CRShzaXplKQkJ CVwKICAgICAgIG1hbGxvY19wcm9iZSAoc2l6ZSk7CQkJXAogICB9IHdoaWxlICgwKQogCi1z dGF0aWMgdm9pZCAqbG1hbGxvYyAoc2l6ZV90LCBib29sKSBBVFRSSUJVVEVfTUFMTE9DX1NJ WkUgKCgxKSk7Ci1zdGF0aWMgdm9pZCAqbHJlYWxsb2MgKHZvaWQgKiwgc2l6ZV90KTsKLQog LyogTGlrZSBtYWxsb2MgYnV0IGNoZWNrIGZvciBubyBtZW1vcnkgYW5kIGJsb2NrIGludGVy cnVwdCBpbnB1dC4gICovCiAKIHZvaWQgKgpAQCAtNzcwLDcgKzc3MCw3IEBAIHhtYWxsb2Mg KHNpemVfdCBzaXplKQogICB2b2lkICp2YWw7CiAKICAgTUFMTE9DX0JMT0NLX0lOUFVUOwot ICB2YWwgPSBsbWFsbG9jIChzaXplLCBmYWxzZSk7CisgIHZhbCA9IG1hbGxvYyAoc2l6ZSk7 CiAgIE1BTExPQ19VTkJMT0NLX0lOUFVUOwogCiAgIGlmICghdmFsKQpAQCAtNzg3LDcgKzc4 Nyw3IEBAIHh6YWxsb2MgKHNpemVfdCBzaXplKQogICB2b2lkICp2YWw7CiAKICAgTUFMTE9D X0JMT0NLX0lOUFVUOwotICB2YWwgPSBsbWFsbG9jIChzaXplLCB0cnVlKTsKKyAgdmFsID0g Y2FsbG9jICgxLCBzaXplKTsKICAgTUFMTE9DX1VOQkxPQ0tfSU5QVVQ7CiAKICAgaWYgKCF2 YWwpCkBAIC04MDQsMTIgKzgwNCw3IEBAIHhyZWFsbG9jICh2b2lkICpibG9jaywgc2l6ZV90 IHNpemUpCiAgIHZvaWQgKnZhbDsKIAogICBNQUxMT0NfQkxPQ0tfSU5QVVQ7Ci0gIC8qIENh bGwgbG1hbGxvYyB3aGVuIEJMT0NLIGlzIG51bGwsIGZvciB0aGUgYmVuZWZpdCBvZiBsb25n LW9ic29sZXRlCi0gICAgIHBsYXRmb3JtcyBsYWNraW5nIHN1cHBvcnQgZm9yIHJlYWxsb2Mg KE5VTEwsIHNpemUpLiAgKi8KLSAgaWYgKCEgYmxvY2spCi0gICAgdmFsID0gbG1hbGxvYyAo c2l6ZSwgZmFsc2UpOwotICBlbHNlCi0gICAgdmFsID0gbHJlYWxsb2MgKGJsb2NrLCBzaXpl KTsKKyAgdmFsID0gcmVhbGxvYyAoYmxvY2ssIHNpemUpOwogICBNQUxMT0NfVU5CTE9DS19J TlBVVDsKIAogICBpZiAoIXZhbCkKQEAgLTk5NCwxNSArOTg5LDIzIEBAIHJlY29yZF94bWFs bG9jIChzaXplX3Qgc2l6ZSkKIH0KIAogCi0vKiBMaWtlIG1hbGxvYyBidXQgdXNlZCBmb3Ig YWxsb2NhdGluZyBMaXNwIGRhdGEuICBOQllURVMgaXMgdGhlCi0gICBudW1iZXIgb2YgYnl0 ZXMgdG8gYWxsb2NhdGUsIFRZUEUgZGVzY3JpYmVzIHRoZSBpbnRlbmRlZCB1c2Ugb2YgdGhl Ci0gICBhbGxvY2F0ZWQgbWVtb3J5IGJsb2NrIChmb3Igc3RyaW5ncywgZm9yIGNvbnNlcywg Li4uKS4gICovCi0KICNpZiAhIFVTRV9MU0JfVEFHCiBleHRlcm4gdm9pZCAqbGlzcF9tYWxs b2NfbG9zZXI7CiB2b2lkICpsaXNwX21hbGxvY19sb3NlciBFWFRFUk5BTExZX1ZJU0lCTEU7 CiAjZW5kaWYKIAorLyogQWxsb2NhdGUgbWVtb3J5IGZvciBMaXNwIGRhdGEuCisgICBOQllU RVMgaXMgdGhlIG51bWJlciBvZiBieXRlcyB0byBhbGxvY2F0ZTsgaXQgbXVzdCBiZSBMaXNw LWFsaWduZWQuCisgICBJZiBDTEVBUklULCBhcnJhbmdlIGZvciB0aGUgYWxsb2NhdGVkIG1l bW9yeSB0byBiZSBjbGVhcmVkCisgICBieSB1c2luZyBjYWxsb2MsIHdoaWNoIGNhbiBiZSBm YXN0ZXIgdGhhbiBtYWxsb2MrbWVtc2V0LgorICAgVFlQRSBkZXNjcmliZXMgdGhlIGludGVu ZGVkIHVzZSBvZiB0aGUgYWxsb2NhdGVkIG1lbW9yeSBibG9jaworICAgKGZvciBzdHJpbmdz LCBmb3IgY29uc2VzLCAuLi4pLgorICAgUmV0dXJuIGEgbnVsbCBwb2ludGVyIGlmIGFuZCBv bmx5IGlmIGFsbG9jYXRpb24gZmFpbGVkLgorCisgICBDb2RlIGFsbG9jYXRpbmcgaGVhcCBt ZW1vcnkgZm9yIExpc3Agc2hvdWxkIHVzZSB0aGlzIGZ1bmN0aW9uIHRvIGdldAorICAgYSBw b2ludGVyIFA7IHRoYXQgd2F5LCBpZiBUIGlzIGFuIGVudW0gTGlzcF9UeXBlIHZhbHVlIGFu ZAorICAgTCA9PSBtYWtlX2xpc3BfcHRyIChQLCBUKSwgdGhlbiBYUE5UUiAoTCkgPT0gUCBh bmQgWFRZUEUgKEwpID09IFQuICAqLworCiBzdGF0aWMgdm9pZCAqCiBsaXNwX21hbGxvYyAo c2l6ZV90IG5ieXRlcywgYm9vbCBjbGVhcml0LCBlbnVtIG1lbV90eXBlIHR5cGUpCiB7CkBA IC0xMDE0LDcgKzEwMTcsNyBAQCBsaXNwX21hbGxvYyAoc2l6ZV90IG5ieXRlcywgYm9vbCBj bGVhcml0LCBlbnVtIG1lbV90eXBlIHR5cGUpCiAgIGFsbG9jYXRlZF9tZW1fdHlwZSA9IHR5 cGU7CiAjZW5kaWYKIAotICB2YWwgPSBsbWFsbG9jIChuYnl0ZXMsIGNsZWFyaXQpOworICB2 YWwgPSBjbGVhcml0ID8gY2FsbG9jICgxLCBuYnl0ZXMpIDogbWFsbG9jIChuYnl0ZXMpOwog CiAjaWYgISBVU0VfTFNCX1RBRwogICAvKiBJZiB0aGUgbWVtb3J5IGp1c3QgYWxsb2NhdGVk IGNhbm5vdCBiZSBhZGRyZXNzZWQgdGhydSBhIExpc3AKQEAgLTEwOTgsMTEgKzExMDEsNyBA QCBhbGlnbmVkX2FsbG9jIChzaXplX3QgYWxpZ25tZW50LCBzaXplX3Qgc2l6ZSkKICAgICAg VmVyaWZ5IHRoaXMgZm9yIGFsbCBhcmd1bWVudHMgdGhpcyBmdW5jdGlvbiBpcyBnaXZlbi4g ICovCiAgIHN0YXRpY19hc3NlcnQgKEJMT0NLX0FMSUdOICUgc2l6ZW9mICh2b2lkICopID09 IDAKIAkJICYmIFBPV0VSX09GXzIgKEJMT0NLX0FMSUdOIC8gc2l6ZW9mICh2b2lkICopKSk7 Ci0gIHN0YXRpY19hc3NlcnQgKE1BTExPQ19JU19MSVNQX0FMSUdORUQKLQkJIHx8IChMSVNQ X0FMSUdOTUVOVCAlIHNpemVvZiAodm9pZCAqKSA9PSAwCi0JCSAgICAgJiYgUE9XRVJfT0Zf MiAoTElTUF9BTElHTk1FTlQgLyBzaXplb2YgKHZvaWQgKikpKSk7Ci0gIGVhc3NlcnQgKGFs aWdubWVudCA9PSBCTE9DS19BTElHTgotCSAgIHx8ICghTUFMTE9DX0lTX0xJU1BfQUxJR05F RCAmJiBhbGlnbm1lbnQgPT0gTElTUF9BTElHTk1FTlQpKTsKKyAgZWFzc2VydCAoYWxpZ25t ZW50ID09IEJMT0NLX0FMSUdOKTsKIAogICB2b2lkICpwOwogICByZXR1cm4gcG9zaXhfbWVt YWxpZ24gKCZwLCBhbGlnbm1lbnQsIHNpemUpID09IDAgPyBwIDogMDsKQEAgLTEzNTAsODEg KzEzNDksNiBAQCBsaXNwX2FsaWduX2ZyZWUgKHZvaWQgKmJsb2NrKQogICBNQUxMT0NfVU5C TE9DS19JTlBVVDsKIH0KIAotLyogVHJ1ZSBpZiBhIG1hbGxvYy1yZXR1cm5lZCBwb2ludGVy IFAgaXMgc3VpdGFibHkgYWxpZ25lZCBmb3IgU0laRSwKLSAgIHdoZXJlIExpc3Agb2JqZWN0 IGFsaWdubWVudCBtYXkgYmUgbmVlZGVkIGlmIFNJWkUgaXMgYSBtdWx0aXBsZSBvZgotICAg TElTUF9BTElHTk1FTlQuICAqLwotCi1zdGF0aWMgYm9vbAotbGFsaWduZWQgKHZvaWQgKnAs IHNpemVfdCBzaXplKQotewotICByZXR1cm4gKE1BTExPQ19JU19MSVNQX0FMSUdORUQgfHwg KGludHB0cl90KSBwICUgTElTUF9BTElHTk1FTlQgPT0gMAotCSAgfHwgc2l6ZSAlIExJU1Bf QUxJR05NRU5UICE9IDApOwotfQotCi0vKiBMaWtlIG1hbGxvYyBhbmQgcmVhbGxvYyBleGNl cHQgcmV0dXJuIG51bGwgb25seSBvbiBmYWlsdXJlLAotICAgdGhlIHJlc3VsdCBpcyBMaXNw LWFsaWduZWQgaWYgU0laRSBpcywgYW5kIGxyZWFsbG9jJ3MgcG9pbnRlcgotICAgYXJndW1l bnQgbXVzdCBiZSBub25udWxsLiAgQ29kZSBhbGxvY2F0aW5nIEMgaGVhcCBtZW1vcnkKLSAg IGZvciBhIExpc3Agb2JqZWN0IHNob3VsZCB1c2Ugb25lIG9mIHRoZXNlIGZ1bmN0aW9ucyB0 byBvYnRhaW4gYQotICAgcG9pbnRlciBQOyB0aGF0IHdheSwgaWYgVCBpcyBhbiBlbnVtIExp c3BfVHlwZSB2YWx1ZSBhbmQgTCA9PQotICAgbWFrZV9saXNwX3B0ciAoUCwgVCksIHRoZW4g WFBOVFIgKEwpID09IFAgYW5kIFhUWVBFIChMKSA9PSBULgotCi0gICBJZiBDTEVBUklULCBh cnJhbmdlIGZvciB0aGUgYWxsb2NhdGVkIG1lbW9yeSB0byBiZSBjbGVhcmVkLgotICAgVGhp cyBtaWdodCB1c2UgY2FsbG9jLCBhcyBjYWxsb2MgY2FuIGJlIGZhc3RlciB0aGFuIG1hbGxv YyttZW1zZXQuCi0KLSAgIE9uIHR5cGljYWwgbW9kZXJuIHBsYXRmb3JtcyB0aGVzZSBmdW5j dGlvbnMnIGxvb3BzIGRvIG5vdCBpdGVyYXRlLgotICAgT24gbm93LXJhcmUgKGFuZCBwZXJo YXBzIG5vbmV4aXN0ZW50KSBwbGF0Zm9ybXMsIHRoZSBjb2RlIGNhbiBsb29wLAotICAgcmVh bGxvY2F0aW5nICh0eXBpY2FsbHkgd2l0aCBsYXJnZXIgYW5kIGxhcmdlciBzaXplcykgdW50 aWwgdGhlCi0gICBhbGxvY2F0b3IgcmV0dXJucyBhIExpc3AtYWxpZ25lZCBwb2ludGVyLiAg VGhpcyBsb29wIGluCi0gICB0aGVvcnkgY291bGQgcmVwZWF0IGZvcmV2ZXIuICBJZiBhbiBp bmZpbml0ZSBsb29wIGlzIHBvc3NpYmxlIG9uIGEKLSAgIHBsYXRmb3JtLCBhIGJ1aWxkIHdv dWxkIHN1cmVseSBsb29wIGFuZCB0aGUgYnVpbGRlciBjYW4gdGhlbiBzZW5kCi0gICB1cyBh IGJ1ZyByZXBvcnQuICBBZGRpbmcgYSBjb3VudGVyIHRvIHRyeSB0byBkZXRlY3QgYW55IHN1 Y2ggbG9vcAotICAgd291bGQgY29tcGxpY2F0ZSB0aGUgY29kZSAoYW5kIHBvc3NpYmx5IGlu dHJvZHVjZSBidWdzLCBpbiBjb2RlCi0gICB0aGF0J3MgbmV2ZXIgcmVhbGx5IGV4ZXJjaXNl ZCkgZm9yIGxpdHRsZSBiZW5lZml0LiAgKi8KLQotc3RhdGljIHZvaWQgKgotbG1hbGxvYyAo c2l6ZV90IHNpemUsIGJvb2wgY2xlYXJpdCkKLXsKLSNpZmRlZiBVU0VfQUxJR05FRF9BTExP QwotICBpZiAoISBNQUxMT0NfSVNfTElTUF9BTElHTkVEICYmIHNpemUgJSBMSVNQX0FMSUdO TUVOVCA9PSAwKQotICAgIHsKLSAgICAgIHZvaWQgKnAgPSBhbGlnbmVkX2FsbG9jIChMSVNQ X0FMSUdOTUVOVCwgc2l6ZSk7Ci0gICAgICBpZiAocCkKLQl7Ci0JICBpZiAoY2xlYXJpdCkK LQkgICAgbWVtY2xlYXIgKHAsIHNpemUpOwotCX0KLSAgICAgIGVsc2UgaWYgKCEgKE1BTExP Q18wX0lTX05PTk5VTEwgfHwgc2l6ZSkpCi0JcmV0dXJuIGFsaWduZWRfYWxsb2MgKExJU1Bf QUxJR05NRU5ULCBMSVNQX0FMSUdOTUVOVCk7Ci0gICAgICByZXR1cm4gcDsKLSAgICB9Ci0j ZW5kaWYKLQotICB3aGlsZSAodHJ1ZSkKLSAgICB7Ci0gICAgICB2b2lkICpwID0gY2xlYXJp dCA/IGNhbGxvYyAoMSwgc2l6ZSkgOiBtYWxsb2MgKHNpemUpOwotICAgICAgaWYgKGxhbGln bmVkIChwLCBzaXplKSAmJiAoTUFMTE9DXzBfSVNfTk9OTlVMTCB8fCBzaXplIHx8IHApKQot CXJldHVybiBwOwotICAgICAgZnJlZSAocCk7Ci0gICAgICBzaXplX3QgYmlnZ2VyOwotICAg ICAgaWYgKCFja2RfYWRkICgmYmlnZ2VyLCBzaXplLCBMSVNQX0FMSUdOTUVOVCkpCi0Jc2l6 ZSA9IGJpZ2dlcjsKLSAgICB9Ci19Ci0KLXN0YXRpYyB2b2lkICoKLWxyZWFsbG9jICh2b2lk ICpwLCBzaXplX3Qgc2l6ZSkKLXsKLSAgd2hpbGUgKHRydWUpCi0gICAgewotICAgICAgcCA9 IHJlYWxsb2MgKHAsIHNpemUpOwotICAgICAgaWYgKGxhbGlnbmVkIChwLCBzaXplKSAmJiAo c2l6ZSB8fCBwKSkKLQlyZXR1cm4gcDsKLSAgICAgIHNpemVfdCBiaWdnZXI7Ci0gICAgICBp ZiAoIWNrZF9hZGQgKCZiaWdnZXIsIHNpemUsIExJU1BfQUxJR05NRU5UKSkKLQlzaXplID0g YmlnZ2VyOwotICAgIH0KLX0KLQogDAogLyoqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqCiAJCQkgSW50ZXJ2 YWwgQWxsb2NhdGlvbgotLSAKMi40NS4yCgo= --------------IZewYNnB0xJKnM0AGlgL79ez-- From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2025 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 75551@debbugs.gnu.org, Eli Zaretskii Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.17370640273764 (code B ref 75551); Thu, 16 Jan 2025 21:48:01 +0000 Received: (at 75551) by debbugs.gnu.org; 16 Jan 2025 21:47:07 +0000 Received: from localhost ([127.0.0.1]:34969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYXhj-0000ye-3f for submit@debbugs.gnu.org; Thu, 16 Jan 2025 16:47:07 -0500 Received: from out-183.mta1.migadu.com ([2001:41d0:203:375::b7]:29366) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYXhh-0000y8-8I for 75551@debbugs.gnu.org; Thu, 16 Jan 2025 16:47:05 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=topbug.net; s=key1; t=1737064017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vcrbagkSxCWxSv20udGAYZZqemg6U4CDXAJj4o97t9w=; b=UFTHa9KUL3QxwuMrH2jXdvwkpIgBGJc3yXUK4YminSwenKvpqzKjGolca7DN7tVAuVZbpz FevGpkisdWq1CrCHAI6lNU0+I+3bAVebQjG9Z7zHHApmJ2U6/k1l0HK+672iSQUMEyJNtE Ox27Q+kFkm4fiA7w/jmIitaLZ8JV3/l9vwQKD9AvbxevFcCBFutKpwemhe1AD0dcycFe8Z vU4F4wRXFIkxis6o6UXlYu31Z9rL95FB/xdKY8x5yy8fv8jF4YDt/7VYj82UjvioL4Fk10 dKpIGtvVHfEJCBheYyLavsnMjq1ovwuxc/J80NcrjphpJq9nruFbJE9QuPTzfg== From: Hong Xu In-Reply-To: (Paul Eggert's message of "Wed, 15 Jan 2025 23:41:44 -0800") References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> Date: Thu, 16 Jan 2025 13:46:53 -0800 Message-ID: <871px21lf6.fsf@topbug.net> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-01-15 Wed 23:41 GMT-08, Paul Eggert wrote: > On 2025-01-15 16:11, Hong Xu wrote: >> It seems like the code is a bit less ideal to me -- on an imaginary >> oddball host, this memory exhaustion bug is so frequent that I would >> rather consider Emacs unsupported on such an oddball host. >> I agree that it may be better to just remove lrealloc > > Good points. Attached is a patch to make that change in a safe way. Please take > a look at it and give it a try. After applying the patch to the master branch, I'm getting a memory exhaustion error when starting Emacs: $ ./src/temacs -Q emacs: memory exhausted This is my backtrace: #0 memory_full (nbytes=0) at ../../src/alloc.c:4319 #1 0x0000000000600854 in xrealloc (block=0x100f180, size=0) at ../../src/alloc.c:811 #2 0x00000000005e33cc in shrink_regexp_cache () at ../../src/search.c:150 #3 0x00000000006093f6 in garbage_collect () at ../../src/alloc.c:6526 #4 0x00000000006091a1 in maybe_garbage_collect () at ../../src/alloc.c:6442 #5 0x000000000063e2a6 in maybe_gc () at ../../src/lisp.h:5979 #6 0x0000000000645632 in Ffuncall (nargs=2, args=0x7fffffffacb0) at ../../src/eval.c:3077 #7 0x0000000000657397 in mapcar1 (leni=1472, vals=0x103eea0, fn=0x9f7c0, seq=0x8ccffb ) at ../../src/fns.c:3388 #8 0x000000000065789a in Fmapconcat (function=0x9f7c0, sequence=0x8ccffb , separator=0x8a90e4 ) at ../../src/fns.c:3475 #9 0x00000000006a604e in hash_native_abi () at ../../src/comp.c:798 #10 0x0000000000564adb in main (argc=2, argv=0x7fffffffb0a8) at ../../src/emacs.c:2499 Looks like realloc with size=0 need to be specifically handled as it acts as freeing the memory and returns null. -- Hong From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2025 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Hong Xu Cc: 75551@debbugs.gnu.org, Eli Zaretskii Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.17370994605692 (code B ref 75551); Fri, 17 Jan 2025 07:38:02 +0000 Received: (at 75551) by debbugs.gnu.org; 17 Jan 2025 07:37:40 +0000 Received: from localhost ([127.0.0.1]:35835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYgvD-0001Tj-HW for submit@debbugs.gnu.org; Fri, 17 Jan 2025 02:37:40 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:60944) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYgvA-0001TT-Ky for 75551@debbugs.gnu.org; Fri, 17 Jan 2025 02:37:37 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 7E77F3C082EB9; Thu, 16 Jan 2025 23:37:30 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id F8f7zOYoATuZ; Thu, 16 Jan 2025 23:37:29 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A085A3C123847; Thu, 16 Jan 2025 23:37:29 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu A085A3C123847 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1737099449; bh=w2/8dGM2NtghdhOFKG11SGMXYKAuZXlEsoMi31ML5pA=; h=Message-ID:Date:MIME-Version:To:From; b=HGqLul9D9CmQdRxf3AWGNO3wT8rW9QsDGeT2dKjFI3aJUahOriTJC/WIPYfIvlah+ NE0R9JTAcQYzeAHoUsthIZMuyROBJl1HECEHbzkm/h4mENA4vsOuasW6dzatMt94sk +kEyz1mHK+olCwOJoy3rBbJkK4TdKZEymI/9/ulX2t5giaaZuEVUn0GtpaYwsytmSq Soq/V5YXefqpx5oMdhN2VCR6VW2wQpjsywyHJVWV79KXV1ItI16v5ugp4EjOEWYu5h DEAN+rsvpHtvD7jEktCyLo5xou7spid7MEMMCrZPCRz6toFCpy0UjLEZEaFG8+gStG BKPGaqHT+GHvg== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id 9oUuS3M3sEqx; Thu, 16 Jan 2025 23:37:29 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 7F1873C082EB9; Thu, 16 Jan 2025 23:37:29 -0800 (PST) Content-Type: multipart/mixed; boundary="------------CXP3j1pEQy7nVggSZcg49Kep" Message-ID: <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> Date: Thu, 16 Jan 2025 23:37:29 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> <871px21lf6.fsf@topbug.net> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <871px21lf6.fsf@topbug.net> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------CXP3j1pEQy7nVggSZcg49Kep Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-01-16 13:46, Hong Xu wrote: > After applying the patch to the master branch, I'm getting a memory > exhaustion error when starting Emacs: Oh, I was assuming sane malloc/realloc behavior and you tested on a platform which doesn't do that. Gnulib fixes that and I thought Emacs was already using Gnulib for this, but I now see that Emacs uses Gnulib to fix only malloc, not realloc. Please try the attached two patches instead. The first one arranges for Emacs to also fix realloc. The second one is the same patch that I gave you earlier, the patch that simplifies the lrealloc code. The MS-Windows port already fixes malloc and realloc in a different way, so the first patch should affect only non-MS-Windows platforms. --------------CXP3j1pEQy7nVggSZcg49Kep Content-Type: text/x-patch; charset=UTF-8; name="0001-Let-Gnulib-deal-with-malloc-realloc-0.patch" Content-Disposition: attachment; filename="0001-Let-Gnulib-deal-with-malloc-realloc-0.patch" Content-Transfer-Encoding: base64 RnJvbSBhOWVlMGE1ZmFlMWYyNTUxYzZhY2ZhZGFlODAzYzZkM2ZmNzY5ZDAzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDE2IEphbiAyMDI1IDIzOjI4OjM0IC0wODAwClN1YmplY3Q6IFtQQVRD SCAxLzJdIExldCBHbnVsaWIgZGVhbCB3aXRoIG1hbGxvYy9yZWFsbG9jIDAKCkluc3RlYWQg b2Ygd29ycnlpbmcgYWJvdXQgd2hldGhlciBtYWxsb2MgYW5kIHJlYWxsb2MgeWllbGQgYQpu b24tbnVsbCBwb2ludGVyIHdoZW4gZ2l2ZW4gc2l6ZSAwICh0aGUgdHJhZGl0aW9uYWwgYmVo YXZpb3IKcmVjb21tZW5kZWQgYnkgRG91ZyBNY0lscm95LCBhbmQgdGhlIG9ubHkgYmVoYXZp b3IgdGhhdCBtYWtlcwpzZW5zZSBmb3IgRW1hY3MpLCBsZXQgR251bGliIGFycmFuZ2UgZm9y IHRoZSB0cmFkaXRpb25hbCBiZWhhdmlvci4KKiBhZG1pbi9tZXJnZS1nbnVsaWIgKEdOVUxJ Ql9NT0RVTEVTKTogQWRkIG1hbGxvYy1nbnUgKHdoaWNoIHdlCndlcmUgYWxyZWFkeSBkZXBl bmRpbmcgb24gaW5kaXJlY3RseSkgYW5kIHJlYWxsb2MtcG9zaXguCiogbGliL2dudWxpYi5t ay5pbiwgbTQvZ251bGliLWNvbXAubTQ6ClJlZ2VuZXJhdGUgYnkgcnVubmluZyBhZG1pbi9t ZXJnZS1nbnVsaWIuCi0tLQogYWRtaW4vbWVyZ2UtZ251bGliIHwgIDQgKystLQogbGliL2du dWxpYi5tay5pbiAgIHwgIDggKystLS0tLS0KIG00L2dudWxpYi1jb21wLm00ICB8IDQzICsr KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDMgZmlsZXMgY2hh bmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv YWRtaW4vbWVyZ2UtZ251bGliIGIvYWRtaW4vbWVyZ2UtZ251bGliCmluZGV4IDJlYWI1YWI4 YjljLi5hZTQzMzk2MWRmMyAxMDA3NTUKLS0tIGEvYWRtaW4vbWVyZ2UtZ251bGliCisrKyBi L2FkbWluL21lcmdlLWdudWxpYgpAQCAtNDEsMTEgKzQxLDExIEBAIEdOVUxJQl9NT0RVTEVT PQogICBmcmVlLXBvc2l4IGZzdGF0YXQgZnN1c2FnZSBmc3luYyBmdXRpbWVucwogICBnZXRs aW5lIGdldGxvYWRhdmcgZ2V0b3B0LWdudSBnZXRyYW5kb20gZ2V0dGltZSBnZXR0aW1lb2Zk YXkgZ2l0bG9nLXRvLWNoYW5nZWxvZwogICBpZWVlNzU0LWggaWdub3JlLXZhbHVlIGludHBy b3BzIGxhcmdlZmlsZSBsaWJnbXAgbHN0YXQKLSAgbWFueXdhcm5pbmdzIG1lbW1lbS1zaW1w bGUgbWVtcGNweSBtZW1yY2hyIG1lbXNldF9leHBsaWNpdAorICBtYWxsb2MtZ251IG1hbnl3 YXJuaW5ncyBtZW1tZW0tc2ltcGxlIG1lbXBjcHkgbWVtcmNociBtZW1zZXRfZXhwbGljaXQK ICAgbWlubWF4IG1rb3N0ZW1wIG1rdGltZQogICBuYW5vc2xlZXAgbnByb2MgbnN0cmZ0aW1l CiAgIHBhdGhtYXggcGlwZTIgcHNlbGVjdCBwdGhyZWFkX3NpZ21hc2sKLSAgcWNvcHktYWNs IHJlYWRsaW5rIHJlYWRsaW5rYXQgcmVnZXgKKyAgcWNvcHktYWNsIHJlYWRsaW5rIHJlYWRs aW5rYXQgcmVhbGxvYy1wb3NpeCByZWdleAogICBzaWcyc3RyIHNpZ2Rlc2NyX25wIHNvY2ts ZW4gc3RhdC10aW1lIHN0ZC1nbnUxMQogICBzdGRjX2JpdF93aWR0aCBzdGRjX2NvdW50X29u ZXMgc3RkY190cmFpbGluZ196ZXJvcwogICBzdGRja2RpbnQtaCBzdGRkZWYtaCBzdGRpby1o CmRpZmYgLS1naXQgYS9saWIvZ251bGliLm1rLmluIGIvbGliL2dudWxpYi5tay5pbgppbmRl eCBjZTg3NDA0OGY0YS4uYzA0NDc1N2YyYTYgMTAwNjQ0Ci0tLSBhL2xpYi9nbnVsaWIubWsu aW4KKysrIGIvbGliL2dudWxpYi5tay5pbgpAQCAtMTMyLDYgKzEzMiw3IEBACiAjICBsYXJn ZWZpbGUgXAogIyAgbGliZ21wIFwKICMgIGxzdGF0IFwKKyMgIG1hbGxvYy1nbnUgXAogIyAg bWFueXdhcm5pbmdzIFwKICMgIG1lbW1lbS1zaW1wbGUgXAogIyAgbWVtcGNweSBcCkBAIC0x NTAsNiArMTUxLDcgQEAKICMgIHFjb3B5LWFjbCBcCiAjICByZWFkbGluayBcCiAjICByZWFk bGlua2F0IFwKKyMgIHJlYWxsb2MtcG9zaXggXAogIyAgcmVnZXggXAogIyAgc2lnMnN0ciBc CiAjICBzaWdkZXNjcl9ucCBcCkBAIC0xNDc2LDE0ICsxNDc4LDEyIEBAIGdsX0dOVUxJQl9F TkFCTEVEXzAzZTBhYWFkNGNiODljYTc1NzY1M2JkMzY3YTZjY2I3X0NPTkRJVElPTiA9IEBn bF9HTlVMSUJfRU5BQkxFCiBnbF9HTlVMSUJfRU5BQkxFRF8yNjA5NDFjMGU1ZGM2N2VjOWU4 N2QxZmIzMjFjMzAwYl9DT05ESVRJT04gPSBAZ2xfR05VTElCX0VOQUJMRURfMjYwOTQxYzBl NWRjNjdlYzllODdkMWZiMzIxYzMwMGJfQ09ORElUSU9OQAogZ2xfR05VTElCX0VOQUJMRURf NTI2NDI5NGFhMGE1NTU3NTQxYjUzYzhjNzQxZjdmMzFfQ09ORElUSU9OID0gQGdsX0dOVUxJ Ql9FTkFCTEVEXzUyNjQyOTRhYTBhNTU1NzU0MWI1M2M4Yzc0MWY3ZjMxX0NPTkRJVElPTkAK IGdsX0dOVUxJQl9FTkFCTEVEXzYwOTllOTczN2Y3NTdkYjM2YzQ3ZmE5ZDlmMDJlODhjX0NP TkRJVElPTiA9IEBnbF9HTlVMSUJfRU5BQkxFRF82MDk5ZTk3MzdmNzU3ZGIzNmM0N2ZhOWQ5 ZjAyZTg4Y19DT05ESVRJT05ACi1nbF9HTlVMSUJfRU5BQkxFRF82MWJjYWNhNzZiM2U2Zjlh ZTU1ZDU3YTFjMzE5M2JjNF9DT05ESVRJT04gPSBAZ2xfR05VTElCX0VOQUJMRURfNjFiY2Fj YTc2YjNlNmY5YWU1NWQ1N2ExYzMxOTNiYzRfQ09ORElUSU9OQAogZ2xfR05VTElCX0VOQUJM RURfODQ0NDAzNGVhNzc5Yjg4NzY4ODY1YmI2MGI0ZmI4YzlfQ09ORElUSU9OID0gQGdsX0dO VUxJQl9FTkFCTEVEXzg0NDQwMzRlYTc3OWI4ODc2ODg2NWJiNjBiNGZiOGM5X0NPTkRJVElP TkAKIGdsX0dOVUxJQl9FTkFCTEVEXzkyNTY3N2YwMzQzZGU2NGI4OWE5ZjBjNzkwYjQxMDRj X0NPTkRJVElPTiA9IEBnbF9HTlVMSUJfRU5BQkxFRF85MjU2NzdmMDM0M2RlNjRiODlhOWYw Yzc5MGI0MTA0Y19DT05ESVRJT05ACiBnbF9HTlVMSUJfRU5BQkxFRF9hOTc4Njg1MGU5OTlh ZTY1YTgzNmE2MDQxZThlNWVkMV9DT05ESVRJT04gPSBAZ2xfR05VTElCX0VOQUJMRURfYTk3 ODY4NTBlOTk5YWU2NWE4MzZhNjA0MWU4ZTVlZDFfQ09ORElUSU9OQAogZ2xfR05VTElCX0VO QUJMRURfYmU0NTNjZWM1ZWVjZjU3MzFhMjc0ZjJkZTdmMmRiMzZfQ09ORElUSU9OID0gQGds X0dOVUxJQl9FTkFCTEVEX2JlNDUzY2VjNWVlY2Y1NzMxYTI3NGYyZGU3ZjJkYjM2X0NPTkRJ VElPTkAKIGdsX0dOVUxJQl9FTkFCTEVEX2Nsb2V4ZWNfQ09ORElUSU9OID0gQGdsX0dOVUxJ Ql9FTkFCTEVEX2Nsb2V4ZWNfQ09ORElUSU9OQAogZ2xfR05VTElCX0VOQUJMRURfZGlyZmRf Q09ORElUSU9OID0gQGdsX0dOVUxJQl9FTkFCTEVEX2RpcmZkX0NPTkRJVElPTkAKLWdsX0dO VUxJQl9FTkFCTEVEX2U4MGJmNmY3NTcwOTVkMmU1ZmM5NGRhZmI4ZjhmYzhiX0NPTkRJVElP TiA9IEBnbF9HTlVMSUJfRU5BQkxFRF9lODBiZjZmNzU3MDk1ZDJlNWZjOTRkYWZiOGY4ZmM4 Yl9DT05ESVRJT05ACiBnbF9HTlVMSUJfRU5BQkxFRF9lbmRpYW5fQ09ORElUSU9OID0gQGds X0dOVUxJQl9FTkFCTEVEX2VuZGlhbl9DT05ESVRJT05ACiBnbF9HTlVMSUJfRU5BQkxFRF9l dWlkYWNjZXNzX0NPTkRJVElPTiA9IEBnbF9HTlVMSUJfRU5BQkxFRF9ldWlkYWNjZXNzX0NP TkRJVElPTkAKIGdsX0dOVUxJQl9FTkFCTEVEX2ZkMzhjN2U0NjNiNTQ3NDRiNzdiOThhZWFm YjRmYTdjX0NPTkRJVElPTiA9IEBnbF9HTlVMSUJfRU5BQkxFRF9mZDM4YzdlNDYzYjU0NzQ0 Yjc3Yjk4YWVhZmI0ZmE3Y19DT05ESVRJT05ACkBAIC0yNjg2LDkgKzI2ODYsNyBAQCBlbmRp ZgogIyMgYmVnaW4gZ251bGliIG1vZHVsZSBtYWxsb2MtZ251CiBpZmVxICgsJChPTUlUX0dO VUxJQl9NT0RVTEVfbWFsbG9jLWdudSkpCiAKLWlmbmVxICgsJChnbF9HTlVMSUJfRU5BQkxF RF9lODBiZjZmNzU3MDk1ZDJlNWZjOTRkYWZiOGY4ZmM4Yl9DT05ESVRJT04pKQogCi1lbmRp ZgogRVhUUkFfRElTVCArPSBtYWxsb2MuYwogCiBFWFRSQV9saWJnbnVfYV9TT1VSQ0VTICs9 IG1hbGxvYy5jCkBAIC0yOTMxLDEyICsyOTI5LDEwIEBAIGVuZGlmCiAjIyBiZWdpbiBnbnVs aWIgbW9kdWxlIHJlYWxsb2MtcG9zaXgKIGlmZXEgKCwkKE9NSVRfR05VTElCX01PRFVMRV9y ZWFsbG9jLXBvc2l4KSkKIAotaWZuZXEgKCwkKGdsX0dOVUxJQl9FTkFCTEVEXzYxYmNhY2E3 NmIzZTZmOWFlNTVkNTdhMWMzMTkzYmM0X0NPTkRJVElPTikpCiBpZm5lcSAoLCQoR0xfQ09O RF9PQkpfUkVBTExPQ19QT1NJWF9DT05ESVRJT04pKQogbGliZ251X2FfU09VUkNFUyArPSBy ZWFsbG9jLmMKIGVuZGlmCiAKLWVuZGlmCiBlbmRpZgogIyMgZW5kICAgZ251bGliIG1vZHVs ZSByZWFsbG9jLXBvc2l4CiAKZGlmZiAtLWdpdCBhL200L2dudWxpYi1jb21wLm00IGIvbTQv Z251bGliLWNvbXAubTQKaW5kZXggZGQwODNjYWUwNWQuLjk4MGJhZjgzOTk4IDEwMDY0NAot LS0gYS9tNC9nbnVsaWItY29tcC5tNAorKysgYi9tNC9nbnVsaWItY29tcC5tNApAQCAtNDI0 LDYgKzQyNCwxMSBAQCBBQ19ERUZVTgogICBdKQogICBnbF9TWVNfU1RBVF9NT0RVTEVfSU5E SUNBVE9SKFtsc3RhdF0pCiAgIGdsX01PRFVMRV9JTkRJQ0FUT1IoW2xzdGF0XSkKKyAgZ2xf RlVOQ19NQUxMT0NfR05VCisgIGlmIHRlc3QgJFJFUExBQ0VfTUFMTE9DX0ZPUl9NQUxMT0Nf R05VID0gMTsgdGhlbgorICAgIEFDX0xJQk9CSihbbWFsbG9jXSkKKyAgZmkKKyAgZ2xfU1RE TElCX01PRFVMRV9JTkRJQ0FUT1IoW21hbGxvYy1nbnVdKQogICBBQ19SRVFVSVJFKFtnbF9G VU5DX01BTExPQ19QT1NJWF0pCiAgIGlmIHRlc3QgJFJFUExBQ0VfTUFMTE9DX0ZPUl9NQUxM T0NfUE9TSVggPSAxOyB0aGVuCiAgICAgQUNfTElCT0JKKFttYWxsb2NdKQpAQCAtNTAyLDYg KzUwNywxMSBAQCBBQ19ERUZVTgogICBnbF9DT05ESVRJT05BTChbR0xfQ09ORF9PQkpfUkVB RExJTktBVF0sCiAgICAgICAgICAgICAgICAgIFt0ZXN0ICRIQVZFX1JFQURMSU5LQVQgPSAw IHx8IHRlc3QgJFJFUExBQ0VfUkVBRExJTktBVCA9IDFdKQogICBnbF9VTklTVERfTU9EVUxF X0lORElDQVRPUihbcmVhZGxpbmthdF0pCisgIGdsX0ZVTkNfUkVBTExPQ19QT1NJWAorICBn bF9GVU5DX1JFQUxMT0NfMF9OT05OVUxMCisgIGdsX0NPTkRJVElPTkFMKFtHTF9DT05EX09C Sl9SRUFMTE9DX1BPU0lYXSwKKyAgICAgICAgICAgICAgICAgW3Rlc3QgJFJFUExBQ0VfUkVB TExPQ19GT1JfUkVBTExPQ19QT1NJWCAhPSAwXSkKKyAgZ2xfU1RETElCX01PRFVMRV9JTkRJ Q0FUT1IoW3JlYWxsb2MtcG9zaXhdKQogICBnbF9SRUdFWAogICBnbF9DT05ESVRJT05BTChb R0xfQ09ORF9PQkpfUkVHRVhdLCBbdGVzdCAkYWNfdXNlX2luY2x1ZGVkX3JlZ2V4ID0geWVz XSkKICAgQU1fQ09ORF9JRihbR0xfQ09ORF9PQkpfUkVHRVhdLCBbCkBAIC02ODQsMTIgKzY5 NCwxMCBAQCBBQ19ERUZVTgogICBnbF9nbnVsaWJfZW5hYmxlZF84NDQ0MDM0ZWE3NzliODg3 Njg4NjViYjYwYjRmYjhjOT1mYWxzZQogICBnbF9nbnVsaWJfZW5hYmxlZF9hOTc4Njg1MGU5 OTlhZTY1YTgzNmE2MDQxZThlNWVkMT1mYWxzZQogICBnbF9nbnVsaWJfZW5hYmxlZF9sY2ht b2Q9ZmFsc2UKLSAgZ2xfZ251bGliX2VuYWJsZWRfZTgwYmY2Zjc1NzA5NWQyZTVmYzk0ZGFm YjhmOGZjOGI9ZmFsc2UKICAgZ2xfZ251bGliX2VuYWJsZWRfNTI2NDI5NGFhMGE1NTU3NTQx YjUzYzhjNzQxZjdmMzE9ZmFsc2UKICAgZ2xfZ251bGliX2VuYWJsZWRfb3Blbj1mYWxzZQog ICBnbF9nbnVsaWJfZW5hYmxlZF8wM2UwYWFhZDRjYjg5Y2E3NTc2NTNiZDM2N2E2Y2NiNz1m YWxzZQogICBnbF9nbnVsaWJfZW5hYmxlZF9yYXdtZW1jaHI9ZmFsc2UKLSAgZ2xfZ251bGli X2VuYWJsZWRfNjFiY2FjYTc2YjNlNmY5YWU1NWQ1N2ExYzMxOTNiYzQ9ZmFsc2UKICAgZ2xf Z251bGliX2VuYWJsZWRfNjA5OWU5NzM3Zjc1N2RiMzZjNDdmYTlkOWYwMmU4OGM9ZmFsc2UK ICAgZ2xfZ251bGliX2VuYWJsZWRfc3RydG9sbD1mYWxzZQogICBnbF9nbnVsaWJfZW5hYmxl ZF91dGltZW5zPWZhbHNlCkBAIC04MTEsNyArODE5LDYgQEAgQUNfREVGVU4KICAgICBpZiAk Z2xfZ251bGliX2VuYWJsZWRfODQ0NDAzNGVhNzc5Yjg4NzY4ODY1YmI2MGI0ZmI4Yzk7IHRo ZW4gOjsgZWxzZQogICAgICAgQUNfUFJPR19NS0RJUl9QCiAgICAgICBnbF9nbnVsaWJfZW5h YmxlZF84NDQ0MDM0ZWE3NzliODg3Njg4NjViYjYwYjRmYjhjOT10cnVlCi0gICAgICBmdW5j X2dsX2dudWxpYl9tNGNvZGVfNjFiY2FjYTc2YjNlNmY5YWU1NWQ1N2ExYzMxOTNiYzQKICAg ICBmaQogICB9CiAgIGZ1bmNfZ2xfZ251bGliX200Y29kZV9hOTc4Njg1MGU5OTlhZTY1YTgz NmE2MDQxZThlNWVkMSAoKQpAQCAtODI3LDkgKzgzNCw2IEBAIEFDX0RFRlVOCiAgICAgICBp ZiB0ZXN0ICRIQVZFX0dST1VQX01FTUJFUiA9IDA7IHRoZW4KICAgICAgICAgZnVuY19nbF9n bnVsaWJfbTRjb2RlX2dldGdyb3VwcwogICAgICAgZmkKLSAgICAgIGlmIHRlc3QgJEhBVkVf R1JPVVBfTUVNQkVSID0gMDsgdGhlbgotICAgICAgICBmdW5jX2dsX2dudWxpYl9tNGNvZGVf ZTgwYmY2Zjc1NzA5NWQyZTVmYzk0ZGFmYjhmOGZjOGIKLSAgICAgIGZpCiAgICAgZmkKICAg fQogICBmdW5jX2dsX2dudWxpYl9tNGNvZGVfbGNobW9kICgpCkBAIC04NDQsMTcgKzg0OCw2 IEBAIEFDX0RFRlVOCiAgICAgICBnbF9nbnVsaWJfZW5hYmxlZF9sY2htb2Q9dHJ1ZQogICAg IGZpCiAgIH0KLSAgZnVuY19nbF9nbnVsaWJfbTRjb2RlX2U4MGJmNmY3NTcwOTVkMmU1ZmM5 NGRhZmI4ZjhmYzhiICgpCi0gIHsKLSAgICBpZiAkZ2xfZ251bGliX2VuYWJsZWRfZTgwYmY2 Zjc1NzA5NWQyZTVmYzk0ZGFmYjhmOGZjOGI7IHRoZW4gOjsgZWxzZQotICAgICAgZ2xfRlVO Q19NQUxMT0NfR05VCi0gICAgICBpZiB0ZXN0ICRSRVBMQUNFX01BTExPQ19GT1JfTUFMTE9D X0dOVSA9IDE7IHRoZW4KLSAgICAgICAgQUNfTElCT0JKKFttYWxsb2NdKQotICAgICAgZmkK LSAgICAgIGdsX1NURExJQl9NT0RVTEVfSU5ESUNBVE9SKFttYWxsb2MtZ251XSkKLSAgICAg IGdsX2dudWxpYl9lbmFibGVkX2U4MGJmNmY3NTcwOTVkMmU1ZmM5NGRhZmI4ZjhmYzhiPXRy dWUKLSAgICBmaQotICB9CiAgIGZ1bmNfZ2xfZ251bGliX200Y29kZV81MjY0Mjk0YWEwYTU1 NTc1NDFiNTNjOGM3NDFmN2YzMSAoKQogICB7CiAgICAgaWYgJGdsX2dudWxpYl9lbmFibGVk XzUyNjQyOTRhYTBhNTU1NzU0MWI1M2M4Yzc0MWY3ZjMxOyB0aGVuIDo7IGVsc2UKQEAgLTg5 OSwxNyArODkyLDYgQEAgQUNfREVGVU4KICAgICAgIGdsX2dudWxpYl9lbmFibGVkX3Jhd21l bWNocj10cnVlCiAgICAgZmkKICAgfQotICBmdW5jX2dsX2dudWxpYl9tNGNvZGVfNjFiY2Fj YTc2YjNlNmY5YWU1NWQ1N2ExYzMxOTNiYzQgKCkKLSAgewotICAgIGlmICRnbF9nbnVsaWJf ZW5hYmxlZF82MWJjYWNhNzZiM2U2ZjlhZTU1ZDU3YTFjMzE5M2JjNDsgdGhlbiA6OyBlbHNl Ci0gICAgICBnbF9GVU5DX1JFQUxMT0NfUE9TSVgKLSAgICAgIGdsX0ZVTkNfUkVBTExPQ18w X05PTk5VTEwKLSAgICAgIGdsX0NPTkRJVElPTkFMKFtHTF9DT05EX09CSl9SRUFMTE9DX1BP U0lYXSwKLSAgICAgICAgICAgICAgICAgICAgIFt0ZXN0ICRSRVBMQUNFX1JFQUxMT0NfRk9S X1JFQUxMT0NfUE9TSVggIT0gMF0pCi0gICAgICBnbF9TVERMSUJfTU9EVUxFX0lORElDQVRP UihbcmVhbGxvYy1wb3NpeF0pCi0gICAgICBnbF9nbnVsaWJfZW5hYmxlZF82MWJjYWNhNzZi M2U2ZjlhZTU1ZDU3YTFjMzE5M2JjND10cnVlCi0gICAgZmkKLSAgfQogICBmdW5jX2dsX2du dWxpYl9tNGNvZGVfNjA5OWU5NzM3Zjc1N2RiMzZjNDdmYTlkOWYwMmU4OGMgKCkKICAgewog ICAgIGlmICRnbF9nbnVsaWJfZW5hYmxlZF82MDk5ZTk3MzdmNzU3ZGIzNmM0N2ZhOWQ5ZjAy ZTg4YzsgdGhlbiA6OyBlbHNlCkBAIC0xMDExLDkgKzk5Myw2IEBAIEFDX0RFRlVOCiAgIGlm IHRlc3QgJGFjX3VzZV9pbmNsdWRlZF9yZWdleCA9IHllczsgdGhlbgogICAgIGZ1bmNfZ2xf Z251bGliX200Y29kZV9mZDM4YzdlNDYzYjU0NzQ0Yjc3Yjk4YWVhZmI0ZmE3YwogICBmaQot ICBpZiB0ZXN0ICRhY191c2VfaW5jbHVkZWRfcmVnZXggPSB5ZXM7IHRoZW4KLSAgICBmdW5j X2dsX2dudWxpYl9tNGNvZGVfZTgwYmY2Zjc1NzA5NWQyZTVmYzk0ZGFmYjhmOGZjOGIKLSAg ZmkKICAgaWYgdGVzdCAkYWNfdXNlX2luY2x1ZGVkX3JlZ2V4ID0geWVzOyB0aGVuCiAgICAg ZnVuY19nbF9nbnVsaWJfbTRjb2RlX3ZlcmlmeQogICBmaQpAQCAtMTA0NywxMiArMTAyNiwx MCBAQCBBQ19ERUZVTgogICBBTV9DT05ESVRJT05BTChbZ2xfR05VTElCX0VOQUJMRURfODQ0 NDAzNGVhNzc5Yjg4NzY4ODY1YmI2MGI0ZmI4YzldLCBbJGdsX2dudWxpYl9lbmFibGVkXzg0 NDQwMzRlYTc3OWI4ODc2ODg2NWJiNjBiNGZiOGM5XSkKICAgQU1fQ09ORElUSU9OQUwoW2ds X0dOVUxJQl9FTkFCTEVEX2E5Nzg2ODUwZTk5OWFlNjVhODM2YTYwNDFlOGU1ZWQxXSwgWyRn bF9nbnVsaWJfZW5hYmxlZF9hOTc4Njg1MGU5OTlhZTY1YTgzNmE2MDQxZThlNWVkMV0pCiAg IEFNX0NPTkRJVElPTkFMKFtnbF9HTlVMSUJfRU5BQkxFRF9sY2htb2RdLCBbJGdsX2dudWxp Yl9lbmFibGVkX2xjaG1vZF0pCi0gIEFNX0NPTkRJVElPTkFMKFtnbF9HTlVMSUJfRU5BQkxF RF9lODBiZjZmNzU3MDk1ZDJlNWZjOTRkYWZiOGY4ZmM4Yl0sIFskZ2xfZ251bGliX2VuYWJs ZWRfZTgwYmY2Zjc1NzA5NWQyZTVmYzk0ZGFmYjhmOGZjOGJdKQogICBBTV9DT05ESVRJT05B TChbZ2xfR05VTElCX0VOQUJMRURfNTI2NDI5NGFhMGE1NTU3NTQxYjUzYzhjNzQxZjdmMzFd LCBbJGdsX2dudWxpYl9lbmFibGVkXzUyNjQyOTRhYTBhNTU1NzU0MWI1M2M4Yzc0MWY3ZjMx XSkKICAgQU1fQ09ORElUSU9OQUwoW2dsX0dOVUxJQl9FTkFCTEVEX29wZW5dLCBbJGdsX2du dWxpYl9lbmFibGVkX29wZW5dKQogICBBTV9DT05ESVRJT05BTChbZ2xfR05VTElCX0VOQUJM RURfMDNlMGFhYWQ0Y2I4OWNhNzU3NjUzYmQzNjdhNmNjYjddLCBbJGdsX2dudWxpYl9lbmFi bGVkXzAzZTBhYWFkNGNiODljYTc1NzY1M2JkMzY3YTZjY2I3XSkKICAgQU1fQ09ORElUSU9O QUwoW2dsX0dOVUxJQl9FTkFCTEVEX3Jhd21lbWNocl0sIFskZ2xfZ251bGliX2VuYWJsZWRf cmF3bWVtY2hyXSkKLSAgQU1fQ09ORElUSU9OQUwoW2dsX0dOVUxJQl9FTkFCTEVEXzYxYmNh Y2E3NmIzZTZmOWFlNTVkNTdhMWMzMTkzYmM0XSwgWyRnbF9nbnVsaWJfZW5hYmxlZF82MWJj YWNhNzZiM2U2ZjlhZTU1ZDU3YTFjMzE5M2JjNF0pCiAgIEFNX0NPTkRJVElPTkFMKFtnbF9H TlVMSUJfRU5BQkxFRF82MDk5ZTk3MzdmNzU3ZGIzNmM0N2ZhOWQ5ZjAyZTg4Y10sIFskZ2xf Z251bGliX2VuYWJsZWRfNjA5OWU5NzM3Zjc1N2RiMzZjNDdmYTlkOWYwMmU4OGNdKQogICBB TV9DT05ESVRJT05BTChbZ2xfR05VTElCX0VOQUJMRURfc3RydG9sbF0sIFskZ2xfZ251bGli X2VuYWJsZWRfc3RydG9sbF0pCiAgIEFNX0NPTkRJVElPTkFMKFtnbF9HTlVMSUJfRU5BQkxF RF91dGltZW5zXSwgWyRnbF9nbnVsaWJfZW5hYmxlZF91dGltZW5zXSkKLS0gCjIuNDUuMgoK --------------CXP3j1pEQy7nVggSZcg49Kep Content-Type: text/x-patch; charset=UTF-8; name="0002-Simplify-alloc-by-assuming-MALLOC_IS_LISP_ALIGNED.patch" Content-Disposition: attachment; filename*0="0002-Simplify-alloc-by-assuming-MALLOC_IS_LISP_ALIGNED.patch" Content-Transfer-Encoding: base64 RnJvbSA3ZDk0ZDAwZGRjMmU4MmU1Y2NiYmM1YWViNzZmNDdjOGYyOTlkNzE3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDE1IEphbiAyMDI1IDIzOjMyOjQzIC0wODAwClN1YmplY3Q6IFtQQVRD SCAyLzJdIFNpbXBsaWZ5IGFsbG9jIGJ5IGFzc3VtaW5nIE1BTExPQ19JU19MSVNQX0FMSUdO RUQKClByb2JsZW0gcmVwb3J0ZWQgYnkgSG9uZyBYdSA8aHR0cHM6Ly9idWdzLmdudS5vcmcv NzU1NTEjMTQ+LgoqIHNyYy9hbGxvYy5jIChNQUxMT0NfSVNfTElTUF9BTElHTkVEKTogc3Rh dGljX2Fzc2VydCBpdCwKc2luY2UgaXQgaXMgdHJ1ZSBvbiBhbGwgY3VycmVudCBFbWFjcyBw bGF0Zm9ybXMuCkFsbCB1c2VzIHNpbXBsaWZpZWQgdG8gYXNzdW1lIGl0IGlzIHRydWUuCih4 bWFsbG9jLCB4emFsbG9jLCB4cmVhbGxvYywgbGlzcF9tYWxsb2MpOiBKdXN0IHVzZQptYWxs b2MvY2FsbG9jL3JlYWxsb2MuICBTaW5jZSB3ZSBhcmUgdXNpbmcgdGhlIG1hbGxvYy1nbnUK YW5kIHJlYWxsb2MtcG9zaXggbW9kdWxlcywgd2UgbmVlZCBub3Qgd29ycnkgYWJvdXQgd2hl dGhlcgp0aGVzZSBmdW5jdGlvbnMgcmV0dXJuIGEgbnVsbCBwb2ludGVyIGZvciB6ZXJvLXNp emUgcmVxdWVzdHMuCih4cmVhbGxvYyk6IFN0b3Agd29ycnlpbmcgYWJvdXQgbm8tbG9uZ2Vy LWV4aXN0aW5nIHBsYXRmb3Jtcwp3aGVyZSByZWFsbG9jIChudWxscHRyLCAuLi4pIGRpZCBu b3Qgd29yay4KKGxhbGlnbmVkLCBsbWFsbG9jLCBscmVhbGxvYyk6IFJlbW92ZS4gIEFsbCB1 c2VzIHJlbW92ZWQuCi0tLQogc3JjL2FsbG9jLmMgfCAxMjggKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI2 IGluc2VydGlvbnMoKyksIDEwMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYWxs b2MuYyBiL3NyYy9hbGxvYy5jCmluZGV4IDgzMDdjNzRjMTA2Li5lNzI5MGM1NWY4OCAxMDA2 NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3JjL2FsbG9jLmMKQEAgLTcwNCwyMSArNzA0 LDI0IEBAICNkZWZpbmUgQ09NTU9OX01VTFRJUExFKGEsIGIpIFwKICAgKChhKSAlIChiKSA9 PSAwID8gKGEpIDogKGIpICUgKGEpID09IDAgPyAoYikgOiAoYSkgKiAoYikpCiAKIC8qIEFs aWdubWVudCBuZWVkZWQgZm9yIG1lbW9yeSBibG9ja3MgdGhhdCBhcmUgYWxsb2NhdGVkIHZp YSBtYWxsb2MKLSAgIGFuZCB0aGF0IGNvbnRhaW4gTGlzcCBvYmplY3RzLiAgT24gdHlwaWNh bCBob3N0cyBtYWxsb2MgYWxyZWFkeQotICAgYWxpZ25zIHN1ZmZpY2llbnRseSwgYnV0IGV4 dHJhIHdvcmsgaXMgbmVlZGVkIG9uIG9kZGJhbGwgaG9zdHMKLSAgIHdoZXJlIEVtYWNzIHdv dWxkIGNyYXNoIGlmIG1hbGxvYyByZXR1cm5lZCBhIG5vbi1HQ0FMSUdORUQgcG9pbnRlci4g ICovCisgICBhbmQgdGhhdCBjb250YWluIExpc3Agb2JqZWN0cy4gICovCiBlbnVtIHsgTElT UF9BTElHTk1FTlQgPSBhbGlnbm9mICh1bmlvbiB7IHVuaW9uIGVtYWNzX2FsaWduX3R5cGUg eDsKIAkJCQkJIEdDQUxJR05FRF9VTklPTl9NRU1CRVIgfSkgfTsKIHN0YXRpY19hc3NlcnQg KExJU1BfQUxJR05NRU5UICUgR0NBTElHTk1FTlQgPT0gMCk7CiAKLS8qIFRydWUgaWYgbWFs bG9jIChOKSBpcyBrbm93biB0byByZXR1cm4gc3RvcmFnZSBzdWl0YWJseSBhbGlnbmVkIGZv cgotICAgTGlzcCBvYmplY3RzIHdoZW5ldmVyIE4gaXMgYSBtdWx0aXBsZSBvZiBMSVNQX0FM SUdOTUVOVC4gIEluCi0gICBwcmFjdGljZSB0aGlzIGlzIHRydWUgd2hlbmV2ZXIgYWxpZ25v ZiAobWF4X2FsaWduX3QpIGlzIGFsc28gYQorLyogVmVyaWZ5IEVtYWNzJ3MgYXNzdW1wdGlv biB0aGF0IG1hbGxvYyAoTikgcmV0dXJucyBzdG9yYWdlIHN1aXRhYmx5CisgICBhbGlnbmVk IGZvciBMaXNwIG9iamVjdHMgd2hlbmV2ZXIgTiBpcyBhIG11bHRpcGxlIG9mIExJU1BfQUxJ R05NRU5ULgorICAgVGhpcyBhc3N1bXB0aW9uIGhvbGRzIGZvciBjdXJyZW50IEVtYWNzIHBv cnRpbmcgdGFyZ2V0czsKKyAgIGlmIHRoZSBhc3N1bXB0aW9uIGZhaWxzIG9uIGEgbmV3IHBs YXRmb3JtLCB0aGlzIGNoZWNrIHNob3VsZAorICAgY2F1c2UgY29tcGlsYXRpb24gdG8gZmFp bCBhbmQgc29tZSBwb3J0aW5nIHdvcmsgd2lsbCBuZWVkIHRvIGJlIGRvbmUuCisKKyAgIElu IHByYWN0aWNlIHRoZSBhc3N1bXB0aW9uIGhvbGRzIHdoZW4gYWxpZ25vZiAobWF4X2FsaWdu X3QpIGlzIGFsc28gYQogICAgbXVsdGlwbGUgb2YgTElTUF9BTElHTk1FTlQuICBUaGlzIHdv cmtzIGV2ZW4gZm9yIGJ1Z2d5IHBsYXRmb3JtcwogICAgbGlrZSBNaW5HVyBjaXJjYSAyMDIw LCB3aGVyZSBhbGlnbm9mIChtYXhfYWxpZ25fdCkgaXMgMTYgZXZlbiB0aG91Z2gKICAgIHRo ZSBtYWxsb2MgYWxpZ25tZW50IGlzIG9ubHkgOCwgYW5kIHdoZXJlIEVtYWNzIHN0aWxsIHdv cmtzIGJlY2F1c2UKICAgIGl0IG5ldmVyIGRvZXMgYW55dGhpbmcgdGhhdCByZXF1aXJlcyBh biBhbGlnbm1lbnQgb2YgMTYuICAqLwogZW51bSB7IE1BTExPQ19JU19MSVNQX0FMSUdORUQg PSBhbGlnbm9mIChtYXhfYWxpZ25fdCkgJSBMSVNQX0FMSUdOTUVOVCA9PSAwIH07CitzdGF0 aWNfYXNzZXJ0IChNQUxMT0NfSVNfTElTUF9BTElHTkVEKTsKIAogLyogSWYgY29tcGlsZWQg d2l0aCBYTUFMTE9DX0JMT0NLX0lOUFVUX0NIRUNLLCBkZWZpbmUgYSBzeW1ib2wKICAgIEJM T0NLX0lOUFVUX0lOX01FTU9SWV9BTExPQ0FUT1JTIHRoYXQgaXMgdmlzaWJsZSB0byB0aGUg ZGVidWdnZXIuCkBAIC03NTksOSArNzYyLDYgQEAgI2RlZmluZSBNQUxMT0NfUFJPQkUoc2l6 ZSkJCQlcCiAgICAgICBtYWxsb2NfcHJvYmUgKHNpemUpOwkJCVwKICAgfSB3aGlsZSAoMCkK IAotc3RhdGljIHZvaWQgKmxtYWxsb2MgKHNpemVfdCwgYm9vbCkgQVRUUklCVVRFX01BTExP Q19TSVpFICgoMSkpOwotc3RhdGljIHZvaWQgKmxyZWFsbG9jICh2b2lkICosIHNpemVfdCk7 Ci0KIC8qIExpa2UgbWFsbG9jIGJ1dCBjaGVjayBmb3Igbm8gbWVtb3J5IGFuZCBibG9jayBp bnRlcnJ1cHQgaW5wdXQuICAqLwogCiB2b2lkICoKQEAgLTc3MCw3ICs3NzAsNyBAQCB4bWFs bG9jIChzaXplX3Qgc2l6ZSkKICAgdm9pZCAqdmFsOwogCiAgIE1BTExPQ19CTE9DS19JTlBV VDsKLSAgdmFsID0gbG1hbGxvYyAoc2l6ZSwgZmFsc2UpOworICB2YWwgPSBtYWxsb2MgKHNp emUpOwogICBNQUxMT0NfVU5CTE9DS19JTlBVVDsKIAogICBpZiAoIXZhbCkKQEAgLTc4Nyw3 ICs3ODcsNyBAQCB4emFsbG9jIChzaXplX3Qgc2l6ZSkKICAgdm9pZCAqdmFsOwogCiAgIE1B TExPQ19CTE9DS19JTlBVVDsKLSAgdmFsID0gbG1hbGxvYyAoc2l6ZSwgdHJ1ZSk7CisgIHZh bCA9IGNhbGxvYyAoMSwgc2l6ZSk7CiAgIE1BTExPQ19VTkJMT0NLX0lOUFVUOwogCiAgIGlm ICghdmFsKQpAQCAtODA0LDEyICs4MDQsNyBAQCB4cmVhbGxvYyAodm9pZCAqYmxvY2ssIHNp emVfdCBzaXplKQogICB2b2lkICp2YWw7CiAKICAgTUFMTE9DX0JMT0NLX0lOUFVUOwotICAv KiBDYWxsIGxtYWxsb2Mgd2hlbiBCTE9DSyBpcyBudWxsLCBmb3IgdGhlIGJlbmVmaXQgb2Yg bG9uZy1vYnNvbGV0ZQotICAgICBwbGF0Zm9ybXMgbGFja2luZyBzdXBwb3J0IGZvciByZWFs bG9jIChOVUxMLCBzaXplKS4gICovCi0gIGlmICghIGJsb2NrKQotICAgIHZhbCA9IGxtYWxs b2MgKHNpemUsIGZhbHNlKTsKLSAgZWxzZQotICAgIHZhbCA9IGxyZWFsbG9jIChibG9jaywg c2l6ZSk7CisgIHZhbCA9IHJlYWxsb2MgKGJsb2NrLCBzaXplKTsKICAgTUFMTE9DX1VOQkxP Q0tfSU5QVVQ7CiAKICAgaWYgKCF2YWwpCkBAIC05OTQsMTUgKzk4OSwyMyBAQCByZWNvcmRf eG1hbGxvYyAoc2l6ZV90IHNpemUpCiB9CiAKIAotLyogTGlrZSBtYWxsb2MgYnV0IHVzZWQg Zm9yIGFsbG9jYXRpbmcgTGlzcCBkYXRhLiAgTkJZVEVTIGlzIHRoZQotICAgbnVtYmVyIG9m IGJ5dGVzIHRvIGFsbG9jYXRlLCBUWVBFIGRlc2NyaWJlcyB0aGUgaW50ZW5kZWQgdXNlIG9m IHRoZQotICAgYWxsb2NhdGVkIG1lbW9yeSBibG9jayAoZm9yIHN0cmluZ3MsIGZvciBjb25z ZXMsIC4uLikuICAqLwotCiAjaWYgISBVU0VfTFNCX1RBRwogZXh0ZXJuIHZvaWQgKmxpc3Bf bWFsbG9jX2xvc2VyOwogdm9pZCAqbGlzcF9tYWxsb2NfbG9zZXIgRVhURVJOQUxMWV9WSVNJ QkxFOwogI2VuZGlmCiAKKy8qIEFsbG9jYXRlIG1lbW9yeSBmb3IgTGlzcCBkYXRhLgorICAg TkJZVEVTIGlzIHRoZSBudW1iZXIgb2YgYnl0ZXMgdG8gYWxsb2NhdGU7IGl0IG11c3QgYmUg TGlzcC1hbGlnbmVkLgorICAgSWYgQ0xFQVJJVCwgYXJyYW5nZSBmb3IgdGhlIGFsbG9jYXRl ZCBtZW1vcnkgdG8gYmUgY2xlYXJlZAorICAgYnkgdXNpbmcgY2FsbG9jLCB3aGljaCBjYW4g YmUgZmFzdGVyIHRoYW4gbWFsbG9jK21lbXNldC4KKyAgIFRZUEUgZGVzY3JpYmVzIHRoZSBp bnRlbmRlZCB1c2Ugb2YgdGhlIGFsbG9jYXRlZCBtZW1vcnkgYmxvY2sKKyAgIChmb3Igc3Ry aW5ncywgZm9yIGNvbnNlcywgLi4uKS4KKyAgIFJldHVybiBhIG51bGwgcG9pbnRlciBpZiBh bmQgb25seSBpZiBhbGxvY2F0aW9uIGZhaWxlZC4KKworICAgQ29kZSBhbGxvY2F0aW5nIGhl YXAgbWVtb3J5IGZvciBMaXNwIHNob3VsZCB1c2UgdGhpcyBmdW5jdGlvbiB0byBnZXQKKyAg IGEgcG9pbnRlciBQOyB0aGF0IHdheSwgaWYgVCBpcyBhbiBlbnVtIExpc3BfVHlwZSB2YWx1 ZSBhbmQKKyAgIEwgPT0gbWFrZV9saXNwX3B0ciAoUCwgVCksIHRoZW4gWFBOVFIgKEwpID09 IFAgYW5kIFhUWVBFIChMKSA9PSBULiAgKi8KKwogc3RhdGljIHZvaWQgKgogbGlzcF9tYWxs b2MgKHNpemVfdCBuYnl0ZXMsIGJvb2wgY2xlYXJpdCwgZW51bSBtZW1fdHlwZSB0eXBlKQog ewpAQCAtMTAxNCw3ICsxMDE3LDcgQEAgbGlzcF9tYWxsb2MgKHNpemVfdCBuYnl0ZXMsIGJv b2wgY2xlYXJpdCwgZW51bSBtZW1fdHlwZSB0eXBlKQogICBhbGxvY2F0ZWRfbWVtX3R5cGUg PSB0eXBlOwogI2VuZGlmCiAKLSAgdmFsID0gbG1hbGxvYyAobmJ5dGVzLCBjbGVhcml0KTsK KyAgdmFsID0gY2xlYXJpdCA/IGNhbGxvYyAoMSwgbmJ5dGVzKSA6IG1hbGxvYyAobmJ5dGVz KTsKIAogI2lmICEgVVNFX0xTQl9UQUcKICAgLyogSWYgdGhlIG1lbW9yeSBqdXN0IGFsbG9j YXRlZCBjYW5ub3QgYmUgYWRkcmVzc2VkIHRocnUgYSBMaXNwCkBAIC0xMDk4LDExICsxMTAx LDcgQEAgYWxpZ25lZF9hbGxvYyAoc2l6ZV90IGFsaWdubWVudCwgc2l6ZV90IHNpemUpCiAg ICAgIFZlcmlmeSB0aGlzIGZvciBhbGwgYXJndW1lbnRzIHRoaXMgZnVuY3Rpb24gaXMgZ2l2 ZW4uICAqLwogICBzdGF0aWNfYXNzZXJ0IChCTE9DS19BTElHTiAlIHNpemVvZiAodm9pZCAq KSA9PSAwCiAJCSAmJiBQT1dFUl9PRl8yIChCTE9DS19BTElHTiAvIHNpemVvZiAodm9pZCAq KSkpOwotICBzdGF0aWNfYXNzZXJ0IChNQUxMT0NfSVNfTElTUF9BTElHTkVECi0JCSB8fCAo TElTUF9BTElHTk1FTlQgJSBzaXplb2YgKHZvaWQgKikgPT0gMAotCQkgICAgICYmIFBPV0VS X09GXzIgKExJU1BfQUxJR05NRU5UIC8gc2l6ZW9mICh2b2lkICopKSkpOwotICBlYXNzZXJ0 IChhbGlnbm1lbnQgPT0gQkxPQ0tfQUxJR04KLQkgICB8fCAoIU1BTExPQ19JU19MSVNQX0FM SUdORUQgJiYgYWxpZ25tZW50ID09IExJU1BfQUxJR05NRU5UKSk7CisgIGVhc3NlcnQgKGFs aWdubWVudCA9PSBCTE9DS19BTElHTik7CiAKICAgdm9pZCAqcDsKICAgcmV0dXJuIHBvc2l4 X21lbWFsaWduICgmcCwgYWxpZ25tZW50LCBzaXplKSA9PSAwID8gcCA6IDA7CkBAIC0xMzUw LDgxICsxMzQ5LDYgQEAgbGlzcF9hbGlnbl9mcmVlICh2b2lkICpibG9jaykKICAgTUFMTE9D X1VOQkxPQ0tfSU5QVVQ7CiB9CiAKLS8qIFRydWUgaWYgYSBtYWxsb2MtcmV0dXJuZWQgcG9p bnRlciBQIGlzIHN1aXRhYmx5IGFsaWduZWQgZm9yIFNJWkUsCi0gICB3aGVyZSBMaXNwIG9i amVjdCBhbGlnbm1lbnQgbWF5IGJlIG5lZWRlZCBpZiBTSVpFIGlzIGEgbXVsdGlwbGUgb2YK LSAgIExJU1BfQUxJR05NRU5ULiAgKi8KLQotc3RhdGljIGJvb2wKLWxhbGlnbmVkICh2b2lk ICpwLCBzaXplX3Qgc2l6ZSkKLXsKLSAgcmV0dXJuIChNQUxMT0NfSVNfTElTUF9BTElHTkVE IHx8IChpbnRwdHJfdCkgcCAlIExJU1BfQUxJR05NRU5UID09IDAKLQkgIHx8IHNpemUgJSBM SVNQX0FMSUdOTUVOVCAhPSAwKTsKLX0KLQotLyogTGlrZSBtYWxsb2MgYW5kIHJlYWxsb2Mg ZXhjZXB0IHJldHVybiBudWxsIG9ubHkgb24gZmFpbHVyZSwKLSAgIHRoZSByZXN1bHQgaXMg TGlzcC1hbGlnbmVkIGlmIFNJWkUgaXMsIGFuZCBscmVhbGxvYydzIHBvaW50ZXIKLSAgIGFy Z3VtZW50IG11c3QgYmUgbm9ubnVsbC4gIENvZGUgYWxsb2NhdGluZyBDIGhlYXAgbWVtb3J5 Ci0gICBmb3IgYSBMaXNwIG9iamVjdCBzaG91bGQgdXNlIG9uZSBvZiB0aGVzZSBmdW5jdGlv bnMgdG8gb2J0YWluIGEKLSAgIHBvaW50ZXIgUDsgdGhhdCB3YXksIGlmIFQgaXMgYW4gZW51 bSBMaXNwX1R5cGUgdmFsdWUgYW5kIEwgPT0KLSAgIG1ha2VfbGlzcF9wdHIgKFAsIFQpLCB0 aGVuIFhQTlRSIChMKSA9PSBQIGFuZCBYVFlQRSAoTCkgPT0gVC4KLQotICAgSWYgQ0xFQVJJ VCwgYXJyYW5nZSBmb3IgdGhlIGFsbG9jYXRlZCBtZW1vcnkgdG8gYmUgY2xlYXJlZC4KLSAg IFRoaXMgbWlnaHQgdXNlIGNhbGxvYywgYXMgY2FsbG9jIGNhbiBiZSBmYXN0ZXIgdGhhbiBt YWxsb2MrbWVtc2V0LgotCi0gICBPbiB0eXBpY2FsIG1vZGVybiBwbGF0Zm9ybXMgdGhlc2Ug ZnVuY3Rpb25zJyBsb29wcyBkbyBub3QgaXRlcmF0ZS4KLSAgIE9uIG5vdy1yYXJlIChhbmQg cGVyaGFwcyBub25leGlzdGVudCkgcGxhdGZvcm1zLCB0aGUgY29kZSBjYW4gbG9vcCwKLSAg IHJlYWxsb2NhdGluZyAodHlwaWNhbGx5IHdpdGggbGFyZ2VyIGFuZCBsYXJnZXIgc2l6ZXMp IHVudGlsIHRoZQotICAgYWxsb2NhdG9yIHJldHVybnMgYSBMaXNwLWFsaWduZWQgcG9pbnRl ci4gIFRoaXMgbG9vcCBpbgotICAgdGhlb3J5IGNvdWxkIHJlcGVhdCBmb3JldmVyLiAgSWYg YW4gaW5maW5pdGUgbG9vcCBpcyBwb3NzaWJsZSBvbiBhCi0gICBwbGF0Zm9ybSwgYSBidWls ZCB3b3VsZCBzdXJlbHkgbG9vcCBhbmQgdGhlIGJ1aWxkZXIgY2FuIHRoZW4gc2VuZAotICAg dXMgYSBidWcgcmVwb3J0LiAgQWRkaW5nIGEgY291bnRlciB0byB0cnkgdG8gZGV0ZWN0IGFu eSBzdWNoIGxvb3AKLSAgIHdvdWxkIGNvbXBsaWNhdGUgdGhlIGNvZGUgKGFuZCBwb3NzaWJs eSBpbnRyb2R1Y2UgYnVncywgaW4gY29kZQotICAgdGhhdCdzIG5ldmVyIHJlYWxseSBleGVy Y2lzZWQpIGZvciBsaXR0bGUgYmVuZWZpdC4gICovCi0KLXN0YXRpYyB2b2lkICoKLWxtYWxs b2MgKHNpemVfdCBzaXplLCBib29sIGNsZWFyaXQpCi17Ci0jaWZkZWYgVVNFX0FMSUdORURf QUxMT0MKLSAgaWYgKCEgTUFMTE9DX0lTX0xJU1BfQUxJR05FRCAmJiBzaXplICUgTElTUF9B TElHTk1FTlQgPT0gMCkKLSAgICB7Ci0gICAgICB2b2lkICpwID0gYWxpZ25lZF9hbGxvYyAo TElTUF9BTElHTk1FTlQsIHNpemUpOwotICAgICAgaWYgKHApCi0JewotCSAgaWYgKGNsZWFy aXQpCi0JICAgIG1lbWNsZWFyIChwLCBzaXplKTsKLQl9Ci0gICAgICBlbHNlIGlmICghIChN QUxMT0NfMF9JU19OT05OVUxMIHx8IHNpemUpKQotCXJldHVybiBhbGlnbmVkX2FsbG9jIChM SVNQX0FMSUdOTUVOVCwgTElTUF9BTElHTk1FTlQpOwotICAgICAgcmV0dXJuIHA7Ci0gICAg fQotI2VuZGlmCi0KLSAgd2hpbGUgKHRydWUpCi0gICAgewotICAgICAgdm9pZCAqcCA9IGNs ZWFyaXQgPyBjYWxsb2MgKDEsIHNpemUpIDogbWFsbG9jIChzaXplKTsKLSAgICAgIGlmIChs YWxpZ25lZCAocCwgc2l6ZSkgJiYgKE1BTExPQ18wX0lTX05PTk5VTEwgfHwgc2l6ZSB8fCBw KSkKLQlyZXR1cm4gcDsKLSAgICAgIGZyZWUgKHApOwotICAgICAgc2l6ZV90IGJpZ2dlcjsK LSAgICAgIGlmICghY2tkX2FkZCAoJmJpZ2dlciwgc2l6ZSwgTElTUF9BTElHTk1FTlQpKQot CXNpemUgPSBiaWdnZXI7Ci0gICAgfQotfQotCi1zdGF0aWMgdm9pZCAqCi1scmVhbGxvYyAo dm9pZCAqcCwgc2l6ZV90IHNpemUpCi17Ci0gIHdoaWxlICh0cnVlKQotICAgIHsKLSAgICAg IHAgPSByZWFsbG9jIChwLCBzaXplKTsKLSAgICAgIGlmIChsYWxpZ25lZCAocCwgc2l6ZSkg JiYgKHNpemUgfHwgcCkpCi0JcmV0dXJuIHA7Ci0gICAgICBzaXplX3QgYmlnZ2VyOwotICAg ICAgaWYgKCFja2RfYWRkICgmYmlnZ2VyLCBzaXplLCBMSVNQX0FMSUdOTUVOVCkpCi0Jc2l6 ZSA9IGJpZ2dlcjsKLSAgICB9Ci19Ci0KIAwKIC8qKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgogCQkJIElu dGVydmFsIEFsbG9jYXRpb24KLS0gCjIuNDUuMgoK --------------CXP3j1pEQy7nVggSZcg49Kep-- From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2025 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 75551@debbugs.gnu.org, Eli Zaretskii Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173714795928200 (code B ref 75551); Fri, 17 Jan 2025 21:06:02 +0000 Received: (at 75551) by debbugs.gnu.org; 17 Jan 2025 21:05:59 +0000 Received: from localhost ([127.0.0.1]:39029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYtXS-0007Kl-VX for submit@debbugs.gnu.org; Fri, 17 Jan 2025 16:05:59 -0500 Received: from out-173.mta1.migadu.com ([2001:41d0:203:375::ad]:38848) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYtXQ-0007KV-BG for 75551@debbugs.gnu.org; Fri, 17 Jan 2025 16:05:57 -0500 Message-ID: <1ed33476-6073-48b6-99a5-f5df75e4b746@topbug.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=topbug.net; s=key1; t=1737147949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AabzdiwD6/ptfYfPjX5pySjbaUKwTCVQ5N/C1pJoZk8=; b=miY+U4KfD9OIe2z2YXOq8427adgTDUTuYETKhhRTfZ6ww9IDgo/Ubi6dO8RW4odfHWHQSx fyykIBYxNI3lUk/JtQIpXH+xyNnZfDnYoOu2RvvPT+OKTU+vUFtFvCwn+qgmab10Kb8CQ8 Bf8A8apWgP37wTQeqkrclLEBRTBREwSPsKpxga+H68MSbMgI0hk1mle/x7brL2gLJlm3f/ +8qlQpy1cETlcpFZBog6bJ8bwDVRzDt7bC+eLfmzpEj0IvrINpQFW9KrtziLV4YF5fRgXK n+Nv9+JgYBvYdzTBDGLydFoS5mfMzYSwVSEK0Tb7FJzFrHVkdqvmc8/KZrx5bQ== Date: Fri, 17 Jan 2025 13:05:36 -0800 MIME-Version: 1.0 References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> <871px21lf6.fsf@topbug.net> <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Hong Xu In-Reply-To: <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu 2025/01/16 23:37:29-0800 (PST), Paul Eggert wrote: > On 2025-01-16 13:46, Hong Xu wrote: >> After applying the patch to the master branch, I'm getting a memory >> exhaustion error when starting Emacs: > > Oh, I was assuming sane malloc/realloc behavior and you tested on a platform which doesn't do that. Gnulib fixes that and I thought Emacs was already using Gnulib for this, but I now see that Emacs uses Gnulib to fix only malloc, not realloc. > > Please try the attached two patches instead. The first one arranges for Emacs to also fix realloc. The second one is the same patch that I gave you earlier, the patch that simplifies the lrealloc code. > > The MS-Windows port already fixes malloc and realloc in a different way, so the first patch should affect only non-MS-Windows platforms. Thanks, the patch looks good to me and works well on my host! From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2025 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 75551@debbugs.gnu.org, hong@topbug.net Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173714808128435 (code B ref 75551); Fri, 17 Jan 2025 21:08:01 +0000 Received: (at 75551) by debbugs.gnu.org; 17 Jan 2025 21:08:01 +0000 Received: from localhost ([127.0.0.1]:39035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYtZQ-0007OY-L6 for submit@debbugs.gnu.org; Fri, 17 Jan 2025 16:08:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60906) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYtZP-0007OH-5Z for 75551@debbugs.gnu.org; Fri, 17 Jan 2025 16:07:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYtZJ-0006eh-1i; Fri, 17 Jan 2025 16:07:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3fq9xSzxbahrrT1xPrMV5L5Rl4mTIxfcS+JTf0iYl+g=; b=LYN7qeaIAtDt qQcAJfLxyv8ya+lnuTQFXoSAUZvRguZDmgqOZAtmWfUaEbeRjSeRdWqkSVSuhJj6BFCKDLmWtYhxs tiPgsFitIxqlclSGqpF+Tsn7diml09V1ihpQ24hC8ifnOIAKKq+IpzSqij1deClQi88DMnk6uv40S U+hdb2OmT6k4PshLV7uABuQjbfYH75fhCNHLTprDY/uNFW13PMP7YAigvhAzvJGdIcPwUOR3uRimQ p7GisxlU6DGbXdEJMVehu23/N8bvfouVjxahKW8k7hGucwoPRcroGHNDfP/lJR8XMRWllgdNN33mT U+RqZUFv52NJz+2gqMOWkA==; Date: Fri, 17 Jan 2025 23:07:50 +0200 Message-Id: <86o705cfo9.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> (message from Paul Eggert on Thu, 16 Jan 2025 23:37:29 -0800) References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> <871px21lf6.fsf@topbug.net> <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 16 Jan 2025 23:37:29 -0800 > Cc: Eli Zaretskii , 75551@debbugs.gnu.org > From: Paul Eggert > > The MS-Windows port already fixes malloc and realloc in a different way, > so the first patch should affect only non-MS-Windows platforms. Since you add the realloc-posix module, it will need to be omitted on MS-Windows. From unknown Sat Aug 16 19:14:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Hong Xu Subject: bug#75551: closed (Re: bug#75551: Potentially erroneous long loop in lrealloc) Message-ID: References: <9b738e2e-76ea-43cb-8764-c6bb58c738a2@cs.ucla.edu> <87plkq3z4t.fsf@topbug.net> X-Gnu-PR-Message: they-closed 75551 X-Gnu-PR-Package: emacs Reply-To: 75551@debbugs.gnu.org Date: Fri, 17 Jan 2025 23:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1737158282-27693-1" This is a multi-part message in MIME format... ------------=_1737158282-27693-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75551: Potentially erroneous long loop in lrealloc which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75551@debbugs.gnu.org. --=20 75551: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75551 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1737158282-27693-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75551-done) by debbugs.gnu.org; 17 Jan 2025 23:57:15 +0000 Received: from localhost ([127.0.0.1]:39337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYwDC-0007Be-VU for submit@debbugs.gnu.org; Fri, 17 Jan 2025 18:57:15 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:45094) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYwDA-0007BN-Af for 75551-done@debbugs.gnu.org; Fri, 17 Jan 2025 18:57:13 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8E6213C123862; Fri, 17 Jan 2025 15:57:06 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id ymsMEx9HAxQe; Fri, 17 Jan 2025 15:57:06 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 5302D3C123863; Fri, 17 Jan 2025 15:57:06 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 5302D3C123863 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1737158226; bh=jvxxpyx8sfKmbIuTBSernQg4EoQVO/NlXatNTYLqX9c=; h=Message-ID:Date:MIME-Version:To:From; b=RxQtL1FjQG+ra8JgRzL80aRigf1VFnNIoGCaSqn/sgvbbBXw7cvfkGUNQy7FBT54m bUhgIVdkCuEXF6XJsBBl+Q2+CT/bd07tSSzCjptB59zFRjL7Hhtk857vKOC1Npxp06 1vIgA0IciFPt9qYakdJ4GbIJ5Yud5/tHLoj8F73Y6HCcJmPG/GjMK67Bl8j2iuqwGw wCrMqQwhewh8xxDOzCvQLrbdKe8TpgZtZiDYpzkAO+KT9dtJKHo7JsM2uk0LJ7x/tW 1TMC866sJDB9lUS/Ut7cVtzL6+UE+s0ATlpkYbtidDFDxwy3KP8DSxL0/OKd3dNUmD oBYK9cEqjiWCg== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id NioO4pDQmglz; Fri, 17 Jan 2025 15:57:06 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 3749C3C123862; Fri, 17 Jan 2025 15:57:06 -0800 (PST) Message-ID: <9b738e2e-76ea-43cb-8764-c6bb58c738a2@cs.ucla.edu> Date: Fri, 17 Jan 2025 15:57:05 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#75551: Potentially erroneous long loop in lrealloc To: Hong Xu References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> <871px21lf6.fsf@topbug.net> <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> <1ed33476-6073-48b6-99a5-f5df75e4b746@topbug.net> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <1ed33476-6073-48b6-99a5-f5df75e4b746@topbug.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75551-done Cc: 75551-done@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-01-17 13:05, Hong Xu wrote: > Thanks, the patch looks good to me and works well on my host! Thanks for checking. I installed it on the master branch and am marking this bug as done. ------------=_1737158282-27693-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jan 2025 02:31:21 +0000 Received: from localhost ([127.0.0.1]:53424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXWi9-0003sp-Bo for submit@debbugs.gnu.org; Mon, 13 Jan 2025 21:31:21 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52790) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tXWi6-0003sR-9T for submit@debbugs.gnu.org; Mon, 13 Jan 2025 21:31:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXWhz-0001gZ-UF for bug-gnu-emacs@gnu.org; Mon, 13 Jan 2025 21:31:11 -0500 Received: from sender4-of-o54.zoho.com ([136.143.188.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXWhw-0000xT-1o for bug-gnu-emacs@gnu.org; Mon, 13 Jan 2025 21:31:11 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1736821861; cv=none; d=zohomail.com; s=zohoarc; b=mce6KwXPEpqBjCwx4LCkJvWmbc19h950SsJLgYVxmysBvs0CIwbiyHa4dfQdBX67L1TApxKsNoBXrCvRpLeDPECWjaxejCN+UGXwukRuDyIgPy+qUj0/UuhEyum5ngl3FQMHX/4cAeqK1N1NVjFro5XG80vy+8SNMGDUOA7quow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1736821861; h=Content-Type:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=nT8oiVYjIOnJn9iNqygjXp9mOuf2FaymIEbjeNwErgc=; b=UTdHUGoAg/QbKGevMzqAJE4X5wMsCuIbmJEq8nHi/TYP+NayVG6fRVsaxczdofgCxIKx0Flf+u0+I7mQVmtVH4jc2htf1Op3jqvWMBiJqwZ1N5ffezNG+6WewsiV5tAav1w0nBY3U4U0AH6XUV3D4UMQN1zq7I6d7vaXTOZgTqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=topbug.net; spf=pass smtp.mailfrom=hong@topbug.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1736821861; s=zoho; d=topbug.net; i=hong@topbug.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=nT8oiVYjIOnJn9iNqygjXp9mOuf2FaymIEbjeNwErgc=; b=SXSMvmXqdZyfmn/buKXOvXEnkCRc7aUn+QR2QlOsWCpDYNUdrK80hwm9WtbEjtkp Tm83w0DM3Et0qeMDkowL4fTUp5ONSyfAmmfjF+kXiY0uhymruxmadEH8LnTvBGVBRTr sQx47GGbKTU68LP57Lmm0T9AvftufrmTnVX9xEBQ= Received: by mx.zohomail.com with SMTPS id 1736821859894540.7416289092154; Mon, 13 Jan 2025 18:30:59 -0800 (PST) From: Hong Xu To: bug-gnu-emacs Subject: Potentially erroneous long loop in lrealloc User-Agent: mu4e 1.12.8; emacs 29.4 Date: Mon, 13 Jan 2025 18:30:58 -0800 Message-ID: <87plkq3z4t.fsf@topbug.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.54; envelope-from=hong@topbug.net; helo=sender4-of-o54.zoho.com X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.787, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) lrealloc has a loop that keeps checking alignment by calling laligned: while (true) { p = realloc (p, size); if (laligned (p, size) && (size || p)) return p; size_t bigger = size + LISP_ALIGNMENT; if (size < bigger) size = bigger; } Note that the loop increment size by LISP_ALIGNMENT each time if the conditions are not satisfied. One check in aligned is size % LISP_ALIGNMENT != 0: static bool laligned (void *p, size_t size) { return (MALLOC_IS_LISP_ALIGNED || (intptr_t) p % LISP_ALIGNMENT == 0 || size % LISP_ALIGNMENT != 0); } Consider a host where MALLOC_IS_LISP_ALIGNED is false and p % LISP_ALIGNMENT is frequently nonzero. if lrealloc is called with size being a multiplier of LISP_ALIGNMENT, the loop can take a long time to end until p % LISP_ALIGNMENT == 0, potentially until OOM. Based on my understanding, this part is to address some "oddball" hosts (based on the comment in alloc.c). But this does seem like a bug to me if Emacs is running on such an oddball host... -- Hong ------------=_1737158282-27693-1-- From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2025 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 75551@debbugs.gnu.org, hong@topbug.net Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173715832727803 (code B ref 75551); Fri, 17 Jan 2025 23:59:02 +0000 Received: (at 75551) by debbugs.gnu.org; 17 Jan 2025 23:58:47 +0000 Received: from localhost ([127.0.0.1]:39345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYwEh-0007EN-Ex for submit@debbugs.gnu.org; Fri, 17 Jan 2025 18:58:47 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:57002) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYwEe-0007E5-BX for 75551@debbugs.gnu.org; Fri, 17 Jan 2025 18:58:46 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id BF3FD3C123862; Fri, 17 Jan 2025 15:58:38 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id XlT_tzHAs7Dq; Fri, 17 Jan 2025 15:58:38 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 66C913C123863; Fri, 17 Jan 2025 15:58:38 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 66C913C123863 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1737158318; bh=2urOaYgxAbqVgqhiDI0/8d97X7nigLcBzDmIfa9w58A=; h=Message-ID:Date:MIME-Version:To:From; b=L1njZtMh1pMNY8oGjD9loW2doOfI4OFiwYxi7gtPiqHvCjiIE6MPZcEXKOwmtoVj8 wuAbrDd1HVIRx6xBKdGVAjSNe9rVU+Uz9Hv1YpGzC9ydxZY2jlfIPlVsmTXRyO4ULS FtMt19LL6RcG+x9YHMxo31W0ONIajfJhcVCdHyiSgA40FIBKjYJ21E9+9Sbi4MGd+J g37Kt5HKGPLOyMhur9hagrC3Y/YOnuiuSYK5L1bSn9cJh4TfVA6rHSzYEADDZHWV8F jBWlo4MWlGB+FNG1494L3bgpGRBFhMbXL3J4vIjNhGQnNUT6Vhvop0BlnCZzGEAfbf BdT+4qKE3CEyQ== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id mvSstnYnxRmt; Fri, 17 Jan 2025 15:58:38 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 44DB23C123862; Fri, 17 Jan 2025 15:58:38 -0800 (PST) Message-ID: <005f8272-5cb7-457e-a293-88c812031337@cs.ucla.edu> Date: Fri, 17 Jan 2025 15:58:38 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> <871px21lf6.fsf@topbug.net> <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> <86o705cfo9.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <86o705cfo9.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-01-17 13:07, Eli Zaretskii wrote: >> Date: Thu, 16 Jan 2025 23:37:29 -0800 >> Cc: Eli Zaretskii , 75551@debbugs.gnu.org >> From: Paul Eggert >> >> The MS-Windows port already fixes malloc and realloc in a different way, >> so the first patch should affect only non-MS-Windows platforms. > > Since you add the realloc-posix module, it will need to be omitted on > MS-Windows. I already did that in 2021 in commit 1a65d49931ebc37adc48cd2406220b586e62f778, which added OMIT_GNULIB_MODULE_realloc-posix to nt/gnulib-cfg.mk. That line hasn't been needed for some time, but it'll be needed now that Emacs is using realloc-posix directly. By the way, nt/gnulib-cfg.mk seems to contain some other OMIT_GNULIB_MODULE_* lines it no longer needs. A quick check suggests the following Gnulib modules have unnecessary lines like that. These unnecessary lines don't break builds of course. float fpucw [probably a typo for fputcw but that isn't needed either] fseterr realloc-gnu secure_getenv signbit size_max stpncpy xsize From unknown Sat Aug 16 19:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75551: Potentially erroneous long loop in lrealloc Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Jan 2025 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 75551@debbugs.gnu.org, hong@topbug.net Received: via spool by 75551-submit@debbugs.gnu.org id=B75551.173718635719171 (code B ref 75551); Sat, 18 Jan 2025 07:46:02 +0000 Received: (at 75551) by debbugs.gnu.org; 18 Jan 2025 07:45:57 +0000 Received: from localhost ([127.0.0.1]:39815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZ3Wm-0004z9-UM for submit@debbugs.gnu.org; Sat, 18 Jan 2025 02:45:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48184) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tZ3Wk-0004yr-7m for 75551@debbugs.gnu.org; Sat, 18 Jan 2025 02:45:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tZ3Wd-0005fG-Uw; Sat, 18 Jan 2025 02:45:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q5kbDxMMMOxBSrog77P0IuXlMkXsbyh5715yd9iPZ94=; b=CFbpHNfGBQBI bKEftRHoto5Clh42nPZjBZl1XLy3v8ifcGkVism3GHcZsfhM6N39ZaPX4YxY148KoTEmsLCY83aSf rIaDut5CwvT1xIKAyuVkt+0PKYZ+G/q9fMq4/9/692UrJUQad+eL76ksR83BnUA8X7Lk+fzIvGqv/ s60+tNNO0pZExRede9Oyv/an9IaQsr8wcv//CUB7ZXgEKlvErFwXXZaoDTSPMJDGGyd1s0juZZDAi kIL3j2sIlAgM2BSYGAIK5yEb4FzBicYH1B4tY1romLgYWI26o4MXT+PGWhxfI+xAORhB0FGR1mToj Yh/S251SqT8Sq2FIarw7QQ==; Date: Sat, 18 Jan 2025 09:45:33 +0200 Message-Id: <86jzasd0pu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <005f8272-5cb7-457e-a293-88c812031337@cs.ucla.edu> (message from Paul Eggert on Fri, 17 Jan 2025 15:58:38 -0800) References: <87plkq3z4t.fsf@topbug.net> <86wmeyt6fp.fsf@gnu.org> <38312c28-5808-449f-9bce-28bfb8705775@cs.ucla.edu> <87plknobxg.fsf@topbug.net> <871px21lf6.fsf@topbug.net> <282ea38f-6c64-46fd-9a4d-fcac264fbc80@cs.ucla.edu> <86o705cfo9.fsf@gnu.org> <005f8272-5cb7-457e-a293-88c812031337@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 17 Jan 2025 15:58:38 -0800 > Cc: hong@topbug.net, 75551@debbugs.gnu.org > From: Paul Eggert > > On 2025-01-17 13:07, Eli Zaretskii wrote: > >> Date: Thu, 16 Jan 2025 23:37:29 -0800 > >> Cc: Eli Zaretskii , 75551@debbugs.gnu.org > >> From: Paul Eggert > >> > >> The MS-Windows port already fixes malloc and realloc in a different way, > >> so the first patch should affect only non-MS-Windows platforms. > > > > Since you add the realloc-posix module, it will need to be omitted on > > MS-Windows. > > I already did that in 2021 in commit > 1a65d49931ebc37adc48cd2406220b586e62f778, which added > OMIT_GNULIB_MODULE_realloc-posix to nt/gnulib-cfg.mk. That line hasn't > been needed for some time, but it'll be needed now that Emacs is using > realloc-posix directly. Right, thanks. > By the way, nt/gnulib-cfg.mk seems to contain some other > OMIT_GNULIB_MODULE_* lines it no longer needs. A quick check suggests > the following Gnulib modules have unnecessary lines like that. These > unnecessary lines don't break builds of course. Thanks, I removed them now.