GNU bug report logs - #75530
[PATCH 0/3] Consistently remap read-only-mode for special edit modes

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liam Hupfer <liam <at> hpfr.net>
Cc: 75530 <at> debbugs.gnu.org
Subject: bug#75530: [PATCH 1/3] Remap read-only-mode in wdired-mode-map
Date: Sun, 02 Feb 2025 21:38:16 +0200

> From: Liam Hupfer <liam <at> hpfr.net>
> Cc: 75530 <at> debbugs.gnu.org
> Date: Sun, 02 Feb 2025 13:22:17 -0600
> 
> >> +—
> >> +*** wdired-exit binding now respects changes to read-only-mode.
> >> +Previously ’wdired-mode-map’ bound ’wdired-exit’ to ’C-x C-q’. Now a
> >> +remap of ’read-only-mode’ is used. This matches Dired’s
> >> +’wdired-change-to-wdired-mode’ binding.
> >
> > Also, this entry should mention the key bindings explicitly, since
> > that is what is being remapped.  And the last sentence is not needed,
> > since NEWS doesn’t normally need to justify the changes, only to
> > describe them.
> 
> Can you give an example of what you expect here? Since the default
> ‘read-only-mode’ binding is also C-x C-q, the only user-facing aspect of
> this change is the remap itself. Users who don’t change their
> ‘read-only-mode’ binding will not notice any difference.

Instead of talking about remapping read-only-mode, I'd like NEWS to
explain what that means from the user POV.  I presume you wanted to
allow users bind read-only-mode to something other than "C-x C-q", and
have wdired-exit binding to follow suit.  This is what the NEWS entry
should say.  Talking about remapping describes the implementation, not
the user-facing changes in behavior.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.