GNU bug report logs - #75530
[PATCH 0/3] Consistently remap read-only-mode for special edit modes

Previous Next

Full log

Message #20 received at 75530 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liam Hupfer <liam <at> hpfr.net>
Cc: 75530 <at> debbugs.gnu.org
Subject: Re: bug#75530: [PATCH 1/3] Remap read-only-mode in wdired-mode-map
Date: Sat, 18 Jan 2025 12:23:02 +0200

> Cc: Liam Hupfer <liam <at> hpfr.net>
> From: Liam Hupfer <liam <at> hpfr.net>
> Date: Sun, 12 Jan 2025 19:00:34 -0600
> 
> dired-mode-map already remaps read-only-mode to dired-toggle-read-only.
> Make wdired-mode-map remap as well, instead of hardcoding the default
> C-x C-q.

Thanks.

> * lisp/wdired.el (wdired-mode-map): Remap read-only-mode to wdired-exit.
> * etc/NEWS (Dired): Document remap.
> ---
>  etc/NEWS       | 6 ++++++
>  lisp/wdired.el | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/etc/NEWS b/etc/NEWS
> index d017c872fa3..220730c2cc0 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -785,6 +785,12 @@ Without 'dired-hide-details-hide-absolute-location':
>  When 'dired-make-directory-clickable' is non-nil, clicking on the base
>  name of the directory now reverts the Dired buffer.
>  
> +---
> +*** wdired-exit binding now respects changes to read-only-mode.
> +Previously 'wdired-mode-map' bound 'wdired-exit' to 'C-x C-q'. Now a
> +remap of 'read-only-mode' is used. This matches Dired's
> +'wdired-change-to-wdired-mode' binding.

Please leave two spaces between sentences, per our conventions.

Also, this entry should mention the key bindings explicitly, since
that is what is being remapped.  And the last sentence is not needed,
since NEWS doesn't normally need to justify the changes, only to
describe them.

P.S. When you submit modified patches, please mention the bug number
in the commit log message.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.