Subject: Re: bug#75530: [PATCH 1/3] Remap read-only-mode in wdired-mode-map

From: Liam Hupfer <[email-masked]>
Date: Sun, 02 Feb 2025 13:22:17 -0600

Thanks for the review Eli!

Eli Zaretskii <[email-masked]> writes:
>> diff –git a/etc/NEWS b/etc/NEWS
>> index d017c872fa3..220730c2cc0 100644
>> — a/etc/NEWS
>> +++ b/etc/NEWS
>> @@ -785,6 +785,12 @@ Without ’dired-hide-details-hide-absolute-location’:
>>  When ’dired-make-directory-clickable’ is non-nil, clicking on the base
>>  name of the directory now reverts the Dired buffer.
>>  
>> +—
>> +*** wdired-exit binding now respects changes to read-only-mode.
>> +Previously ’wdired-mode-map’ bound ’wdired-exit’ to ’C-x C-q’. Now a
>> +remap of ’read-only-mode’ is used. This matches Dired’s
>> +’wdired-change-to-wdired-mode’ binding.
>
> Also, this entry should mention the key bindings explicitly, since
> that is what is being remapped.  And the last sentence is not needed,
> since NEWS doesn’t normally need to justify the changes, only to
> describe them.

Can you give an example of what you expect here? Since the default
‘read-only-mode’ binding is also C-x C-q, the only user-facing aspect of
this change is the remap itself. Users who don’t change their
‘read-only-mode’ binding will not notice any difference.

—Liam