GNU bug report logs - #75526
python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75526: closed (python.el uses treesit-declare-unavailable-functions
 despite requiring emacs >v24.4)
Date: Sun, 02 Mar 2025 17:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 2 Mar 2025 09:55:23 -0800
with message-id <CADwFkm=V5FMRfY5CDBi=eREq_VBT2JBShRqSD6VBCYxW5z3opg <at> mail.gmail.com>
and subject line Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4
has caused the debbugs.gnu.org bug report #75526,
regarding python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75526: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75526
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: JD Smith <jdtsmith <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: python.el uses treesit-declare-unavailable-functions despite
 requiring emacs >v24.4
Date: Sun, 12 Jan 2025 16:45:58 -0500

The TS support in python.el breaks versions of emacs prior to v30, since it calls the recently introduced macro `treesit-declare-unavailable-functions`.  The header still notes:

;; Version: 0.28
;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23"))
;; Maintainer: emacs-devel <at> gnu.org

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Philip Kaludercic <philipk <at> posteo.net>
Cc: mail <at> daniel-mendler.de, casouri <at> gmail.com, 75526-done <at> debbugs.gnu.org,
 JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions
 despite requiring emacs >v24.4
Date: Sun, 2 Mar 2025 09:55:23 -0800

Version: 31.1

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> We definitely don't want to translate those into fontlock.
> AFAIK, there are just two ways to solve this:
>
> - Bump package-requires to Emacs-29.
> - Use (require 'treesit nil t) and than sprinkle enough `fboundp` tests
>   around treesitter code to allow loading `python.el` into Emacs<29.
>   It's perfectly OK if `python-ts-mode` doesn't work in Emacs<29.
>
> Bumping package-requires to 29 might not be a bad idea since noone
> complained (until now) in the 2½ years since we added (require 'treesit)
> to the code.

True, so let's just save us a ton of headache:

I have bumped the requirement to Emacs 29.1, which fixes all the
outstanding issues reported here.  With that, I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.