GNU bug report logs - #75526
python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4

Previous Next

Full log

View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: Philip Kaludercic <philipk <at> posteo.net>, JD Smith <jdtsmith <at> gmail.com>, Stefan Kangas <stefankangas <at> gmail.com>, 75526 <at> debbugs.gnu.org
Subject: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4
Date: Mon, 27 Jan 2025 19:56:52 -0800

> On Jan 24, 2025, at 11:02 PM, Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
> 
> Stefan Kangas <stefankangas <at> gmail.com> writes:
> 
>> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>> 
>>> Stefan Kangas <stefankangas <at> gmail.com> writes:
>>> 
>>>> JD Smith <jdtsmith <at> gmail.com> writes:
>>>> 
>>>>> The TS support in python.el breaks versions of emacs prior to v30, since it calls the recently introduced macro `treesit-declare-unavailable-functions`.  The header still notes:
>>>>> 
>>>>> ;; Version: 0.28
>>>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23"))
>>>>> ;; Maintainer: emacs-devel <at> gnu.org
>>>> 
>>>> Maybe this could be fixed in compat?
>>> 
>>> Yes, we can add the macro `treesit-declare-unavailable-functions` to
>>> Compat. But python.el needs to `(require 'treesit nil 'noerror)` instead
>>> of `(require 'treesit)`.
>> 
>> Thanks.  Please let us know when this is implemented and which version
>> of compat we should require.  Then we can also make the above change at
>> the same time.
> 
> Yes, but it will take a while until compat-31 is released. We usually
> release at the time of the branch creation of the corresponding Emacs
> version (emacs-31). Until then, it is probably better to revert the
> change in python.el.
> 
> Daniel

Thanks, I reverted it on master.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.