From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 12 16:46:21 2025 Received: (at submit) by debbugs.gnu.org; 12 Jan 2025 21:46:22 +0000 Received: from localhost ([127.0.0.1]:49336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tX5mn-0000an-Kv for submit@debbugs.gnu.org; Sun, 12 Jan 2025 16:46:21 -0500 Received: from lists.gnu.org ([2001:470:142::17]:53714) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tX5ml-0000aa-6H for submit@debbugs.gnu.org; Sun, 12 Jan 2025 16:46:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tX5mf-0003Fa-JH for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2025 16:46:13 -0500 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tX5md-0002k4-UT for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2025 16:46:13 -0500 Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-7b6eb531e13so204041285a.0 for ; Sun, 12 Jan 2025 13:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736718370; x=1737323170; darn=gnu.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=zU8V9/N1dFbE2C5J0neaP3DTWkEpy6yKGIr1nb5fPcs=; b=FbvmW4Sb+ZnpekVLCzpwaLqiVFmTVpqgKLVitte0Ej8Litd75aWc8Bqkn2iJ1kOs1l zLONWzJoRNI49UDG7TtcpLLtnde8a5xvyqlUy7PEhHZXMOlHTnFPN9rsqRyInJpA+kVm 1tO1U6bsXIE7pzOL477YCaKtJ4WK0ZETGyeNFbOI/mC0FSLSuRxGhPKoq4LDiPYxjF0V JIFlq1mqJEsFxpqb8J9hFFfSVpF4XD/d/+QE57tuSeUXoaTJ6vldkQBNi9HyvsA+dEjJ XT2I+QZTqCz1gx7K2vvBuiYHpVNTcbwq2rezjG62G3cGH5hu2PbrvfmT3Skh1lIFqRbu iMrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736718370; x=1737323170; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zU8V9/N1dFbE2C5J0neaP3DTWkEpy6yKGIr1nb5fPcs=; b=e/0vTABMC0FA1jT2G5JMG8FUwJRGSRakZDR6YQbxdCEr7btaGoflXnq6MO+cOz27P0 juMPxnGEStVtkycCdsLiINyppR1hS5uPWBKgfVevuX4F1qwKc+eKrSZ2GpG0FBX4TmRW NNlGNOl//ZDdIuz0eV8fSPeByckjj1XAnWvTgnDTHtCBojK0crvdsJU6nd2PjipheizT eKbDkvcwaC2We47Ld0ezXl1kh9CI2dGhBC92g+3Sn4uhUyaIUUtvdDiJsWuJ/Mr/K3wI RgB0c74UUBC/J6/b2VPFvxOx1xVE9a135JVEV1NdeUCvujT5W2xm3eY2ApLejsx4gMOu fOvg== X-Gm-Message-State: AOJu0Yz7Kk2MCWGSmuloTa42ZPGuakmSZ/+qkjkr1DetoyXOIaZVfVD5 jrrPPTU/2wmu7gM6ullYnhwVri8yqyTiJHyNnU8B62VJEFVvSDc3javaRQ== X-Gm-Gg: ASbGncvhDOlHRIqI/ItjbC1fXCHkV2942V61vMxtBi7DvoQ2BaE1Bo88CQIJ2oMWoBI w+5qY85cFcdMfMFlFC0THCmXAjL6Apvbem58lGMQzIniJGo6t+tkEXtO3ovcxyZjhoUS4Cnihw9 yIS1uo6NlLkxcWbHVn7UAdsk5w2izP15dauPG8UGzLTgp/ouA13oVWNAQjLzhLTJjtpctkFiMUv uScxkxba23M7koAl3x2RG5Y6I040IOTP5cwkFAYXOozTyXQmlsRd3JquiCihg3BzKEnLXrehK+J UUO3+F0bNZ7V18nIx5f1lntF+xuu X-Google-Smtp-Source: AGHT+IH4o5tvJ4AGrwC/x8FEx+zG8OLPsZ5gZUAeXUQeJ5V0ZSyuCQs4DyCly1bCBc6j4L+AsRwb+g== X-Received: by 2002:a05:620a:178c:b0:7b6:e20c:1a0e with SMTP id af79cd13be357-7bcd9787b48mr2828597885a.51.1736718370214; Sun, 12 Jan 2025 13:46:10 -0800 (PST) Received: from smtpclient.apple (cm-24-53-185-196.buckeyecom.net. [24.53.185.196]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce35031acsm420184185a.88.2025.01.12.13.46.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jan 2025 13:46:09 -0800 (PST) From: JD Smith Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 Message-Id: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> Date: Sun, 12 Jan 2025 16:45:58 -0500 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3826.300.87.4.3) Received-SPF: pass client-ip=2607:f8b0:4864:20::72a; envelope-from=jdtsmith@gmail.com; helo=mail-qk1-x72a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The TS support in python.el breaks versions of emacs prior to v30, since = it calls the recently introduced macro = `treesit-declare-unavailable-functions`. The header still notes: ;; Version: 0.28 ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23")) ;; Maintainer: emacs-devel@gnu.org From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 12 17:29:52 2025 Received: (at 75526) by debbugs.gnu.org; 12 Jan 2025 22:29:52 +0000 Received: from localhost ([127.0.0.1]:49392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tX6Su-0005RV-0A for submit@debbugs.gnu.org; Sun, 12 Jan 2025 17:29:52 -0500 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:52499) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tX6Sp-0005RC-Ek for 75526@debbugs.gnu.org; Sun, 12 Jan 2025 17:29:49 -0500 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-aaedd529ba1so536626566b.1 for <75526@debbugs.gnu.org>; Sun, 12 Jan 2025 14:29:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736720981; x=1737325781; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=VYhdJSHFEOr6aStUYqmPPR9Fb51+W1Bff7aXT4PoQec=; b=ETAYr4OgpKkYQhcxEEN+ulV/RkJIJkx2LKsw4dOO7wSwy2ZpqTNT7GxrWb8p8Dej8g hkPgL9xbh3X3723KN4qlHVZPbq+TEPSodDatqOf9mQ2D5XmkWGXsNmT/T7tGvLUo6Nc+ p15XA18r0RwtG2EyyHFfVluH8jF/TDV42bjlRTEu5An2A+XID7xizYNobghDkXWEfy8E i9GOebNIxlCX/o5ijFiYmyH+xaZo8mLZTheNVZt4WhhFo0bfoMP5GKgZU4E/RMKzmTjT R5Ld92glvF8tEL1LCr0UN3A3XkVrv6BYFRguIFZNCLbfgt2cOocI75VLy9o5FxyfIt2o 49zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736720981; x=1737325781; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VYhdJSHFEOr6aStUYqmPPR9Fb51+W1Bff7aXT4PoQec=; b=ZsbIp3zsFyXx14AjxIlJirMuJ2ZZc5y4WE2isN8eDIZo2gr+Ls8KfWj19QI82iLc2x rTg1zYjBz2yCgyjFCWMkibmlvQt+fTDF/iK3DhRHZc+aRX6A4OfACsosYBOTtukbZV3g WrRgj3NFh77GrOavTI4xmEP4+jl/yTnnln1fekFEC5hZU/V21Tbs535xLjH1iGMrn0Zj NwuymSG/7qkfwY7Qw2VZ5Kt+7klZr09fJE3qPQYohwkU4ElgaXPPC5pyu5xrTOiHnoVM XdczxPSDZIA5e3SLd6dRiE5HhuSXXZ/PJBIEORTLfxMViqF9sF9UppuOMjgH4AurJfrm nebA== X-Forwarded-Encrypted: i=1; AJvYcCVMHZhnlV6I8YgECH11Joz8EvyF0PmJZ3Je+9tKnAPkfqcr2xwvd3GOQOtuB9xOB/ep0hlvSg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzYqoUOKrXKNjLtjP3NDEyf2HdV1gv1x+FPhHEAmH5FWq3kwgvI VrzD1oyrspJWxMy2/W2dsb3mz41MpnjbMiCiEZAJsgnniFkvXr5VjaFAE0unoaqoFSAg6Sug95N ehbpdfdhufuu/oXlh0vGgta85/2s= X-Gm-Gg: ASbGncteHxmmvilRCcWHWnQsfllfV1Mmm5B5T2Ta2lernJV0aJiiMA+Eg5xgnhGN/bB /5gx2Ns6iiWbmVAFZHwOfSvMu7AhWPj8evSXK11Um X-Google-Smtp-Source: AGHT+IHO8KjS5FVOrKUxtV5z4nkZbUFaV88CGDHWSIzgLbSYGUHBWp+3IKcuvA0RLWcC35nfbo3g2Ml0JPLaMS66NH4= X-Received: by 2002:a05:6402:530f:b0:5d1:2377:5af3 with SMTP id 4fb4d7f45d1cf-5d972e00027mr42304773a12.5.1736720980698; Sun, 12 Jan 2025 14:29:40 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 12 Jan 2025 22:29:40 +0000 From: Stefan Kangas In-Reply-To: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> MIME-Version: 1.0 Date: Sun, 12 Jan 2025 22:29:40 +0000 X-Gm-Features: AbW1kvaTD4uPnbQf4n8R22knELQjackJ4fkAhwMR2-Ny6qNRCTeoIIbG6L6Lf8s Message-ID: Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 To: JD Smith , 75526@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Daniel Mendler , Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) JD Smith writes: > The TS support in python.el breaks versions of emacs prior to v30, since it calls the recently introduced macro `treesit-declare-unavailable-functions`. The header still notes: > > ;; Version: 0.28 > ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23")) > ;; Maintainer: emacs-devel@gnu.org Maybe this could be fixed in compat? From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 12 18:58:28 2025 Received: (at 75526) by debbugs.gnu.org; 12 Jan 2025 23:58:28 +0000 Received: from localhost ([127.0.0.1]:49496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tX7qe-0000xn-1M for submit@debbugs.gnu.org; Sun, 12 Jan 2025 18:58:28 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:55161 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tX7qa-0000xD-GR for 75526@debbugs.gnu.org; Sun, 12 Jan 2025 18:58:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GefhlcnogR59JPcItxNokhGZl0/J7xPOkCGCTA7EKcE=; b=qHgcw5iKJQMBHLqQxxDXnLdMPl 4qmYPRI4x1QNw9Kl/NtYx677foRjHQwxcUKSHvN2EbmOIPM3wkWIq/Liuf8K7SjD/6cos17tLi0MC l6c1Z5bKVHOuJKtBbVEVh2njWqTRMjY8SSSdEkL3UsDMxd5/ydTd4oeXp6HFo9zk+Du0=; From: Daniel Mendler To: Stefan Kangas Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: (Stefan Kangas's message of "Sun, 12 Jan 2025 22:29:40 +0000") References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> Date: Mon, 13 Jan 2025 00:58:13 +0100 Message-ID: <87o70bfuui.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , 75526@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > JD Smith writes: > >> The TS support in python.el breaks versions of emacs prior to v30, since it calls the recently introduced macro `treesit-declare-unavailable-functions`. The header still notes: >> >> ;; Version: 0.28 >> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23")) >> ;; Maintainer: emacs-devel@gnu.org > > Maybe this could be fixed in compat? Yes, we can add the macro `treesit-declare-unavailable-functions` to Compat. But python.el needs to `(require 'treesit nil 'noerror)` instead of `(require 'treesit)`. Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 13 01:19:32 2025 Received: (at 75526) by debbugs.gnu.org; 13 Jan 2025 06:19:32 +0000 Received: from localhost ([127.0.0.1]:49903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXDnP-00013P-Lh for submit@debbugs.gnu.org; Mon, 13 Jan 2025 01:19:31 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:60923) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tXDnN-000138-20 for 75526@debbugs.gnu.org; Mon, 13 Jan 2025 01:19:29 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-21654fdd5daso63671355ad.1 for <75526@debbugs.gnu.org>; Sun, 12 Jan 2025 22:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736749163; x=1737353963; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IZ+SLXgVH4jXTqnA2YuoPBo8P9G/cBcI1Z4JKHVfCjY=; b=fI6SmEr2qz//Ws2ltmZhB7m0MBaig/sw/O+RqVbMJ3FsKGQpUKlQTz7BVYOniXZUkb 4rN98KSJpN6+Sv9WDM9+u5rObJkiFAKp3TKoA2xsSr2Guc4wYdHKaPVHTOQIxvPQXaYP x85FYVmCtZNE549pAvpBMwUT/0zXEGw8scrKeOugVzfpf9Xc7wxtupEy0/2IWshbM5dP jnuIpKD5GxjByA0CSrLkbk6TPUdtUctnwiYuVM9he8YZQqBwXkcWiiTCB8WZMD+Z6wto VfJturWX/c6PewM9mRjJektD/3lu74jNAxmHK6RMYjaOF019OirNJX1bMhVHxSCtu8di r+3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736749163; x=1737353963; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IZ+SLXgVH4jXTqnA2YuoPBo8P9G/cBcI1Z4JKHVfCjY=; b=bvz8HpI3P8i6ucBFmyRDIQvwnc45ovfiJx/14ufHtefAU6Z1q1I3hWGGvdsGi6A4Gn 6NVIqfGwQOy2KsPhcOERds3USgBIrH5BlMsZbfLKszK3h9o7++Dj4Ms2xk6y66yY/Bzt lsx0Nu7ve0v/LikxzwjqshOHVcFZ7guqxPZvmdvxlaLW3gubiRFQKLYS+Fi0Sj/i4s5i cPcQtaMNA9yJcTCw/0FrN34Oi+TBduNEdgCZzArhezFlj5c4dn9yunnjbESNoKw+BXB3 cmgBF4FBjNyRYl47MFq1vBPulDOK0pLUl1zS5dQqex2HlQpiREJ2tjMdl++a9rbF4lmx yJFw== X-Forwarded-Encrypted: i=1; AJvYcCXJqBPfyA0v2YdTkB9yys7Dz6C0FPNMb2CZWvVXzp4G1iGN4125BT6h03RVrmRHT8cdVFdLJg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx3VqjFZo+PU6XHN0mQ/CYT3t2isUG6b//a1VIXm0TBvWJxZJ9L Ix/KWlG3SyWAn8j5D2XUgG+GVQ5ogb3AF8sMnX2218epTKn1I7LH X-Gm-Gg: ASbGnctz2oEcSjdiR1D0XD44q765iv9th/D0X6db3nqjujxn9IdfLZBIM+YvKtu7Z55 htb4gGZQ1UToCf16V40DnSfH8OjElXDlOhQmMhIFoaceHOwjkmUQO/LvJUpEVd7xmgpJPK8DkoJ hVVMY4ncdAaDfpZCZr+o3NtSQvfGt9iXDjFYb7RVyEQtKogtiHaSkihoq91MF7vferNgOuz8y8n 3T4irC5wf3xwaX8S3StbZHqGJhk4H2D5cwo7vwsZ8eIUjNMjCRIkgsQf5BJhzhVAVDjoeaRNJ0/ QAug X-Google-Smtp-Source: AGHT+IHJhjRXcfAbNJ8Tr9lgz4YKXG5VByqMjzxfmdTURoO2uM8x/TQV8pVysGtlUuy7DdiwFa2tmA== X-Received: by 2002:a17:902:d2d2:b0:216:393b:23e0 with SMTP id d9443c01a7336-21a83fde4dbmr308049695ad.36.1736749162714; Sun, 12 Jan 2025 22:19:22 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:c04e:a612:3dd1:a163]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f23499csm46329745ad.193.2025.01.12.22.19.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jan 2025 22:19:20 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 From: Yuan Fu In-Reply-To: <87o70bfuui.fsf@daniel-mendler.de> Date: Sun, 12 Jan 2025 22:19:08 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> To: Daniel Mendler X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , JD Smith , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 12, 2025, at 3:58=E2=80=AFPM, Daniel Mendler via Bug reports = for GNU Emacs, the Swiss army knife of text editors = wrote: >=20 > Stefan Kangas writes: >=20 >> JD Smith writes: >>=20 >>> The TS support in python.el breaks versions of emacs prior to v30, = since it calls the recently introduced macro = `treesit-declare-unavailable-functions`. The header still notes: >>>=20 >>> ;; Version: 0.28 >>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq = "2.23")) >>> ;; Maintainer: emacs-devel@gnu.org >>=20 >> Maybe this could be fixed in compat? >=20 > Yes, we can add the macro `treesit-declare-unavailable-functions` to > Compat. But python.el needs to `(require 'treesit nil 'noerror)` = instead > of `(require 'treesit)`. Oops, sorry about that. I didn=E2=80=99t know python.el is on ELPA. Let = me know if there=E2=80=99s anything needed from me. Yuan From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 24 18:59:43 2025 Received: (at 75526) by debbugs.gnu.org; 24 Jan 2025 23:59:43 +0000 Received: from localhost ([127.0.0.1]:47675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbTaQ-0003Me-Oq for submit@debbugs.gnu.org; Fri, 24 Jan 2025 18:59:43 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:50399) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tbTaP-0003MP-92 for 75526@debbugs.gnu.org; Fri, 24 Jan 2025 18:59:41 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5d3cf094768so5000813a12.0 for <75526@debbugs.gnu.org>; Fri, 24 Jan 2025 15:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737763175; x=1738367975; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=NEvA0iDytjv10hj9esJBOhe/EGMDsaD11CotR1zkuZA=; b=RuQp2OkE9Q933jxD/03jJKzYBdt1L53Cr5UGSYwOabKtHiGnt3UbBOM3RDdFQyLCU9 DtBhaJ4xPfC/LIGI3WL3rsCAz+D6UBRjKVQilmCpOBeCKqKIRRSNpe4lVK0JxrYGycTa RMZ6nqf0pkt3L+mE4fmwBkEWPpigT1Zaw/4PwaAqFUBsTgcLZKVXQw7kAPOuG0FiKFj2 aDbfXPGANFI8/4EpaxE8KMy2eN7DDXJ/R/DMUqLUMdKJmMOJtuXV04j6hLtFs2SZ6CLU p+erDqO73JiwpMKyhr2ibVmiqmcoqGFBuVQh9N4o/0BL2iQNAEGsbOR3El57o84fbV/S bRrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737763175; x=1738367975; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NEvA0iDytjv10hj9esJBOhe/EGMDsaD11CotR1zkuZA=; b=LLb+q9f9h2iQJ5foBK2OBTBWE0frNxiTp4lg2Ta/UxmvkyPjNcin1HmNlyxOJYzJjF i/ps+xhSK9uv95ImsGzKuvvkYFcjn1YVYeBU02iCKbzx2jL0kYhP9xVAJLUpgsrCQnqc 7qS8lE7osfedYeEmQYbS2hNJdh7BvCdOqhGEgCpabkrFUm5l81Ec2VEHy6y+gcUuEkFl 09PgzNmS+GIK3zVIUNwbaWnk5RstDkbs6Lcvq/rMJnf4/iAFnxt1CSyAeZVs2MxRRv/8 OYObEpEfR7nu4TObyvow37icwWlGA6GsGOfsfsQDGArCJUO2wkj2hC3hKkhp39tpnndC T2gg== X-Forwarded-Encrypted: i=1; AJvYcCWBvBrV+dqY3eRwa41A0VnjmMqZMj4LduxHnkUAf8rCubsv5v1NNLZH3+nWyXuWa4QSCChKgw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzyazzE7QVgE5tP2VtNPRCctYK/7YcQLY3BMye1DgCqNIjqkXNY 4xcZHlCOMZPHe79nw5Nxg/wR1kOHJDu617UlmdmeGq6cBrBFV8I/VRLkj4NQISPxdEh13JVsn69 zYdGeZgp92Z9/6+8/oQO9GYRnFRM= X-Gm-Gg: ASbGncsC/X1CpaNsBtCjJ0egxEa2BbfAgK1mmf90oOS4dsrylJV0aRqnvI8UsjE2X2t nzxXhx4+jZJj935fJDuTWTrHlbR50zd9dVDhRQCY9vZHQfQjfA0hE11w6gQQ3Vd8= X-Google-Smtp-Source: AGHT+IEFGV9ckyK47H9FTjM6FGekczFJvZrkJulz8H83eU8+O9aqRWh4Q/a2BtjNbJdgafYnxJKovguLEEtRd6qDatI= X-Received: by 2002:a05:6402:5207:b0:5d3:ce7f:ac05 with SMTP id 4fb4d7f45d1cf-5db7db235d6mr29912661a12.31.1737763174806; Fri, 24 Jan 2025 15:59:34 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jan 2025 17:59:34 -0600 From: Stefan Kangas In-Reply-To: <87o70bfuui.fsf@daniel-mendler.de> References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> MIME-Version: 1.0 Date: Fri, 24 Jan 2025 17:59:34 -0600 X-Gm-Features: AWEUYZmYvmtf_s2ZJZhaFalr8I8BozoaM3sTKfYZU-uBIazdXd4-TVojHAHjjz0 Message-ID: Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 To: Daniel Mendler Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , 75526@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mendler writes: > Stefan Kangas writes: > >> JD Smith writes: >> >>> The TS support in python.el breaks versions of emacs prior to v30, since it calls the recently introduced macro `treesit-declare-unavailable-functions`. The header still notes: >>> >>> ;; Version: 0.28 >>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23")) >>> ;; Maintainer: emacs-devel@gnu.org >> >> Maybe this could be fixed in compat? > > Yes, we can add the macro `treesit-declare-unavailable-functions` to > Compat. But python.el needs to `(require 'treesit nil 'noerror)` instead > of `(require 'treesit)`. Thanks. Please let us know when this is implemented and which version of compat we should require. Then we can also make the above change at the same time. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 25 02:02:47 2025 Received: (at 75526) by debbugs.gnu.org; 25 Jan 2025 07:02:47 +0000 Received: from localhost ([127.0.0.1]:48220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbaBq-0004hk-MA for submit@debbugs.gnu.org; Sat, 25 Jan 2025 02:02:46 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:51875 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tbaBn-0004hJ-99 for 75526@debbugs.gnu.org; Sat, 25 Jan 2025 02:02:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L7tx+gpU24oZxjjHzO0dHSndGWQHT/AYQwcspCaGsFM=; b=qj9oLNoQAkpv1DTeLsoBo5lxjR EAPED49+9lrRvhOunuADb04C7O/FFAj+Igec19Qxa83+YTbXgKnKvUHRK4NPHnCmCK9JwrAb36JNE 13TNkrWirvyKumOgfMhC1mvMcliZhAJ2VC/7HYGQkTnWY5ZQGvB521fD/9HY1tmduHu0=; From: Daniel Mendler To: Stefan Kangas Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: (Stefan Kangas's message of "Fri, 24 Jan 2025 17:59:34 -0600") References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> Date: Sat, 25 Jan 2025 08:02:35 +0100 Message-ID: <871pwr8jg4.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , 75526@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > Daniel Mendler writes: > >> Stefan Kangas writes: >> >>> JD Smith writes: >>> >>>> The TS support in python.el breaks versions of emacs prior to v30, since it calls the recently introduced macro `treesit-declare-unavailable-functions`. The header still notes: >>>> >>>> ;; Version: 0.28 >>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23")) >>>> ;; Maintainer: emacs-devel@gnu.org >>> >>> Maybe this could be fixed in compat? >> >> Yes, we can add the macro `treesit-declare-unavailable-functions` to >> Compat. But python.el needs to `(require 'treesit nil 'noerror)` instead >> of `(require 'treesit)`. > > Thanks. Please let us know when this is implemented and which version > of compat we should require. Then we can also make the above change at > the same time. Yes, but it will take a while until compat-31 is released. We usually release at the time of the branch creation of the corresponding Emacs version (emacs-31). Until then, it is probably better to revert the change in python.el. Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 27 20:54:06 2025 Received: (at 75526) by debbugs.gnu.org; 28 Jan 2025 01:54:06 +0000 Received: from localhost ([127.0.0.1]:34994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcanm-0007Nr-1m for submit@debbugs.gnu.org; Mon, 27 Jan 2025 20:54:06 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:53322) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tcank-0007NL-Ea for 75526@debbugs.gnu.org; Mon, 27 Jan 2025 20:54:04 -0500 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-215770613dbso63560345ad.2 for <75526@debbugs.gnu.org>; Mon, 27 Jan 2025 17:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738029238; x=1738634038; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MvDodhdHH0eLB5aJUHVA9dqkOHbT8pMsMAzCots0TGM=; b=JfE9t0DE8OguekexowbkK6/z32mKFV+n4oXF+Lo7lkTEo4mB50Z8e8NCPSMlt7gRfI HcxyUwFAkkzpJVD47SePgsxrKY7Bjg+UC+WG1zd8nWHDL+AMuL0P0Zq0Eseg6NyE1NaU RAAw0uP+1X+ssUx5sk/CvmMtNwxxiItVKdyEmrXSsO++QX2POiD3AfYhtcVwiqAIFZJF b8Z8qZJh3m9yPtdRKfNoRT7UmJwJfF8wMWJoiZyaqT1w/ZVBQfHqCPunlJAbkU7PD8sR RTHpCeniOslzrHwA6zIN+APAEj1szyU2Hx6WsChuO2UMKAC0f38FLMf+7GyOEW4/o2QU dcFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738029238; x=1738634038; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MvDodhdHH0eLB5aJUHVA9dqkOHbT8pMsMAzCots0TGM=; b=DSRjsOFJt3v4naSh9+woCGoUVrNIRNiwqbkiaBw1nfBPnFN9TJo5tGFq+Kab1PrLyS 26RYzt2Ts21CxqcITIIIXWafWlzQqq7xwVoatLDeZV5LsxbaRr9gA3WhovbO90BwPM5N eezfwVxmCfiDVBPBlv6J0BMVTTm4SNdm98pg4il2qgLgFz86AgXgDCzQxHSzwlULeUDD wirBH8ed2BqJnh+p48p9eNlTE9XhuNguwpQF784JAvTpkVLBPSv1RSoFojIBRDt9mh3I O/lzvwDdZ2j8ZP0tqiQTJ6U2vbuUiwhVsRPK6EIgX4IAis2XKu04eguZB1Y98I0X9HgU IF9A== X-Forwarded-Encrypted: i=1; AJvYcCXJ/3HNqZN1h8yfQwsxk4Pc0zf9Z5cc4idrSH6aC/+4yzAc63aDoUUrAx0Ez9LNI48MGxjvRw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxTcyxz123fM+QtnDGs6jvT9RfEzhpvrA/6zlN8jqRQqAafTpwa Ulaz2MYnhPQa6Hn2RW5ZZxHvnz9EJvSvKkEpS/+RN+egtV2jeUMo X-Gm-Gg: ASbGncsJ//2fjz6+0T914VgmNflXSAue4qYVWBIqM0fHwlMBspek/vUjfq1q+qisKvU xzIK73PbMcji3jtWSZBF+5UKqz32vrN7UlVgNbSvFnq+G0y8lguj9fhYUgOqx/5FVZ8p/sUZHCE mxk9kgJ0CwyxS0anfzZS2fS5adCGzmaefbtuj83B9rek1xvNeQ68dSlOUPaa9Aj13JvoVKFfo80 2KlmYeEDpt7ACueTXAfRQOFe9+VwI7w7BRZGBGPqMhMxdcCqhJeR8IcRsoipAtHLKbKSxUeOHlR HWNgKb4ESSOEKxkN/kIf/HYF4+JJ X-Google-Smtp-Source: AGHT+IHqU0T1cNLoP55MObw8H1+oD9PKIfylIHuyyFLEGIC5g2d0SJvnUS0LeofPJ2P59rnIQ1XNSQ== X-Received: by 2002:a17:902:f544:b0:216:2a36:5b2e with SMTP id d9443c01a7336-21c355a4cfbmr642365025ad.32.1738029238272; Mon, 27 Jan 2025 17:53:58 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:954a:ef64:25ce:1e3c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da3d9b8e0sm71283815ad.40.2025.01.27.17.53.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jan 2025 17:53:57 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 From: Yuan Fu In-Reply-To: Date: Mon, 27 Jan 2025 17:53:46 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> To: Daniel Mendler X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , JD Smith , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 12, 2025, at 10:19=E2=80=AFPM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Jan 12, 2025, at 3:58=E2=80=AFPM, Daniel Mendler via Bug reports = for GNU Emacs, the Swiss army knife of text editors = wrote: >>=20 >> Stefan Kangas writes: >>=20 >>> JD Smith writes: >>>=20 >>>> The TS support in python.el breaks versions of emacs prior to v30, = since it calls the recently introduced macro = `treesit-declare-unavailable-functions`. The header still notes: >>>>=20 >>>> ;; Version: 0.28 >>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq = "2.23")) >>>> ;; Maintainer: emacs-devel@gnu.org >>>=20 >>> Maybe this could be fixed in compat? >>=20 >> Yes, we can add the macro `treesit-declare-unavailable-functions` to >> Compat. But python.el needs to `(require 'treesit nil 'noerror)` = instead >> of `(require 'treesit)`. >=20 > Oops, sorry about that. I didn=E2=80=99t know python.el is on ELPA. = Let me know if there=E2=80=99s anything needed from me. >=20 > Yuan Any progress on this? I can add it to compat.el if no one is available = right now. Compat.el is on savannah, right? Yuan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 27 22:57:13 2025 Received: (at 75526) by debbugs.gnu.org; 28 Jan 2025 03:57:14 +0000 Received: from localhost ([127.0.0.1]:35146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcciv-0004Tz-Ey for submit@debbugs.gnu.org; Mon, 27 Jan 2025 22:57:13 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:61784) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tccis-0004Tm-Cg for 75526@debbugs.gnu.org; Mon, 27 Jan 2025 22:57:11 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-21669fd5c7cso91691925ad.3 for <75526@debbugs.gnu.org>; Mon, 27 Jan 2025 19:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738036624; x=1738641424; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IB5GIr30gAij3iP+DUPZ2mMRr25ZVJkrzKV8BqFKBxk=; b=jviXZcYl88ZmmF5RYt76ThxFHBOWD4huSdqxu9425dX/hq+IW932A/xl8Xq2p2C5eh gGKkwt7w/X3hpLgMf/remv3Mm0g29OG74kO0GXws8r7hrCn8TbFXdwIlzL0L6oZg6plV ptqO899760w3vu4WRY2JTwAu0/9rONTjsIHksYxfd4wnlhyWZkpDhUMFSt0KTiWZkl9g cvCuBRsHcWIjlw+EgbLbT4AwUvX0b2FsPzcBCyHpmcHgHVbaV1/dnE85rTdsqIExKwKS RN8khWQWFNAXvdbL1P6Pi9Vw6awi1zytQVcpys5DCLmKV5ocmRnwl5BobVuSfkWMRrte avVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738036624; x=1738641424; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IB5GIr30gAij3iP+DUPZ2mMRr25ZVJkrzKV8BqFKBxk=; b=o8iVmKscG6fnrd9I53mUn8v4McA8mPBBePCmMv4YP3P/TTUW+BMEDAjF6hVL0jXgig t5mC+OzvKznCoJknimgWav5GdU/tSJMflWz+vCbQUn7z2WWQ12Gjr/NUJaVJzLsJ8I+c /Rdwy9v+7A6H7AKV63KjMnaCOTpup+rgvgtC8fIx5lSl+fQbWQ4Su8v3uiiaR26mkpa0 ZRKcZjXdVGl3EJJenZZKjBe7KMPNQdsbR5IHqeqJxgnMChoNSMfGVMXJzwuQ3hf2Ip5L bbAFagyElGxxBH2JGxRr+/Czf5/1iPJYFTXUmqEKhYZUezO7KbV+e5HyRyzENPyuDroy wJAw== X-Forwarded-Encrypted: i=1; AJvYcCXDG/vX6nbPk8mnZNe0mdsiebbjodRFW+QuPsuJzEW7Zw7PhYLyAVnWPSx+oowbCHRRpKFB4w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyJTdp1BWHHn2FghMyHd4R6i2oKIzLw0QoXqMOjQ5LjaGe/HgBI OGHe0yNLIqUfcVtj+sZKErylJIYKBS+pGBuIM4nEuR7qvI4OlK+M X-Gm-Gg: ASbGncuIamarrz2LJpp5uhetcgCfrjmAsxtLqkNFa3Z4mK/ZheUeTy2IDnxfrUgYLwL p08du+RILJWF6Nh6fm49vpdx7UMHWrw9kB8eBBdJRRYFNMjs//xt4eqz2At4Gf0PrN9+haMMaUs wuIwiDZd5mktf/uX618ttIJUDW6+JL7qBDpSSkHNpI/P7DxDJK5gG3b1ZSdlnWSCPE++qVp1Z9L RculpbxXg3xg7FOP/0plnqGUMW0N82jAhRKxpz/L/Q7HQvqRctsIUkFiBoG534bPp6lb/SA7cpl DwDJzI4GOGsRxH32jKg7FIaBMyutMWjzpiWjhMg= X-Google-Smtp-Source: AGHT+IFATy4d4G81aM5aajz2naRrB8HQ1uzIQDmQ4FoAcJWgtoYNjYemhDbqowhsnuFtReFgTciWTQ== X-Received: by 2002:a05:6a20:6ca9:b0:1e1:aab8:3887 with SMTP id adf61e73a8af0-1eb215ec4famr50913330637.39.1738036624174; Mon, 27 Jan 2025 19:57:04 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:954a:ef64:25ce:1e3c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a77c851sm8275544b3a.137.2025.01.27.19.57.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jan 2025 19:57:03 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 From: Yuan Fu In-Reply-To: <871pwr8jg4.fsf@daniel-mendler.de> Date: Mon, 27 Jan 2025 19:56:52 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <6DFBCCE6-3047-4DDD-AB17-EF018BD4A08B@gmail.com> References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <871pwr8jg4.fsf@daniel-mendler.de> To: Daniel Mendler X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , JD Smith , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 24, 2025, at 11:02=E2=80=AFPM, Daniel Mendler via Bug reports = for GNU Emacs, the Swiss army knife of text editors = wrote: >=20 > Stefan Kangas writes: >=20 >> Daniel Mendler writes: >>=20 >>> Stefan Kangas writes: >>>=20 >>>> JD Smith writes: >>>>=20 >>>>> The TS support in python.el breaks versions of emacs prior to v30, = since it calls the recently introduced macro = `treesit-declare-unavailable-functions`. The header still notes: >>>>>=20 >>>>> ;; Version: 0.28 >>>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq = "2.23")) >>>>> ;; Maintainer: emacs-devel@gnu.org >>>>=20 >>>> Maybe this could be fixed in compat? >>>=20 >>> Yes, we can add the macro `treesit-declare-unavailable-functions` to >>> Compat. But python.el needs to `(require 'treesit nil 'noerror)` = instead >>> of `(require 'treesit)`. >>=20 >> Thanks. Please let us know when this is implemented and which = version >> of compat we should require. Then we can also make the above change = at >> the same time. >=20 > Yes, but it will take a while until compat-31 is released. We usually > release at the time of the branch creation of the corresponding Emacs > version (emacs-31). Until then, it is probably better to revert the > change in python.el. >=20 > Daniel Thanks, I reverted it on master. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 28 01:55:59 2025 Received: (at 75526) by debbugs.gnu.org; 28 Jan 2025 06:55:59 +0000 Received: from localhost ([127.0.0.1]:35365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcfVv-0007N8-5Y for submit@debbugs.gnu.org; Tue, 28 Jan 2025 01:55:59 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:47997 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tcfVr-0007Mr-Oq for 75526@debbugs.gnu.org; Tue, 28 Jan 2025 01:55:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5obsK47hGUD+qkOkc3OWkSeIjnbKSlEqSMlY0Ln2UsY=; b=GEfFNHZ8U+oNC15cHmqPCMYcea CiyIxXvDVUNScvT1tRe+YFIdI4PO6feaiJHOLc3QxjleriiGukC4QpSI4pxX9be2iHRz368xwzDFl dpvY8X9NVQEZ/6JgYwzYdzRI4+wccPUPLS5Pky879r6Ssv80Pc7VxVprBfhbr+HnFhls=; From: Daniel Mendler To: Yuan Fu Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: (Yuan Fu's message of "Mon, 27 Jan 2025 17:53:46 -0800") References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> Date: Tue, 28 Jan 2025 07:55:47 +0100 Message-ID: <87sep3mnpo.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , JD Smith , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Yuan Fu writes: >> On Jan 12, 2025, at 10:19=E2=80=AFPM, Yuan Fu wrote: >>=20 >>=20 >>=20 >>> On Jan 12, 2025, at 3:58=E2=80=AFPM, Daniel Mendler via Bug reports for= GNU Emacs, the Swiss army knife of text editors wr= ote: >>>=20 >>> Stefan Kangas writes: >>>=20 >>>> JD Smith writes: >>>>=20 >>>>> The TS support in python.el breaks versions of emacs prior to v30, si= nce it calls the recently introduced macro `treesit-declare-unavailable-fun= ctions`. The header still notes: >>>>>=20 >>>>> ;; Version: 0.28 >>>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.23")) >>>>> ;; Maintainer: emacs-devel@gnu.org >>>>=20 >>>> Maybe this could be fixed in compat? >>>=20 >>> Yes, we can add the macro `treesit-declare-unavailable-functions` to >>> Compat. But python.el needs to `(require 'treesit nil 'noerror)` instead >>> of `(require 'treesit)`. >>=20 >> Oops, sorry about that. I didn=E2=80=99t know python.el is on ELPA. Let = me know if there=E2=80=99s anything needed from me. >>=20 >> Yuan > > Any progress on this? I can add it to compat.el if no one is available ri= ght now. Compat.el is on savannah, right? No, this is too early. Compat-31 is still far away. > Yuan From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 28 22:00:41 2025 Received: (at 75526) by debbugs.gnu.org; 29 Jan 2025 03:00:41 +0000 Received: from localhost ([127.0.0.1]:39421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcyJk-0001BD-QK for submit@debbugs.gnu.org; Tue, 28 Jan 2025 22:00:41 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:50638) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tcyJg-0001At-2y for 75526@debbugs.gnu.org; Tue, 28 Jan 2025 22:00:36 -0500 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2ee86a1a92dso8879444a91.1 for <75526@debbugs.gnu.org>; Tue, 28 Jan 2025 19:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738119630; x=1738724430; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3h4hGy0mLB0QyKk2W/xVSeaSGPret/78+dTwh/V2M7k=; b=JNFzt0Qe7cDFjUwD8GT4xJCljvxiwZKL8Ss4IiEjBHHFNqWWboZO3crj/yQszASPDU 38iWKeJPMUXKArCOD/wsCu4PPL80BDGDBP2CPq7gFRi4zinhUCmqdm5qwFmk9iZnW8g3 XWZtUtb3yG39on+qze33hy1qNhYyY9gTK5DLsTZ9ED0tIIuq2+smhMWpRuItWx9Lswfd xUqKzLUUv2FM4quq8MtFmZnEoNzzzMDHoCq2TYcXXwwQg+3krUpZECEqCMyXVsqfdQ8B ABRrTVPtfWtVAKLG8SBSBM1u2svgE9ASkhxYpPKxdaAbJSoYv/+Dto1kpAR/81FFNXJ6 lZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738119630; x=1738724430; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3h4hGy0mLB0QyKk2W/xVSeaSGPret/78+dTwh/V2M7k=; b=p3GtS+VFGlkgl7X8+7P/spJcJ7DEXFyyLmFrOZ0he3CA9grnakUIXj2M1ssNAdZdBu xSopmSIwgEWqNKBQprfBHZd0z/++rPAHf/3TktyiwqXln6V/EWCmxzoV+LdKnArYdmuC vSff3+UTj6Qmz2qDPBXSPPigLJf8lRvv0BN5h2tPrmw2R/g3E56ilZj0/sK75X5KszLN xmRFzd1Q3Mfhwn2pyKjozKEWgs/0qR8jwcO2zJU2jycXiAVBKLANMEjQVJhOykJEYnhF P43zJRQuqgK7y8A0BmH0SCISbG5IX+9rGD+FPnPNy258UOIgx+lUl7M993Xn6sMcWZSQ Zy3w== X-Forwarded-Encrypted: i=1; AJvYcCWIzJ9jVqyaaESoBctR9sW8E3BAV4DSUdcn+yw+2odnfxlXSJY43DWSveeWQnUgBfG2ak29BQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywrk1swIjgYGgM5XtdwBNW7TofBJaJ+YBBTc5N6KOmp06WBCtpH EyoKZM8hUzNAUt00XzNUdPaa7BiHUFmoPbDH7pg2IxyTlG3j1VdZ X-Gm-Gg: ASbGnctG6IuvX+b/YEaamAtNSmIJ0ijCbCckNcLXzedBfOwn4ca9f8mA8KXCvKwCROv QkraJVm0f3pU8LtN1aFGLAtJ0HJ6lX/DboY5A8+WfM9czvuHgb/nowOlSmstlHGzJDV2SIdzpOP PzWlTP1qN1GAHvsvJcrN35XH5Z/N1ZtVj5vRbuGvQy8w4w6sF0m1948nLvVRVX90S4wyW2YVcvK ey+/89dpJYRuGGcQLSWgxRAhCFyHglCgE9aWWd0sbY35lGKRLkne92E5swqZJ0H4H/BFlUwkxzz 8ZQxEaSWfrJKJn/jRXS0ftRpNAvS9OUFRuiYZ3A= X-Google-Smtp-Source: AGHT+IGwPIxbfdro5vEX9p89p1Iezx7Xk1L7/cOMLLD+606DQjLADOFcs6bYyu9SnCcpRMxMl3es4g== X-Received: by 2002:a17:90b:2f44:b0:2ee:c91a:ad05 with SMTP id 98e67ed59e1d1-2f83abc3987mr2049369a91.3.1738119629730; Tue, 28 Jan 2025 19:00:29 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:78af:756b:c744:4c15]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f83bf9498asm337192a91.32.2025.01.28.19.00.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jan 2025 19:00:29 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 From: Yuan Fu In-Reply-To: <87sep3mnpo.fsf@daniel-mendler.de> Date: Tue, 28 Jan 2025 19:00:17 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> To: Daniel Mendler X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Philip Kaludercic , JD Smith , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 27, 2025, at 10:55=E2=80=AFPM, Daniel Mendler = wrote: >=20 > Yuan Fu writes: >=20 >>> On Jan 12, 2025, at 10:19=E2=80=AFPM, Yuan Fu = wrote: >>>=20 >>>=20 >>>=20 >>>> On Jan 12, 2025, at 3:58=E2=80=AFPM, Daniel Mendler via Bug reports = for GNU Emacs, the Swiss army knife of text editors = wrote: >>>>=20 >>>> Stefan Kangas writes: >>>>=20 >>>>> JD Smith writes: >>>>>=20 >>>>>> The TS support in python.el breaks versions of emacs prior to = v30, since it calls the recently introduced macro = `treesit-declare-unavailable-functions`. The header still notes: >>>>>>=20 >>>>>> ;; Version: 0.28 >>>>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq = "2.23")) >>>>>> ;; Maintainer: emacs-devel@gnu.org >>>>>=20 >>>>> Maybe this could be fixed in compat? >>>>=20 >>>> Yes, we can add the macro `treesit-declare-unavailable-functions` = to >>>> Compat. But python.el needs to `(require 'treesit nil 'noerror)` = instead >>>> of `(require 'treesit)`. >>>=20 >>> Oops, sorry about that. I didn=E2=80=99t know python.el is on ELPA. = Let me know if there=E2=80=99s anything needed from me. >>>=20 >>> Yuan >>=20 >> Any progress on this? I can add it to compat.el if no one is = available right now. Compat.el is on savannah, right? >=20 > No, this is too early. Compat-31 is still far away. Thanks. I reverted the change in python.el Yuan= From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 20:39:53 2025 Received: (at 75526) by debbugs.gnu.org; 28 Feb 2025 01:39:53 +0000 Received: from localhost ([127.0.0.1]:41119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnpM0-0006ss-Ra for submit@debbugs.gnu.org; Thu, 27 Feb 2025 20:39:53 -0500 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:54380) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tnpLz-0006sb-2g for 75526@debbugs.gnu.org; Thu, 27 Feb 2025 20:39:51 -0500 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-46fcbb96ba9so19292571cf.0 for <75526@debbugs.gnu.org>; Thu, 27 Feb 2025 17:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740706785; x=1741311585; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=ABbHLeM4hP+zSf3q48mdzW9Cq3dr0ZZyttvMWvRodPo=; b=bpJh5cbG6vtL1HpXyDau6gAz+Jn2lji/b5UGKP26x6Cgp5nm96InNcL0g1ECynh2Dj uXges0r/ZQPzLGHUeBekDp+NGO3SPyZlUXofeY5mgs/zZJ8cytFcPLOD5TcbEhVL4398 SemqZjCeLD8mTK7Epo1RoxQ4k4Tfw0WvGEuKGPA5OPeBLxOpEJTyYbp+xLjwwr6cYZ+v LMIabPFeHZoA4MNw1sy3szxPlhuVEyf6XTw8H6uRfkM38C4DAS1ykrt2hJd5991LlMfi Yg6CAry0nb/pzZC7Th5Dj4UGpaWHtvRIWFZdsACuS7Q5Z7pU1qKaE/sCL07oTnGzmoZT 6PBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740706785; x=1741311585; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ABbHLeM4hP+zSf3q48mdzW9Cq3dr0ZZyttvMWvRodPo=; b=JwPCzHPl8os9KetxYFSPVUjNene05iSbxevsMER339sxOW3+D3PMShz9ISL2p+4kpP X7i+oie5KtbGveEdtOQs8q86W6XxSJ5lHrSNZ5+7sNpmzDLLYENQ7G7FXgwOKGXbr/XV zHyCtlHgqv9IuKsS7P0Ry2Zwl81lHXS1ODcFy/Rcd+GpRETVW8d3oQGxLXuIS7GqETU+ cRt+vI45Q1sejbvwtY8mdAyT7HePP+pi1F6LHYl13ML/OaqyzNcFmgkmTyK4IuQ76SkV PD3ZAu/E90apRrncb7GJX9LOF925RyngdMPod45WwKVV0K+1YB3aVGeH4kkcp1zNWcAq uo8w== X-Forwarded-Encrypted: i=1; AJvYcCV0NEHB6Ff2ilP6ytuQorud2vf6XHxG7Lnx14QePTGLt5lgNgX3sXF6u9Raafu7joKAr0rfvw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyr254TM5T9X6F2SynLxWSMRCrzBcI4FezV0Dgir9wcTOjlEn+R uH7JCnBvzMWrMpHKt/6h0r/MffbOymYPJ/kjETv72y7i+O+XEPWh X-Gm-Gg: ASbGncumSX3drBEwvc6LEAwiNzsYbMyM8+KAQV3na9661iFg/JkhItROyWk/s+awR2z z5BaF3ewLRLsTWckK6x5Q7P/yw8OOngg0OXFX5tvIo9R9eVxLr1APEWD6uYbDWLaUhqMemELkd9 HkXnxz883qjdsUHaihlMNjtBjquoyaZVyaYa841yy6UBUbiGQVn1hezx3yi/eJjJKoISMqxxPXH fpDZ5VOrnaK+5kjtVJsBkgDzaBpWi/YX5TMuig+wDXj1FWg5PaO3PUQ3VgP7kWDKZBONBjWxjWx HiFEiKJFfqyM55yPXy7m+J+P6ys4ZR/7hrSFPML6eJ+YWPYpawgE+IEY+1OkxKpld5vxk7hmKg= = X-Google-Smtp-Source: AGHT+IG6I5ibW4JbtH+9tAVJy5iIF8hZUPdFFH2oGenSBgAWupWCnDjhQeCqCMaTlgnxnYCru269dw== X-Received: by 2002:a05:622a:646:b0:472:54d:295a with SMTP id d75a77b69052e-474bc08de3emr19615121cf.30.1740706785200; Thu, 27 Feb 2025 17:39:45 -0800 (PST) Received: from smtpclient.apple (cm-24-53-185-196.buckeyecom.net. [24.53.185.196]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-474721bf65asm18150221cf.36.2025.02.27.17.39.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Feb 2025 17:39:44 -0800 (PST) From: JD Smith Message-Id: <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_F188DA71-0F8B-4BEF-B69E-8E3D19624987" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 Date: Thu, 27 Feb 2025 20:39:33 -0500 In-Reply-To: <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> To: Yuan Fu References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Daniel Mendler , Philip Kaludercic , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_F188DA71-0F8B-4BEF-B69E-8E3D19624987 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 28, 2025, at 10:00=E2=80=AFPM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Jan 27, 2025, at 10:55=E2=80=AFPM, Daniel Mendler = wrote: >>=20 >> Yuan Fu writes: >>=20 >>>> On Jan 12, 2025, at 10:19=E2=80=AFPM, Yuan Fu = wrote: >>>>=20 >>>>=20 >>>>=20 >>>>> On Jan 12, 2025, at 3:58=E2=80=AFPM, Daniel Mendler via Bug = reports for GNU Emacs, the Swiss army knife of text editors = wrote: >>>>>=20 >>>>> Stefan Kangas writes: >>>>>=20 >>>>>> JD Smith writes: >>>>>>=20 >>>>>>> The TS support in python.el breaks versions of emacs prior to = v30, since it calls the recently introduced macro = `treesit-declare-unavailable-functions`. The header still notes: >>>>>>>=20 >>>>>>> ;; Version: 0.28 >>>>>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq = "2.23")) >>>>>>> ;; Maintainer: emacs-devel@gnu.org >>>>>>=20 >>>>>> Maybe this could be fixed in compat? >>>>>=20 >>>>> Yes, we can add the macro `treesit-declare-unavailable-functions` = to >>>>> Compat. But python.el needs to `(require 'treesit nil 'noerror)` = instead >>>>> of `(require 'treesit)`. >>>>=20 >>>> Oops, sorry about that. I didn=E2=80=99t know python.el is on ELPA. = Let me know if there=E2=80=99s anything needed from me. >>>>=20 >>>> Yuan >>>=20 >>> Any progress on this? I can add it to compat.el if no one is = available right now. Compat.el is on savannah, right? >>=20 >> No, this is too early. Compat-31 is still far away. >=20 > Thanks. I reverted the change in python.el >=20 Thanks. Unfortunately there are now new changes to python.el which = again break Emacs < 30. The file still mentions:=20 > Package-Requires: ((emacs "24.4")=20 It now uses the Emacs 30 only `derived-mode-add-parents'. If python.el = is going to be developed primarily on master, it should probably be = removed from MELPA or at least use compat. I'll take this up with them. JD= --Apple-Mail=_F188DA71-0F8B-4BEF-B69E-8E3D19624987 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jan 28, = 2025, at 10:00=E2=80=AFPM, Yuan Fu <casouri@gmail.com> = wrote:



On Jan 27, 2025, at 10:55=E2=80=AFPM, Daniel = Mendler <mail@daniel-mendler.de> wrote:

Yuan Fu = <casouri@gmail.com> writes:

On Jan 12, 2025, at 10:19=E2=80=AF= PM, Yuan Fu <casouri@gmail.com> wrote:



On Jan 12, 2025, at 3:58=E2=80=AFPM, Daniel Mendler via = Bug reports for GNU Emacs, the Swiss army knife of text editors = <bug-gnu-emacs@gnu.org> wrote:

Stefan Kangas = <stefankangas@gmail.com> writes:

JD= Smith <jdtsmith@gmail.com> writes:

The TS support in python.el breaks versions of emacs prior = to v30, since it calls the recently introduced macro = `treesit-declare-unavailable-functions`.  The header still = notes:

;; Version: 0.28
;; Package-Requires: ((emacs "24.4") = (compat "29.1.1.0") (seq "2.23"))
;; Maintainer: = emacs-devel@gnu.org

Maybe this could be fixed in = compat?

Yes, we can add the macro = `treesit-declare-unavailable-functions` to
Compat. But python.el = needs to `(require 'treesit nil 'noerror)` instead
of `(require = 'treesit)`.

Oops, sorry about that. I didn=E2=80=99t = know python.el is on ELPA. Let me know if there=E2=80=99s anything = needed from me.

Yuan

Any progress on this? I = can add it to compat.el if no one is available right now. Compat.el is = on savannah, right?

No, this is too early. Compat-31 = is still far away.

Thanks. = I reverted the change in python.el


Thanks. =  Unfortunately there are now new changes to python.el which again = break Emacs < 30.  The file still mentions: 

Package-Requires: ((emacs = "24.4") 

It now uses the = Emacs 30 only `derived-mode-add-parents'.  If python.el is going to = be developed primarily on master, it should probably be removed from = MELPA or at least use compat.  I'll take this up with = them.

JD
= --Apple-Mail=_F188DA71-0F8B-4BEF-B69E-8E3D19624987-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 03:34:19 2025 Received: (at 75526) by debbugs.gnu.org; 28 Feb 2025 08:34:19 +0000 Received: from localhost ([127.0.0.1]:44814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnvp5-0005bQ-0S for submit@debbugs.gnu.org; Fri, 28 Feb 2025 03:34:19 -0500 Received: from mout02.posteo.de ([185.67.36.66]:49911) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tnvoz-0005at-TM for 75526@debbugs.gnu.org; Fri, 28 Feb 2025 03:34:16 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 682BF240101 for <75526@debbugs.gnu.org>; Fri, 28 Feb 2025 09:34:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740731647; bh=uhP4nzNOcU2/U5kfeB3v61m+L+atUbmdNbohOeE2pkA=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=nzdTWmNSbQpZ66fYej/hEY+wpNr9CEJrCV0OoAIfLmgZDs1AL/gAQoZoXJos5OwXH eZuQGH7goDpn22Z3e22ZCLg6foQFnuqR+RTWC0eyXfpJDdHrv9MPGQbVc2DhC89N0S hilkiscnFhjEvRBSbODv3CxiMR24lfGggGFLhfigd2XrO6YX4xx9gxnSdSysN/Z4yB L6uCNsoWWv+d9u9xgruHYFMjQW48CPMNdhhvOO8LPWw9kOSoJ4D9tZn0C2ScmOf4gl URBoNIqQcTgXLU6DKOqTVc1bo3f2q4fobjUN0iEyPo6ZfLnoEg11fbUrE9m95f/+Mg xG4iJ2XL5vG9Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z41hZ36nKz6twM; Fri, 28 Feb 2025 09:34:05 +0100 (CET) From: Philip Kaludercic To: JD Smith Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Fri, 28 Feb 2025 08:34:04 +0000 Message-ID: <87wmdah3ib.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75526 Cc: Daniel Mendler , Yuan Fu , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) JD Smith writes: >> On Jan 28, 2025, at 10:00=E2=80=AFPM, Yuan Fu wrote: >>=20 >>=20 >>=20 >>> On Jan 27, 2025, at 10:55=E2=80=AFPM, Daniel Mendler wrote: >>>=20 >>> Yuan Fu writes: >>>=20 >>>>> On Jan 12, 2025, at 10:19=E2=80=AFPM, Yuan Fu wro= te: >>>>>=20 >>>>>=20 >>>>>=20 >>>>>> On Jan 12, 2025, at 3:58=E2=80=AFPM, Daniel Mendler via Bug reports = for GNU Emacs, the Swiss army knife of text editors = wrote: >>>>>>=20 >>>>>> Stefan Kangas writes: >>>>>>=20 >>>>>>> JD Smith writes: >>>>>>>=20 >>>>>>>> The TS support in python.el breaks versions of emacs prior to >>>>>>>> v30, since it calls the recently introduced macro >>>>>>>> `treesit-declare-unavailable-functions`. The header still >>>>>>>> notes: >>>>>>>>=20 >>>>>>>> ;; Version: 0.28 >>>>>>>> ;; Package-Requires: ((emacs "24.4") (compat "29.1.1.0") (seq "2.2= 3")) >>>>>>>> ;; Maintainer: emacs-devel@gnu.org >>>>>>>=20 >>>>>>> Maybe this could be fixed in compat? >>>>>>=20 >>>>>> Yes, we can add the macro `treesit-declare-unavailable-functions` to >>>>>> Compat. But python.el needs to `(require 'treesit nil 'noerror)` ins= tead >>>>>> of `(require 'treesit)`. >>>>>=20 >>>>> Oops, sorry about that. I didn=E2=80=99t know python.el is on ELPA. L= et me know if there=E2=80=99s anything needed from me. >>>>>=20 >>>>> Yuan >>>>=20 >>>> Any progress on this? I can add it to compat.el if no one is available= right now. Compat.el is on savannah, right? >>>=20 >>> No, this is too early. Compat-31 is still far away. >>=20 >> Thanks. I reverted the change in python.el >>=20 > > Thanks. Unfortunately there are now new changes to python.el which again= break Emacs < 30. The file still mentions:=20 > >> Package-Requires: ((emacs "24.4")=20 > > > It now uses the Emacs 30 only `derived-mode-add-parents'. If > python.el is going to be developed primarily on master, it should > probably be removed from MELPA or at least use compat. I'll take this > up with them. python.el is on MELPA? (and it /does/ use Compat!) But note that Compat doesn't implement everything, IIRC this includes derived-mode-add-parents. > JD From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 07:35:14 2025 Received: (at 75526) by debbugs.gnu.org; 28 Feb 2025 12:35:14 +0000 Received: from localhost ([127.0.0.1]:46663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnzaD-0004if-UK for submit@debbugs.gnu.org; Fri, 28 Feb 2025 07:35:14 -0500 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:61906) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tnzaB-0004cq-08 for 75526@debbugs.gnu.org; Fri, 28 Feb 2025 07:35:12 -0500 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7c0892e4b19so224914485a.3 for <75526@debbugs.gnu.org>; Fri, 28 Feb 2025 04:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740746105; x=1741350905; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=A5c6Vat6aPBujCEGugXagY1GS8+Bw2fcwhQjgbp5quA=; b=JPAPZgxoqvNtirK8QtRrU+55HbNZRnnJJEBChxty9RQpn4k12mPHxpO7bCqwdNe2WS wtfs34Td8cIuYlPI4c08qBXLRfyhpy3iQF1XSXeLSG3CjMsHUrO0/V/PtxiYC9ctjW38 t6Mic0O5WBrKSVXNx0/xN6o6fDOJj3BqUm8cP9GvZ3QSx8uLLxXNKNsf4cfvjGTAp7UE bexvDj8YaEbE3d02tb8FigFDgZtezLhAxgO3F56vPkXS3qR59RXYb9ZMJdnpUmmuf7cm yHswqrHhRiVZfvKaGk3hNK+joTukHMSnJv1GrPJn1PJY5TwkywXoUda4g1oogX0cVKi9 cusw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740746105; x=1741350905; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A5c6Vat6aPBujCEGugXagY1GS8+Bw2fcwhQjgbp5quA=; b=peLRZNuVol3dJq/xhdLC8lZHXCpWUXSHWi2Hk1haj8sl4mRSSCQuva8ReWM5gd5GvY 4aDppJ0gvhSWhT0FeAvTNREIhPJTV+UXZF/kRYlomtQAuITpTYNE2i+atb8xdEssbSBx +eU5HU0I9PLK2M+cG+BrNeMyT1F3ZFuhIqvBKtecc/hQsLPFCx9FExnIEJeWSD5dqZSt F+tkSq3bODHUCyLl1UJ5QJO3Lhqo+8w3JpUMzrTR4WtIo/yIh1AzZ8BTwUbYtdFB7BWC eDdV16H9BC3nGMFG2YrPT6JsnsHfbcpB9lBhyo7JOOuXW1XXzR4PUNYGIFggT/MMAe94 ty6g== X-Forwarded-Encrypted: i=1; AJvYcCXmILvpmvGzxV3sFchgy0BvClYqcWMY20dRyQ3XXuO9PmoE8431f6KSBKUmAXIQnyecG0GYng==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwMNFNVhaRS/hZayHCIdtdia3UswvoRKUCK+fvzJmFWWDpALp+s Gbtwjnj+uC9SQ6P1lvqudvsnbpGpqObVCyJI3ZlhTcpEsw6Tx1qz X-Gm-Gg: ASbGncuoaKLayDx4aMTAQystdiTBAh+nr7JdwF5yVijQW8j9H7OrZZjv1EKgL9JEw8P 4rtx4l4y1ckVBLzWMehqmtEDoHDp2sWFtr7lPBI4NqCK1SAGAOIYFAym9FroAz9+bM0jO1gKHkl dcKVBkd0Bk0dynvZnT0nOgTrmCS076HX3DYK8HxeVPAttt88EdOMxTsGqDZ51uLxLpw0qWsy2BX P3vUKv+3CwPrKfCTatqfSaBGEGD99gI3vFAefbTSy4lvu5SB/m4T1GpU5Te04ynW9AOuF/dAC0R 9jFr09JGNAh+sr2mEb0SkXpQhRBX1g8wfzTtj45Lpded+SNyw80ibCysfLdnklKGXgi0d8C/Zw= = X-Google-Smtp-Source: AGHT+IGu6FjnFX8g+99TfrP8TnZc4Cd6YLcvdMUnhm3S8TQ6a7aUpK2Jg1knev4eu30GcszvzBSCYA== X-Received: by 2002:a05:620a:2a01:b0:7c0:7eb4:6635 with SMTP id af79cd13be357-7c39c4b64aamr366284385a.20.1740746105065; Fri, 28 Feb 2025 04:35:05 -0800 (PST) Received: from smtpclient.apple (cm-24-53-185-196.buckeyecom.net. [24.53.185.196]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c378daa790sm239957085a.93.2025.02.28.04.35.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Feb 2025 04:35:04 -0800 (PST) From: JD Smith Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_5FAF6C64-320A-4132-BBA6-23184AD99E10" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 Date: Fri, 28 Feb 2025 07:34:53 -0500 In-Reply-To: <87wmdah3ib.fsf@posteo.net> To: Philip Kaludercic References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> <87wmdah3ib.fsf@posteo.net> X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: Daniel Mendler , Yuan Fu , Stefan Kangas , 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_5FAF6C64-320A-4132-BBA6-23184AD99E10 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 >=20 > python.el is on MELPA? (and it /does/ use Compat!) But note that = Compat > doesn't implement everything, IIRC this includes > derived-mode-add-parents. Sorry, I was confusing the python-mode on MELPA. The issue is actually = with the version on gnu-devel:=20 https://elpa.gnu.org/devel/python.html=EF=BF=BC --Apple-Mail=_5FAF6C64-320A-4132-BBA6-23184AD99E10 Content-Type: multipart/related; type="text/html"; boundary="Apple-Mail=_7B780FB5-BE36-43E8-98CE-5637F19355CE" --Apple-Mail=_7B780FB5-BE36-43E8-98CE-5637F19355CE Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

python.el is on MELPA? (and it /does/ use = Compat!)  But note that Compat
doesn't = implement everything, IIRC this includes
derived-mode-add-parents.

Sorry, I was = confusing the python-mode on MELPA.  The issue is actually with the = version on gnu-devel: 

3D"favicon.png"


= --Apple-Mail=_7B780FB5-BE36-43E8-98CE-5637F19355CE Content-Transfer-Encoding: base64 Content-Disposition: inline; filename=favicon.png Content-Type: image/png; x-unix-mode=0666; name="favicon.png" Content-Id: iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABHNCSVQICAgIfAhkiAAAAAlwSFlz AAAC/QAAAv0BdmBG1AAAABl0RVh0U29mdHdhcmUAd3d3Lmlua3NjYXBlLm9yZ5vuPBoAAAHtSURB VDiNjVI9aJNRFD33fUkrCjoEFTEYsAjSgh0EE5OvJnFQEFzEOnQVKtIEKjh0LLgITg7aTa1ghWaz RRcHG0y/Vl3s1EGQNlJ0kCKJJE2+d49D0hpJUnu2d+875577I/gPCvFsnwEuimi/pa7EF49OCyZ1 Ox/oRvx86e6B36Wqa8CIivSAmgY4Xji/EYaHe10FPrq3TyoDxyvl6hEDhAk5AaKPwCmCoNHTrf// EfASmRe+YgRgIyDwAa4C2CDwiuC6QB92FSBkU5pkAW5VesrP0++eVXebkWl9bAVD4xR5hIaFa71b +8O7kZuF2uHFMgk4mASRJjBrrL0fW55a2ZNAIT4WMWJcUPsJMwDYq4QKYedswM8k80+LHQU+JMYG rMoDCC7/bY0/SJ33YefFcRaG3k9tdnTguZkUFG8A7Gvw8FWEd6KLh+daj6YTGltQ3NwhAzUnqMlz +cfFrqwWmKaPGQD1Zszx686VpWj24F4Edmaw7GYHVTkB4DqAAKFKaJHU7zRaIixUtUTRX1C7kFqa mRaAbVv4dHb0kN8bTCk1StGQQisKrYI2RmiSUCqY+xmujdzI5WzHOwCA/NDoMaNyQVVdER1UatnS vhWpv057L1fbWtjG7PCwE/4WOgNIBOCamtoXt/Ck1K3QH+lz3g3Q0C/jAAAAAElFTkSuQmCC --Apple-Mail=_7B780FB5-BE36-43E8-98CE-5637F19355CE-- --Apple-Mail=_5FAF6C64-320A-4132-BBA6-23184AD99E10-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 19:59:04 2025 Received: (at 75526) by debbugs.gnu.org; 2 Mar 2025 00:59:04 +0000 Received: from localhost ([127.0.0.1]:47423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toXfb-0000q8-Oj for submit@debbugs.gnu.org; Sat, 01 Mar 2025 19:59:04 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:57455) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1toXfX-0000p2-Oc for 75526@debbugs.gnu.org; Sat, 01 Mar 2025 19:59:01 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5e4ad1d67bdso5173622a12.2 for <75526@debbugs.gnu.org>; Sat, 01 Mar 2025 16:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740877133; x=1741481933; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=nknYNxDnVTlIP0W1/g3ICl/T/bhGSNFZBHrpC+/yGW4=; b=Gd+kJ7N6nQ6pxsCXEwuophrmb9LnV1alh0wZZiA9K6i7JKl12V0/vfSbnY0gwD/aFh 5DWwFjAEaogGS5yJm3ZBi5n4P6KWJnlLjrn6Mx8acyzfAIhNNVigjUTPUxniV2dtkqQl erpWAIPktuFeprnmijI7HfohspQRHoT6c99zXwvlhrlfxEFa2aigiDMCNwK7t+9P42og r00PvbFeKEjsomTOK2MNNTn12/1DQWMx4bUMM4jT2YODiu4Da3vjFTjvnPqhtjFEmLXh CSXF31kvoH/udRctW7sdFi1EHaXkVF0OzHmN97K35gJPEZyXYXXlVoxINez77/cirhte 8BnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740877133; x=1741481933; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nknYNxDnVTlIP0W1/g3ICl/T/bhGSNFZBHrpC+/yGW4=; b=ftYq6MByV5F/pYfNqwlDqSXqaA9IWKfHUFQqeCaOowY0Z0yPYLbMkjjNhLp+kleRnW iRgj+Mb9Y5QGxUH4XYrwC/XHl3K7Wzv52xH/HYwGWysxSEzYxUkTuliMXbsfzsPwXjNW s565+XRqtNnZb+5ITerCmV7Eq0gMpSX4WpUd4VWRxnYVCHwuavXuszQKwMNRpFpy+c5+ eUyxORPMMMcW5yILsgkFN+UtV3pQhWUrj1RyJquRZBYy8llYi5r6j+Th3V9xwhllqvv8 22omVkCIeu6EcJi9r3LLb7K97+sdJuFnlI0rcD23huFDFJx2U0PcTmEICcY04Jwe5wO0 J3Bw== X-Gm-Message-State: AOJu0YwVMM4QGzgoFZuhIDIj39XyrLZXgMDqK+sL9IKmKthay9UQsgqp /NCwHAGi7uF8kD7XKyG832avHOg3FetyPqlLWDnG8Gs6rHmXWsdg5B+gZLnSsbhPqq6yR1Ba4Ug A8IFYhSUnsBiQIOViZcWCuJQ3S30= X-Gm-Gg: ASbGncuRL/QMKZEeZG51aF4V2+t482+W/Eh1+DjZCdCx3+Zcucaw+cqBL6a02JeqZeD iKiSsSa2TvON4k2cATs31cOKVe2DcVK+awb3Yxune6J8xdDKrCGgtOcUOQFSM+ky3DQW5EWogIi tM9/cp0pgq0sU/F3RtPQwpR/ornQ== X-Google-Smtp-Source: AGHT+IEx6qJF2rGXUTUUcJkjRUhT2sg717WgDEyxFXKmZGnEZ35X2/nD/RlTUVt8X58uVKq1A1aKJJl8LvT54s+gcJw= X-Received: by 2002:a05:6402:35d2:b0:5e4:c086:b78d with SMTP id 4fb4d7f45d1cf-5e4d690883bmr10860081a12.0.1740877132726; Sat, 01 Mar 2025 16:58:52 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 1 Mar 2025 16:58:51 -0800 From: Stefan Kangas In-Reply-To: <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> MIME-Version: 1.0 Date: Sat, 1 Mar 2025 16:58:51 -0800 X-Gm-Features: AQ5f1JpZ6lUy2CwO0XXhi6RFU5WxCsLIm03Yr7YrMmHoeuTkXxj2u_1crgS0aRQ Message-ID: Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 To: JD Smith Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: mail@daniel-mendler.de, philipk@posteo.net, casouri@gmail.com, monnier@iro.umontreal.ca, 75526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) JD Smith writes: > Thanks. Unfortunately there are now new changes to python.el which again break Emacs < 30. The file still mentions: > >> Package-Requires: ((emacs "24.4") > > > It now uses the Emacs 30 only `derived-mode-add-parents'. If python.el is going to be developed primarily on master, it should probably be removed from MELPA or at least use compat. I'll take this up with them. Hmm, there seem to be several compatibility issues here. I'm detailings my findings below. 1. Excluding treesit symbols (see below), these are the symbols that python.el itself needs, per version: 28.1 project-root 28.1 split-string-shell-command 27.1 rx-let 26.1 prog-first-column 25.1 font-lock-ensure 25.1 make-process Philip, Daniel, WDYT of the feasability of adding support for these symbols to compat? Would it be worth the effort? See also point 2 and 3 below. 2. Stefan Monnier added the call to `derived-mode-add-parents', which needs Emacs 30.1. Stefan, can we avoid making that call? Perhaps it should be added to compat? 3. We also need the below symbols: 26.1 flymake-make-diagnostic 26.1 flymake-diag-region 27.1 project-files 25.1 project-current This could perhaps be fixed by depending on project and flymake. Unfortunately, project 1.0 and flymake 0.1 (the earliest versions available on GNU ELPA) themselves need Emacs 26.1 and Emacs 26.3. So maybe we should just bump the required version of python.el to Emacs 26.3? Alternatively, perhaps the above could also be added to compat? I'll let Philip and Daniel comment on this too. 4. More complicated to resolve perhaps are these symbols from Emacs 29.1: 29.1 treesit [require] 29.1 treesit-buffer-root-node 29.1 treesit-defun-name 29.1 treesit-filter-child 29.1 treesit-font-lock-rules 29.1 treesit-fontify-with-override 29.1 treesit-induce-sparse-tree 29.1 treesit-major-mode-setup 29.1 treesit-node-at 29.1 treesit-node-child-by-field-name 29.1 treesit-node-children 29.1 treesit-node-end 29.1 treesit-node-field-name 29.1 treesit-node-parent 29.1 treesit-node-prev-sibling 29.1 treesit-node-start 29.1 treesit-node-text 29.1 treesit-node-type 29.1 treesit-parser-create 29.1 treesit-ready-p Yuan, Philip, Daniel, any ideas for how to handle this compatibility issue? From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 23:22:18 2025 Received: (at 75526) by debbugs.gnu.org; 2 Mar 2025 04:22:18 +0000 Received: from localhost ([127.0.0.1]:49836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toaqI-0000Nk-Ay for submit@debbugs.gnu.org; Sat, 01 Mar 2025 23:22:18 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36586) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1toaqC-0000Lw-De for 75526@debbugs.gnu.org; Sat, 01 Mar 2025 23:22:13 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2E4E844145B; Sat, 1 Mar 2025 23:22:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740889319; bh=m1w/bMYO6/xCb4QjHy38FickhxVvyWE2w8gpVgNA5is=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WLubuA+hMHkBFtszQulUWNYXiyfUxIXCPXRE3mnLh42w1FlmOkOYgw0GtAgCY12XC mIn5qMAtmGOLvgSFDASBT28FQXt1ImJaEFaZ/h6yGreoGuY47+x1AplDVp0NvWgLhb jtsffrkH+pl/rKqur6IgRDiLYA1QKgEH75LXhAT1Ewi7Gv0m3wG8XnGSsddlB4h/MU trdQu+2aUMRxyujhFeokdTXSIG+u8IpH/jg5O51gtwcdApFXGmKLltJoK692xni34P 33bPoJjigDEgC3dz3O07yEi08VzkevuLOI7KchPsmVLqNpLEu97rDFIHSe0B9GDS8U GJh2eMLrPwaHg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0C29E4414AE; Sat, 1 Mar 2025 23:21:59 -0500 (EST) Received: from alfajor (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ADB17120776; Sat, 1 Mar 2025 23:21:58 -0500 (EST) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: Message-ID: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> Date: Sat, 01 Mar 2025 23:21:58 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.399 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75526 Cc: mail@daniel-mendler.de, philipk@posteo.net, casouri@gmail.com, 75526@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Thanks. Unfortunately there are now new changes to python.el which again >> break Emacs < 30. The file still mentions: >> >>> Package-Requires: ((emacs "24.4") We should probably bump this up, indeed. > 2. Stefan Monnier added the call to `derived-mode-add-parents', which > needs Emacs 30.1. > > Stefan, can we avoid making that call? Perhaps it should be added to > compat? We can just wrap the call inside an `fboundp` test. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 23:41:16 2025 Received: (at 75526) by debbugs.gnu.org; 2 Mar 2025 04:41:16 +0000 Received: from localhost ([127.0.0.1]:50109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tob8d-0005TL-4Y for submit@debbugs.gnu.org; Sat, 01 Mar 2025 23:41:16 -0500 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:46212) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tob8Z-0005SC-JK for 75526@debbugs.gnu.org; Sat, 01 Mar 2025 23:41:12 -0500 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5e4b410e48bso5155707a12.0 for <75526@debbugs.gnu.org>; Sat, 01 Mar 2025 20:41:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740890465; x=1741495265; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=DuSrN2YmcE5moa4dypFSiqMT2MHmVHiOptfKGZYsRX4=; b=Bk2zBKn/6KOwC9zLO0fsQXlIANdmFDFwQWPFQAWxyCT1qa5a0zbw9008Bw/cAHq1np +KahseFKnEQ9u8r75VgPly+GOAfc8Bk6B4IpIEPfA/4Ro4aC/+3KLY8kfX73rYCEmQDR GkDI3SFTA6/3VC8fzod9/qkAYGZkZ7+w5y5Mfaw290fxcOtcLDwF+ezySLOM9ZEw5sPR p5oVDWjZwua1IvEeh9ad70s/5CHnj18Q/RoVNW0eFQTN76wYU8NWC04YGaWIzG053Y0a hM+BoeL4HEKPaL1cy2MaDuZYa9U5LdQKQEsIHnznf5pydttf5F+VK8drTkaWPTrkQqxv eocQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740890465; x=1741495265; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DuSrN2YmcE5moa4dypFSiqMT2MHmVHiOptfKGZYsRX4=; b=nSfl8pQB2U1peAGyrO/h7vhcSd9oX8k6aQ9Jco/D4g5FfOVQHxLiNk0AwdpfhvDYfA MbYrHefXXiZTeLKcyp27sCgJK2r9wD+cgK+ATwSEevK4GB9ror9tbJ4fb+zo25sOUdzt o0r4iBJGD4QT6kFBseUR8guYw1IHf3pBzLVgXuAeabNLycsPsaV57vv2nWtpl8HIVLbK I+vc353F99xhdF5y0vVZ9LKnnOXZfa/WnbLZ0vGMBpCaRPfE7rqUIEuWX9g5PIoWu4Ie OCqT3mWy3fJwjTTdrurM2UUKipfS8c9eOQBBlBkA4YOwD3eR08A7F59op1/E1vX2YDHK FQ8A== X-Forwarded-Encrypted: i=1; AJvYcCV48lqkY35tuUmPEJ9MOJ6g6gbWqhz61HgPRWW/ElyKxP+Sd5VPAN6bGc72TqbsoR5uEZKo7g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzLmoRCJpvItB/X/DNXKPtb3tvm/XHaVthvwv7FSU4NxPB53rfX nbfTYLTjbaiZxBXGkhbuXKtFUUOiqryDuWKB6EX1eFCAxGogOhQVwvfF/UkPu+rHajQwc3/Nk0C Jbb1wf3ejCvFKx14RNHJnXs53bmQ= X-Gm-Gg: ASbGncvEoib4w53z6TwXGZtcWe2903O6F1SIftqm+q5cMe8jrD2I1A3mc8e2XDnOs4K KOpylEZyL41eJpTW7nqe64TJv8209mAk0TugWxYSudubjXkYvWlgoxzoCx6M/uOMznCa7IZ4DwG SMWzUE15cWFWRF0Yzcz1QZKKDXBQ== X-Google-Smtp-Source: AGHT+IH/VHdHGw4DPuHMxWf323ALxWpog1zVZm6ZhnDuET/YZ58lEuKforJwNjay5qk0rgr2URRkSufXybl4jCeZgjs= X-Received: by 2002:a05:6402:35c6:b0:5e0:3584:28d2 with SMTP id 4fb4d7f45d1cf-5e4d6ad37f2mr9754711a12.2.1740890465131; Sat, 01 Mar 2025 20:41:05 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 1 Mar 2025 20:41:04 -0800 From: Stefan Kangas In-Reply-To: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> MIME-Version: 1.0 Date: Sat, 1 Mar 2025 20:41:04 -0800 X-Gm-Features: AQ5f1JriQokfOg6U7y49fwXJhMViiIgYVQKS1cE9UHgQzrnp5qhhIEPGIH29__k Message-ID: Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: mail@daniel-mendler.de, philipk@posteo.net, casouri@gmail.com, 75526@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>> Thanks. Unfortunately there are now new changes to python.el which again >>> break Emacs < 30. The file still mentions: >>> >>>> Package-Requires: ((emacs "24.4") > > We should probably bump this up, indeed. I bumped the requirement to Emacs 26.3, which fixes some of the issues reported here. Let's see if we need to bump it even higher. >> 2. Stefan Monnier added the call to `derived-mode-add-parents', which >> needs Emacs 30.1. >> >> Stefan, can we avoid making that call? Perhaps it should be added to >> compat? > > We can just wrap the call inside an `fboundp` test. Thanks, I did that. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 23:48:34 2025 Received: (at 75526) by debbugs.gnu.org; 2 Mar 2025 04:48:35 +0000 Received: from localhost ([127.0.0.1]:50213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tobFi-0000lK-Kv for submit@debbugs.gnu.org; Sat, 01 Mar 2025 23:48:34 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44703) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tobFf-0000kf-T4 for 75526@debbugs.gnu.org; Sat, 01 Mar 2025 23:48:32 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0644810022F; Sat, 1 Mar 2025 23:48:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740890905; bh=rGBUiisNDaQY+CB0xogjRKtwZhAXwuRHaLuA5/DY4fw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KyV9wXVEfLuBZKBqfgFWA3DzyvBoA3Hn49pOvvhs7GMoYjvxyYv0UYP34gqOvwfYO w/aEtMLeSbKIWqDyXiaOPH3SomnUSydOKWcuKiKkvT9F8RcvYY0FGTJNsFeAScd6sv x6a/No0JaRNk7HZs2N34j9vfperH/Gh9BpFgCX3txeSroB3vtxalhWKBY6Fo0iihY3 Nm/zVtqWiLGn31dErKGVVC3d9WUQgE/GoUEpCCZXK/C9KJKsfU2+MZjbkYGqsp8U1j HS6GnbaXVBe6X1z+4X/CZfNaPEBmhAYXWmryHGM7s5CmLQrjJmutD9MtG4+e8Xzc1m Vc842gc6EBUfg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3E9B6100040; Sat, 1 Mar 2025 23:48:25 -0500 (EST) Received: from alfajor (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DFFBE120304; Sat, 1 Mar 2025 23:48:24 -0500 (EST) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: Message-ID: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> Date: Sat, 01 Mar 2025 23:48:24 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.234 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75526 Cc: mail@daniel-mendler.de, philipk@posteo.net, casouri@gmail.com, 75526@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Package-Requires: ((emacs "24.4") >> We should probably bump this up, indeed. > I bumped the requirement to Emacs 26.3, which fixes some of the issues > reported here. Let's see if we need to bump it even higher. I wouldn't worry about it until someone complains. =F0=9F=99=82 Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 00:01:40 2025 Received: (at 75526) by debbugs.gnu.org; 2 Mar 2025 05:01:41 +0000 Received: from localhost ([127.0.0.1]:50360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tobSO-000283-42 for submit@debbugs.gnu.org; Sun, 02 Mar 2025 00:01:40 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:45540) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tobSK-00027N-G5 for 75526@debbugs.gnu.org; Sun, 02 Mar 2025 00:01:38 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5dee07e51aaso6277648a12.3 for <75526@debbugs.gnu.org>; Sat, 01 Mar 2025 21:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740891690; x=1741496490; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=1TK+QXjb3PTOW/IMC76Cy6dmXjulP7M5mzTRA9wPWDI=; b=ZIttGS6deQj8uZ3F6aIHoYoe/OfQb0+YFmwMQKX6QzkIckYPXi/ro1MLurfc+0VMBW cf7neXMtSv+aM6J58SWoOtJOhimKlSSlBULJ/znzO+A9j1SDn/J+uCRMRtSIcoBoxYTa RGqAIXBMr2b/YZAQ+RBcmn/btZ3y9liKm7QkpxJeSPIu8h9C6ku4kgbrXnfmjm25Jdvu bybh6FAMvANjCnitr0RuZ9tb7xCum7FYAzoifXvZveMB4TiWrZR3ElaiRkFAthaP/E1H +klf4ht2ZDbNjvE90CsLFhA5pnKw7g/b+0hfpN83Yyg3cJlyHbm2EjkdFrIJaz7MIIt1 pH5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740891690; x=1741496490; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1TK+QXjb3PTOW/IMC76Cy6dmXjulP7M5mzTRA9wPWDI=; b=t8yfbqvLIkPyfQdMLFnRn91lTCuQcRMnH5ZhECxewSlI5EnfeRJUpyM1ZUTgXQRGbi 3xEAgR9vSHv2PFZh+I6uP+nas+bO8Eck7XrUzE0kpyZxF7U+5ac7Y+9JUCxdf5FqMMqm QVtUysXQH0RwIj/+HvjIOJwkx6TFPmOZ8awcwl8LGmCyYt3qrmGf4Yorcj7/DU1yDvs/ w64zyzN2bjnAPCUaS2Dc5goBeZMwjyN4TNBoaBv4+OZ7KNkFZU6h3Eobyfonx6s0GUGN 7BkfOTrzs4Pv1J+7RWh0xIjORsDiFMhwKEziV6DX4fM2/cEMk9Aln15NeB4iU9iif9OZ d0AQ== X-Forwarded-Encrypted: i=1; AJvYcCWePyq3AeJWuqU1v11DOCj4gw9gszRKMc4UJ+UiXTVKZiFa3lvxb+nnzrZHRNirLDRjMge9WA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxywC7SZYgsCCyHMqOalGCUF6GT+rXdU08kSydiEi/GVBuFneEm itn9CgI1ZbpcHxa/SgJPCNJgtTQI+xtp+YnAGD57p+Lmxbxw653ErFq9/ag1qu47ghSgTRmucvR xCK75r1JujMYY5V+oQL5u87ILpfY= X-Gm-Gg: ASbGncsPD1IfLB4GMizAlXSo1CDzw5WTuy89MRZ7wdPkyk5kHOHOWWQuwK1WwPwPZ1J W9sd0qRO8p+GQpeMfe8oMA3cfQDE+IaPP6e6SmcLqpLetR1cVo/0SHqahathuU5oB5enX+IJg/+ AgsaZ23QsW3aKUC2wmQZSFB7j0qg== X-Google-Smtp-Source: AGHT+IHXiUTSeQelTcHSqyYwQG6MSx03i8efXFAl5XlbBN79Kh7xkNFPMDiSjJYvThpAqCbMMbs0w177tjI8PG6Jrd8= X-Received: by 2002:a05:6402:51d2:b0:5e4:d11e:7c4c with SMTP id 4fb4d7f45d1cf-5e4d6b878e2mr10236119a12.28.1740891690242; Sat, 01 Mar 2025 21:01:30 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 1 Mar 2025 21:01:29 -0800 From: Stefan Kangas In-Reply-To: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> MIME-Version: 1.0 Date: Sat, 1 Mar 2025 21:01:29 -0800 X-Gm-Features: AQ5f1Jr4tN6JLI9wrwSvaACkDbwg2NZLbsAccsyS92vqT5nIHSN2d8rQE7ZAFUs Message-ID: Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526 Cc: mail@daniel-mendler.de, philipk@posteo.net, casouri@gmail.com, 75526@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>>>>> Package-Requires: ((emacs "24.4") >>> We should probably bump this up, indeed. >> I bumped the requirement to Emacs 26.3, which fixes some of the issues >> reported here. Let's see if we need to bump it even higher. > > I wouldn't worry about it until someone complains. =F0=9F=99=82 Fair enough, but I thought this bug was exactly such a complaint? :-) From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 11:27:43 2025 Received: (at 75526) by debbugs.gnu.org; 2 Mar 2025 16:27:43 +0000 Received: from localhost ([127.0.0.1]:33667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tomAI-0006JS-Nd for submit@debbugs.gnu.org; Sun, 02 Mar 2025 11:27:43 -0500 Received: from mout01.posteo.de ([185.67.36.65]:54381) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tomAF-0006Ia-GS for 75526@debbugs.gnu.org; Sun, 02 Mar 2025 11:27:41 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id F0A88240027 for <75526@debbugs.gnu.org>; Sun, 2 Mar 2025 17:27:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740932852; bh=P6pLj6Sy8uk96bOysWM3C543egQDhaG4dXdsrqjN+so=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=qvXoayiXbHvnJUUWngvzfsRQGF4Ud+zhMJrXVKZUUAsJp4QYAD6lPGAD87I9JZu7b QBaac9CoDzHkwh5x2kBuFTzOih3/8pa6xjmn33bN+O3ikklk5K/tMWi8zaUJvy4imA OXI4quS2P1rSuAWbo6SbPyc3YfeQ8ayBPI+EenxvdJUU3eW70kXwcO9eEMzY/36Mes 7uHaMapoOX7vBIT40LMWJHtyFl7j/rnHbbzAF+lxWtu0T2EhvX+mXP7Jp5L2l/rgou kFP24ARQo5THeJRoQ4pp+1AJiosxxzcwMMx3B+K/yXZmT02SDw46KPEPdysfhmDKZ7 hMYGcNeZfodzA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z5S5t3Xnfz9rxD; Sun, 2 Mar 2025 17:27:30 +0100 (CET) From: Philip Kaludercic To: Stefan Kangas Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sun, 02 Mar 2025 16:27:30 +0000 Message-ID: <877c5775zh.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 75526 Cc: mail@daniel-mendler.de, casouri@gmail.com, 75526@debbugs.gnu.org, JD Smith , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Stefan Kangas writes: > JD Smith writes: > >> Thanks. Unfortunately there are now new changes to python.el which again break Emacs < 30. The file still mentions: >> >>> Package-Requires: ((emacs "24.4") >> >> >> It now uses the Emacs 30 only `derived-mode-add-parents'. If >> python.el is going to be developed primarily on master, it should >> probably be removed from MELPA or at least use compat. I'll take >> this up with them. > > Hmm, there seem to be several compatibility issues here. I'm > detailings my findings below. > > 1. Excluding treesit symbols (see below), these are the symbols that > python.el itself needs, per version: > > 28.1 project-root > 28.1 split-string-shell-command > 27.1 rx-let > 26.1 prog-first-column > 25.1 font-lock-ensure > 25.1 make-process > > Philip, Daniel, WDYT of the feasability of adding support for these > symbols to compat? Would it be worth the effort? See also point 2 > and 3 below. I think that split-string-shell-command, prog-first-column, font-lock-ensure and possibly make-process could be back-ported, but rx-let would require modifying a lot of rx which would be out of scope of Compat. > 2. Stefan Monnier added the call to `derived-mode-add-parents', which > needs Emacs 30.1. > > Stefan, can we avoid making that call? Perhaps it should be added to > compat? > > 3. We also need the below symbols: > > 26.1 flymake-make-diagnostic > 26.1 flymake-diag-region > 27.1 project-files > 25.1 project-current > > This could perhaps be fixed by depending on project and flymake. > Unfortunately, project 1.0 and flymake 0.1 (the earliest versions > available on GNU ELPA) themselves need Emacs 26.1 and Emacs 26.3. So > maybe we should just bump the required version of python.el to Emacs > 26.3? > > Alternatively, perhaps the above could also be added to compat? I'll > let Philip and Daniel comment on this too. I would rather that Compat doesn't depend on a newer version of flymake and project. > 4. More complicated to resolve perhaps are these symbols from Emacs 29.1: > > 29.1 treesit [require] > 29.1 treesit-buffer-root-node > 29.1 treesit-defun-name > 29.1 treesit-filter-child > 29.1 treesit-font-lock-rules > 29.1 treesit-fontify-with-override > 29.1 treesit-induce-sparse-tree > 29.1 treesit-major-mode-setup > 29.1 treesit-node-at > 29.1 treesit-node-child-by-field-name > 29.1 treesit-node-children > 29.1 treesit-node-end > 29.1 treesit-node-field-name > 29.1 treesit-node-parent > 29.1 treesit-node-prev-sibling > 29.1 treesit-node-start > 29.1 treesit-node-text > 29.1 treesit-node-type > 29.1 treesit-parser-create > 29.1 treesit-ready-p > > Yuan, Philip, Daniel, any ideas for how to handle this compatibility > issue? I still haven't familiarised myself with the treesit API, and I don't know if there is a reasonable way to translate these into fontlock... From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 11:51:28 2025 Received: (at 75526) by debbugs.gnu.org; 2 Mar 2025 16:51:28 +0000 Received: from localhost ([127.0.0.1]:33922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tomXI-0006Kr-8u for submit@debbugs.gnu.org; Sun, 02 Mar 2025 11:51:28 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36593) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tomXF-0006K7-Ec for 75526@debbugs.gnu.org; Sun, 02 Mar 2025 11:51:26 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 775EC806EF; Sun, 2 Mar 2025 11:51:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740934277; bh=RwHQnS1h78pX3n0QrVmc8vvi/6VDJgBEH8eCUELCRU4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VrXbL/2N2v7EAoAgNlEMw6w+DNs5jbUz5KcQJtwYVqArS6Za12DsExZDTrqAazUva RxSIx9vZMIZMmpSIX/tTwNfVPICsRwEBlmgqfYA+kGXFP42Et/KHruDFkXVy4D/aSw GkRrS/2seNxKdeGxuwzk/irwfCOXWeQHtg2WcNEBjgY+o13DV0oO8aPrmxO10Y42hA txfxkWzH+aoRwZ+sCVnRdaMZbDZ6oWbQ9oydostfu8K3uI/q4KBP5m79UQUcCNfyyY gl/gut0/p6jGFFf0/Qx6ZNZY7cXR73QDSME+Ou7jS5KdDRNJ651cf65e2c5uiBMWOF JVUge6LHPo8sg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 14C1880372; Sun, 2 Mar 2025 11:51:17 -0500 (EST) Received: from alfajor (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B9BE112053B; Sun, 2 Mar 2025 11:51:16 -0500 (EST) From: Stefan Monnier To: Philip Kaludercic Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 In-Reply-To: <877c5775zh.fsf@posteo.net> Message-ID: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> <877c5775zh.fsf@posteo.net> Date: Sun, 02 Mar 2025 11:51:15 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.251 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75526 Cc: 75526@debbugs.gnu.org, casouri@gmail.com, Stefan Kangas , JD Smith , mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> 4. More complicated to resolve perhaps are these symbols from Emacs 29.1: >> >> 29.1 treesit [require] >> 29.1 treesit-buffer-root-node >> 29.1 treesit-defun-name >> 29.1 treesit-filter-child >> 29.1 treesit-font-lock-rules >> 29.1 treesit-fontify-with-override >> 29.1 treesit-induce-sparse-tree >> 29.1 treesit-major-mode-setup >> 29.1 treesit-node-at >> 29.1 treesit-node-child-by-field-name >> 29.1 treesit-node-children >> 29.1 treesit-node-end >> 29.1 treesit-node-field-name >> 29.1 treesit-node-parent >> 29.1 treesit-node-prev-sibling >> 29.1 treesit-node-start >> 29.1 treesit-node-text >> 29.1 treesit-node-type >> 29.1 treesit-parser-create >> 29.1 treesit-ready-p >> >> Yuan, Philip, Daniel, any ideas for how to handle this compatibility >> issue? > > I still haven't familiarised myself with the treesit API, and I don't > know if there is a reasonable way to translate these into fontlock... We definitely don't want to translate those into fontlock. AFAIK, there are just two ways to solve this: - Bump package-requires to Emacs-29. - Use (require 'treesit nil t) and than sprinkle enough `fboundp` tests around treesitter code to allow loading `python.el` into Emacs<29. It's perfectly OK if `python-ts-mode` doesn't work in Emacs<29. Bumping package-requires to 29 might not be a bad idea since noone complained (until now) in the 2=BD years since we added (require 'treesit) to the code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 12:55:36 2025 Received: (at 75526-done) by debbugs.gnu.org; 2 Mar 2025 17:55:37 +0000 Received: from localhost ([127.0.0.1]:34622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tonXK-0004FS-1v for submit@debbugs.gnu.org; Sun, 02 Mar 2025 12:55:36 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:54696) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tonXG-0004EE-MA for 75526-done@debbugs.gnu.org; Sun, 02 Mar 2025 12:55:32 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5dca468c5e4so6467313a12.1 for <75526-done@debbugs.gnu.org>; Sun, 02 Mar 2025 09:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740938124; x=1741542924; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=4A2WH2i+4RgMx4N0qIhKrXvSuriitCReNzXwMiJ7yHY=; b=Se7iKHDfWYKyTiHSq1/GAr4lDoLZb7zklBf2hFv3XwsB5bIX5BVFC3v7dKZu6c8JDo edLHL/YfAcDwj7SUK1U7L27EMq6COkT1xgHM/bN4kGes1bgiHoDHXrqV1h6H80r30M1j ydpXZnpc6AH5K9C42Jnf1yjJvsrp0pzJbfzTcOEhGFF1WlfmVwDVbp/Wum3seO9+wztl pJ0E8F/G1fPcAj/s68fk0jgIbCQGz05uOEkOasM1gXx95/P18UQ6q4KLNr3xS3fVRrP0 1psxyNGk8oQRXPjBMYJG+NXGBEo/LR1v53pb4UEzGslu43+MIPlpRHoXL5rOFcHvpgYG Hl8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740938124; x=1741542924; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4A2WH2i+4RgMx4N0qIhKrXvSuriitCReNzXwMiJ7yHY=; b=wF6RCQJEiRUPtJbtZcONFKeJO9QKRvq5AjEZgzHQEbGQ2xdm+5vzytudWtReR6wL9y JQfrG4SEJpZ1x/0UwJgjcAFdHbYilP9RH7BlaESir0PZLvptUazS5AjuA/vEtLlS5LN9 bPMhdLeLxxO6ntCdxLjGbeMbjbl45SjSf4kdfv/O4SLvGMP0GC1eDYBnXPxBq6jAOmK0 5bVbM09g2igzJMRgD/W19ybvBIDQgqWlRj5FHlppV3RK6Cx6V8YyfoBxpSS84LizQ+AT tehDHyPm3Kg9v98UT8lIiO9hbnJbITx8JM2rm8oLO1IPhmrAte1eSvbdCHLVlNc6HwVo WSdg== X-Forwarded-Encrypted: i=1; AJvYcCWU2Xup2wmQ0F2uvhCyAMGMN51KGEU+cQPoEKeBQcaE4lSG1JFZ/m/cSnhdGf8cLsjh2A7NxxYE2ZaX@debbugs.gnu.org X-Gm-Message-State: AOJu0YydHhAyrAc36i+Jov9Tfm0xXnfPuROIdY4D3iezMsCYJAJHUXL+ 2SeD0L0Rur76183KzZBMXSFlz5oMo1QUq2mprlRBQkuVZAEE4VbIDMBW3WGrgKw0klh54khzZ1C H+kd+l67AqSa98C0WP096NFx/awM= X-Gm-Gg: ASbGncs2xqVXtQky5WMi9Fs2+Dn/jApipsEFfWbuB4AO9+WM7HbToWJESaOmayFQx+/ 66Vykj96mvxmB+aYe5alji0bYzCOx9dBnTmpB/s9H1b3IykgpxOErj4R7sSAnOcVnBBkaE71dNK nnrffF+96MfnjOta/aJyekPlK80g== X-Google-Smtp-Source: AGHT+IEm64ymy+zaKMqxoyiM8VPRIeJJqnLRVbe0r/2Ur1wnsMmagZo1Ie3bRSwxHBzBtNygCWN7vO8XjY8+ckmsFwU= X-Received: by 2002:a05:6402:84d:b0:5df:5188:11cc with SMTP id 4fb4d7f45d1cf-5e4d6b702a7mr10708305a12.20.1740938123735; Sun, 02 Mar 2025 09:55:23 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 Mar 2025 09:55:23 -0800 From: Stefan Kangas In-Reply-To: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> <877c5775zh.fsf@posteo.net> MIME-Version: 1.0 Date: Sun, 2 Mar 2025 09:55:23 -0800 X-Gm-Features: AQ5f1JpfSh2niQzkbaiLRC1uLME0xSKq1dgZAHok4iZJIaR2MEFY994cNZ8ezaQ Message-ID: Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 To: Stefan Monnier , Philip Kaludercic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526-done Cc: mail@daniel-mendler.de, casouri@gmail.com, 75526-done@debbugs.gnu.org, JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Stefan Monnier writes: > We definitely don't want to translate those into fontlock. > AFAIK, there are just two ways to solve this: > > - Bump package-requires to Emacs-29. > - Use (require 'treesit nil t) and than sprinkle enough `fboundp` tests > around treesitter code to allow loading `python.el` into Emacs<29. > It's perfectly OK if `python-ts-mode` doesn't work in Emacs<29. > > Bumping package-requires to 29 might not be a bad idea since noone > complained (until now) in the 2=C2=BD years since we added (require 'tree= sit) > to the code. True, so let's just save us a ton of headache: I have bumped the requirement to Emacs 29.1, which fixes all the outstanding issues reported here. With that, I'm closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 04 18:22:58 2025 Received: (at 75526-done) by debbugs.gnu.org; 4 Mar 2025 23:22:58 +0000 Received: from localhost ([127.0.0.1]:33505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpbbG-0001Uo-DZ for submit@debbugs.gnu.org; Tue, 04 Mar 2025 18:22:58 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:44151) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tpbbE-0001UY-FJ for 75526-done@debbugs.gnu.org; Tue, 04 Mar 2025 18:22:57 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-22356471820so100377725ad.0 for <75526-done@debbugs.gnu.org>; Tue, 04 Mar 2025 15:22:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741130570; x=1741735370; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vm8DdArvITjgrXV2DjvSPVrGDYVdK+5S5cZ6jAbAqEg=; b=iVI6GQJ0nSa2hElWDZrRhUC7e0F34qPm/nWStd5KNnqbYg4ax0T3tAcSZFQ0rzpVph arKsADz3dgxk80UayjDiidlvDJEyJde+qwwC1FX26mgaqUnlEpI3YyXlL+Hgup5HgqPI byN4wVFfysOct4iaZWXmrrVAiVCpgpvOR+XXcYsJkiAfhd+5FeM9ROtZJQi0LMiPeZvh Iq5YUZI36b2ruDW82ldqYjqLEypQt9y1cexSkoE8Lm2n1dWQZ78as9adstnHc63BhyQY LI5dKPwCJlm0RxDMxXSJYf6TlfamtETpQoxp4Z9PMIbDtMmu+5fOPIabMgdj/HTWmPcf FqOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741130570; x=1741735370; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vm8DdArvITjgrXV2DjvSPVrGDYVdK+5S5cZ6jAbAqEg=; b=uinwRvXakRVGAAkMtQCAxZEMXaLuSMI0Vn9AqJSrsUm71sD4FtrKiycVLFusqJPNcd e0T+StaXXXzkhxmcn40TG3/mwGP1BFSCr0Li7jJBLxOYp/wXV6yDcVxvMmpNipi8Cfpr Rd7Yu+SadJAXN1hpbqZW83gPgci8VJArsnULtXwwU/J2dZCbY0/2SL6mBvNR1PuAlL9N kiwkYeWJQu3MbwKKHAl/mbrMmugbqWoMuQj0iJoM9i39mJwxnTsB372Lpvoe8+TmmFbI tjxhQHq5ML1Dc86pUuEUbTUU0lPHpjpWaH8oKeUKZ9NNMmNwWODprilKONPxhX4nzgdI 5SWQ== X-Forwarded-Encrypted: i=1; AJvYcCWKoAdY9wSmyC3aZSk1sGegS2IAcRi2EM+earKzXOJc5W0IATgG6F3bHTVcAA1STdbXPdXfM5h3vzyi@debbugs.gnu.org X-Gm-Message-State: AOJu0YzX1Fp00ONr86SbfJ7t4XKVz3Pq6Hv4B0Cyo8JypGMmRrzLwMvb +4oRTrIdx6KgGYCZWgQK0pn9WpEX224NxkKxEyNHUbzBxhRR03VteMoWRQ== X-Gm-Gg: ASbGncthkW2bM40ZvVWfCmHQfTVbKsaGyW4dYTotJMBhSt1KUic/pZUzu178lRLMqVJ Aw8AFKGSrmaix4vdzsQg1jlhFVIdu88zNLtVbwrSW0BXpMfyC89/c+BLj72ibfXlO9P5OFsL+q6 C5pLDss1G2aCIPqWvLUyjZptQmei4JYwSslvuyRjdWKnVZ8ziWA8heLeN/kTAHJlFQeQ6sLFmRd WRWcSjSqEImFTPsB6e2frRqLMCbODHuinMcNr4cCaOlLhgO0aW4Xp4Xc4Xq3Zjzvy5cvPC28jfI agC6ax6LKFlNYd12xGt8mG4dhT6rXLHKOvNWet+1+U8ln2klPHmVM7WO84gX85t3Ac4/ X-Google-Smtp-Source: AGHT+IE1u5ZNqQoBR+brjPgTGGU9Sc800jmIwBCAteRQJwbVhGaqekrSNyg8sbtGJyMD8PLysFi4iA== X-Received: by 2002:a17:903:2311:b0:221:7b4a:474b with SMTP id d9443c01a7336-223f1c99435mr18293755ad.24.1741130570415; Tue, 04 Mar 2025 15:22:50 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:c004:4d68:8d79:7ea8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22350547cddsm100973835ad.259.2025.03.04.15.22.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Mar 2025 15:22:49 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75526: python.el uses treesit-declare-unavailable-functions despite requiring emacs >v24.4 From: Yuan Fu In-Reply-To: Date: Tue, 4 Mar 2025 15:22:38 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20D9F687-4E89-4A36-B5BF-EAD07A311B9E@gmail.com> <87o70bfuui.fsf@daniel-mendler.de> <87sep3mnpo.fsf@daniel-mendler.de> <7B5B5169-E58D-4D0A-BA05-EE4820EB2325@gmail.com> <3508490F-43D5-4B87-80E3-FE932D06D95E@gmail.com> <877c5775zh.fsf@posteo.net> To: Stefan Kangas X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75526-done Cc: mail@daniel-mendler.de, Philip Kaludercic , 75526-done@debbugs.gnu.org, Stefan Monnier , JD Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 2, 2025, at 9:55=E2=80=AFAM, Stefan Kangas = wrote: >=20 > Version: 31.1 >=20 > Stefan Monnier writes: >=20 >> We definitely don't want to translate those into fontlock. >> AFAIK, there are just two ways to solve this: >>=20 >> - Bump package-requires to Emacs-29. >> - Use (require 'treesit nil t) and than sprinkle enough `fboundp` = tests >> around treesitter code to allow loading `python.el` into Emacs<29. >> It's perfectly OK if `python-ts-mode` doesn't work in Emacs<29. >>=20 >> Bumping package-requires to 29 might not be a bad idea since noone >> complained (until now) in the 2=C2=BD years since we added (require = 'treesit) >> to the code. >=20 > True, so let's just save us a ton of headache: >=20 > I have bumped the requirement to Emacs 29.1, which fixes all the > outstanding issues reported here. With that, I'm closing this bug. Thanks! Saves a lot of headache indeed :) Yuan= From unknown Sat Aug 09 05:00:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 02 Apr 2025 11:24:20 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator