GNU bug report logs - #75521
scratch/igc: Delete unused macro DEFVAR_LISP_NOPROX

Previous Next

Full log

Message #163 received at 75521 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: 75521 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#75521: scratch/igc: Delete unused macro DEFVAR_LISP_NOPROX
Date: Thu, 16 Jan 2025 17:54:14 +0200

> Date: Tue, 14 Jan 2025 21:58:37 +0000
> From: Pip Cet <pipcet <at> protonmail.com>
> Cc: stefankangas <at> gmail.com, 75521 <at> debbugs.gnu.org
> 
> > I was asking about the problem where that code makes the values of
> > Vfont_weight_table and its 2 brethren vulnerable to being GC'ed.
> > That's the only problem I tried to solve with that patch.  That
> > Vfont_weight_table etc. are also updated to reflect the changes in
> > font_style_table is a nice benefit.
> 
> Not really a benefit: updating the variables might expose other
> (crashable) bugs more.
> 
> > If you agree that this problem will be solved by the patch, then I'd
> > like to install it, because it's very simple and localized, so the
> > risk to break something is IMO very low.
> 
> It introduces what are effectively new crashable bugs by attempting to
> fix old ones.  I'm neutral: installing this patch won't improve things
> significantly, but if you think there might be a slight improvement, you
> probably have your reasons.

Thanks, so I've now installed the patch on the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.