GNU bug report logs - #75521
scratch/igc: Delete unused macro DEFVAR_LISP_NOPROX

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75521 <at> debbugs.gnu.org, pipcet <at> protonmail.com
Subject: bug#75521: scratch/igc: Delete unused macro DEFVAR_LISP_NOPROX
Date: Wed, 15 Jan 2025 19:45:55 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Are you okay with removing this on the scratch/igc branch only?
>
> I have no problems with doing that on the branch conditioned by
> "#ifdef HAVE_MPS", if indeed DEFVAR_LISP_NOPRO is equivalent to
> DEFVAR_LISP there.

Thanks, done in commit de864e4f3b2.

> But are they indeed equivalent?  staticpro still
> exists on the branch, and AFAICT we create a root from staticvec.  So
> why are they equivalent?

Yes, they had the same definition:

#define DEFVAR_LISP(lname, vname, doc)			\
  do {							\
    static struct Lisp_Fwd const o_fwd			\
      = {Lisp_Fwd_Obj, .u.objvar = &globals.f_##vname};	\
    defvar_lisp (&o_fwd, lname);			\
  } while (false)
#ifdef HAVE_MPS
#define DEFVAR_LISP_NOPRO(lname, vname, doc)		\
  do {							\
    static struct Lisp_Fwd const o_fwd			\
      = {Lisp_Fwd_Obj, .u.objvar = &globals.f_##vname};	\
    defvar_lisp (&o_fwd, lname);			\
  } while (false)
#else

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.