GNU bug report logs - #75521
scratch/igc: Delete unused macro DEFVAR_LISP_NOPROX

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75521 <at> debbugs.gnu.org, pipcet <at> protonmail.com
Subject: bug#75521: scratch/igc: Delete unused macro DEFVAR_LISP_NOPROX
Date: Mon, 13 Jan 2025 21:09:02 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Mon, 13 Jan 2025 20:01:24 +0000
>> Cc: pipcet <at> protonmail.com, 75521 <at> debbugs.gnu.org
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> >> I'm curious why this was considered worth optimizing in the first place.
>> >
>> > What is the optimization here? DEFVAR_LISP_NOPRO or font_style_table?
>>
>> I was thinking of DEFVAR_LISP_NOPRO:
>
> AFAIU, it's there to avoid protecting something that is already
> protected.  staticvec[] is a static vector, so wasting slots there is
> best avoided.

Yes, indeed, but that seems like an optimization that is not worth
doing.  Not these days, at any rate.

It complicates the code, leading to confusion (case in point: this long
thread where many cycles were spent discussing it), and the performance
gains are not likely to even be measurable.

Note that with MPS, DEFVAR_LISP and DEFVAR_LISP_NOPRO are equivalent.
So by getting rid of DEFVAR_LISP_NOPRO, we would reduce the delta
between igc and master as a nice bonus.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.