GNU bug report logs - #75500
[PATCH] Fix keybinding alignment in `tmm-menubar'

Previous Next

Full log

Message #17 received at 75500 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75500 <at> debbugs.gnu.org
Subject: Re: bug#75500: [PATCH] Fix keybinding alignment in `tmm-menubar'
Date: Sat, 18 Jan 2025 17:30:29 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Cc: 75500 <at> debbugs.gnu.org
>> Date: Sat, 18 Jan 2025 15:11:10 +0100
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> Date: Sat, 11 Jan 2025 18:42:54 +0100
>> >> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> >> 
>> >> In tmm-menubar, for entries prepended by a numerical shortcut, the
>> >> associated keybinding ends up being misaligned.  For instance, you can
>> >> see that in the eww menu for the entry "List bookmarks".  This patch
>> >> fixes this misalignment.
>> >
>> > Thanks.  However, I couldn't see any misalignments in "List
>> > bookmarks".  Could you perhaps show a recipe for reproducing this,
>> > starting from "emacs -Q"?
>> 
>> You're right.  For me, the 'b' shortcut was "taken" for the "Back to
>> previous page" entry.  Anyway, you should see the misalignment for the
>> "List cookies" entry with the following recipe:
>> 
>>       - emacs -Q
>>       - M-: (setopt tmm-shortcut-inside-entry t) <RET>
>>       - M-x eww <RET>
>>       - gnu.org <RET>
>>       - M-x tmm-menubar <RET> E
>
> OK, I see it now, thanks.
>
> Coming back to the patch: please make sure the doc string of the
> function you are adding is according to our conventions (first line is
> a single complete sentence), and please explain in the comments _why_
> this shortening is needed and why exactly 2 spaces.

Do you meant like this?

[0001-Fix-keybinding-alignment-in-tmm-menubar.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.