GNU bug report logs - #75495
[PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'

Previous Next

Full log

Message #37 received at 75495 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 75495 <at> debbugs.gnu.org
Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom
 `ibuffer-human-readable-size'
Date: Sun, 26 Jan 2025 12:16:16 +0100

>>>>> On Sat, 25 Jan 2025 10:23:39 +0200, Eli Zaretskii <eliz <at> gnu.org> said:

    >> From: Daniel Mendler <mail <at> daniel-mendler.de>
    >> Cc: Eli Zaretskii <eliz <at> gnu.org>
    >> Date: Sat, 25 Jan 2025 08:40:46 +0100
    >> 
    >> Pengji Zhang <me <at> pengjiz.com> writes:
    >> 
    >> > Daniel Mendler <mail <at> daniel-mendler.de> writes:
    >> >
    >> >> Yes, we should. I have attached the improved patch to this mail.
    >> >
    >> > It works great. Thanks!
    >> 
    >> Hello Eli,
    >> 
    >> does this patch (and my other Ibuffer patch) look okay to you, such that
    >> they can be installed? Thanks.

    Eli> Didn't yet have time to review it, will do soon.

It would be good if the patch consistently used either "size" or
"sizes" in the code and docstring, rather than a mix. Iʼd lean
slightly (but only slightly) to "sizes".

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.