GNU bug report logs - #75495
[PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'

Previous Next

Full log

Message #34 received at 75495-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: me <at> pengjiz.com, 75495-done <at> debbugs.gnu.org
Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom
 `ibuffer-human-readable-size'
Date: Sat, 25 Jan 2025 11:42:59 +0200

> Cc: 75495 <at> debbugs.gnu.org
> Date: Sun, 19 Jan 2025 14:45:29 +0100
> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Pengji Zhang <me <at> pengjiz.com> writes:
> 
> > Daniel Mendler <mail <at> daniel-mendler.de> writes:
> >
> >>+             (or (get-text-property (1- (length s)) 'ibuffer-size s)
> >>+                 (get-text-property 0 'ibuffer-size s) 0))))
> >
> > Should we consider centered column as well? I know it sounds unusual,
> > but for completeness I would like to support that as well.
> >
> > Maybe we could skip the leading spaces:
> >
> >       (get-text-property 0 'ibuffer-size (string-trim-left s " +"))
> >
> > What do you think?
> 
> Yes, we should. I have attached the improved patch to this mail.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.