GNU bug report logs - #75495
[PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75495: closed ([PATCH] ibuffer: New defcustom `ibuffer-human-readable-size')
Date: Sat, 25 Jan 2025 09:44:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 25 Jan 2025 11:42:59 +0200
with message-id <861pwrw7oc.fsf <at> gnu.org>
and subject line Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'
has caused the debbugs.gnu.org bug report #75495,
regarding [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75495: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75495
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'
Date: Sat, 11 Jan 2025 14:28:07 +0100

[Message part 3 (text/plain, inline)]

Tags: patch

This patch adds the customization option `ibuffer-human-readable-size'.
If customized to t, buffer sizes in Ibuffer are shown in human readable
format.

[0001-ibuffer-New-defcustom-ibuffer-human-readable-size.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: me <at> pengjiz.com, 75495-done <at> debbugs.gnu.org
Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom
 `ibuffer-human-readable-size'
Date: Sat, 25 Jan 2025 11:42:59 +0200

> Cc: 75495 <at> debbugs.gnu.org
> Date: Sun, 19 Jan 2025 14:45:29 +0100
> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Pengji Zhang <me <at> pengjiz.com> writes:
> 
> > Daniel Mendler <mail <at> daniel-mendler.de> writes:
> >
> >>+             (or (get-text-property (1- (length s)) 'ibuffer-size s)
> >>+                 (get-text-property 0 'ibuffer-size s) 0))))
> >
> > Should we consider centered column as well? I know it sounds unusual,
> > but for completeness I would like to support that as well.
> >
> > Maybe we could skip the leading spaces:
> >
> >       (get-text-property 0 'ibuffer-size (string-trim-left s " +"))
> >
> > What do you think?
> 
> Yes, we should. I have attached the improved patch to this mail.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.