GNU bug report logs - #75495
[PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'

Previous Next

Full log

View this message in rfc822 format

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Pengji Zhang <me <at> pengjiz.com>
Cc: 75495 <at> debbugs.gnu.org
Subject: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size'
Date: Sun, 19 Jan 2025 14:45:29 +0100

[Message part 1 (text/plain, inline)]

Pengji Zhang <me <at> pengjiz.com> writes:

> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>
>>+             (or (get-text-property (1- (length s)) 'ibuffer-size s)
>>+                 (get-text-property 0 'ibuffer-size s) 0))))
>
> Should we consider centered column as well? I know it sounds unusual,
> but for completeness I would like to support that as well.
>
> Maybe we could skip the leading spaces:
>
>       (get-text-property 0 'ibuffer-size (string-trim-left s " +"))
>
> What do you think?

Yes, we should. I have attached the improved patch to this mail.

Daniel

[0001-ibuffer-New-defcustom-ibuffer-human-readable-size.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.