From unknown Sun Jun 22 22:42:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#75495 <75495@debbugs.gnu.org> To: bug#75495 <75495@debbugs.gnu.org> Subject: Status: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' Reply-To: bug#75495 <75495@debbugs.gnu.org> Date: Mon, 23 Jun 2025 05:42:56 +0000 retitle 75495 [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' reassign 75495 emacs submitter 75495 Daniel Mendler severity 75495 normal tag 75495 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 11 08:28:37 2025 Received: (at submit) by debbugs.gnu.org; 11 Jan 2025 13:28:37 +0000 Received: from localhost ([127.0.0.1]:41768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWbXY-00049Q-Mv for submit@debbugs.gnu.org; Sat, 11 Jan 2025 08:28:37 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38254) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWbXV-00048h-T7 for submit@debbugs.gnu.org; Sat, 11 Jan 2025 08:28:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWbXE-0000H1-BD for bug-gnu-emacs@gnu.org; Sat, 11 Jan 2025 08:28:17 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWbXA-0001NN-DC for bug-gnu-emacs@gnu.org; Sat, 11 Jan 2025 08:28:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AsDuPL08Ow2ZHItNk8F1pJEO2/mH23pbvDiGoyED2nc=; b=xFmydI0nES42e3UEOOLEv8Mfuw 2QTotO9VL2OhHkeM2uocvASAiW73kO6CbHxAWnVi7z6GVZMXxlocat9BWQsn8yxBo4saMfoxVt9lV MXY6AneiZc4lTIdgKsRGYpuqxeBZcCcM+4dVZjxaPHU/Iiwv1jF6l/Z5mqphRChiZwnk=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org Subject: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' Date: Sat, 11 Jan 2025 14:28:07 +0100 Message-ID: <87ikqlbhug.fsf@daniel-mendler.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch This patch adds the customization option `ibuffer-human-readable-size'. If customized to t, buffer sizes in Ibuffer are shown in human readable format. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-ibuffer-New-defcustom-ibuffer-human-readable-size.patch >From e516d867edcfeda4840ba8e067534bc8582ee0e9 Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Sat, 11 Jan 2025 14:22:02 +0100 Subject: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' * lisp/ibuffer.el (ibuffer-human-readable-size): New defcustom. (define-ibuffer-column size): Use it. * etc/NEWS: Mention new defcustom. --- etc/NEWS | 3 +++ lisp/ibuffer.el | 26 +++++++++++++++++--------- 2 files changed, 20 insertions(+), 9 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index d017c872fa3..d20c71897bc 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -338,6 +338,9 @@ modal editing packages. The variable 'ibuffer-formats' configures the Ibuffer formats. Add 'recency' to the format to display the column. +*** New user option 'ibuffer-human-readable-size'. +When non-nil, buffer sizes are shown in human readable format. + ** Smerge *** New command 'smerge-extend' extends a conflict over surrounding lines. diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 32bc8140703..65f8ca53693 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -186,6 +186,10 @@ ibuffer-fontification-alist (sexp :tag "Test Form") face))) +(defcustom ibuffer-human-readable-size nil + "Show buffer sizes in human-readable format." + :type 'boolean) + (defcustom ibuffer-use-other-window nil "If non-nil, display Ibuffer in another window by default." :type 'boolean) @@ -1714,15 +1718,19 @@ size (:inline t :header-mouse-map ibuffer-size-header-map :summarizer - (lambda (column-strings) - (let ((total 0)) - (dolist (string column-strings) - (setq total - ;; like, ewww ... - (+ (float (string-to-number string)) - total))) - (format "%.0f" total)))) - (format "%s" (buffer-size))) + (lambda (strings) + (let ((total + (cl-loop + for s in strings sum + (or (get-text-property 0 'ibuffer--buffer-size s) 0)))) + (if ibuffer-human-readable-size + (file-size-human-readable total) + (number-to-string total))))) + (let ((size (buffer-size))) + (propertize (if ibuffer-human-readable-size + (file-size-human-readable size) + (number-to-string size)) + 'ibuffer--buffer-size size))) (define-ibuffer-column recency (:inline t :summarizer ignore :header-mouse-map ibuffer-recency-header-map) -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 12 07:34:44 2025 Received: (at 75495) by debbugs.gnu.org; 12 Jan 2025 12:34:44 +0000 Received: from localhost ([127.0.0.1]:46360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWxAx-0002cA-Ur for submit@debbugs.gnu.org; Sun, 12 Jan 2025 07:34:44 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:44561 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWxAu-0002bp-M0 for 75495@debbugs.gnu.org; Sun, 12 Jan 2025 07:34:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fCE30eogx+xjYCe+BxtvfceNyG7IVheGVk/Gl+q89Sc=; b=CJ17oRh2PMdyRJD0rsjZpD9sQf cJkIzUER3R24IguA4SWtONJ2oML6z0GUQ5UY/rvohQoBli273vc6td23hiK6iPsgpnxNihidf5pO8 pKRhuyt9Dg/4mKX1/VLyY7GMZTIJ/83RexeI9E8iS+kA4NR3Y8vuy8uJwoOb98AtSACo=; From: Daniel Mendler To: 75495@debbugs.gnu.org Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' In-Reply-To: <87ikqlbhug.fsf@daniel-mendler.de> (Daniel Mendler's message of "Sat, 11 Jan 2025 14:28:07 +0100") References: <87ikqlbhug.fsf@daniel-mendler.de> Date: Sun, 12 Jan 2025 13:34:30 +0100 Message-ID: <87h664p5wp.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75495 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Daniel Mendler writes: > This patch adds the customization option `ibuffer-human-readable-size'. > If customized to t, buffer sizes in Ibuffer are shown in human readable > format. I have attached an improved version of the patch to this mail, where it is ensured that the summarizer works for a left or right aligned size column. Daniel --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ibuffer-New-defcustom-ibuffer-human-readable-size.patch >From 556b043da41f6196072d71cf4dfbc4fd2c1f1695 Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Sat, 11 Jan 2025 14:22:02 +0100 Subject: [PATCH 1/2] ibuffer: New defcustom `ibuffer-human-readable-size' * lisp/ibuffer.el (ibuffer-human-readable-size): New defcustom. (define-ibuffer-column size): Use it. * etc/NEWS: Mention new defcustom. --- etc/NEWS | 3 +++ lisp/ibuffer.el | 27 ++++++++++++++++++--------- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index d017c872fa3..d20c71897bc 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -338,6 +338,9 @@ modal editing packages. The variable 'ibuffer-formats' configures the Ibuffer formats. Add 'recency' to the format to display the column. +*** New user option 'ibuffer-human-readable-size'. +When non-nil, buffer sizes are shown in human readable format. + ** Smerge *** New command 'smerge-extend' extends a conflict over surrounding lines. diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 32bc8140703..cb69915e6b7 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -186,6 +186,10 @@ ibuffer-fontification-alist (sexp :tag "Test Form") face))) +(defcustom ibuffer-human-readable-size nil + "Show buffer sizes in human-readable format." + :type 'boolean) + (defcustom ibuffer-use-other-window nil "If non-nil, display Ibuffer in another window by default." :type 'boolean) @@ -1714,15 +1718,20 @@ size (:inline t :header-mouse-map ibuffer-size-header-map :summarizer - (lambda (column-strings) - (let ((total 0)) - (dolist (string column-strings) - (setq total - ;; like, ewww ... - (+ (float (string-to-number string)) - total))) - (format "%.0f" total)))) - (format "%s" (buffer-size))) + (lambda (strings) + (let ((total + (cl-loop + for s in strings sum + (or (get-text-property (1- (length s)) 'ibuffer-size s) + (get-text-property 0 'ibuffer-size s) 0)))) + (if ibuffer-human-readable-size + (file-size-human-readable total) + (number-to-string total))))) + (let ((size (buffer-size))) + (propertize (if ibuffer-human-readable-size + (file-size-human-readable size) + (number-to-string size)) + 'ibuffer-size size))) (define-ibuffer-column recency (:inline t :summarizer ignore :header-mouse-map ibuffer-recency-header-map) -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 05:12:03 2025 Received: (at 75495) by debbugs.gnu.org; 18 Jan 2025 10:12:03 +0000 Received: from localhost ([127.0.0.1]:40277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZ5oB-0006YB-5e for submit@debbugs.gnu.org; Sat, 18 Jan 2025 05:12:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57102) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tZ5o9-0006Xc-1q for 75495@debbugs.gnu.org; Sat, 18 Jan 2025 05:12:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tZ5o3-00009m-3Z; Sat, 18 Jan 2025 05:11:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lQLmlZpjnm9NipNFHyuwIMCurEkmxw0oYLIBidE5OoQ=; b=cmwYm2ZBeBdy Nks671VoYhOchX/BJmdkIMZz4ch8Dp39TGn0y++uXu1+KVYN71tOihBK9uG0glaQUwmOjK2ZUBbxK T9pMX2uCsWC9pOR9j6z0xYOa92ZndRnf5nMcgzok333b8s7wWaxsLcRnF/alX7PPej8Qy8EVntXjp 3vR7+jgckDlbNw3UXuZIM+DY0bor8SHiX+DCwF1g5Qpz/tzTghNXpig5qV7degsCWfuYQA1RNclor w9EAcp3i182rTLvQpev22rFP3nqTDtJvF5HtL+PbZlRCYK1v6DOvuLVjqYZP6VYpIE0F9SWDj5tfs f04zeIHegJsEF9UBfUWXJQ==; Date: Sat, 18 Jan 2025 12:11:52 +0200 Message-Id: <86frlgbfdj.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87h664p5wp.fsf@daniel-mendler.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' References: <87ikqlbhug.fsf@daniel-mendler.de> <87h664p5wp.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75495 Cc: 75495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 12 Jan 2025 13:34:30 +0100 > From: Daniel Mendler via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Daniel Mendler writes: > > > This patch adds the customization option `ibuffer-human-readable-size'. > > If customized to t, buffer sizes in Ibuffer are shown in human readable > > format. > > I have attached an improved version of the patch to this mail, where it > is ensured that the summarizer works for a left or right aligned size > column. Thanks. > +(defcustom ibuffer-human-readable-size nil > + "Show buffer sizes in human-readable format." > + :type 'boolean) This needs a :version tag. Also, I think the doc string should explain in more detail what we mean by "human-readable format". From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 05:33:39 2025 Received: (at 75495) by debbugs.gnu.org; 18 Jan 2025 10:33:40 +0000 Received: from localhost ([127.0.0.1]:40338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZ695-0002Gt-Dh for submit@debbugs.gnu.org; Sat, 18 Jan 2025 05:33:39 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:32995 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tZ693-0002Gc-E5 for 75495@debbugs.gnu.org; Sat, 18 Jan 2025 05:33:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RS60iMTJWIjIjRLVsVMeLVVImrNoreF+vQ7SbAOOV8o=; b=MuN8j/Mirnh9+P+5OhzgNgXvVE +oP6MWXokxkYWY0O+ySypc00dmh0GuOeuw5HfEHhgb1U37fJMsfDqNmpMNtYdcw5W0Kg9eYlMF0pl NuZ3SuZprw4kTPNDZeg6CFXuF4q4kvZiE3iG0OyI9RKL0vCQSGC4/23PSlqpbZJt17Yk=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' In-Reply-To: <86frlgbfdj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Jan 2025 12:11:52 +0200") References: <87ikqlbhug.fsf@daniel-mendler.de> <87h664p5wp.fsf@daniel-mendler.de> <86frlgbfdj.fsf@gnu.org> Date: Sat, 18 Jan 2025 11:33:30 +0100 Message-ID: <87cygkcsxx.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75495 Cc: 75495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Date: Sun, 12 Jan 2025 13:34:30 +0100 >> From: Daniel Mendler via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Daniel Mendler writes: >> >> > This patch adds the customization option `ibuffer-human-readable-size'. >> > If customized to t, buffer sizes in Ibuffer are shown in human readable >> > format. >> >> I have attached an improved version of the patch to this mail, where it >> is ensured that the summarizer works for a left or right aligned size >> column. > > Thanks. > >> +(defcustom ibuffer-human-readable-size nil >> + "Show buffer sizes in human-readable format." >> + :type 'boolean) > > This needs a :version tag. > > Also, I think the doc string should explain in more detail what we > mean by "human-readable format". Thank you for the review. I have attached an updated patch to this mail. Daniel --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ibuffer-New-defcustom-ibuffer-human-readable-size.patch >From 57358674a7c5b5231c6be97546f86838c3413e33 Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Sat, 11 Jan 2025 14:22:02 +0100 Subject: [PATCH 1/2] ibuffer: New defcustom `ibuffer-human-readable-size' * lisp/ibuffer.el (ibuffer-human-readable-size): New defcustom. (define-ibuffer-column size): Use it. * etc/NEWS: Mention new defcustom. --- etc/NEWS | 3 +++ lisp/ibuffer.el | 29 ++++++++++++++++++++--------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 0b849dec450..ad099f34541 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -353,6 +353,9 @@ You can now set `asm-comment-char' from 'asm-mode-hook' instead. The variable 'ibuffer-formats' configures the Ibuffer formats. Add 'recency' to the format to display the column. +*** New user option 'ibuffer-human-readable-size'. +When non-nil, buffer sizes are shown in human readable format. + ** Smerge *** New command 'smerge-extend' extends a conflict over surrounding lines. diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 32bc8140703..c0033af8435 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -186,6 +186,12 @@ ibuffer-fontification-alist (sexp :tag "Test Form") face))) +(defcustom ibuffer-human-readable-size nil + "Show buffer sizes in human-readable format. +Use the function `file-size-human-readable' for formatting." + :type 'boolean + :version "31.1") + (defcustom ibuffer-use-other-window nil "If non-nil, display Ibuffer in another window by default." :type 'boolean) @@ -1714,15 +1720,20 @@ size (:inline t :header-mouse-map ibuffer-size-header-map :summarizer - (lambda (column-strings) - (let ((total 0)) - (dolist (string column-strings) - (setq total - ;; like, ewww ... - (+ (float (string-to-number string)) - total))) - (format "%.0f" total)))) - (format "%s" (buffer-size))) + (lambda (strings) + (let ((total + (cl-loop + for s in strings sum + (or (get-text-property (1- (length s)) 'ibuffer-size s) + (get-text-property 0 'ibuffer-size s) 0)))) + (if ibuffer-human-readable-size + (file-size-human-readable total) + (number-to-string total))))) + (let ((size (buffer-size))) + (propertize (if ibuffer-human-readable-size + (file-size-human-readable size) + (number-to-string size)) + 'ibuffer-size size))) (define-ibuffer-column recency (:inline t :summarizer ignore :header-mouse-map ibuffer-recency-header-map) -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 07:26:12 2025 Received: (at 75495) by debbugs.gnu.org; 19 Jan 2025 12:26:12 +0000 Received: from localhost ([127.0.0.1]:45171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZUNY-0000ny-Eh for submit@debbugs.gnu.org; Sun, 19 Jan 2025 07:26:12 -0500 Received: from fhigh-a2-smtp.messagingengine.com ([103.168.172.153]:44231) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tZUNU-0000nh-T2 for 75495@debbugs.gnu.org; Sun, 19 Jan 2025 07:26:09 -0500 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 34B3C11400CE for <75495@debbugs.gnu.org>; Sun, 19 Jan 2025 07:26:03 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Sun, 19 Jan 2025 07:26:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pengjiz.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1737289563; x=1737375963; bh=aZIAffMQdUyAI82oiEX5Vf+64gvUUTlf DKvqanMARzI=; b=NEevqPiM/zrn8Xmw7QXS4B7ZgEaIqJvAyDuJq5ognIwcTO44 LTJW6LJXuAQIV1IQ/DG+JTfdvAJ3Mon+qyHcCDbVlAk89AVLdcha0jHJtJZPG3Jh mN7xThtgBrs3XtRaMF03+PidOgJAuRAYCivEN6UD/4TJ+Nk4eUStUnRjFaCxQ44T kMMZBIeA7b2ZJc5fPLAVGtglvUB0oSMk0KNkos/3GKAN7xQCrqqoIkd9iTzzspBG oIoLnm8mfD/u/iMY+9mNnPc/M6xIwwQOLRU2ryCujLBW0/0SyO/Oh6gO4e17sGC6 sWqPxJ0oeseRtBc2pCHtk32/PekzK5ImnQjGKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1737289563; x= 1737375963; bh=aZIAffMQdUyAI82oiEX5Vf+64gvUUTlfDKvqanMARzI=; b=B HLjRGuHhKXpTwAhdyTv/DlmbDrDKoNc0MtoNfr6sz2GFv7cJLmXfnxYx5dp8Jjxi jZGwI4oV/9qvb7fPAt2lhe3ilKhTctiC9WbFzj425ou30bfWmSHVGbUWZxfv1IQJ rgLItw0UEtUb08v1nAhcKKU5BpYm1Ym7Wx/Oy6Jgk4SBUVkRoxK9paMDrbLnQncC RsqLjIhk4FowDcKEwsW30I/zH7JJFOS0lrHbHMA6og6mWVItYioDMtWm6Nzff6mJ DuicGEzZf1ADqrtCaKzv+Z0MFy1xKBoelxIm0BwOik2AK2sZ2FZuJ//YC6fpqMIK J2wlwVJEwdSMCdjjX1nHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeijedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuff fkgggtsehttdertddttddtnecuhfhrohhmpefrvghnghhjihcukghhrghnghcuoehmvges phgvnhhgjhhiiidrtghomheqnecuggftrfgrthhtvghrnheptdfhjeekueduleevffelff elhfeuueeufeehkeefteeuhfeiffethfdvhfevuedvnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepmhgvsehpvghnghhjihiirdgtohhmpdhnsg gprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeejheegleeh seguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i16614472:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <75495@debbugs.gnu.org>; Sun, 19 Jan 2025 07:26:02 -0500 (EST) From: Pengji Zhang To: 75495@debbugs.gnu.org Subject: Re: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' Date: Sun, 19 Jan 2025 20:25:58 +0800 Message-ID: <87wmer3s89.fsf@pengjiz.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75495 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Daniel Mendler writes: >+ (or (get-text-property (1- (length s)) 'ibuffer-size s) >+ (get-text-property 0 'ibuffer-size s) 0)))) Should we consider centered column as well? I know it sounds unusual, but for completeness I would like to support that as well. Maybe we could skip the leading spaces: (get-text-property 0 'ibuffer-size (string-trim-left s " +")) What do you think? Pengji From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 08:45:45 2025 Received: (at 75495) by debbugs.gnu.org; 19 Jan 2025 13:45:45 +0000 Received: from localhost ([127.0.0.1]:45288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZVcX-0001wI-0v for submit@debbugs.gnu.org; Sun, 19 Jan 2025 08:45:45 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:34317 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tZVcR-0001vq-QZ for 75495@debbugs.gnu.org; Sun, 19 Jan 2025 08:45:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9mPOJ9WiVlCOT6e89nTvytob3fLan7Qt4BY85lOCg+o=; b=BMddQreEe0YDj8COSi6KfwVnPs CT6jua63UMb6msVAFQ18CwXOgn1t0njWYpAKfL3u5PH6yKIXWou/cJWdUglNLouiz/7Dczob+3wqM OH4EOP3BvCc50BWN1iFxN2djZxf++c9EnOmbIRr0AkuTd3GDgZ8KxBrhd46Jym5D1rqA=; From: Daniel Mendler To: Pengji Zhang Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' In-Reply-To: <87wmer3s89.fsf@pengjiz.com> (Pengji Zhang's message of "Sun, 19 Jan 2025 20:25:58 +0800") References: <87ikqlbhug.fsf@daniel-mendler.de> <87wmer3s89.fsf@pengjiz.com> Date: Sun, 19 Jan 2025 14:45:29 +0100 Message-ID: <87ikqavrwm.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75495 Cc: 75495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Pengji Zhang writes: > Daniel Mendler writes: > >>+ (or (get-text-property (1- (length s)) 'ibuffer-size s) >>+ (get-text-property 0 'ibuffer-size s) 0)))) > > Should we consider centered column as well? I know it sounds unusual, > but for completeness I would like to support that as well. > > Maybe we could skip the leading spaces: > > (get-text-property 0 'ibuffer-size (string-trim-left s " +")) > > What do you think? Yes, we should. I have attached the improved patch to this mail. Daniel --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ibuffer-New-defcustom-ibuffer-human-readable-size.patch >From a5856981a9afb8c3943dbb57fbf648d28ef438b8 Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Sat, 11 Jan 2025 14:22:02 +0100 Subject: [PATCH 1/2] ibuffer: New defcustom `ibuffer-human-readable-size' * lisp/ibuffer.el (ibuffer-human-readable-size): New defcustom. (define-ibuffer-column size): Use it. * etc/NEWS: Mention new defcustom. --- etc/NEWS | 3 +++ lisp/ibuffer.el | 29 ++++++++++++++++++++--------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 0b849dec450..ad099f34541 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -353,6 +353,9 @@ You can now set `asm-comment-char' from 'asm-mode-hook' instead. The variable 'ibuffer-formats' configures the Ibuffer formats. Add 'recency' to the format to display the column. +*** New user option 'ibuffer-human-readable-size'. +When non-nil, buffer sizes are shown in human readable format. + ** Smerge *** New command 'smerge-extend' extends a conflict over surrounding lines. diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 32bc8140703..11340d4bd9e 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -186,6 +186,12 @@ ibuffer-fontification-alist (sexp :tag "Test Form") face))) +(defcustom ibuffer-human-readable-size nil + "Show buffer sizes in human-readable format. +Use the function `file-size-human-readable' for formatting." + :type 'boolean + :version "31.1") + (defcustom ibuffer-use-other-window nil "If non-nil, display Ibuffer in another window by default." :type 'boolean) @@ -1714,15 +1720,20 @@ size (:inline t :header-mouse-map ibuffer-size-header-map :summarizer - (lambda (column-strings) - (let ((total 0)) - (dolist (string column-strings) - (setq total - ;; like, ewww ... - (+ (float (string-to-number string)) - total))) - (format "%.0f" total)))) - (format "%s" (buffer-size))) + (lambda (strings) + (let ((total + (cl-loop + for s in strings + for i = (text-property-not-all 0 (length s) 'ibuffer-size nil s) + if i sum (get-text-property i 'ibuffer-size s)))) + (if ibuffer-human-readable-size + (file-size-human-readable total) + (number-to-string total))))) + (let ((size (buffer-size))) + (propertize (if ibuffer-human-readable-size + (file-size-human-readable size) + (number-to-string size)) + 'ibuffer-size size))) (define-ibuffer-column recency (:inline t :summarizer ignore :header-mouse-map ibuffer-recency-header-map) -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 19:58:02 2025 Received: (at 75495) by debbugs.gnu.org; 20 Jan 2025 00:58:02 +0000 Received: from localhost ([127.0.0.1]:48302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tZg77-0004H0-QJ for submit@debbugs.gnu.org; Sun, 19 Jan 2025 19:58:02 -0500 Received: from fhigh-b2-smtp.messagingengine.com ([202.12.124.153]:46285) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tZg74-0004Gd-8u for 75495@debbugs.gnu.org; Sun, 19 Jan 2025 19:57:59 -0500 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id DD7ED2540104; Sun, 19 Jan 2025 19:57:51 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Sun, 19 Jan 2025 19:57:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pengjiz.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1737334671; x=1737421071; bh=UzGkeuoe/A MKcY22qkTsTXZE+QsAOG0ul2fJ2NdQFNg=; b=mvlRmqtAzEYyhIDCWkBcz5dYeJ zBqGS8ZRytPPwAIuy+yB4v+Cz++dy4hzMxZ1RKUxIkaOTzAVTl0i8g3y0DsjlSv8 LhG2ZW+iJfxsHWYY28FcsZ7BTx6v2fxQqVzgmiMnr1NivAmqecRV+Mi+r0kmyMHB 95tG8mLcICtaH34yrtvL6w86vwWLCcTg89mORmPTud4G3uATz4239cIW60JhoU3v a6zBF8HAjT/6xo7yj9Xi+LybnCWCELBk4Cy7Rpw08m/bq03b67JlYfy9cXhFhB4M QXD6ZjHmRKz16otpZ+k2BIaeVUjMvXHTROqh0LPm97H1PeT6qCR6FokKZcFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1737334671; x=1737421071; bh=UzGkeuoe/AMKcY22qkTsTXZE+QsAOG0ul2f J2NdQFNg=; b=w/ZHN0m43U1HasVWJN7GAluuLXGWvwk4G0HRxFq9nTklbzejACs UVUckDyQ8JymCv9OLkE9z6GrKWtKNUHcWNXgiqZ/iqLUjb5xejbELEDJTSPIbsPu VZ+UcpAxTsM8JJLd0JHaJf0V+OzhCpNQwyf+jmVINWXOoBDUkHZ++LDA6XxHIeTF ygxczsA4aNyM7zioL+I+Po+gzv64fyv4hwYdTiSyPZh15Xinv1l7x490JsVq0ZB3 NHnENkFCrVEfL7bR/N7SZRQvIAaGeWAort2cd4r3gGkMaHLSsxS/0EdZiWKcozwG bnB0og09k1k3GuTEwMlZQQNV9dfLIkaNCMw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeikedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf gjfhffkfggtgesthdtredttddttdenucfhrhhomheprfgvnhhgjhhiucgkhhgrnhhguceo mhgvsehpvghnghhjihiirdgtohhmqeenucggtffrrghtthgvrhhnpeegfeeiiedvudekie dtgedufedtvedtueetieffhfdvhefftefgieejieelleehgeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmvgesphgvnhhgjhhiiidrtghomh dpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgr ihhlsegurghnihgvlhdqmhgvnhgulhgvrhdruggvpdhrtghpthhtohepjeehgeelheesug gvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i16614472:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Jan 2025 19:57:50 -0500 (EST) From: Pengji Zhang To: Daniel Mendler Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' In-Reply-To: <87ikqavrwm.fsf@daniel-mendler.de> References: <87ikqlbhug.fsf@daniel-mendler.de> <87wmer3s89.fsf@pengjiz.com> <87ikqavrwm.fsf@daniel-mendler.de> Date: Mon, 20 Jan 2025 08:57:47 +0800 Message-ID: <87a5bms3n8.fsf@pengjiz.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75495 Cc: 75495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Daniel Mendler writes: > Yes, we should. I have attached the improved patch to this mail. It works great. Thanks! Pengji From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 25 02:40:59 2025 Received: (at 75495) by debbugs.gnu.org; 25 Jan 2025 07:40:59 +0000 Received: from localhost ([127.0.0.1]:48260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbamo-0006bu-PH for submit@debbugs.gnu.org; Sat, 25 Jan 2025 02:40:59 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:39925 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tbamm-0006bb-8T for 75495@debbugs.gnu.org; Sat, 25 Jan 2025 02:40:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BJfujfK+2ZN2QzV+az84euxkWUWFcZUS1mA04kYzSEY=; b=pagTMabNCCuq1oL7tzx87SupKj yseroqCzstkB6pT8X4Ypl7cooHRS/HzZVPfnogDGxxFevkgF14qfwiUXVRBGPiWUPUDTuYxl2kJxh cbte2zNfwuE9o2gx1DJPXQYy+Q6eVV50dajUdkFsBcaGr+2j34qhDCe0lrMlNW44wW+M=; From: Daniel Mendler To: 75495@debbugs.gnu.org Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' In-Reply-To: <87a5bms3n8.fsf@pengjiz.com> (Pengji Zhang's message of "Mon, 20 Jan 2025 08:57:47 +0800") References: <87ikqlbhug.fsf@daniel-mendler.de> <87wmer3s89.fsf@pengjiz.com> <87ikqavrwm.fsf@daniel-mendler.de> <87a5bms3n8.fsf@pengjiz.com> Date: Sat, 25 Jan 2025 08:40:46 +0100 Message-ID: <87y0yz7341.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75495 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Pengji Zhang writes: > Daniel Mendler writes: > >> Yes, we should. I have attached the improved patch to this mail. > > It works great. Thanks! Hello Eli, does this patch (and my other Ibuffer patch) look okay to you, such that they can be installed? Thanks. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 25 03:23:53 2025 Received: (at 75495) by debbugs.gnu.org; 25 Jan 2025 08:23:54 +0000 Received: from localhost ([127.0.0.1]:48325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbbSL-0000Bz-Kk for submit@debbugs.gnu.org; Sat, 25 Jan 2025 03:23:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52864) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tbbSI-0000Bg-7k for 75495@debbugs.gnu.org; Sat, 25 Jan 2025 03:23:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbbSB-0008Nd-OY; Sat, 25 Jan 2025 03:23:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KD9569Nq5xh2zg33Faeu3XAET61vRIeZHSYX2F9RPJk=; b=G45GFtRa6Ixt oSrp68+rq3R55gshSFcW2C6CffPVuOepvIZT8qd/vtJcyUcFaH2zNLyJ2XIhvYBJbfHdfrlkSE5cw I8ikbE+f1yFi0C4jScBiRZpzDxbasq7alswNyjs6ByLa5a9o0txDTeZ4cmjudMPWp9aEIs7G0foVz cRzvNhkNNqDb+XNjmDQu3GfBiq82lm1Fe/vVjQIjK8/PHrOMnw9iz27XKGBTIqlV/9w8RVvn35bN/ mCCrjZXlYRyUc+dntZ5NXZEw1a5G417+TjlUzC27adfeWimdPkc+Zmk/0jYwHcTsFoApa9KSxtsZy pc2Vx7+3TwEwOducHK8gSQ==; Date: Sat, 25 Jan 2025 10:23:39 +0200 Message-Id: <86msffwbck.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87y0yz7341.fsf@daniel-mendler.de> (message from Daniel Mendler on Sat, 25 Jan 2025 08:40:46 +0100) Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' References: <87ikqlbhug.fsf@daniel-mendler.de> <87wmer3s89.fsf@pengjiz.com> <87ikqavrwm.fsf@daniel-mendler.de> <87a5bms3n8.fsf@pengjiz.com> <87y0yz7341.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75495 Cc: 75495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: Eli Zaretskii > Date: Sat, 25 Jan 2025 08:40:46 +0100 > > Pengji Zhang writes: > > > Daniel Mendler writes: > > > >> Yes, we should. I have attached the improved patch to this mail. > > > > It works great. Thanks! > > Hello Eli, > > does this patch (and my other Ibuffer patch) look okay to you, such that > they can be installed? Thanks. Didn't yet have time to review it, will do soon. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 25 04:43:11 2025 Received: (at 75495-done) by debbugs.gnu.org; 25 Jan 2025 09:43:11 +0000 Received: from localhost ([127.0.0.1]:48532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbch4-0001pk-Mv for submit@debbugs.gnu.org; Sat, 25 Jan 2025 04:43:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44548) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tbch1-0001pS-RV for 75495-done@debbugs.gnu.org; Sat, 25 Jan 2025 04:43:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbcgv-0001DS-Em; Sat, 25 Jan 2025 04:43:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ig/DYCdQwabr0Xo8vtnrhtSkoi68JSKZ9Q6uf9ElKIU=; b=Z9g4WEUfamCc BNvW/7APr9oi+ETWBDzXTaCzB5yTjBUeiygLhHzY1/itkrRHDauk8BS3NPNEaQ9pcdTZsuDEj7/i2 2nYkiwdqUk5fZ9r743WhRJuyMNrYjEupMfO3INoxe9dxc/tIPWiOAGfOyv4IKPsbpKgsVnOXgUlqu D4eBU01OUWPEPb6My9K5Gb5mRjFP2c5QtWAnwNRCRwoMZHODmNmjgQXfKvOE3vToEVPxgJmrCh6dJ jIZ04NyunY6uRQeRonQCqd3Y5SCXq1AfJittPyTAyzRhnFLCllkb54FuUccbYi1jMel1ltTUUkVYv q6WsPERnnRh69Py+1vJegw==; Date: Sat, 25 Jan 2025 11:42:59 +0200 Message-Id: <861pwrw7oc.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87ikqavrwm.fsf@daniel-mendler.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' References: <87ikqlbhug.fsf@daniel-mendler.de> <87wmer3s89.fsf@pengjiz.com> <87ikqavrwm.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75495-done Cc: me@pengjiz.com, 75495-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 75495@debbugs.gnu.org > Date: Sun, 19 Jan 2025 14:45:29 +0100 > From: Daniel Mendler via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Pengji Zhang writes: > > > Daniel Mendler writes: > > > >>+ (or (get-text-property (1- (length s)) 'ibuffer-size s) > >>+ (get-text-property 0 'ibuffer-size s) 0)))) > > > > Should we consider centered column as well? I know it sounds unusual, > > but for completeness I would like to support that as well. > > > > Maybe we could skip the leading spaces: > > > > (get-text-property 0 'ibuffer-size (string-trim-left s " +")) > > > > What do you think? > > Yes, we should. I have attached the improved patch to this mail. Thanks, installed on master, and closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 06:16:28 2025 Received: (at 75495) by debbugs.gnu.org; 26 Jan 2025 11:16:28 +0000 Received: from localhost ([127.0.0.1]:54903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tc0ct-0001My-Sj for submit@debbugs.gnu.org; Sun, 26 Jan 2025 06:16:28 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:52471) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tc0cq-0001Md-Bh for 75495@debbugs.gnu.org; Sun, 26 Jan 2025 06:16:25 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4363ae65100so38071225e9.0 for <75495@debbugs.gnu.org>; Sun, 26 Jan 2025 03:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737890177; x=1738494977; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KbEFeq7BXnFN273/Mp0ZFbFCxindIwGGQ3uOawl6b00=; b=S4KnJIz3+DFfiMlGPT0yCYnA7M2s22didriyvRro6/61fdO8MX3fHMw/AIHJjARY+U q4fKeHvleTz5RHiAnFEjlAAn+QLeGmOKiMhMxmhQIkF5f6aYbUrPta1zbfHO8asxFqXV B1E8NDGCnbwfzj0/ZdEPwq7U7eA9mMba9Q1TbCPoBXvWMq/DqSU/W002oqFIDO3GHWN4 MZlnKl+MD07OPqZA7q+UVGabxgElmFDgpnIXuiWA+9nCVF3n9cQ3jydW9vSPS96ZfXio yByPYr55Txu1XIDbJ9bRchfbbWbwBC5G1kULwqE4enZTLZU09TTt9XwDfBFFRIMYMk8t rCFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737890177; x=1738494977; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KbEFeq7BXnFN273/Mp0ZFbFCxindIwGGQ3uOawl6b00=; b=RX+H5UFxYM98//YXJSkpvSAymTMZBLRApt+LyRv9DnjWvsLYqwYC5yTulM+eHhGhmk HcPIVs1cDuQ6sPg42vYAks4TidPVdsZ3uYofziY8NtpMNgTO2Yu/zl+ZaeovQgDyAA3H czmYoteTSxYyIbnBAjkI0Khginx/Geb6zpz+jzjSFBXT+LbaC5i558BHyrjoAhYLU7Wo eTuEtfDOfoJgy8/Mqn0ZScWA5PcwPtpxtvYuxQzcSRmCLDJHuSNcJLE+ERl0Wcee8Ge6 97w6xvlH+6tv2j/l0rLQyN/vETjdabnpX0FeRLzEXUXg+rot1FZLjqPV6DVx3s9qhztL rGjQ== X-Forwarded-Encrypted: i=1; AJvYcCU3A2D1b7I1zdeXGC87SIAQI4bpRgV23Tjn5I1bCVY1oA2yr5YjAWidbElOOmnRGggrEISACg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YypMwQDUNjE57KGSlaRDSVE07UzSGLZ0IP3SD7zQXU/s9ShjBoD drBXyf35JsPNpJu7z1MlSp3M74IILPVHPnEnyt7SusQorWjissVSH1xFjA== X-Gm-Gg: ASbGncsA2R/3WWHLiDP5V6Q9l/Sd5xA/Iuxih6xARPjK0tC0Uy0FPuJE2DnBB6OlS1l S8dNB1MuwSjDK61wgqqWTAF8Oh0zeCfNC/o4zvKPkgq6JcOpMKj+WVeCH4Eqd+U/dWtHxwWv+ux zRlaN5jWbzxsfEAhlfp8GyC3eRCj88XhS8GNLWR62+1ug7oKnllRefTYlmeQHlSF4PbDfAuqyxE SNB3WaRGNTGpAsXJRVd1VDBVBczzEABTZwYY8cf9HMqxDkc0aWagWCfRVScKEO8fqXr X-Google-Smtp-Source: AGHT+IFVdDwG1qyJHjzR9gYD04WwEmJr5gjmjtSIfJlnzrf85f/0EQ3yYHmF7xuRvsZ3X1SJ8FHueA== X-Received: by 2002:a05:600c:3542:b0:434:fec5:4ed1 with SMTP id 5b1f17b1804b1-43891453027mr294165965e9.26.1737890177073; Sun, 26 Jan 2025 03:16:17 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:9094:4960:42e7:829a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd48ae56sm90920465e9.21.2025.01.26.03.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2025 03:16:16 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#75495: [PATCH] ibuffer: New defcustom `ibuffer-human-readable-size' In-Reply-To: <86msffwbck.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jan 2025 10:23:39 +0200") References: <87ikqlbhug.fsf@daniel-mendler.de> <87wmer3s89.fsf@pengjiz.com> <87ikqavrwm.fsf@daniel-mendler.de> <87a5bms3n8.fsf@pengjiz.com> <87y0yz7341.fsf@daniel-mendler.de> <86msffwbck.fsf@gnu.org> Date: Sun, 26 Jan 2025 12:16:16 +0100 Message-ID: <87ldux4ygv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75495 Cc: Daniel Mendler , 75495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 25 Jan 2025 10:23:39 +0200, Eli Zaretskii said: >> From: Daniel Mendler >> Cc: Eli Zaretskii >> Date: Sat, 25 Jan 2025 08:40:46 +0100 >>=20 >> Pengji Zhang writes: >>=20 >> > Daniel Mendler writes: >> > >> >> Yes, we should. I have attached the improved patch to this mail. >> > >> > It works great. Thanks! >>=20 >> Hello Eli, >>=20 >> does this patch (and my other Ibuffer patch) look okay to you, such = that >> they can be installed? Thanks. Eli> Didn't yet have time to review it, will do soon. It would be good if the patch consistently used either "size" or "sizes" in the code and docstring, rather than a mix. I=CA=BCd lean slightly (but only slightly) to "sizes". Robert --=20 From unknown Sun Jun 22 22:42:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Feb 2025 12:24:20 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator