GNU bug report logs - #75456
31.0.50; Cannot find the definition of the predicate in `treesit-thing-settings'" sexp-list)

Previous Next

Full log

View this message in rfc822 format

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 75456 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#75456: 31.0.50; Cannot find the definition of the predicate in `treesit-thing-settings'" sexp-list)
Date: Mon, 03 Feb 2025 22:32:07 +0100

[Message part 1 (text/plain, inline)]

Ciao Yuan, thank you!
The attached patch solves the problem. I will fix php-ts-mode and
mhtml-ts-mode in the next few days.

Vincenzo

In data martedì 28 gennaio 2025 02:58:00 Ora standard dell’Europa centrale, 
Yuan Fu ha scritto:
> > On Jan 27, 2025, at 5:37 PM, Yuan Fu <casouri <at> gmail.com> wrote:
> >> On Jan 19, 2025, at 10:59 PM, Yuan Fu <casouri <at> gmail.com> wrote:
> >>> On Jan 18, 2025, at 8:52 AM, Vincenzo Pupillo <v.pupillo <at> gmail.com>
> >>> wrote:
> >>> 
> >>> Ciao Yuan,
> >>> 
> >>> In data sabato 18 gennaio 2025 07:27:32 Ora standard dell’Europa
> >>> centrale,
> >>> 
> >>> Yuan Fu ha scritto:
> >>>> ....
> >>>> 
> >>>> I just pushed a fix, now you shouldn’t see jsdoc parsers anymore. Can
> >>>> you
> >>>> see if this fixes the problem you had?
> >>> 
> >>> I only tested js.el with
> >>> 0001-language-at-point-function-that-handles-local- parser.patch
> >>> I tested only js.el with the
> >>> 0001-language-at-point-function-that-handles-
> >>> local-parser.patch because it was less complex. The font-locking is ok
> >>> but the indentation of jsdoc type comments breaks because there are no
> >>> specific rules (for jsdoc) and also this message appears:
> >>> 
> >>> Error running timer 'show-paren-function': (treesit-no-parser jsdoc)
> >>> 
> >>> The comment:
> >>> ;; 2. In most cases, a function shouldn't implicitly create a parser.
> >>> ;; All parsers should be created explicitly by user.
> >>> 
> >>> Does this imply that we need to create local parsers as well?
> >> 
> >> No, that means treesit.el has a bug. I’ll fix it.
> >> 
> >> Yuan
> > 
> > Ok, so it’s two-fold. I fixed the problem that caused the
> > treesit-no-parser error on emacs-30 a few days ago, it should be on
> > master now.
> > 
> > As for jsdoc not having indentation rules, I think the right solution is
> > to add comment indentation rules for jsdoc too. You can just copy the
> > rules from js-ts-mode, js-ts-mode uses the canned rules from
> > c-ts-common.el anyway.
> Sorry, I lied, turns out I haven’t pushed the patch to emacs-30 yet. I did
> that just now. It should be on master in a few days.
> 
> Yuan

[0001-Correctly-handled-the-local-parser-for-jsdoc.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.