GNU bug report logs - #75433
[PATCH] Adding libvarlink and support for kanshictl

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75433 in the body.
You can then email your comments to 75433 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Till Robin Zickel <trzickel <at> illegalaliensfrom.space>
To: guix-patches <at> gnu.org
Subject: [PATCH] Adding libvarlink and support for kanshictl
Date: Wed, 8 Jan 2025 13:15:59 +0100

[Message part 1 (text/plain, inline)]

Kanshi (https://git.sr.ht/~emersion/kanshi) has added support for 
controlling the daemon remotely. To enable this, kanshi has to be build 
with libvarlink present. This patch adds libvarlink to the 
serialization.scm and extends the kanshi package inputs.

I tested the build on amd64 and on aarch64 with qemu as per the guide. 
Unfortunately my laptop ran out of disk space while compiling the 
toolchain for armhf so I did not test that.

[0001-gnu-added-libvarlink-and-added-it-as-dependency-to-k.patch (text/x-patch, attachment)]

[OpenPGP_0x47934FBE9284E6D0.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Message #10 received at 75433-done <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Till Robin Zickel <trzickel <at> illegalaliensfrom.space>
Cc: 75433-done <at> debbugs.gnu.org
Subject: Re: [bug#75433] [PATCH] Adding libvarlink and support for kanshictl
Date: Sun, 12 Jan 2025 12:40:04 +0800

[Message part 1 (text/plain, inline)]

Till Robin Zickel <trzickel <at> illegalaliensfrom.space> writes:

> Kanshi (https://git.sr.ht/~emersion/kanshi) has added support for
> controlling the daemon remotely. To enable this, kanshi has to be
> build with libvarlink present. This patch adds libvarlink to the
> serialization.scm and extends the kanshi package inputs.
>
> I tested the build on amd64 and on aarch64 with qemu as per the
> guide. Unfortunately my laptop ran out of disk space while compiling
> the toolchain for armhf so I did not test that.
>
> [2. text/x-patch; 0001-gnu-added-libvarlink-and-added-it-as-dependency-to-k.patch]...

please use 'git send-email' next.

>
> [3. OpenPGP public key --- application/pgp-keys; OpenPGP_0x47934FBE9284E6D0.asc]...

> +
> +(define-public libvarlink
> +  (package
> +    (name "libvarlink")
> +    (version "24")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/varlink/libvarlink")
> +             (commit "24")))

use (commit version).

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "098jw9h48p2py6lwxyjrlzvv9zqvqgfsxc4pddfsviab65n9n5gw"))))
> +    (build-system meson-build-system)
> +    (inputs (list))

If there is no input, you don't have to write it.

> +    (native-inputs (list python glibc-utf8-locales)) ;needed for unit tests

use python-minimal. Reduce dependency size.

> +    (arguments
> +     (list
> +      #:phases #~(modify-phases %standard-phases
> +                   (add-after 'unpack 'patch-/bin/sh
> +                     (lambda _
> +                       (substitute* "lib/meson.build"
> +                         (("/bin/sh")
> +                          (which "sh")))))
> +                   (add-after 'unpack 'patch-/usr/bin/env
> +                     (lambda _
> +                       (substitute* "varlink-wrapper.py"
> +                         (("/usr/bin/env")
> +                          (which "env"))))))))
> +    (home-page "https://varlink.org/")
> +    (synopsis "Varlink C IPC library and command line tool")
> +    (description
> +     "This package provides the C implementation of the varlink
> +interface description protocol and its associated command line tool")
> +    (license license:asl2.0)))
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 1da2e752ff..77ff61c5d8 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -2561,7 +2561,7 @@ (define-public kanshi
>         (sha256
>          (base32 "0g5glpkcn54ypfym4lpfdjai479yfazcai1rg86bn72nkcbpwfql"))))
>      (build-system meson-build-system)
> -    (inputs (list libscfg wayland))
> +    (inputs (list libscfg libvarlink wayland))
>      (native-inputs (append (if (%current-target-system)
>                                 (list pkg-config-for-build)
>                                 (list))
> -- 
I split it into separate commit.


And pushed. closing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.