From unknown Fri Sep 05 15:34:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7543 <7543@debbugs.gnu.org> To: bug#7543 <7543@debbugs.gnu.org> Subject: Status: Optional parameter `localpart' in url-cookie-retrieve is used as a string Reply-To: bug#7543 <7543@debbugs.gnu.org> Date: Fri, 05 Sep 2025 22:34:42 +0000 retitle 7543 Optional parameter `localpart' in url-cookie-retrieve is used = as a string reassign 7543 emacs submitter 7543 Lennart Borgman severity 7543 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 13:16:41 2010 Received: (at submit) by debbugs.gnu.org; 3 Dec 2010 18:16:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POaBV-0006vz-CG for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:16:41 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POaBT-0006vn-Hs for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:16:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POaGz-0007zV-Uc for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:22:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:60358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POaGz-0007zI-8a for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:22:21 -0500 Received: from [140.186.70.92] (port=42085 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POaGt-0001r8-Ug for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2010 13:22:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POaGs-0007xl-TI for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2010 13:22:15 -0500 Received: from mail-ey0-f169.google.com ([209.85.215.169]:53402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POaGs-0007xS-Oc for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2010 13:22:14 -0500 Received: by eydd26 with SMTP id d26so18989411eyd.0 for ; Fri, 03 Dec 2010 10:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=Upe9Xnmnyg+3jUpFfeH0bTrcc3QRJdOw4BZtvPJRTyU=; b=uhu+7VsAfhhxfo6osQJUDM5RMCGfbrlbDjqNwcbVMUK58KaYlmfN6QesgPQPRf1lv7 8GCcNj90bCXTFJn46KIwpk0iauPPh4Q11sWXvaXUxK8zpFFMHMVA8Lz17VEhbn/R4C6+ 6VA331fVgLIGg4GcXAiZBYv9DmPcsHQUvbOV4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=roG+uGPUNTRFZmcMWBCB6GC5zcBRcArcAdifN1iA2HjALIgRdOao11ITZb3aV9BQlZ HhATJKDsu8efwSYBwuuaFy5b7Gn0sfeKVocc63DYuknZrjQ5QEJOy1B0lRzBwC7uHq8Y Z+bpLfvV1xy6HpvYQCcy1z+yffmWI+pgi426k= Received: by 10.213.26.68 with SMTP id d4mr3005061ebc.71.1291400532856; Fri, 03 Dec 2010 10:22:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.29.8 with HTTP; Fri, 3 Dec 2010 10:21:52 -0800 (PST) From: Lennart Borgman Date: Fri, 3 Dec 2010 19:21:52 +0100 Message-ID: Subject: Optional parameter `localpart' in url-cookie-retrieve is used as a string To: Emacs Bugs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) The function looks like (defun url-cookie-retrieve (host &optional localpart secure) However localpart is used without checking it in (if (and (if (stringp localpart-match) (string-match (concat "^" (regexp-quote localpart-match)) localpart) Should not both localpart-match and localpart be checked with (stringp ...)? This is with a checkout from 2010-10-19 (my patched version, I don't think I have any changes there). From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 17:36:03 2010 Received: (at 7543) by debbugs.gnu.org; 4 Dec 2010 22:36:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0i2-0008AB-QR for submit@debbugs.gnu.org; Sat, 04 Dec 2010 17:36:02 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0i0-00089i-Qq for 7543@debbugs.gnu.org; Sat, 04 Dec 2010 17:36:01 -0500 Received: from furball (dhcp128036014248.central.yale.edu [128.36.14.248]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB4MfmWY017470 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 4 Dec 2010 17:41:48 -0500 Received: by furball (Postfix, from userid 1000) id 2D95A16059F; Sat, 4 Dec 2010 17:41:48 -0500 (EST) From: Chong Yidong To: Lennart Borgman Subject: Re: bug#7543: Optional parameter `localpart' in url-cookie-retrieve is used as a string References: Date: Sat, 04 Dec 2010 17:41:48 -0500 In-Reply-To: (Lennart Borgman's message of "Fri, 3 Dec 2010 19:21:52 +0100") Message-ID: <874oatxis3.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7543 Cc: 7543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Lennart Borgman writes: > The function looks like > > (defun url-cookie-retrieve (host &optional localpart secure) > > However localpart is used without checking it in > > (if (and (if (stringp localpart-match) > (string-match (concat "^" (regexp-quote > localpart-match)) > localpart) > > Should not both localpart-match and localpart be checked with (stringp ...)? Fixed, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 17:36:17 2010 Received: (at control) by debbugs.gnu.org; 4 Dec 2010 22:36:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0iG-0008Ae-Vc for submit@debbugs.gnu.org; Sat, 04 Dec 2010 17:36:17 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0iF-0008AQ-3B for control@debbugs.gnu.org; Sat, 04 Dec 2010 17:36:15 -0500 Received: from furball (dhcp128036014248.central.yale.edu [128.36.14.248]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB4Mg2Au026258 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 4 Dec 2010 17:42:03 -0500 Received: by furball (Postfix, from userid 1000) id 923E116059F; Sat, 4 Dec 2010 17:42:02 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 7543 Date: Sat, 04 Dec 2010 17:42:02 -0500 Message-ID: <87pqthb1ol.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 7543 thanks From unknown Fri Sep 05 15:34:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator