GNU bug report logs - #7543
Optional parameter `localpart' in url-cookie-retrieve is used as a string

Previous Next

Package: emacs;

Reported by: Lennart Borgman <lennart.borgman <at> gmail.com>

Date: Fri, 3 Dec 2010 18:17:02 UTC

Severity: normal

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7543 in the body.
You can then email your comments to 7543 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7543; Package emacs. (Fri, 03 Dec 2010 18:17:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Lennart Borgman <lennart.borgman <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 03 Dec 2010 18:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Optional parameter `localpart' in url-cookie-retrieve is used as a
	string
Date: Fri, 3 Dec 2010 19:21:52 +0100

The function looks like

  (defun url-cookie-retrieve (host &optional localpart secure)

However localpart is used without checking it in

	    (if (and (if (stringp localpart-match)
			 (string-match (concat "^" (regexp-quote
						    localpart-match))
				       localpart)

Should not both localpart-match and localpart be checked with (stringp ...)?

This is with a checkout from 2010-10-19 (my patched version, I don't
think I have any changes there).
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7543; Package emacs. (Sat, 04 Dec 2010 22:37:01 GMT) Full text and rfc822 format available.

Message #8 received at 7543 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 7543 <at> debbugs.gnu.org
Subject: Re: bug#7543: Optional parameter `localpart' in url-cookie-retrieve
	is used as a string
Date: Sat, 04 Dec 2010 17:41:48 -0500

Lennart Borgman <lennart.borgman <at> gmail.com> writes:

> The function looks like
>
>   (defun url-cookie-retrieve (host &optional localpart secure)
>
> However localpart is used without checking it in
>
> 	    (if (and (if (stringp localpart-match)
> 			 (string-match (concat "^" (regexp-quote
> 						    localpart-match))
> 				       localpart)
>
> Should not both localpart-match and localpart be checked with (stringp ...)?

Fixed, thanks.
bug closed, send any further explanations to Lennart Borgman <lennart.borgman <at> gmail.com> Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> debbugs.gnu.org. (Sat, 04 Dec 2010 22:37:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 02 Jan 2011 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 250 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.