GNU bug report logs - #75414
[PATCH 0/2] Add roll-back action to guix deploy

Previous Next

Full log

Message #44 received at 75414 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Evgeny Pisemsky <mail <at> pisemsky.site>, 75414 <at> debbugs.gnu.org,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#75414] [PATCH v2 1/1] deploy: Add --roll-back option.
Date: Fri, 28 Feb 2025 01:23:32 +0000

Hi Maxim,

Thanks for the review!

> The change LGTM, but I was just thinking that --roll-back, which doesn't
> actually 'deploy' anything (it rathers does something more akind to
> 'guix deploy -x -- sudo guix system roll-back', right ?), was a bit odd
> to have under 'guix deploy'.  Probably not important enough to block
> this contribution.  I'd say, go ahead!

That's true. It's not the best user experience. The idea was that we'd
revisit that decision later. See earlier discussion on this issue.

Regards,
Arun

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.