GNU bug report logs - #75414
[PATCH 0/2] Add roll-back action to guix deploy

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>, Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>, Ludovic Courtès <ludo <at> gnu.org>, Evgeny Pisemsky <mail <at> pisemsky.site>, 75414 <at> debbugs.gnu.org, Christopher Baines <guix <at> cbaines.net>
Subject: [bug#75414] [PATCH v2 1/1] deploy: Add --roll-back option.
Date: Fri, 28 Feb 2025 09:41:57 +0900

Hi Arun,

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * guix/scripts/deploy.scm (guix-deploy): Add the --roll-back option.
> (show-what-to-deploy): Add #:roll-back? argument.
> (roll-back-machine*): New function.
> (show-help): Document the --roll-back option.
> * doc/guix.texi (Invoking guix deploy): Document the --roll-back option.
>
> Change-Id: Ic5084f287aefb2d1d28380ca4ba1c6971cb913e7

The change LGTM, but I was just thinking that --roll-back, which doesn't
actually 'deploy' anything (it rathers does something more akind to
'guix deploy -x -- sudo guix system roll-back', right ?), was a bit odd
to have under 'guix deploy'.  Probably not important enough to block
this contribution.  I'd say, go ahead!

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

--
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.