From unknown Sat Aug 16 23:47:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation Resent-From: Gabriel Santos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2025 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 75410@debbugs.gnu.org Cc: Stefan Kangas X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173619408431553 (code B ref -1); Mon, 06 Jan 2025 20:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 20:08:04 +0000 Received: from localhost ([127.0.0.1]:40222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUtON-0008Cr-PS for submit@debbugs.gnu.org; Mon, 06 Jan 2025 15:08:04 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUtOM-0008C9-6l for submit@debbugs.gnu.org; Mon, 06 Jan 2025 15:08:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUtOD-0000Na-Bn for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:07:53 -0500 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUtOA-00048g-5A for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:07:52 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 92E722594B; Mon, 6 Jan 2025 21:07:35 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3qeRuywPNRtq; Mon, 6 Jan 2025 21:07:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1736194050; bh=yZwXsqjZTDhmDHRD9msZ+CtDnhipEbtTj0M00JKMeoA=; h=From:To:Cc:Subject:Date; b=lmuvco3Eb0X0vzMB9DvVtFdDQJveDomChV8siRQItZo0W5uFMBSOw1EogqR2Ovg5u lkiWgRPI6Uv7iZRj3jk9X1sYIdB9STHdtDPrEk9R98+/45v3A1nUwMv+SY1wLv5U58 wW2ZQ1R4aU8VObgP1KJTMP27n6uIGnZpXfkor2nS5kYwz05Zb3q/XAQdkhtGKfpL8U rWmvYAy1I58WqsdhDH/MaJD4UROpXZUIbS3SfqnWB0GtZtzR8j7eh4zGaHlIPJ474e ueQZFkpA/Vrn94VoP59EBi0bwjPcscBTEnQvdUrzTiJ9jlGiA1Q+LBQOJJyIdIN2MN nEDUi7vLUk+XQ== From: Gabriel Santos Date: Mon, 06 Jan 2025 17:07:24 -0300 Message-ID: <87o70j4sg3.fsf@disroot.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.21.23.139; envelope-from=gabrielsantosdesouza@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Greetings, I discovered this mode through a blog post from Sacha: And I really liked it. Though, I felt that it was missing something: Some keybinds for navigation besides C-n and C-p, like those found in other read-only modes, such as dired-mode. This patch binds the following keys in `image-dired-thumbnail-mode-map': - "f" :: `image-dired-forward-image' - "b" :: `image-dired-backward-image' - "n" :: `image-dired-next-line' - "p" :: `image-dired-previous-line' - "a" :: `image-dired-move-beginning-of-line' - "e" :: `image-dired-move-end-of-line' These keys are currently unused in the mode. Regards, -- Gabriel Santos --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-image-dired--Add-extra-keybinds-for-navigation.patch Content-Description: [PATCH] image-dired: Add extra keybinds for navigation >From 8f7a1234ce7642f587e435347bf7ba22b397ce18 Mon Sep 17 00:00:00 2001 From: Gabriel Santos Date: Mon, 6 Jan 2025 16:56:31 -0300 Subject: [PATCH] image-dired: Add extra keybinds for navigation * lisp/image/image-dired.el (image-dired-thumbnail-mode-map): Bind previously unused keys for alternative navigation. --- lisp/image/image-dired.el | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 71c272e4388..b35199c60d4 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -944,6 +944,15 @@ You probably want to use this together with (defvar-keymap image-dired-thumbnail-mode-map :doc "Keymap for `image-dired-thumbnail-mode'." + + ;; Regular navigation + "f" #'image-dired-forward-image + "b" #'image-dired-backward-image + "n" #'image-dired-next-line + "p" #'image-dired-previous-line + "a" #'image-dired-move-beginning-of-line + "e" #'image-dired-move-end-of-line + "d" #'image-dired-flag-thumb-original-file "" #'image-dired-flag-thumb-original-file "m" #'image-dired-mark-thumb-original-file -- 2.47.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 21:27:56 2025 Received: (at control) by debbugs.gnu.org; 21 Jan 2025 02:27:56 +0000 Received: from localhost ([127.0.0.1]:52659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta3zg-0004W5-E9 for submit@debbugs.gnu.org; Mon, 20 Jan 2025 21:27:56 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:48639) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ta3ze-0004Vo-Fp for control@debbugs.gnu.org; Mon, 20 Jan 2025 21:27:54 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5d9f0a6adb4so10409036a12.1 for ; Mon, 20 Jan 2025 18:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737426468; x=1738031268; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=9dxakQjLNH2ZCcEsIr5Vfwnw6rW3yf/QXbMDe9nmUb0=; b=XMrvPeiQ9cww4MulycOehV75o+KEccbn5w3/AJLCaCZ4yzvIgPl7f4jdC4JJ7WF0XK 5+v11UshGc2Qc9zOhmntCdUZfObb6HNExuGvN5AgThQDhNb9/kN06pUMJxXFvcUOixSF vL+wzAz/21cyEQ8UVvudXOXZ/kfWNW9xC9/184yrzCm3zUCzAELmkErahTzRmdQNXeBz fknseqAA2z4zJw3igu/kwE+UWoEagaNi34jQYoHpoe/aXg6GLuGyhVdrV4NDCI5wcknN saWkGzNE1HPFZervO30SY9YSgA6sDigIkqtlVnECoh7c0xFt4fNTeBnfqwHJvOcEaXZ3 QltQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737426468; x=1738031268; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9dxakQjLNH2ZCcEsIr5Vfwnw6rW3yf/QXbMDe9nmUb0=; b=YZF7c1roD1gFNbe6QW8ghYC30lZXJk8EKjeSdjQO76m49DwfM9Tz8kT5UAbn84VS+2 /udkme50M9+9KDL5X6knj+n3LWxhaFQdPXGpuPYbB8XouQrGdnu6GrajKiz9usPBdZDR RRA+AvynFCu8LFP4mADf/CUlQ/WBHGwyyOx7qpJhTdtY/COVgVXNyH90SUErsmJl+Jtt sHZ2MO1VbrYIODMCtB/o02CsvwJsGcZutbmY/W6pcNEajDGn+Br0AKW7zqlN3NSGB3vl hDDAp6oRViHYIPIGZXfti5ANY6K2dSQfI6K8zJanhz16R81z3ymgeaMCL8ruIurA9VzU oB4w== X-Gm-Message-State: AOJu0Yw0g9HtHVWtNan3V1nitN6IgWkDdJsA1/mduqRXvOHbNCHpAqFR KGAL+fdcqrosZCsLF6Ii06WRfHixI+O0IvCRoQh9SjCB6V3+Pk2KWcRjWnsfA55i4AcZgrlEBHj ykAGFMSMBTJ9qMJ4yWRH7TfJzFtdnBG7e X-Gm-Gg: ASbGncux6hq1EEZffNU1HxUX4cACjSvqmFBSzrp7YCZ2FCyCSKIE5UCU6d3XVF8MZsH L3Ga/d1s+Pvcx9h6OQ9BFcETWgLO/Uerov2KHnFJm/70YgxBWRvUcMQ== X-Google-Smtp-Source: AGHT+IEhxlPzPzqgrgACPv/dmrmQqTAHNhtUlQXg895YtUgSBqstNsgrUas6/ZU3vp8kC0QcwzM5fU8xkHghKdbuOdA= X-Received: by 2002:a05:6402:2681:b0:5d0:bcdd:ff9c with SMTP id 4fb4d7f45d1cf-5db7d2dc2admr14034848a12.2.1737426468226; Mon, 20 Jan 2025 18:27:48 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Jan 2025 20:27:47 -0600 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 20 Jan 2025 20:27:47 -0600 X-Gm-Features: AbW1kvYBZ92vCpLCbNAcv8vNtJPJx5LDnIyZG1vzcFMHTYmA8T4dJ3X8X8mW5bY Message-ID: Subject: control message for bug #75410 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 75410 wishlist quit From unknown Sat Aug 16 23:47:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jan 2025 00:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gabriel Santos Cc: 75410@debbugs.gnu.org Received: via spool by 75410-submit@debbugs.gnu.org id=B75410.173776352514382 (code B ref 75410); Sat, 25 Jan 2025 00:06:01 +0000 Received: (at 75410) by debbugs.gnu.org; 25 Jan 2025 00:05:25 +0000 Received: from localhost ([127.0.0.1]:47689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbTfw-0003ju-IG for submit@debbugs.gnu.org; Fri, 24 Jan 2025 19:05:24 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:61441) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tbTfu-0003jb-02 for 75410@debbugs.gnu.org; Fri, 24 Jan 2025 19:05:22 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5d3f28a4fccso3907148a12.2 for <75410@debbugs.gnu.org>; Fri, 24 Jan 2025 16:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737763516; x=1738368316; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=MbJteffx08xLtUX78BL1khXJdJEep6W5j9ZnHDtnHa4=; b=kCoETuQIFyKiA+nzR/g3k+U4xhdPuf9Jj/+Z9Tv+n1beouZvkxQkCjQfuqTFZt9Uej HI5sehblIPVrTCNJk9KgZKUMns8Snaa082GOf8AsAB+RhZpWIHfQNI+4/ynmF+l1D1vf hGKA1VxRgebtmRvvpDAc65KDSg/up1Muy65sJXefWEQ6YLvjvxT0gqsy9LnNAeUuQ62Y OmtGR6tHmOqzn7Dz9LRJSLl9rJq/Jd9OtElwpVhYLDC9//LEMiuOnOAtq6CKwGu8rvrw 2cr45Hl3hNT7zmw0hmKQT2PC3LEANwghpus9TDvCqmZdP0ZoNDKF3xPJwy8GDgYuYfrE DRAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737763516; x=1738368316; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MbJteffx08xLtUX78BL1khXJdJEep6W5j9ZnHDtnHa4=; b=PxYyjlI3gIRkxFxEaOOjyQevzWiWXheIXxQ07De+HMtPorVcX74Sa1svSSsX2Tq8TK UU/lfm1DEHpndB+x3fJGF531Q/w0xlEWBmy+H5s9Zfk+OuaojwFfC4vq8Z69nhQUjO8I xsI9bHRFDtAJoNIyBmGLLEbWvRv9YAJLdFQegdPH0QVyxTaRcAOpGHQQTPMNq/4BVhyu mcWoz+SGnFnodHa4Fv/FoDIC/dWrvjAeV252OdBQ2VGj8WhmGmvtiWezux+aFNVDrpFo wrNTnlSKOWHaZaIZ3+i0nGhVdCbO2liAnSklIX7gVRBxoRGkgeaGxbKNkYMDiNb0wKM2 Lk8Q== X-Gm-Message-State: AOJu0Yw79NnJ/ekLFhYkCSp5f70Q3p2KPoD4Z4c3U1Ih7PCzkTcDdQzb cahKq2UADlzeC6O3GsGMQDfQLnAmMhPklzy+F+d2U6/KgjJTk5NYWq8zi0TUSxR8Doij1rXsSdc GdiQOFHIeSmctQwUmZv8swX/S2fU= X-Gm-Gg: ASbGncvVmjax7a4SXPRGFoPNrexbJwpD8YF+fVpuO+BxHscerDRvWLIYLENLb2M7Bod NBVxmmDtX1yJPQFJJcf8O/rwPt4U3ciApOF0K1ZaPFH9vZPqlw8vXJ+zGMclLffk= X-Google-Smtp-Source: AGHT+IHA9hxkCW56J+yLIrxcODVNt2zf8RUZvjkWVUVBOsmA1vhYu7mf9kvtq4O/YbssJaRXZtXRzYbELUHXkAC+occ= X-Received: by 2002:a05:6402:26d5:b0:5dc:2077:8017 with SMTP id 4fb4d7f45d1cf-5dc20778312mr1638776a12.8.1737763515575; Fri, 24 Jan 2025 16:05:15 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jan 2025 18:05:15 -0600 From: Stefan Kangas In-Reply-To: <87o70j4sg3.fsf@disroot.org> (Gabriel Santos's message of "Mon, 06 Jan 2025 17:07:24 -0300") References: <87o70j4sg3.fsf@disroot.org> MIME-Version: 1.0 Date: Fri, 24 Jan 2025 18:05:15 -0600 X-Gm-Features: AWEUYZn7cvCkJQP8GiMRZ-XucvObk71ktnibmrtytF1iSCrpkhXbtHx4bHIz_bE Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gabriel Santos writes: > Greetings, > > I discovered this mode through a blog post from Sacha: > > > > And I really liked it. That's good to hear! > Though, I felt that it was missing something: > > Some keybinds for navigation besides C-n and C-p, like those found in > other read-only modes, such as dired-mode. > > This patch binds the following keys in `image-dired-thumbnail-mode-map': > > - "f" :: `image-dired-forward-image' > - "b" :: `image-dired-backward-image' > - "n" :: `image-dired-next-line' > - "p" :: `image-dired-previous-line' > - "a" :: `image-dired-move-beginning-of-line' > - "e" :: `image-dired-move-end-of-line' > > These keys are currently unused in the mode. > > Regards, Thanks for the patch! I think this is a good idea, and the patch looks good to go, but such a change should be announced in NEWS, to let people know about it. Could you please resubmit with such an addition? From unknown Sat Aug 16 23:47:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation References: <87o70j4sg3.fsf@disroot.org> In-Reply-To: <87o70j4sg3.fsf@disroot.org> Resent-From: Gabriel Santos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jan 2025 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 75410@debbugs.gnu.org Received: via spool by 75410-submit@debbugs.gnu.org id=B75410.173780363425215 (code B ref 75410); Sat, 25 Jan 2025 11:14:02 +0000 Received: (at 75410) by debbugs.gnu.org; 25 Jan 2025 11:13:54 +0000 Received: from localhost ([127.0.0.1]:48751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbe6s-0006Yd-85 for submit@debbugs.gnu.org; Sat, 25 Jan 2025 06:13:54 -0500 Received: from layka.disroot.org ([178.21.23.139]:50126) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tbe6p-0006YP-GY for 75410@debbugs.gnu.org; Sat, 25 Jan 2025 06:13:52 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8A39225D78; Sat, 25 Jan 2025 12:13:49 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ropuhSUxlPfo; Sat, 25 Jan 2025 12:13:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1737803628; bh=CSjeAeSK6TQX6eyV4nsU6ZEFurLxhYl0BlH/s+FrgHg=; h=From:To:Cc:Subject:Date; b=TF2Zbio9OApTUqU5HsTsMhTn7cpyayHpe1fcnVGSNWmgLDtK6F+AQKsr6HEtoq2Be /f+tx/L24vNEGBmW3byqV2v4BUStviHUwVj31cSx2z2ctvGJJTF2QF6CA6GIzaztNN yR2aNVsTo9kKECWeO6aMpgoYu8/peuy6juwBzyIiCh0o7IfM0MrvomLKBbkD84GHnj A+qW7CSTI47U9J8HuGuvIGiJrNa63Nvg1NiCUc9Rya3kYqVllHDE9PHg0ThwwCiEuc /pkj96CN7IZZPVJQjgu4TVOVeFriIWbE+A9reUrBWFdGlzTQs+5DrVmM5FV4Y57B2z yoybTA5lTaPig== From: Gabriel Santos Date: Sat, 25 Jan 2025 08:13:44 -0300 Message-ID: <87a5bfgn87.fsf@disroot.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello, Attached is the updated patch. Here is the news entry I wrote: " Bound unused letters in 'image-dired-thumbnail-mode-map' For a more comfortable navigation experience (as in, no modifier keys), the keys "f", "b", "n", "p", "a" and "e" are now bound to the same functions as their C- counterparts. " Let me know what you think about it! -- Gabriel Santos --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-image-dired--Add-extra-keybinds-for-navigation.patch Content-Description: [PATCH] image-dired: Add extra keybinds for navigation >From bd08de1878fdefd0aec586907f8d673b8ab5c0f6 Mon Sep 17 00:00:00 2001 From: Gabriel Santos Date: Mon, 6 Jan 2025 16:56:31 -0300 Subject: [PATCH] image-dired: Add extra keybinds for navigation * lisp/image/image-dired.el (image-dired-thumbnail-mode-map): Bind previously unused keys for alternative navigation. --- etc/NEWS | 5 +++++ lisp/image/image-dired.el | 9 +++++++++ 2 files changed, 14 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index 385e943c997..f299bc5c9b9 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -370,6 +370,11 @@ When non-nil, buffer sizes are shown in human readable format. This allows passing a string with wildcards, or a cons cell where the first element is a list and the rest is a list of files. +*** Bound unused letters in 'image-dired-thumbnail-mode-map' +For a more comfortable navigation experience (as in, no modifier keys), +the keys "f", "b", "n", "p", "a" and "e" are now bound to the +same functions as their C- counterparts. + ** Browse URL *** New user option 'browse-url-transform-alist'. diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 452be29c5d5..3034f3ddb9c 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -950,6 +950,15 @@ You probably want to use this together with (defvar-keymap image-dired-thumbnail-mode-map :doc "Keymap for `image-dired-thumbnail-mode'." + + ;; Regular navigation + "f" #'image-dired-forward-image + "b" #'image-dired-backward-image + "n" #'image-dired-next-line + "p" #'image-dired-previous-line + "a" #'image-dired-move-beginning-of-line + "e" #'image-dired-move-end-of-line + "d" #'image-dired-flag-thumb-original-file "" #'image-dired-flag-thumb-original-file "m" #'image-dired-mark-thumb-original-file -- 2.47.1 --=-=-=-- From unknown Sat Aug 16 23:47:39 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Gabriel Santos Subject: bug#75410: closed (Re: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation) Message-ID: References: <87o70j4sg3.fsf@disroot.org> X-Gnu-PR-Message: they-closed 75410 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 75410@debbugs.gnu.org Date: Wed, 12 Feb 2025 05:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1739338502-3114-1" This is a multi-part message in MIME format... ------------=_1739338502-3114-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75410: [PATCH] image-dired: Add extra keybinds for navigation which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75410@debbugs.gnu.org. --=20 75410: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75410 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1739338502-3114-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75410-done) by debbugs.gnu.org; 12 Feb 2025 05:34:18 +0000 Received: from localhost ([127.0.0.1]:60398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ti5O5-0000mj-VU for submit@debbugs.gnu.org; Wed, 12 Feb 2025 00:34:18 -0500 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:47124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ti5O2-0000mP-2N for 75410-done@debbugs.gnu.org; Wed, 12 Feb 2025 00:34:14 -0500 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-aaeec07b705so1003921066b.2 for <75410-done@debbugs.gnu.org>; Tue, 11 Feb 2025 21:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739338448; x=1739943248; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=6Iun0Xv1yr9FCfZcxRtsSyCeGQPVdvo4SwRF8hYhwSU=; b=GE8SuUNbt0FtCkgq4K/yjRiy8ENPO0S2LuJj9TfU/1CyWWByyTRadBgbtEQIu4jImc DAWGpAc/kU7Bzk9EXOafphmBQ4mvbL7ejm4qCX8QTiqmxpgg+IE4Ajk5zXMf3Sdv2JfN quly561wMHdojyKUanJ4lB7kge77IqZ+6UzV+ZaW7TUjOc+wXJ44+Ms/G+ZCciHa+vAN HU9HXvN6gexlwBES5dd0fvUh3jlP6+HmY4w0QOdSA/eq7AcHCqOn0TPyAvKZUPUjw8X0 atbUnK7Rg3uCUmCX8ZKYSof+wd17uJK1qQoi5/v5vLgzY3lQ0lfEdKSIRrNzzgk/jVag Pd7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739338448; x=1739943248; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Iun0Xv1yr9FCfZcxRtsSyCeGQPVdvo4SwRF8hYhwSU=; b=tuqnCaD0GtFOlCPCkpxmzHB4lnaLf1o9T6Gbb4VT8KBXblJImlAicXXbVXjOQ2FcUX IeOAZo2sZBHdTtCVS5++Mw1bV2hqlNe6rizh3ad2JMcMouT7CqBIRj7cOtUhhsWhgz2L 6InLxnnD0Jg6tbYqaW7dMnwWjQ70SvwUPy63uCLoVESKNL2w0TXe+BggnkbwPNP8xcw3 uyE0B2pozwvGIaIwLRC7z4QPdq4OQ6TIxbXRoabJeM+bi3zlkEaU8L+jaer+EbWuruiH 5fX0fv5IGiAGxHRTinhz+QWujXaKQr0Ze7aOWpmMO/ieB7zoqriN8/dIhQeL/Y0kblnj 65aA== X-Gm-Message-State: AOJu0Yy/s3Bnn18Cbo7Ooxfy4p05Kux35S4Z2i5Ut/cTPMxe9jWEIfzr gTIZQX7SY8Z6sIVD7dlvxYSTdiUQ8LwPCOca8YHdjwfu1u1rnKHEwOi1+pfxp37dxqiBVG1zByY /xcPMKktHdE3R1KymoHgL430gP3w= X-Gm-Gg: ASbGncu14PeiXik6SGIr9TESGl1HRwvSfikjpJBcNxQWQjw5aRbb/HKbgBa9AiOkQkn 0PBWPRCNZNI13/aSVqXtEohXpXvZHyPbp37+GuiCTmVKwaeXw9hbfxeqyZs+XIetbPekNwSN6SA == X-Google-Smtp-Source: AGHT+IHGQhwJ5UihUzWyaCa+nhrmX42IY/x7jgf7SpW8x4u8T8gHs63v1vG/G81eVxAfNqsVAEzLmeDo9yBTk74cZtk= X-Received: by 2002:a17:907:d048:b0:ab2:b5f1:567d with SMTP id a640c23a62f3a-ab7f33daa81mr138083966b.32.1739338447504; Tue, 11 Feb 2025 21:34:07 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 21:34:06 -0800 From: Stefan Kangas In-Reply-To: <87a5bfgn87.fsf@disroot.org> References: <87o70j4sg3.fsf@disroot.org> <87a5bfgn87.fsf@disroot.org> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 21:34:06 -0800 X-Gm-Features: AWEUYZmOA6cxJOeiik2kEaYcLUA3Wj3bt_WDkPNwYJm57gaP_qNhehEAXL4qvV4 Message-ID: Subject: Re: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation To: Gabriel Santos Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75410-done Cc: 75410-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Gabriel Santos writes: > Hello, > > Attached is the updated patch. > > Here is the news entry I wrote: > > " > Bound unused letters in 'image-dired-thumbnail-mode-map' > For a more comfortable navigation experience (as in, no modifier keys), > the keys "f", "b", "n", "p", "a" and "e" are now bound to the > same functions as their C- counterparts. > " > > Let me know what you think about it! Thanks! Installed on master as commit 7aa42917288. I'm therefore closing this bug report. ------------=_1739338502-3114-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 20:08:04 +0000 Received: from localhost ([127.0.0.1]:40222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUtON-0008Cr-PS for submit@debbugs.gnu.org; Mon, 06 Jan 2025 15:08:04 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUtOM-0008C9-6l for submit@debbugs.gnu.org; Mon, 06 Jan 2025 15:08:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUtOD-0000Na-Bn for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:07:53 -0500 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUtOA-00048g-5A for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:07:52 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 92E722594B; Mon, 6 Jan 2025 21:07:35 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3qeRuywPNRtq; Mon, 6 Jan 2025 21:07:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1736194050; bh=yZwXsqjZTDhmDHRD9msZ+CtDnhipEbtTj0M00JKMeoA=; h=From:To:Cc:Subject:Date; b=lmuvco3Eb0X0vzMB9DvVtFdDQJveDomChV8siRQItZo0W5uFMBSOw1EogqR2Ovg5u lkiWgRPI6Uv7iZRj3jk9X1sYIdB9STHdtDPrEk9R98+/45v3A1nUwMv+SY1wLv5U58 wW2ZQ1R4aU8VObgP1KJTMP27n6uIGnZpXfkor2nS5kYwz05Zb3q/XAQdkhtGKfpL8U rWmvYAy1I58WqsdhDH/MaJD4UROpXZUIbS3SfqnWB0GtZtzR8j7eh4zGaHlIPJ474e ueQZFkpA/Vrn94VoP59EBi0bwjPcscBTEnQvdUrzTiJ9jlGiA1Q+LBQOJJyIdIN2MN nEDUi7vLUk+XQ== From: Gabriel Santos To: bug-gnu-emacs@gnu.org Subject: [PATCH] image-dired: Add extra keybinds for navigation Date: Mon, 06 Jan 2025 17:07:24 -0300 Message-ID: <87o70j4sg3.fsf@disroot.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.21.23.139; envelope-from=gabrielsantosdesouza@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Greetings, I discovered this mode through a blog post from Sacha: And I really liked it. Though, I felt that it was missing something: Some keybinds for navigation besides C-n and C-p, like those found in other read-only modes, such as dired-mode. This patch binds the following keys in `image-dired-thumbnail-mode-map': - "f" :: `image-dired-forward-image' - "b" :: `image-dired-backward-image' - "n" :: `image-dired-next-line' - "p" :: `image-dired-previous-line' - "a" :: `image-dired-move-beginning-of-line' - "e" :: `image-dired-move-end-of-line' These keys are currently unused in the mode. Regards, -- Gabriel Santos --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-image-dired--Add-extra-keybinds-for-navigation.patch Content-Description: [PATCH] image-dired: Add extra keybinds for navigation >From 8f7a1234ce7642f587e435347bf7ba22b397ce18 Mon Sep 17 00:00:00 2001 From: Gabriel Santos Date: Mon, 6 Jan 2025 16:56:31 -0300 Subject: [PATCH] image-dired: Add extra keybinds for navigation * lisp/image/image-dired.el (image-dired-thumbnail-mode-map): Bind previously unused keys for alternative navigation. --- lisp/image/image-dired.el | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 71c272e4388..b35199c60d4 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -944,6 +944,15 @@ You probably want to use this together with (defvar-keymap image-dired-thumbnail-mode-map :doc "Keymap for `image-dired-thumbnail-mode'." + + ;; Regular navigation + "f" #'image-dired-forward-image + "b" #'image-dired-backward-image + "n" #'image-dired-next-line + "p" #'image-dired-previous-line + "a" #'image-dired-move-beginning-of-line + "e" #'image-dired-move-end-of-line + "d" #'image-dired-flag-thumb-original-file "" #'image-dired-flag-thumb-original-file "m" #'image-dired-mark-thumb-original-file -- 2.47.1 --=-=-=-- ------------=_1739338502-3114-1--