GNU bug report logs - #75410
[PATCH] image-dired: Add extra keybinds for navigation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75410 in the body.
You can then email your comments to 75410 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Kangas <stefankangas <at> gmail.com>
Subject: [PATCH] image-dired: Add extra keybinds for navigation
Date: Mon, 06 Jan 2025 17:07:24 -0300

[Message part 1 (text/plain, inline)]

Greetings,

I discovered this mode through a blog post from Sacha:

<https://sachachua.com/blog/2025/01/using-image-dired-to-browse-the-latest-screenshots-from-multiple-directories/>

And I really liked it.

Though, I felt that it was missing something:

Some keybinds for navigation besides C-n and C-p, like those found in
other read-only modes, such as dired-mode.

This patch binds the following keys in `image-dired-thumbnail-mode-map':

- "f" :: `image-dired-forward-image'
- "b" :: `image-dired-backward-image'
- "n" :: `image-dired-next-line'
- "p" :: `image-dired-previous-line'
- "a" :: `image-dired-move-beginning-of-line'
- "e" :: `image-dired-move-end-of-line'

These keys are currently unused in the mode.

Regards,

--
Gabriel Santos

[0001-image-dired--Add-extra-keybinds-for-navigation.patch (text/x-patch, attachment)]

Message #10 received at 75410 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Cc: 75410 <at> debbugs.gnu.org
Subject: Re: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation
Date: Fri, 24 Jan 2025 18:05:15 -0600

Gabriel Santos <gabrielsantosdesouza <at> disroot.org> writes:

> Greetings,
>
> I discovered this mode through a blog post from Sacha:
>
> <https://sachachua.com/blog/2025/01/using-image-dired-to-browse-the-latest-screenshots-from-multiple-directories/>
>
> And I really liked it.

That's good to hear!

> Though, I felt that it was missing something:
>
> Some keybinds for navigation besides C-n and C-p, like those found in
> other read-only modes, such as dired-mode.
>
> This patch binds the following keys in `image-dired-thumbnail-mode-map':
>
> - "f" :: `image-dired-forward-image'
> - "b" :: `image-dired-backward-image'
> - "n" :: `image-dired-next-line'
> - "p" :: `image-dired-previous-line'
> - "a" :: `image-dired-move-beginning-of-line'
> - "e" :: `image-dired-move-end-of-line'
>
> These keys are currently unused in the mode.
>
> Regards,

Thanks for the patch!  I think this is a good idea, and the patch looks
good to go, but such a change should be announced in NEWS, to let people
know about it.

Could you please resubmit with such an addition?

Message #13 received at 75410 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 75410 <at> debbugs.gnu.org
Subject: Re: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation
Date: Sat, 25 Jan 2025 08:13:44 -0300

[Message part 1 (text/plain, inline)]

Hello,

Attached is the updated patch.

Here is the news entry I wrote:

"
Bound unused letters in 'image-dired-thumbnail-mode-map'
For a more comfortable navigation experience (as in, no modifier keys),
the keys "f", "b", "n", "p", "a" and "e" are now bound to the
same functions as their C- counterparts.
"

Let me know what you think about it!

--
Gabriel Santos

[0001-image-dired--Add-extra-keybinds-for-navigation.patch (text/x-patch, attachment)]

Message #18 received at 75410-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Cc: 75410-done <at> debbugs.gnu.org
Subject: Re: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation
Date: Tue, 11 Feb 2025 21:34:06 -0800

Version: 31.1

Gabriel Santos <gabrielsantosdesouza <at> disroot.org> writes:

> Hello,
>
> Attached is the updated patch.
>
> Here is the news entry I wrote:
>
> "
> Bound unused letters in 'image-dired-thumbnail-mode-map'
> For a more comfortable navigation experience (as in, no modifier keys),
> the keys "f", "b", "n", "p", "a" and "e" are now bound to the
> same functions as their C- counterparts.
> "
>
> Let me know what you think about it!

Thanks!  Installed on master as commit 7aa42917288.

I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.