GNU bug report logs - #7541
24.0.50; define-key error message for non-prefix M-[char]

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7541 in the body.
You can then email your comments to 7541 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Don March <don <at> ohspite.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; define-key error message for non-prefix M-[char]
Date: Fri, 3 Dec 2010 11:35:03 -0500

[Message part 1 (text/plain, inline)]

Typing and evaluating the following code in the scratch
buffer results in an (appropriate) error, but with an incorrect
message:

(setq new-kmap (make-sparse-keymap))
(define-key new-kmap [?a 27] 'command)
(define-key new-kmap [?a ?\M-x] 'command)
;; Debugger entered--Lisp error:
;;   (error "Key sequence a M-x starts with non-prefix key a")
;; (should be:
;;          "Key sequence a M-x starts with non-prefix key a ESC")

The code in keymap.c loops over the characters in the key sequence and
says to report everything before the current character as the
non-prefix key.  But that misses the case when M-x is converted into
[27 ?x] and it's the `27' part that causes the error.

Please see the attached patch.

A few other cases that show the problem:

(setq a (make-sparse-keymap))
(define-key a [27] 'command)
(define-key a [?\M-x] 'command)
;; Debugger entered--Lisp error:
;;   (error "Key sequence M-x starts with non-prefix key ")
;; (should be:
;;          "Key sequence M-x starts with non-prefix key ESC")

(setq new-kmap (make-sparse-keymap))
(define-key new-kmap [?a 27] 'command)
(define-key new-kmap [?a 27 ?x] 'command)
;; Debugger entered--Lisp error:
;;   (error "Key sequence a M-x starts with non-prefix key a ESC")
;; (error text is correct)

(setq new-kmap (make-sparse-keymap))
(define-key new-kmap [?a] 'command)
(define-key new-kmap [?a ?\M-x] 'command)
;; Debugger entered--Lisp error:
;;    (error "Key sequence a M-x starts with non-prefix key a")
;; (error text is correct)

In GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.22.0)
 of 2010-12-03 on lappy
Windowing system distributor `The X.Org Foundation', version 11.0.10900000

[define-key_diff (application/octet-stream, attachment)]

Message #8 received at 7541 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Don March <don <at> ohspite.net>
Cc: 7541 <at> debbugs.gnu.org
Subject: Re: 24.0.50; define-key error message for non-prefix M-[char]
Date: Sun, 03 Jul 2011 15:39:45 +0200

Don March <don <at> ohspite.net> writes:

> Typing and evaluating the following code in the scratch
> buffer results in an (appropriate) error, but with an incorrect
> message:
>
> (setq new-kmap (make-sparse-keymap))
> (define-key new-kmap [?a 27] 'command)
> (define-key new-kmap [?a ?\M-x] 'command)
> ;; Debugger entered--Lisp error:
> ;;   (error "Key sequence a M-x starts with non-prefix key a")
> ;; (should be:
> ;;          "Key sequence a M-x starts with non-prefix key a ESC")
>
> The code in keymap.c loops over the characters in the key sequence and
> says to report everything before the current character as the
> non-prefix key.  But that misses the case when M-x is converted into
> [27 ?x] and it's the `27' part that causes the error.

Your patch for this bug looks correct, but it's more than 10 lines long,
so the FSF needs copyright assignment papers for the code.

Do you have such paperwork on file with the FSF?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #11 received at 7541 <at> debbugs.gnu.org (full text, mbox):

From: Don March <don <at> ohspite.net>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 7541 <at> debbugs.gnu.org
Subject: Re: 24.0.50; define-key error message for non-prefix M-[char]
Date: Sun, 3 Jul 2011 12:24:03 -0400

I just sent an email to assign <at> gnu.org.  I'll report back when the
process is complete.

On Sun, Jul 3, 2011 at 9:39 AM, Lars Magne Ingebrigtsen <larsi <at> gnus.org> wrote:
> Don March <don <at> ohspite.net> writes:
>
>> Typing and evaluating the following code in the scratch
>> buffer results in an (appropriate) error, but with an incorrect
>> message:
>>
>> (setq new-kmap (make-sparse-keymap))
>> (define-key new-kmap [?a 27] 'command)
>> (define-key new-kmap [?a ?\M-x] 'command)
>> ;; Debugger entered--Lisp error:
>> ;;   (error "Key sequence a M-x starts with non-prefix key a")
>> ;; (should be:
>> ;;          "Key sequence a M-x starts with non-prefix key a ESC")
>>
>> The code in keymap.c loops over the characters in the key sequence and
>> says to report everything before the current character as the
>> non-prefix key.  But that misses the case when M-x is converted into
>> [27 ?x] and it's the `27' part that causes the error.
>
> Your patch for this bug looks correct, but it's more than 10 lines long,
> so the FSF needs copyright assignment papers for the code.
>
> Do you have such paperwork on file with the FSF?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>  bloggy blog http://lars.ingebrigtsen.no/
>

Message #14 received at 7541 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Don March <don <at> ohspite.net>
Cc: 7541 <at> debbugs.gnu.org
Subject: Re: 24.0.50; define-key error message for non-prefix M-[char]
Date: Sun, 03 Jul 2011 18:30:21 +0200

Don March <don <at> ohspite.net> writes:

> I just sent an email to assign <at> gnu.org.  I'll report back when the
> process is complete.

Great!

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #17 received at 7541 <at> debbugs.gnu.org (full text, mbox):

From: Don March <don <at> ohspite.net>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 7541 <at> debbugs.gnu.org
Subject: Re: 24.0.50; define-key error message for non-prefix M-[char]
Date: Mon, 1 Aug 2011 17:24:25 -0400

Okay, I just got an email saying my copyright assignment papers have
been received and executed.

On Sun, Jul 3, 2011 at 12:30 PM, Lars Magne Ingebrigtsen <larsi <at> gnus.org> wrote:
> Don March <don <at> ohspite.net> writes:
>
>> I just sent an email to assign <at> gnu.org.  I'll report back when the
>> process is complete.
>
> Great!
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>  bloggy blog http://lars.ingebrigtsen.no/
>

Message #20 received at 7541 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Don March <don <at> ohspite.net>
Cc: 7541 <at> debbugs.gnu.org
Subject: Re: 24.0.50; define-key error message for non-prefix M-[char]
Date: Tue, 02 Aug 2011 17:28:20 +0200

Don March <don <at> ohspite.net> writes:

> Okay, I just got an email saying my copyright assignment papers have
> been received and executed.

Thanks; I've now applied the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.