From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 10:00:06 2025 Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 15:00:06 +0000 Received: from localhost ([127.0.0.1]:39615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUoaL-00015Q-Uc for submit@debbugs.gnu.org; Mon, 06 Jan 2025 10:00:06 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39936) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUoaJ-00012D-Cv for submit@debbugs.gnu.org; Mon, 06 Jan 2025 10:00:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUoaB-0007Nu-4c for guix-patches@gnu.org; Mon, 06 Jan 2025 09:59:55 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUoa4-0000da-Pz for guix-patches@gnu.org; Mon, 06 Jan 2025 09:59:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=g6Jwt4cdSLO8r+HXF6kbwmnRGM01bXY3z4R1wqzhifA=; b=UO2VnkcljqMOdvhCDaEtBw799VA8WFji3jk0L65v26cBKx2hmTEJ6ZeV LndMLRFCAogndB2sfHI/rBcP8AylaxoIFFEWRkgekZawJAeCMhHha+0vl rhKN9ibjHpuuZg5JjQK+hL5g2infU1ojMxsQfh2W/Z0YAS4n+g/M2V2BF Y=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=romain.garbage@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.12,293,1728943200"; d="scan'208";a="105589899" Received: from unknown (HELO guix-A102.bordeaux.inria.fr) ([193.50.110.191]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 15:59:45 +0100 From: Romain GARBAGE To: guix-patches@gnu.org Subject: [PATCH Cuirass] base: Add support for disabling channel authentication. Date: Mon, 6 Jan 2025 15:59:37 +0100 Message-ID: <20250106145937.17780-1-romain.garbage@inria.fr> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=192.134.164.104; envelope-from=romain.garbage@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit Cc: ludovic.courtes@inria.fr, Romain GARBAGE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * src/cuirass/base.scm (channel-update-service, jobset-monitor): Add support for disabling Guix channel authentication. * doc/cuirass.texi (Specifications): Add documentation. --- doc/cuirass.texi | 4 ++++ src/cuirass/base.scm | 19 ++++++++++++++----- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/doc/cuirass.texi b/doc/cuirass.texi index 4c160c3..b3ab4c5 100644 --- a/doc/cuirass.texi +++ b/doc/cuirass.texi @@ -248,6 +248,10 @@ You can store any information you like in properties, but you must make sure that this is serializable. For example, the properties alist cannot contain records. +The special @code{authenticate-channels?} property, when set to +@code{#f}, disables authentication of @emph{all} the channels declared in the +specification, including the Guix channel. + @end table @end deftp diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm index 837de51..89fff82 100644 --- a/src/cuirass/base.scm +++ b/src/cuirass/base.scm @@ -507,7 +507,7 @@ to update Git checkouts, effectively serializing all Git operations." ;; Note: All Git operations are serialized when in fact it would be enough ;; to serialize operations with the same URL (because they are cached in the ;; same directory). - (define (fetch store channels) + (define (fetch store channels authenticate?) (let/ec return (with-exception-handler (lambda (exception) @@ -533,16 +533,17 @@ to update Git checkouts, effectively serializing all Git operations." (lambda () (non-blocking (set-thread-name "git-checkout") - (latest-channel-instances* store channels)))))) + (latest-channel-instances* store channels + #:authenticate? authenticate?)))))) (lambda () (with-store store (let loop () (match (get-message channel) - (`(fetch ,channels ,reply) + (`(fetch ,channels ,authenticate? ,reply) (log-info "fetching channels:~{ '~a'~}" (map channel-name channels)) - (let ((result (fetch store channels))) + (let ((result (fetch store channels authenticate?))) (if result (log-info "pulled commits~{ ~a~}" (zip (map (compose channel-name @@ -741,6 +742,14 @@ concurrently; it sends derivation build requests to BUILDER." (define channels (specification-channels spec)) + (define authenticate? + (match (assq 'authenticate-channels? + (specification-properties spec)) + (#f #t) ; Authenticate by default. + ((_ . authenticate?) + ;; Ensure the return value is a boolean. + (->bool authenticate?)))) + (define (perform-update) (let* ((timestamp (time-second (current-time time-utc))) (recent? (lambda (time) @@ -762,7 +771,7 @@ concurrently; it sends derivation build requests to BUILDER." (match (let ((reply (make-channel))) (log-info "fetching channels for spec '~a'" name) (put-message update-service - `(fetch ,channels ,reply)) + `(fetch ,channels ,authenticate? ,reply)) (get-message reply)) (#f ;; TODO: Send the error to CHANNEL so the web interface base-commit: e1a4675ec417db3e7f97c05c3f2642ab8acb9210 -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 09 09:41:58 2025 Received: (at 75407-done) by debbugs.gnu.org; 9 Jan 2025 14:41:58 +0000 Received: from localhost ([127.0.0.1]:51327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVtjR-0003Kj-Dn for submit@debbugs.gnu.org; Thu, 09 Jan 2025 09:41:57 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:3188) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVtjO-0003KA-IS for 75407-done@debbugs.gnu.org; Thu, 09 Jan 2025 09:41:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=VvmHzhEFnWSjP4sTRnneaIh3cg3+N4YXkDFJ72i9q64=; b=G7F4tnqZPnmVl7pnNsCgrp4ixmEjUfmKfkxC+WJDtEaXAtw2HleJ+rm5 sDNuVz1V+hiNEoHX/L92uzKaSW6ggUq4mR1XoNKslJWKYAvu9/tHWOBj6 Xp7HUVl1bio06zoiquch42hJ0VMHpVmchkragoGkqO82u3SNN/b+CDEs/ Q=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.12,301,1728943200"; d="scan'208";a="105922222" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2025 15:41:47 +0100 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Romain GARBAGE Subject: Re: bug#75407: [PATCH Cuirass] base: Add support for disabling channel authentication. In-Reply-To: <20250106145937.17780-1-romain.garbage@inria.fr> (Romain GARBAGE's message of "Mon, 6 Jan 2025 15:59:37 +0100") References: <20250106145937.17780-1-romain.garbage@inria.fr> Date: Thu, 09 Jan 2025 15:41:46 +0100 Message-ID: <878qrkoxqt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75407-done Cc: 75407-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Romain GARBAGE skribis: > * src/cuirass/base.scm (channel-update-service, jobset-monitor): Add support > for disabling Guix channel authentication. > * doc/cuirass.texi (Specifications): Add documentation. Applied, thanks! From unknown Sun Aug 10 16:48:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 07 Feb 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator