From unknown Thu Aug 14 12:25:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#75405 <75405@debbugs.gnu.org> To: bug#75405 <75405@debbugs.gnu.org> Subject: Status: gzip --synchronous doesn't work with musl Reply-To: bug#75405 <75405@debbugs.gnu.org> Date: Thu, 14 Aug 2025 19:25:24 +0000 retitle 75405 gzip --synchronous doesn't work with musl reassign 75405 gzip submitter 75405 Lasse Collin severity 75405 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 08:29:41 2025 Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 13:29:41 +0000 Received: from localhost ([127.0.0.1]:37291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUnAq-00048k-Ej for submit@debbugs.gnu.org; Mon, 06 Jan 2025 08:29:40 -0500 Received: from lists.gnu.org ([2001:470:142::17]:51388) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUnAn-00048R-EK for submit@debbugs.gnu.org; Mon, 06 Jan 2025 08:29:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUnAh-0001s6-Si for bug-gzip@gnu.org; Mon, 06 Jan 2025 08:29:31 -0500 Received: from mailscanner01.zoner.fi ([84.34.166.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUnAf-0007vq-Cr for bug-gzip@gnu.org; Mon, 06 Jan 2025 08:29:31 -0500 Received: from www25.zoner.fi (www25.zoner.fi [84.34.147.45]) by mailscanner01.zoner.fi (Postfix) with ESMTPS id 858EC423A5 for ; Mon, 6 Jan 2025 15:29:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tukaani.org ; s=x; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TGnEP6Fd5BGTMtaB1VkmdU0KYzNMFIPyE3jpuVoomgA=; b=an/cM8pfp30nICI9knl7lFd1bW oCOnSO2737MaEkF2iqqAdv91BEc7amUVVwmnSMEqb0HiQvOFaCZyi5L0Ut5qJ5IIuQR9m3BnEII8U Yobyasx7kXU9t4FCyH3z5xA136maK4zenDBjgymyeD15cQMi6ATroKHQ1uDgrzFHUVGxPZKrhufny LSAFiZg+hkCKnb2gj6BjlwiiVougZpIAk7Xfjhr2kBwX+EVdug165qgqsIwq2LcYXj5m9lUpokzOT 5AIOzaue2ikM6yk25HTOSqjxSNU9kM7jIbq6PLRO9cgehikQRrR9UADpnFtFfGyVbADLvUhUP8gfk 18pDWWNQ==; Received: from mail.zoner.fi ([84.34.147.244]) by www25.zoner.fi with esmtp (Exim 4.97.1) (envelope-from ) id 1tUnAZ-0000000Bpti-1Qjy for bug-gzip@gnu.org; Mon, 06 Jan 2025 15:29:23 +0200 Date: Mon, 6 Jan 2025 15:29:22 +0200 From: Lasse Collin To: bug-gzip@gnu.org Subject: gzip --synchronous doesn't work with musl Message-ID: <20250106152922.7641cc84.lasse.collin@tukaani.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/l+967C72WL=usjr8/nrA_Z5" Received-SPF: pass client-ip=84.34.166.10; envelope-from=lasse.collin@tukaani.org; helo=mailscanner01.zoner.fi X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --MP_/l+967C72WL=usjr8/nrA_Z5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Linux/musl: $ echo foo > foo $ gzip --synchronous foo gzip: foo.gz: Bad file descriptor =46rom gzip.c: dfd =3D open (dfname, O_SEARCH | O_DIRECTORY); ... if ((synchronous && ((0 <=3D dfd && fdatasync (dfd) !=3D 0 && errno !=3D EINVAL) || (fsync (ofd) !=3D 0 && errno !=3D EINVAL))) || close (ofd) !=3D 0) write_error (); In musl, O_SEARCH maps to Linux-specific O_PATH which doesn't allow fsync or fdatasync. Gnulib's fcntl module's docs already warn about a similar situation with fchmod. As far as I understand this, O_SEARCH in POSIX is only meant for openat and such APIs. Then it makes sense that O_SEARCH becomes O_PATH because O_PATH can open a directory that lacks read permission. This way openat can be used even for such directories. Maybe there is no way to sync a directory that only has write and search permissions. Luckily such a combination is rare. A short fix is using O_RDONLY when --synchronous has been specified: dfd =3D open (dfname, (synchronous ? O_RDONLY : O_SEARCH) | O_DIRECTORY); I also tried opening a separate file descriptor for syncing (see the attachment) but I think the above change is better. However, both have a weakness that if the directory cannot be opened, --synchronous will silently skip syncing the directory. It would be safer to show an error if the directory cannot be opened when --synchronous has been specified. --=20 Lasse Collin --MP_/l+967C72WL=usjr8/nrA_Z5 Content-Type: text/x-patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=dfd_sync.patch RnJvbSA4MzNmOGU3MzFmODk5OGM1NGFkZTcxZDI2M2E5NmY4ZmQzN2QzY2MwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTGFzc2UgQ29sbGluIDxsYXNzZS5jb2xsaW5AdHVrYWFuaS5v cmc+DQpEYXRlOiBNb24sIDYgSmFuIDIwMjUgMTI6NDk6NDggKzAyMDANClN1YmplY3Q6IFtQQVRD SF0gZ3ppcDogRml4IC0tc3luY2hyb25vdXMgd2hlbiBPX1NFQVJDSCAhPSBPX1JET05MWQ0KDQpP biBMaW51eC9tdXNsOg0KDQogICAgJCBlY2hvIGZvbyA+IGZvbw0KICAgICQgZ3ppcCAtLXN5bmNo cm9ub3VzIGZvbw0KDQogICAgZ3ppcDogZm9vLmd6OiBCYWQgZmlsZSBkZXNjcmlwdG9yDQoNCk9f U0VBUkNIIG1hcHMgdG8gTGludXgtc3BlY2lmaWMgT19QQVRILiBUaGUgcmVzdWx0aW5nIGZpbGUg ZGVzY3JpcHRvcg0KZG9lc24ndCBhbGxvdyBmc3luYy4gT19TRUFSQ0ggaXMgb25seSBtZWFudCBm b3Igb3BlbmF0IGFuZCBzdWNoIEFQSXMuDQoNCldoZW4gLS1zeW5jaHJvbm91cyBoYXMgYmVlbiBz cGVjaWZpZWQsIG9wZW4gYSBzZXBhcmF0ZSBmaWxlIGRlc2NyaXB0b3INCndpdGggT19SRE9OTFkg d2hlbiBPX1NFQVJDSCAhPSBPX1JET05MWS4NCg0KQWRkIGEgRklYTUUgYWJvdXQgbGFjayBvZiBl cnJvciBjaGVja2luZy4gSWYgb3BlbmluZyB0aGUgZGlyZWN0b3J5IGZhaWxzLA0KZmRhdGFzeW5j IG9uIHRoZSBkaXJlY3RvcnkgaXMgc2lsZW50bHkgc2tpcHBlZCB3aGljaCBtYWtlcyAtLXN5bmNo cm9ub3VzDQpub3QgcHJvcGVybHkgc3luY2hyb25vdXMuDQotLS0NCiBnemlwLmMgfCAyMiArKysr KysrKysrKysrKysrKysrKystDQogMSBmaWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkNCg0KZGlmZiAtLWdpdCBhL2d6aXAuYyBiL2d6aXAuYw0KaW5kZXggYTMzODQx YS4uYjA2ODdlYyAxMDA2NDQNCi0tLSBhL2d6aXAuYw0KKysrIGIvZ3ppcC5jDQpAQCAtMjE1LDYg KzIxNSw3IEBAIHN0YXRpYyBzdHJ1Y3Qgc3RhdCBpc3RhdDsgICAgICAgICAvKiBzdGF0dXMgZm9y IGlucHV0IGZpbGUgKi8NCiBpbnQgIGlmZDsgICAgICAgICAgICAgICAgICAvKiBpbnB1dCBmaWxl IGRlc2NyaXB0b3IgKi8NCiBpbnQgIG9mZDsgICAgICAgICAgICAgICAgICAvKiBvdXRwdXQgZmls ZSBkZXNjcmlwdG9yICovDQogc3RhdGljIGludCBkZmQgPSAtMTsgICAgICAgLyogb3V0cHV0IGRp cmVjdG9yeSBmaWxlIGRlc2NyaXB0b3IgKi8NCitzdGF0aWMgaW50IGRmZF9zeW5jID0gLTE7ICAv KiBvdXRwdXQgZGlyZWN0b3J5IGZpbGUgZGVzY3JpcHRvciBmb3IgZmRhdGFzeW5jICovDQogdW5z aWduZWQgaW5zaXplOyAgICAgICAgICAgLyogdmFsaWQgYnl0ZXMgaW4gaW5idWYgKi8NCiB1bnNp Z25lZCBpbnB0cjsgICAgICAgICAgICAvKiBpbmRleCBvZiBuZXh0IGJ5dGUgdG8gYmUgcHJvY2Vz c2VkIGluIGluYnVmICovDQogdW5zaWduZWQgb3V0Y250OyAgICAgICAgICAgLyogYnl0ZXMgaW4g b3V0cHV0IGJ1ZmZlciAqLw0KQEAgLTg0OSw2ICs4NTAsMjQgQEAgYXRkaXJfc2V0IChjaGFyIGNv bnN0ICpkaXIsIHB0cmRpZmZfdCBkaXJsZW4pDQogICAgICAgbWVtY3B5IChkZm5hbWUsIGRpciwg ZGlybGVuKTsNCiAgICAgICBkZm5hbWVbZGlybGVuXSA9ICdcMCc7DQogICAgICAgZGZkID0gb3Bl biAoZGZuYW1lLCBPX1NFQVJDSCB8IE9fRElSRUNUT1JZKTsNCisNCisgICAgICBpZiAoc3luY2hy b25vdXMpDQorICAgICAgICB7DQorICAgICAgICAgIGlmIChPX1NFQVJDSCAhPSBPX1JET05MWSkN CisgICAgICAgICAgICB7DQorICAgICAgICAgICAgICBpZiAoMCA8PSBkZmRfc3luYykNCisgICAg ICAgICAgICAgICAgY2xvc2UgKGRmZF9zeW5jKTsNCisgICAgICAgICAgICAgIC8qIEZJWE1FOiBU aGlzIHNob3VsZG4ndCBpZ25vcmUgZXJyb3JzLiBTaWxlbnRseSBza2lwcGluZw0KKyAgICAgICAg ICAgICAgICAgdGhlIGZkYXRhc3luYyBjYWxsIG1lYW5zIHRoYXQgLS1zeW5jaHJvbm91cyBkb2Vz IGl0cyBqb2INCisgICAgICAgICAgICAgICAgIG9ubHkgcGFydGlhbGx5Lg0KKyAgICAgICAgICAg ICAgICovDQorICAgICAgICAgICAgICBkZmRfc3luYyA9IG9wZW4gKGRmbmFtZSwgT19SRE9OTFkg fCBPX0RJUkVDVE9SWSk7DQorICAgICAgICAgICAgfQ0KKyAgICAgICAgICBlbHNlDQorICAgICAg ICAgICAgew0KKyAgICAgICAgICAgICAgZGZkX3N5bmMgPSBkZmQ7DQorICAgICAgICAgICAgfQ0K KyAgICAgICAgfQ0KICAgICB9DQogDQogICByZXR1cm4gZGZkOw0KQEAgLTEwMTAsNyArMTAyOSw4 IEBAIHRyZWF0X2ZpbGUgKGNoYXIgKmluYW1lKQ0KICAgICAgICAgY29weV9zdGF0ICgmaXN0YXQp Ow0KIA0KICAgICAgICAgaWYgKChzeW5jaHJvbm91cw0KLSAgICAgICAgICAgICAmJiAoKDAgPD0g ZGZkICYmIGZkYXRhc3luYyAoZGZkKSAhPSAwICYmIGVycm5vICE9IEVJTlZBTCkNCisgICAgICAg ICAgICAgJiYgKCgwIDw9IGRmZF9zeW5jICYmIGZkYXRhc3luYyAoZGZkX3N5bmMpICE9IDANCisg ICAgICAgICAgICAgICAgICAmJiBlcnJubyAhPSBFSU5WQUwpDQogICAgICAgICAgICAgICAgICB8 fCAoZnN5bmMgKG9mZCkgIT0gMCAmJiBlcnJubyAhPSBFSU5WQUwpKSkNCiAgICAgICAgICAgICB8 fCBjbG9zZSAob2ZkKSAhPSAwKQ0KICAgICAgICAgICB3cml0ZV9lcnJvciAoKTsNCi0tIA0KMi40 Ny4xDQoNCg== --MP_/l+967C72WL=usjr8/nrA_Z5-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 13:02:52 2025 Received: (at 75405) by debbugs.gnu.org; 6 Jan 2025 18:02:52 +0000 Received: from localhost ([127.0.0.1]:39978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUrRD-0001sA-SY for submit@debbugs.gnu.org; Mon, 06 Jan 2025 13:02:52 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:43018) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUrRB-0001rt-0u for 75405@debbugs.gnu.org; Mon, 06 Jan 2025 13:02:50 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 656DF3C00FAB3; Mon, 6 Jan 2025 10:02:42 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id OyylmBkRUXkT; Mon, 6 Jan 2025 10:02:42 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 076E43C082C8C; Mon, 6 Jan 2025 10:02:42 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 076E43C082C8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1736186562; bh=whgOAM8AWp1IRhTkR7V+BfLkrqVIVfuUcdJDTP5DB/4=; h=Message-ID:Date:MIME-Version:To:From; b=NchXPvAJCh9bHNNhBG+NHb2IN7kqie8jhzIYfkHoQuAw8jWZvmIyj1xcfZHtbVtfq LPOC9gU34CCW5oQC4N6mtTYjYwoO+5zwTfocXq1isSgZisMVF3oa5nzKKzB1oEl+LG Ou6IDlD5pZxFM3X22Jd+qjG2XKM8mtfysg2LLfR5D5jWYojTXoTQflNuBcwfK0W1Mx 37Y9oDhlS/8j2J1TXsIn5MZ5vaQf1G9er82ilHEkYaZBuJYowcr7rMX5ejGIJPpMKP eqtNdgT7x5iQzzQre7M6BBRMlGjLWhImIHVrJrjkFyqbZGM+HgH5qvAlNt05B1qWVy w2mtmdzGum3GA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id jNTU_KJPUnMW; Mon, 6 Jan 2025 10:02:41 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id DCF983C00FAB3; Mon, 6 Jan 2025 10:02:41 -0800 (PST) Message-ID: Date: Mon, 6 Jan 2025 10:02:41 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#75405: gzip --synchronous doesn't work with musl To: Lasse Collin References: <20250106152922.7641cc84.lasse.collin@tukaani.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <20250106152922.7641cc84.lasse.collin@tukaani.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75405 Cc: 75405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-01-06 05:29, Lasse Collin wrote: > In musl, O_SEARCH maps to Linux-specific O_PATH That is a bug in musl. musl should not define O_SEARCH to O_PATH on Linux, because O_PATH is not a valid implementation of O_SEARCH. Or if musl wants to do some sort of approximate-but-invalid implementation to POSIX, a better approximation is "#define O_SEARCH O_RDONLY", which is what Gnulib does in lib/fcntl.in.h. The approximation "#define O_SEARCH O_PATH" is more likely to break real-world applications than the approximation "#define O_SEARCH O_RDONLY" is. > As far as I understand this, O_SEARCH in POSIX is only meant for openat > and such APIs. No, O_SEARCH is well defined in POSIX to work in plain 'open'. See . Would the following Gnulib patch work around the musl bug? diff --git a/lib/fcntl.in.h b/lib/fcntl.in.h index 5f06c4fe10..44d02fb9fd 100644 --- a/lib/fcntl.in.h +++ b/lib/fcntl.in.h @@ -369,6 +369,11 @@ _GL_WARN_ON_USE (openat, "openat is not portable - " # define O_RSYNC 0 #endif +/* musl on GNU/Linux mistakenly has "#define O_SEARCH O_PATH". */ +#if defined O_SEARCH && defined O_PATH && O_SEARCH == O_PATH +# undef O_SEARCH +#endif + #ifndef O_SEARCH # define O_SEARCH O_RDONLY /* This is often close enough in older systems. */ #endif From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 13:23:16 2025 Received: (at 75405) by debbugs.gnu.org; 7 Jan 2025 18:23:16 +0000 Received: from localhost ([127.0.0.1]:44612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVEER-000629-HL for submit@debbugs.gnu.org; Tue, 07 Jan 2025 13:23:15 -0500 Received: from mailscanner01.zoner.fi ([84.34.166.10]:49426) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVEEL-00060u-CK for 75405@debbugs.gnu.org; Tue, 07 Jan 2025 13:23:10 -0500 Received: from www25.zoner.fi (www25.zoner.fi [84.34.147.45]) by mailscanner01.zoner.fi (Postfix) with ESMTPS id 9BF3241C6B; Tue, 7 Jan 2025 20:22:57 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tukaani.org ; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mDtwYLlUAiX2FbvN8iR3O4f3e9IsFcGVO/5cV6vtNmE=; b=MSYB1f3zd2Qb4aM73lfngvtj4D 6HYbZXs7YWgtE/nyyFsJwd3kt7n3HRFL0rtd0gKObOT8rt3YbFD+o/OUWV/ULA4+fFBSDdEXGDCoH r1oC5S6ppXVjfcie+1FrmgT2+zcBYFYaOh5MTP710bcT+9MYf0qxF6AUMPls3rS4DIDPRT/8NscRM JSibLLnsqcMKhut7G/8/YhfHaPesKhS8Yt0glQpESMcDTe1zuW8w1Gn3fvvj5t9fKhDInunsz84fV Im2/mAerMEy1ustWu/EFSzGmiOaKf+bNgT+hh2MmXfNdT+I+GEepeM56+H13MV3tQLhr2EVUInxKi YkDwc8ag==; Received: from mail.zoner.fi ([84.34.147.244]) by www25.zoner.fi with esmtp (Exim 4.97.1) (envelope-from ) id 1tVEED-00000005NvQ-1jIN; Tue, 07 Jan 2025 20:22:57 +0200 Date: Tue, 7 Jan 2025 20:22:56 +0200 From: Lasse Collin To: Paul Eggert Subject: Re: bug#75405: gzip --synchronous doesn't work with musl Message-ID: <20250107202256.6f38002c.lasse.collin@tukaani.org> In-Reply-To: References: <20250106152922.7641cc84.lasse.collin@tukaani.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75405 Cc: 75405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2025-01-06 Paul Eggert wrote: > On 2025-01-06 05:29, Lasse Collin wrote: > > As far as I understand this, O_SEARCH in POSIX is only meant for > > openat and such APIs. > > No, O_SEARCH is well defined in POSIX to work in plain 'open'. See > . I had looked at it a few times recently but somehow managed to convince myself that "search only" means something else than it actually does. Thanks for steering me back to the right path! > > In musl, O_SEARCH maps to Linux-specific O_PATH > > That is a bug in musl. musl should not define O_SEARCH to O_PATH on > Linux, because O_PATH is not a valid implementation of O_SEARCH. Or > if musl wants to do some sort of approximate-but-invalid > implementation to POSIX, a better approximation is "#define O_SEARCH > O_RDONLY", which is what Gnulib does in lib/fcntl.in.h. The > approximation "#define O_SEARCH O_PATH" is more likely to break > real-world applications than the approximation "#define O_SEARCH > O_RDONLY" is. musl's approach has the benefit that O_SEARCH works on dirs that lack read permission but, now that I have researched it a bit more, I see it indeed creates a bunch of new issues. For example, if a directory lacks search permission, opening still succeeds. If one wants to use O_PATH to create file descriptors for *at functions, one needs to write the code slightly differently than when using O_SEARCH. So I agree that O_RDONLY is a better approximation for O_SEARCH in the real world. However, one thing that isn't an issue in musl is fchmod which is currently documented in Gnulib's doc/posix-headers/fcntl.texi. fchmod and a few others were fixed in 2013 by using /proc/self/fd.[1] Perhaps Gnulib's docs could be updated to remove fchmod and add fsync and fdatasync. Even if proc-based emulation was added, I don't see how it could be great if it needs to do open+fsync+close where the open with O_RDONLY might fail. But I might be missing something (again). [1] https://git.musl-libc.org/cgit/musl/commit/?id=9ca1f62b0c0d3e50480eb654ac941ff943ce0558 > Would the following Gnulib patch work around the musl bug? It does, thanks! Should it check for __linux__ too to be sure that the workaround won't accidentally apply on some other kernel or libc that has O_PATH? Or perhaps it's safe to assume that nothing else has O_SEARCH == O_PATH. For example, FreeBSD has O_PATH but, as expected, it doesn't equal O_SEARCH. It could be useful to add a test for gzip --synchronous. "make check" passed without the Gnulib patch too. -- Lasse Collin From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 03:37:22 2025 Received: (at 75405) by debbugs.gnu.org; 8 Jan 2025 08:37:22 +0000 Received: from localhost ([127.0.0.1]:45912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVRZ3-00068y-Tn for submit@debbugs.gnu.org; Wed, 08 Jan 2025 03:37:22 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:35198) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVRZ1-00068j-PA for 75405@debbugs.gnu.org; Wed, 08 Jan 2025 03:37:20 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id BE1B63C082C8E; Wed, 8 Jan 2025 00:37:13 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id 1lvVIJr--Hpo; Wed, 8 Jan 2025 00:37:13 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 1AC9C3C082EA3; Wed, 8 Jan 2025 00:37:13 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 1AC9C3C082EA3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1736325433; bh=0MzG1fpqZdfPd5VHNXlPy4wff9pr68S54mrR/bkfBHs=; h=Message-ID:Date:MIME-Version:To:From; b=CJPb2mePiLLuDkMKwypiE8q+FtguCcX6yAMmHtGl41WGe7SSAmMGPSDEyHBrwIEc2 MMlPh6y1OuymSrnJK7kO6a+WVP/MXD/ZMtPZ6a+bGrD/EvD/IcsRV/I1laghGWSIg6 msgdkDtsJloODHLIrSfr9UlE2tkQIbbfZAix3gKbIgvZnt9z7Y9K44oLLMui44LEQs GAxAGhxA5kHN693lQFI0IeJw/EjuwDw2dROdKvfM4S5S9ZIOKpPKsU0ZApe4taJkRp vEQmBp2CybLPHDSIfKNruOqz7bC6O9VdzVgbcQEQQvPhrD8Y98dWQ3ugaryjjM+8f5 smkhzqKDOZ3sA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id jeuLaYsjrxYK; Wed, 8 Jan 2025 00:37:13 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id E9DFB3C082C8E; Wed, 8 Jan 2025 00:37:12 -0800 (PST) Message-ID: <215637dd-6d21-4413-8eac-5fcf006aec63@cs.ucla.edu> Date: Wed, 8 Jan 2025 00:37:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#75405: gzip --synchronous doesn't work with musl To: Lasse Collin References: <20250106152922.7641cc84.lasse.collin@tukaani.org> <20250107202256.6f38002c.lasse.collin@tukaani.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <20250107202256.6f38002c.lasse.collin@tukaani.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75405 Cc: 75405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-01-07 10:22, Lasse Collin wrote: > However, one thing that isn't an issue in musl is fchmod which is > currently documented in Gnulib's doc/posix-headers/fcntl.texi. fchmod > and a few others were fixed in 2013 by using /proc/self/fd.[1] Is that a full fix, though? /proc might not be mounted. > Gnulib's docs could be updated to remove fchmod and add fsync and > fdatasync. Even if proc-based emulation was added, I don't see how it > could be great if it needs to do open+fsync+close where the open with > O_RDONLY might fail. But I might be missing something (again). > > [1] https://git.musl-libc.org/cgit/musl/commit/?id=9ca1f62b0c0d3e50480eb654ac941ff943ce0558 > >> Would the following Gnulib patch work around the musl bug? > > It does, thanks! OK, I installed it. > Should it check for __linux__ too to be sure that the workaround won't > accidentally apply on some other kernel or libc that has O_PATH? Anything else with O_SEARCH == O_PATH is likely to have similar problems. If not, we can cross that bridge when we come to it. > It could be useful to add a test for gzip --synchronous. Feel free.... From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 05:51:08 2025 Received: (at 75405) by debbugs.gnu.org; 8 Jan 2025 10:51:08 +0000 Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVTeV-00046n-II for submit@debbugs.gnu.org; Wed, 08 Jan 2025 05:51:08 -0500 Received: from mailscanner01.zoner.fi ([84.34.166.10]:33142) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVTeR-00046D-7V for 75405@debbugs.gnu.org; Wed, 08 Jan 2025 05:51:06 -0500 Received: from www25.zoner.fi (www25.zoner.fi [84.34.147.45]) by mailscanner01.zoner.fi (Postfix) with ESMTPS id 95B8E43B08; Wed, 8 Jan 2025 12:50:56 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tukaani.org ; s=x; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ahUkaFCR0Hhbk3hlJLu5/YXAAti7S1CdWWJ0NNPrHik=; b=H0RrL+0crglsN0IMVPwTBANHsl aY6gkvkAd6UWlbt8oiDbx3ncLxvNUVO1IJRlLTmtN451KxHVHWUPgqe9lyChJTlrdTE5Quzgk6rze ToOeTrWcS9IFj44SMmkTGVdgZnK7YdxLGKUscHH0p7t+mvMnCQFm30XNZxgOFYtXP2HH/RxXqHQfp eBOMg7TOCjaIN9lJgdKI1iKmQsc4a9KN4oB9nzVc2xUqDQX0RhHfLvXzRA+UDhYJN5mpIVK4JRaz2 dis8FDUkvjs7FGrfBdb/a+WTK6IxtIhfkd/sPRoymy/intdrwb4uY4R0pPfhQRW4mjC9wdUbXhAFU V+iWHeDQ==; Received: from mail.zoner.fi ([84.34.147.244]) by www25.zoner.fi with esmtp (Exim 4.97.1) (envelope-from ) id 1tVTeK-0000000AdUp-1RWj; Wed, 08 Jan 2025 12:50:56 +0200 Date: Wed, 8 Jan 2025 12:50:55 +0200 From: Lasse Collin To: Paul Eggert Subject: Re: bug#75405: gzip --synchronous doesn't work with musl Message-ID: <20250108125055.02400809.lasse.collin@tukaani.org> In-Reply-To: <215637dd-6d21-4413-8eac-5fcf006aec63@cs.ucla.edu> References: <20250106152922.7641cc84.lasse.collin@tukaani.org> <20250107202256.6f38002c.lasse.collin@tukaani.org> <215637dd-6d21-4413-8eac-5fcf006aec63@cs.ucla.edu> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/eafdXziqOBW1GOjc93eccVK" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75405 Cc: 75405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --MP_/eafdXziqOBW1GOjc93eccVK Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2025-01-08 Paul Eggert wrote: > On 2025-01-07 10:22, Lasse Collin wrote: > > > However, one thing that isn't an issue in musl is fchmod which is > > currently documented in Gnulib's doc/posix-headers/fcntl.texi. > > fchmod and a few others were fixed in 2013 by using > > /proc/self/fd.[1] > > Is that a full fix, though? /proc might not be mounted. No, it requires /proc, but it works most of the time... > > It could be useful to add a test for gzip --synchronous. > > Feel free.... Attached. It's based on z-suffix. -- Lasse Collin --MP_/eafdXziqOBW1GOjc93eccVK Content-Type: text/x-patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=test-synchronous.patch RnJvbSA4NjM3MzViZjU1NmE0ZjgyZjc4YjFkZDVhNGI4MDgxZDJmZmEwYjQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTGFzc2UgQ29sbGluIDxsYXNzZS5jb2xsaW5AdHVrYWFuaS5v cmc+DQpEYXRlOiBXZWQsIDggSmFuIDIwMjUgMTI6MTk6MjEgKzAyMDANClN1YmplY3Q6IFtQQVRD SF0gdGVzdHM6IHN5bmNocm9ub3VzOiBuZXcgdGVzdA0KDQoqIHRlc3RzL3N5bmNocm9ub3VzOiBU ZXN0IHRoYXQgLS1zeW5jaHJvbm91cyB3b3Jrcy4gVGhpcw0KZmFpbGVkIHdpdGggbXVzbCAxLjIu NSBiZWZvcmUgdGhlIEdudWxpYiBjb21taXQgMGZiMTg1YjdjZDVlDQooImZjbnRsLWg6IHBvcnQg YmV0dGVyIHRvIG11c2wgb24gR05VL0xpbnV4IikuDQoqIHRlc3RzL01ha2VmaWxlLmFtIChURVNU Uyk6IEFkZCBpdC4NCi0tLQ0KIHRlc3RzL01ha2VmaWxlLmFtIHwgIDEgKw0KIHRlc3RzL3N5bmNo cm9ub3VzIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQogMiBmaWxlcyBjaGFu Z2VkLCAzMSBpbnNlcnRpb25zKCspDQogY3JlYXRlIG1vZGUgMTAwNzU1IHRlc3RzL3N5bmNocm9u b3VzDQoNCmRpZmYgLS1naXQgYS90ZXN0cy9NYWtlZmlsZS5hbSBiL3Rlc3RzL01ha2VmaWxlLmFt DQppbmRleCA0YzEwYTcxLi5kODZjZmIwIDEwMDY0NA0KLS0tIGEvdGVzdHMvTWFrZWZpbGUuYW0N CisrKyBiL3Rlc3RzL01ha2VmaWxlLmFtDQpAQCAtMjksNiArMjksNyBAQCBURVNUUyA9CQkJCQlc DQogICBwaXBlLW91dHB1dAkJCQlcDQogICByZXByb2R1Y2libGUJCQkJXA0KICAgc3RkaW4JCQkJ CVwNCisgIHN5bmNocm9ub3VzCQkJCVwNCiAgIHRpbWVzdGFtcAkJCQlcDQogICB0d28tZmlsZXMJ CQkJXA0KICAgdHJhaWxpbmctbnVsCQkJCVwNCmRpZmYgLS1naXQgYS90ZXN0cy9zeW5jaHJvbm91 cyBiL3Rlc3RzL3N5bmNocm9ub3VzDQpuZXcgZmlsZSBtb2RlIDEwMDc1NQ0KaW5kZXggMDAwMDAw MC4uOTI2MWM5ZQ0KLS0tIC9kZXYvbnVsbA0KKysrIGIvdGVzdHMvc3luY2hyb25vdXMNCkBAIC0w LDAgKzEsMzAgQEANCisjIS9iaW4vc2gNCisjIENoZWNrIHRoYXQgLS1zeW5jaHJvbm91cyB3b3Jr cy4NCisNCisjIENvcHlyaWdodCAyMDE0LTIwMjUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ bmMuDQorDQorIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3Ry aWJ1dGUgaXQgYW5kL29yIG1vZGlmeQ0KKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkNCisjIHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yDQorIyAo YXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLg0KKw0KKyMgVGhpcyBwcm9ncmFtIGlz IGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQorIyBidXQg V0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBv Zg0KKyMgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NF LiAgU2VlIHRoZQ0KKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWls cy4NCisNCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5l cmFsIFB1YmxpYyBMaWNlbnNlDQorIyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwg c2VlIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uDQorIyBsaW1pdCBzbyBkb24ndCBy dW4gaXQgYnkgZGVmYXVsdC4NCisNCisuICIke3NyY2Rpcj0ufS9pbml0LnNoIjsgcGF0aF9wcmVw ZW5kXyAuLg0KKw0KK3ByaW50ZiBhbnl0aGluZyA+IEYgfHwgZnJhbWV3b3JrX2ZhaWx1cmVfDQor Z3ppcCAtLXN5bmNocm9ub3VzIEYgfHwgZmFpbD0xDQordGVzdCAhIC1mIEYgfHwgZmFpbD0xDQor dGVzdCAtZiBGLmd6IHx8IGZhaWw9MQ0KK2d6aXAgLWQgLS1zeW5jaHJvbm91cyBGLmd6IHx8IGZh aWw9MQ0KK3Rlc3QgISAtZiBGLmd6IHx8IGZhaWw9MQ0KK3Rlc3QgLWYgRiB8fCBmYWlsPTENCisN CitFeGl0ICRmYWlsDQotLSANCjIuNDcuMQ0KDQo= --MP_/eafdXziqOBW1GOjc93eccVK-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 09 02:44:10 2025 Received: (at 75405) by debbugs.gnu.org; 9 Jan 2025 07:44:10 +0000 Received: from localhost ([127.0.0.1]:50262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVnD8-0007kJ-5I for submit@debbugs.gnu.org; Thu, 09 Jan 2025 02:44:10 -0500 Received: from mailscanner08.zoner.fi ([5.44.246.17]:59112) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVnD4-0007jb-Ao for 75405@debbugs.gnu.org; Thu, 09 Jan 2025 02:44:08 -0500 Received: from www25.zoner.fi (www25.zoner.fi [84.34.147.45]) by mailscanner08.zoner.fi (Postfix) with ESMTPS id 74EA321324; Thu, 9 Jan 2025 09:43:59 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tukaani.org ; s=x; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BAZrqbNmlX4I9xjTUOJkWT4OfxbT8+vW8BEfKPBNVCE=; b=KOQ9or1eaNWXQebbGmjexA5TX8 H7/IC1QIDKJZBjG1grbTuOhvpjAcuvOJMTQjNyaKyigsGgk/xV8ItJHlchpc0qPG/jVoasPaRPn1E 6Bd9YukWqDAqil9jEnCEz5g6JEn9GgNY0XmOEMJwfmwFbwwHBHJSWGWj5BQfmv+otrmYxQWkpGrzR 60WDTKvRjFIevyj+6Ac41cHZIRsek3Kgrzrv9pgQwezqrqjXWMBcbN62fKLQkq63tKoDjPtF8Axz3 j3y6lauTMvforDMHZfNKeBsp9Vm3fvwhUcK6ubpa9xPARzdJZCNh0SdSZJ1KWHHO49ZEH+frmjMAn ovNUHQkQ==; Received: from mail.zoner.fi ([84.34.147.244]) by www25.zoner.fi with esmtp (Exim 4.97.1) (envelope-from ) id 1tVnCx-0000000HD2x-138f; Thu, 09 Jan 2025 09:43:59 +0200 Date: Thu, 9 Jan 2025 09:43:58 +0200 From: Lasse Collin To: Paul Eggert Subject: Re: bug#75405: gzip --synchronous doesn't work with musl Message-ID: <20250109094358.7c4115e7.lasse.collin@tukaani.org> In-Reply-To: <20250108125055.02400809.lasse.collin@tukaani.org> References: <20250106152922.7641cc84.lasse.collin@tukaani.org> <20250107202256.6f38002c.lasse.collin@tukaani.org> <215637dd-6d21-4413-8eac-5fcf006aec63@cs.ucla.edu> <20250108125055.02400809.lasse.collin@tukaani.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/d5XZ_xdwlxDIdnKVF6m/ypD" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75405 Cc: 75405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/d5XZ_xdwlxDIdnKVF6m/ypD Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2025-01-08 Lasse Collin wrote: > On 2025-01-08 Paul Eggert wrote: > > On 2025-01-07 10:22, Lasse Collin wrote: > > > It could be useful to add a test for gzip --synchronous. > > > > Feel free.... > > Attached. It's based on z-suffix. Syncing is the same in compression and decompression modes, so it's reduntant to test --synchronous with both. Since my previous patch wasn't committed yet, I attached a patch that is three lines shorter. -- Lasse Collin --MP_/d5XZ_xdwlxDIdnKVF6m/ypD Content-Type: text/x-patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=test-synchronous2.patch RnJvbSBiOWUxNzdiNWVhMTBkZjkzNzczNjFkMzgxNTYzNmZjOTM1Nzc0N2JhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTGFzc2UgQ29sbGluIDxsYXNzZS5jb2xsaW5AdHVrYWFuaS5v cmc+DQpEYXRlOiBUaHUsIDkgSmFuIDIwMjUgMDk6MzU6NTggKzAyMDANClN1YmplY3Q6IFtQQVRD SF0gdGVzdHM6IHN5bmNocm9ub3VzOiBuZXcgdGVzdA0KDQoqIHRlc3RzL3N5bmNocm9ub3VzOiBU ZXN0IHRoYXQgLS1zeW5jaHJvbm91cyB3b3Jrcy4gVGhpcw0KZmFpbGVkIHdpdGggbXVzbCAxLjIu NSBiZWZvcmUgdGhlIEdudWxpYiBjb21taXQgMGZiMTg1YjdjZDVlDQooImZjbnRsLWg6IHBvcnQg YmV0dGVyIHRvIG11c2wgb24gR05VL0xpbnV4IikuDQoqIHRlc3RzL01ha2VmaWxlLmFtIChURVNU Uyk6IEFkZCBpdC4NCi0tLQ0KIHRlc3RzL01ha2VmaWxlLmFtIHwgIDEgKw0KIHRlc3RzL3N5bmNo cm9ub3VzIHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrKysrDQogMiBmaWxlcyBjaGFuZ2Vk LCAyOCBpbnNlcnRpb25zKCspDQogY3JlYXRlIG1vZGUgMTAwNzU1IHRlc3RzL3N5bmNocm9ub3Vz DQoNCmRpZmYgLS1naXQgYS90ZXN0cy9NYWtlZmlsZS5hbSBiL3Rlc3RzL01ha2VmaWxlLmFtDQpp bmRleCA0YzEwYTcxLi5kODZjZmIwIDEwMDY0NA0KLS0tIGEvdGVzdHMvTWFrZWZpbGUuYW0NCisr KyBiL3Rlc3RzL01ha2VmaWxlLmFtDQpAQCAtMjksNiArMjksNyBAQCBURVNUUyA9CQkJCQlcDQog ICBwaXBlLW91dHB1dAkJCQlcDQogICByZXByb2R1Y2libGUJCQkJXA0KICAgc3RkaW4JCQkJCVwN CisgIHN5bmNocm9ub3VzCQkJCVwNCiAgIHRpbWVzdGFtcAkJCQlcDQogICB0d28tZmlsZXMJCQkJ XA0KICAgdHJhaWxpbmctbnVsCQkJCVwNCmRpZmYgLS1naXQgYS90ZXN0cy9zeW5jaHJvbm91cyBi L3Rlc3RzL3N5bmNocm9ub3VzDQpuZXcgZmlsZSBtb2RlIDEwMDc1NQ0KaW5kZXggMDAwMDAwMC4u OWMwMzBjZQ0KLS0tIC9kZXYvbnVsbA0KKysrIGIvdGVzdHMvc3luY2hyb25vdXMNCkBAIC0wLDAg KzEsMjcgQEANCisjIS9iaW4vc2gNCisjIENoZWNrIHRoYXQgLS1zeW5jaHJvbm91cyB3b3Jrcy4N CisNCisjIENvcHlyaWdodCAyMDE0LTIwMjUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMu DQorDQorIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3RyaWJ1 dGUgaXQgYW5kL29yIG1vZGlmeQ0KKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkNCisjIHRoZSBGcmVlIFNvZnR3YXJl IEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yDQorIyAoYXQg eW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLg0KKw0KKyMgVGhpcyBwcm9ncmFtIGlzIGRp c3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQorIyBidXQgV0lU SE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0K KyMgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAg U2VlIHRoZQ0KKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4N CisNCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlDQorIyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2Vl IDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uDQorIyBsaW1pdCBzbyBkb24ndCBydW4g aXQgYnkgZGVmYXVsdC4NCisNCisuICIke3NyY2Rpcj0ufS9pbml0LnNoIjsgcGF0aF9wcmVwZW5k XyAuLg0KKw0KK3ByaW50ZiBhbnl0aGluZyA+IEYgfHwgZnJhbWV3b3JrX2ZhaWx1cmVfDQorZ3pp cCAtLXN5bmNocm9ub3VzIEYgfHwgZmFpbD0xDQordGVzdCAhIC1mIEYgfHwgZmFpbD0xDQordGVz dCAtZiBGLmd6IHx8IGZhaWw9MQ0KKw0KK0V4aXQgJGZhaWwNCi0tIA0KMi40Ny4xDQoNCg== --MP_/d5XZ_xdwlxDIdnKVF6m/ypD-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 10 13:19:42 2025 Received: (at 75405-done) by debbugs.gnu.org; 10 Jan 2025 18:19:42 +0000 Received: from localhost ([127.0.0.1]:58724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWJbh-0008Sa-PI for submit@debbugs.gnu.org; Fri, 10 Jan 2025 13:19:41 -0500 Received: from mail.cs.ucla.edu ([131.179.128.66]:56522) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWJbf-0008SI-4a for 75405-done@debbugs.gnu.org; Fri, 10 Jan 2025 13:19:40 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A162B3C12386D; Fri, 10 Jan 2025 10:19:32 -0800 (PST) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id Zdv6SK1WJrUP; Fri, 10 Jan 2025 10:19:32 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 6AFF23C12386E; Fri, 10 Jan 2025 10:19:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 6AFF23C12386E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1736533172; bh=htBdkizyxyiXNdgrWl6eTuNusKl97zPsceBPP1815HM=; h=Message-ID:Date:MIME-Version:To:From; b=U+cy0Ysl8K5fPeOrr654Q9A7nhYP6RFeifbLE7mITtFm02W9ek/0WDtyogcD/5FVN 4tLm7XeskR2itDzGE+M/91Oes2nOPOdPvS0AHriLsm0SzVODHUgt7OntM82nhfKdAf c5MAbbG9j+dSxrpOWwfoQHR4HtEOQrifmQF5L1rXCW8YEIh1HY+mmHCgwu4WUON9l5 1YqMT/zfnE8EWDJcA+R2p4m9peVqLciJOTuZ+UJQoCaM22VsW3ytYzK2q9U7rZ7vEB FKeT/10WMwJmnlDig+4m/DSeMl1y3nZ0PG5Vkc1xrweyJns10KJ0JKhnMVrwhr9aub 05QeqwIeWOieg== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id N7WL5VWO-9wZ; Fri, 10 Jan 2025 10:19:32 -0800 (PST) Received: from [192.168.254.12] (unknown [47.154.28.214]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 4DF0D3C12386D; Fri, 10 Jan 2025 10:19:32 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 10:19:32 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#75405: gzip --synchronous doesn't work with musl To: Lasse Collin References: <20250106152922.7641cc84.lasse.collin@tukaani.org> <20250107202256.6f38002c.lasse.collin@tukaani.org> <215637dd-6d21-4413-8eac-5fcf006aec63@cs.ucla.edu> <20250108125055.02400809.lasse.collin@tukaani.org> <20250109094358.7c4115e7.lasse.collin@tukaani.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <20250109094358.7c4115e7.lasse.collin@tukaani.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75405-done Cc: 75405-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks, I installed that test. Marking this gzip bug as done. From unknown Thu Aug 14 12:25:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Feb 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator