From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 07:57:44 2025 Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 12:57:44 +0000 Received: from localhost ([127.0.0.1]:37152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUmfv-0002PN-Us for submit@debbugs.gnu.org; Mon, 06 Jan 2025 07:57:44 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38364) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUmfs-0002PA-TY for submit@debbugs.gnu.org; Mon, 06 Jan 2025 07:57:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUmfn-0003l5-Bu for guix-patches@gnu.org; Mon, 06 Jan 2025 07:57:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUmfn-0001VJ-0r; Mon, 06 Jan 2025 07:57:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=mGTCHfSg1gZJRnQIY6Hagw+hr9YrgeBwILNs4nj/A7c=; b=abSngXVh/YK860 AvW9iqaZ/NuQCfxt59jmG2VpFGlZOrBViWgta0Z0uN1BiQU7ASXcbOXy+yVIZ69cPElm/syuBkr66 mktk7SRvdtFO+TY68CuZeYKpdf3+/bNj3wZW0prQCtpaSzQq0VZbq4/kGReat6rj1c4bXXgBdYQ6V g5hyeSqD2e6R3+/ZcAy+PV+X8ni0XMZIqHIHBkVKjCOeuyXlxkHC0IX66fZ7Fo9cNt2gaYljKRWBX IqMc9ZP7bGVzi1RRVvuSpXFm+pbJj9ghI97B4bQnHkkuC/5pscA5w1EgbhUCpymVAQ82Y9BlOJKAP OHl3BPfDa8iBcXHL4u/g==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/3] Assorted kexec fixes Date: Mon, 6 Jan 2025 13:57:22 +0100 Message-ID: X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Here’s a bunch of kexec-related fixes for bugs that have been reported over the past week. I checked the ‘kexec_file_load’ binding on i686 and aarch64 this time: it’s definitely missing on i686, and alright on aarch64. I’d like to commit it within a couple of days at most. Feedback welcome! Ludo’. Ludovic Courtès (3): reconfigure: Do not pass KEXEC_FILE_DEBUG. syscalls: Remove wrong syscall ID for ‘kexec_load_file’ on i686. reconfigure: Make ‘load-system-for-kexec’ errors non-fatal. guix/build/syscalls.scm | 6 ++--- guix/scripts/system/reconfigure.scm | 38 +++++++++++++++++++++++------ tests/syscalls.scm | 8 +++--- 3 files changed, 38 insertions(+), 14 deletions(-) base-commit: 6cb47c374469f7c26775520540e1ed79a8bff674 -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 07:59:03 2025 Received: (at 75402) by debbugs.gnu.org; 6 Jan 2025 12:59:03 +0000 Received: from localhost ([127.0.0.1]:37164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUmhC-0002SX-BV for submit@debbugs.gnu.org; Mon, 06 Jan 2025 07:59:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55170) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUmh9-0002S9-5e for 75402@debbugs.gnu.org; Mon, 06 Jan 2025 07:59:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUmh2-0001cw-VR; Mon, 06 Jan 2025 07:58:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=96Shrag1sZeLh4FLtsUKMKIT1KpvwigDVDM+og1ADXE=; b=KX1l5P0mr/wFI7ZSlvxz S5+ht/ghYHBFTZ2rDsacfvfza6kt3CqviO2Dthf4y1wEIs5Q/cGD0ks1d7FAOSVMzWMiYzqh+NbaM 9FfTpYobUWcjVMPeyJodJB7QI7K9anIAnEaByRRtLaNfYQTUcJK6/OvVA6Dtkf/umOnOEFAl8Ot8S +lyk6G1gzHDOhxrzqf2heQ9ZKPxaquKppt1JrHo1WH3qZ4CM2xjS1iE6x367G9G1jgvSLuq+BWEiH 8ebXMZLvBPeXzYGn63u/uW2HtVsvlOCkVMnxcbWbHthkIpfYkyA8G7KBmbE3KoXOJxFVhHMxkNodb xgexnRr64bRsiw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 75402@debbugs.gnu.org Subject: [PATCH 1/3] reconfigure: Do not pass KEXEC_FILE_DEBUG. Date: Mon, 6 Jan 2025 13:58:35 +0100 Message-ID: <5c693e7d8bec42c1430bf9de00b8b408f38c6d39.1736168030.git.ludo@gnu.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75402 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= , nathan , =?UTF-8?q?Simen=20Endsj=C3=B8?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This flag is unsupported in Linux 6.6 and causes ‘kexec_file_load’ to fail with EINVAL. Fixes . * guix/scripts/system/reconfigure.scm (kexec-loading-program): Remove KEXEC_FILE_DEBUG. * guix/build/syscalls.scm (KEXEC_FILE_DEBUG): Add comment. Suggested-by: nathan Reported-by: Simen Endsjø Change-Id: Ia48be7f4cfa9c6352908e4bea6472cd648f866ed --- guix/build/syscalls.scm | 4 ++-- guix/scripts/system/reconfigure.scm | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index 960339e8bf..0f8927844b 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2014-2024 Ludovic Courtès +;;; Copyright © 2014-2025 Ludovic Courtès ;;; Copyright © 2015 David Thompson ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2017 Mathieu Othacehe @@ -783,7 +783,7 @@ (define (string->utf-8/nul-terminated str) (define KEXEC_FILE_UNLOAD #x00000001) (define KEXEC_FILE_ON_CRASH #x00000002) (define KEXEC_FILE_NO_INITRAMFS #x00000004) -(define KEXEC_FILE_DEBUG #x00000008) +(define KEXEC_FILE_DEBUG #x00000008) ;missing from Linux 6.6 (define kexec-load-file (let* ((proc (syscall->procedure int "syscall" diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm index e9e16e3422..96e5bff351 100644 --- a/guix/scripts/system/reconfigure.scm +++ b/guix/scripts/system/reconfigure.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2014-2022, 2024 Ludovic Courtès +;;; Copyright © 2014-2022, 2024-2025 Ludovic Courtès ;;; Copyright © 2016 Alex Kost ;;; Copyright © 2016, 2017, 2018 Chris Marusich ;;; Copyright © 2017 Mathieu Othacehe @@ -198,8 +198,7 @@ (define (kexec-loading-program os) (kexec-load-file kernel initrd (string-join (list #$@(operating-system-kernel-arguments - os root-device))) - KEXEC_FILE_DEBUG))))))) + os root-device)))))))))) (define* (upgrade-shepherd-services eval os) "Using EVAL, a monadic procedure taking a single G-Expression as an argument, -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 07:59:05 2025 Received: (at 75402) by debbugs.gnu.org; 6 Jan 2025 12:59:05 +0000 Received: from localhost ([127.0.0.1]:37166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUmhF-0002Sx-1a for submit@debbugs.gnu.org; Mon, 06 Jan 2025 07:59:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55186) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUmh9-0002SC-Ub for 75402@debbugs.gnu.org; Mon, 06 Jan 2025 07:59:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUmh4-0001d7-Jh; Mon, 06 Jan 2025 07:58:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=McSLnnb/ZR6MiR5MUGIfVjrDgle3UGjmMP0bdeGOTJQ=; b=ccn+2OFNp5GJI5lbI+29 FRIufsJ8X05hn4sQopN7N/otzozAbR+/sQ+SS1Y6fn0e2FHgyxyS+6Uv4jPuwaMGETZBPI+OeA6gI OGSHiTsbiARtRS3Z2TDUsVU3xawDUB7OK9r/cIqmlrSHRD/0fCj9B81CP/03M/m/MKRYKLBIsiCJc d9brErJHr7LqbX+EzCLjZCPYk6ovAz6dwdYIkKnYvpi4pVYb2LccSkp5a/FbTqe/JRJlqr71xZkjA aDIg40MxA5jxs5Bl88R5h9hFBh7kluJ4s68ZKVxy9it2xYm+CngiaTCXywlkUOYm+F96B3h0yIGeE acwtrh7l07ptIg==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 75402@debbugs.gnu.org Subject: [PATCH 2/3] =?UTF-8?q?syscalls:=20Remove=20wrong=20syscall=20ID?= =?UTF-8?q?=20for=20=E2=80=98kexec=5Fload=5Ffile=E2=80=99=20on=20i686.?= Date: Mon, 6 Jan 2025 13:58:36 +0100 Message-ID: <6062eaed018a8c738577dbb699d7e0324a4f8746.1736168031.git.ludo@gnu.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75402 Cc: Dariqq , =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Fixes . * guix/build/syscalls.scm (kexec-load-file): Remove syscall ID for i686. * tests/syscalls.scm ("kexec-load-file"): Accept ENOSYS in addition to EPERM. Reported-by: Dariqq Change-Id: I83fe25636addb57533ed88cbfb40107d265b13a7 --- guix/build/syscalls.scm | 2 +- tests/syscalls.scm | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index 0f8927844b..7e16452462 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -794,8 +794,8 @@ (define kexec-load-file '* ;cmdline unsigned-long))) ;flags (syscall-id (match (utsname:machine (uname)) - ("i686" 320) ("x86_64" 320) + ;; unsupported on i686 ("armv7l" 401) ("aarch64" 294) ("ppc64le" 382) diff --git a/tests/syscalls.scm b/tests/syscalls.scm index eef864d097..d2848879d7 100644 --- a/tests/syscalls.scm +++ b/tests/syscalls.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2014-2021, 2024 Ludovic Courtès +;;; Copyright © 2014-2021, 2024-2025 Ludovic Courtès ;;; Copyright © 2015 David Thompson ;;; Copyright © 2020 Simon South ;;; Copyright © 2020 Mathieu Othacehe @@ -682,15 +682,15 @@ (define perform-container-tests? (when (or (zero? (getuid)) (not (string-contains %host-type "linux"))) (test-skip 1)) -(test-equal "kexec-load-file" - EPERM +(test-assert "kexec-load-file" (catch 'system-error (lambda () (let ((fd1 (open-fdes "/dev/null" O_RDONLY)) (fd2 (open-fdes "/dev/null" O_RDONLY))) (kexec-load-file fd1 fd2 "gnu.repl=yes"))) (lambda args - (system-error-errno args)))) + (member (system-error-errno args) + (list EPERM ENOSYS))))) (test-end) -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 07:59:10 2025 Received: (at 75402) by debbugs.gnu.org; 6 Jan 2025 12:59:10 +0000 Received: from localhost ([127.0.0.1]:37170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUmhJ-0002TJ-EW for submit@debbugs.gnu.org; Mon, 06 Jan 2025 07:59:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50800) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUmhH-0002SY-E9 for 75402@debbugs.gnu.org; Mon, 06 Jan 2025 07:59:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUmhC-0001dj-5p; Mon, 06 Jan 2025 07:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=T9xxGeO4xRkvWjUVaQbFT2D8Ty5il3JsrW87kTrL6xM=; b=jQCmKIEeSG7y9Txz1dE6 4Cr3OcdzuDEwOlRT73Xz/zhgj/PBfv8bFIGl9U5RICqDHTqoxvBJ8PNn88TDjmVolLoJFuMZiuwmo qx8JnsqHqt4DUnT8yXRuwDTj8qOOlpftulkzglLax8O0b5IAttS1tObRhM4vc3KBC7byyShl6tuYa m6OAEzzXmwNHWEXa3TG8XIyAwVzoytQPgwnqWtSms0Z1uUg7Cd5cZtJRHraUukfH7lRDUXkGbVq/4 f8kluzvLLZNxuWajRR6/RFDAPicHL79NatnQKJIhKAJFcBKsMGwIPwxl77/zqYJlq8o0uP7CzuWO8 9kzK+s6ehIQJjg==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 75402@debbugs.gnu.org Subject: [PATCH 3/3] =?UTF-8?q?reconfigure:=20Make=20=E2=80=98load-system-?= =?UTF-8?q?for-kexec=E2=80=99=20errors=20non-fatal.?= Date: Mon, 6 Jan 2025 13:58:37 +0100 Message-ID: <7b6998df5bf49154493079c304e2362eb102b57c.1736168031.git.ludo@gnu.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75402 Cc: Luis Guilherme Coelho , =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Partially fixes . * guix/scripts/system/reconfigure.scm (load-system-for-kexec): Catch exceptions in the gexp. Report them outside. Reported-by: Luis Guilherme Coelho Change-Id: Iebcdc92e29b8623a55967d58a4f353abab01631a --- guix/scripts/system/reconfigure.scm | 33 +++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm index 96e5bff351..d35980590d 100644 --- a/guix/scripts/system/reconfigure.scm +++ b/guix/scripts/system/reconfigure.scm @@ -230,10 +230,35 @@ (define* (upgrade-shepherd-services eval os) to-restart))))))) (define (load-system-for-kexec eval os) - "Load OS so that it can be rebooted into via kexec, if supported. Return -true on success." - (eval #~(and (string-contains %host-type "-linux") - (primitive-load #$(kexec-loading-program os))))) + "Load OS so that it can be rebooted into via kexec, if supported. Print a +warning in case of failure." + (mlet %store-monad + ((result (eval + #~(and (string-contains %host-type "-linux") + (with-exception-handler + (lambda (c) + (define kind-and-args? + (exception-predicate &exception-with-kind-and-args)) + + (list 'exception + (if (kind-and-args? c) + (call-with-output-string + (lambda (port) + (print-exception port #f + (exception-kind c) + (exception-args c)))) + (object->string c)))) + (lambda () + (primitive-load #$(kexec-loading-program os)) + 'success) + #:unwind? #t))))) + (match result + ('success + (return #t)) + (('exception message) + (warning (G_ "failed to load operating system for kexec: ~a~%") + message) + (return #f))))) ;;; -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 05:41:55 2025 Received: (at 75402) by debbugs.gnu.org; 7 Jan 2025 10:41:55 +0000 Received: from localhost ([127.0.0.1]:41869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tV722-0007fy-T4 for submit@debbugs.gnu.org; Tue, 07 Jan 2025 05:41:55 -0500 Received: from wolfsden.cz ([37.205.8.62]:42668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tV720-0007fj-9i for 75402@debbugs.gnu.org; Tue, 07 Jan 2025 05:41:53 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id AECC435DC98; Tue, 7 Jan 2025 10:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1736246510; bh=OnPHuLZzv5XN0mkWB/WtUUWygDFX7AGNnIYZYr+JMpQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=eujMmEa2Qceleu5Eb5FunqEZXHzQ2cyX8o6r+Gh+XZclN298xfG4s1/NwXmfWETCX Zoj6ElVr8cAeJHgk6InqEAFC+EyKbrjKxHyLRZYLZ3rzBSlE9r+NxD/04+0VIbILli YoQSkrw/8VbUWZidZOffsDmvxjCoKsVaEGMMcc40OxzmQ6DBzJFzxElPRfgUT2Dt2D qj/FCBRECZ8JbRZa7sUULymso78lVw+R0A/uKoDrzaB7LvpLUeLI1kras+uvQxCAtQ J6wsR+rtPOKHceSlTlARTim1/DxU4H50kNLCrhI+E60tdLyTkTKLCVO7LlwuLMBYlz zJC8ZbTX8626m+Oj1wfibPVSWQXwfICBk6M8yngj1Mfx4wxsNmSwWP99Lt1XASjvdc CgNB/R7Y8yOzaezyg/i2jR/TWwBtZu7ppysoil1djG9Rh4HoBaEyrmAA9rUf6PSEL4 gZM7oWwB6YOKa7OGbTsgJ0dAS/DkE7G0Q41706CCbCRcm+qwN9nsglAssci5COlQKo vkxopKgaPDQz0M7PtV69UUVdxwBJ35YS8w0VBRPp3J4R4abZFkJMUUmBZQ2LVNDDLG +uFc1SUi1XFLZ6A3b6gRggBJd7ReaFOekSF55liCyshAgZhRSNgj6//Xb+5NZs6ZcC MqfxXEhjBXIW1zL1unE9PO2A= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [193.32.127.135]) by wolfsden.cz (Postfix) with ESMTPSA id 02C4C35DA19; Tue, 7 Jan 2025 10:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1736246505; bh=OnPHuLZzv5XN0mkWB/WtUUWygDFX7AGNnIYZYr+JMpQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Ap7o39TA8Vxde1hAsfanjQ6jCyR9aj+52kQs7XfWwRO658YkbNykQV2RXEF9y+2J3 TK7Lgd1ttRy9IwYYev7zzQZW2xdfCAmJXDOLGv0p4Si1Z6RbMVvNQ+S6WPoeaqFyKR /U6T8mmbaBefp8Z/CLjrX3fZ1t5Ji9T3zwSiwK5uaDzbru2TG4tiiUcvg263qoa7Xi Vio6DVdMW27wmct6NDX8/pvmVvdBumS51dmLx6nYyoXtKLGn+myFWnyHYdJF/haWp1 LO+I9x/YA/PiAkoX6NMpaMeeeFgYvotwoJfEY7MAoR189boudtRDZRM4aucytQJRhS oMyvZW8BFZXhS+7HddYFKolGpgGG93Hr3mYUIc9JNIpREP7s8ux0S0fI7Z4JX+5/7Q kI+3jqEbpZAZ4r+KfclLH4+aPDySCgq75UujzQ4QeJSkm26KrE8OwdEH4YQzD7ljjD JNdGoUBztnxjbvcUvbu5ICLDuoX5VJ02uNLUVdCm5YMNC2ziJ0GjT3VliREqW7casf ooT7X7yCN0AV8HmBVJzKD7cJi2DgULHuKm8oX2PleJKsRgHfv5s8Gs7z5ZPh39uig5 PWua+3CLgc80NljUpKzAUPIMJ7AWMUYZ/2k81mOKZhebO74saoPbR8Gs0sZuskaSJm VJIPvxvyR7WYymliy+UpV6hQ= From: Tomas Volf <~@wolfsden.cz> To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#75402] [PATCH 0/3] Assorted kexec fixes In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Mon, 6 Jan 2025 13:57:22 +0100") References: Date: Tue, 07 Jan 2025 11:41:43 +0100 Message-ID: <87cygyucrc.fsf@wolfsden.cz> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75402 Cc: Josselin Poiret , Simon Tournier , 75402@debbugs.gnu.org, Tobias Geerinckx-Rice , Mathieu Othacehe , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello, > > Here=E2=80=99s a bunch of kexec-related fixes for bugs that have been rep= orted > over the past week. > > I checked the =E2=80=98kexec_file_load=E2=80=99 binding on i686 and aarch= 64 this time: > it=E2=80=99s definitely missing on i686, and alright on aarch64. > > I=E2=80=99d like to commit it within a couple of days at most. Feedback > welcome! While I am hardly an expert here, the changes look reasonable. One feature request though. I think it would be nice to get --no-kexec for guix-deploy as well :) > > Ludo=E2=80=99. > > Ludovic Court=C3=A8s (3): > reconfigure: Do not pass KEXEC_FILE_DEBUG. > syscalls: Remove wrong syscall ID for =E2=80=98kexec_load_file=E2=80=99= on i686. > reconfigure: Make =E2=80=98load-system-for-kexec=E2=80=99 errors non-fa= tal. > > guix/build/syscalls.scm | 6 ++--- > guix/scripts/system/reconfigure.scm | 38 +++++++++++++++++++++++------ > tests/syscalls.scm | 8 +++--- > 3 files changed, 38 insertions(+), 14 deletions(-) > > > base-commit: 6cb47c374469f7c26775520540e1ed79a8bff674 =2D-=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmd9BOcOHH5Ad29sZnNk ZW4uY3oACgkQL7/ufbZ/wanS+A/8CFuYSw7yihIJ/x4Qa2UT7lNWNcDnGPjAw6CB mbC3/ab43IqvENPdWj51VBi1wAfwsy8P9SSOfvrPUPqItYchvXSVNGU7aTXEVFak lb+LTOqZroS/3j8ljGAOuyB4M+cpVIPZiMEDxm7mS3rsv/3d4hcg/bYuxVKYhNJV fLUQA418hn6/CJDBWv3aSxjiKOzAamSolpPwS0JzhIpaegUHFgwrr7sO+B8GhIYO wAWHlrGrrVO0psBIxR0hQ6AO0PSqm2M1CN2EqFgpJDZN97Ix2Y/C6Ty8bXx1sSNX RDjphHrK0rcmcXEVXY+rgSJfmL2BkEOumSJ9I2QnVaZBn+2s5IeiG75s5stg3ahz 4ivkMrMLcXMijpUD5cLQSAYjTD2UTBGeZTLzysNueGfSm0i1wus5mtw4TKnop0lD 1j6yu0UOMUv20imodhWkkS5BZZQsgl+cTfy/tzAGxtv60G7tlZGHo5ILhFtez7Ui oszx24Hn3qXO9+PnaeYdtxsbFQspIjhdSYByI7O2rgSt0JNulhDiwlZRPvw4tf1x TtJQ6z1nV1PHrNhGGmaCbMTJ9DkzoZPjpgajtqrwLy35MG5iwS7Z3mC+8Rr6uBcK uPoaEg9GdkDOWLevTQwrfd+V00u0GYKNCQgzGOiMzczUKn6y+CdgQtzTrT6WBD0R qx5gek8= =SI76 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 05:48:32 2025 Received: (at 75402) by debbugs.gnu.org; 7 Jan 2025 10:48:32 +0000 Received: from localhost ([127.0.0.1]:41879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tV78R-0007yj-O7 for submit@debbugs.gnu.org; Tue, 07 Jan 2025 05:48:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50680) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tV78O-0007yV-BL for 75402@debbugs.gnu.org; Tue, 07 Jan 2025 05:48:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tV78H-0006Cu-Gx; Tue, 07 Jan 2025 05:48:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=sgJ+On4uDeWLIMpRnVWfuinxsrObhXmDZB2cKQTmhxI=; b=gy8OFaP75A11sP1rUL5O I0eJneI48Ln69V49w7dAjRr3v0SQu6LB2A5q9mggylU8yqVGu+pihohnVBw/WG4DpGv+ukSqybdcr 4+ivCwQjktzeAxpjAKB0GYNaU4VlC49UI7Yz+gLkqT+kCa2FwV15ehVXLvKhoDV74er/xWHmWDJgF SKyb8twyfUln5GG2X3EdHr2wyZFiL2cQ35C0FP8spWHR8OSL4Z1H4PSCpu5Wef5i6uuAWKL0FCKxa 3WVpWXBN2+fcfBhvEqx3XyzIv7rus55QCMWIIFrJnYqp6AMwWsusQfeTkKWvQrVk0UwPdlIbMVwsZ wplgR95kykEFxQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tomas Volf <~@wolfsden.cz> Subject: Re: [bug#75402] [PATCH 0/3] Assorted kexec fixes In-Reply-To: <87cygyucrc.fsf@wolfsden.cz> (Tomas Volf's message of "Tue, 07 Jan 2025 11:41:43 +0100") References: <87cygyucrc.fsf@wolfsden.cz> Date: Tue, 07 Jan 2025 11:48:18 +0100 Message-ID: <87r05e293h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75402 Cc: Josselin Poiret , Simon Tournier , 75402@debbugs.gnu.org, Tobias Geerinckx-Rice , Mathieu Othacehe , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tomas Volf <~@wolfsden.cz> skribis: > Ludovic Court=C3=A8s writes: > >> Hello, >> >> Here=E2=80=99s a bunch of kexec-related fixes for bugs that have been re= ported >> over the past week. >> >> I checked the =E2=80=98kexec_file_load=E2=80=99 binding on i686 and aarc= h64 this time: >> it=E2=80=99s definitely missing on i686, and alright on aarch64. >> >> I=E2=80=99d like to commit it within a couple of days at most. Feedback >> welcome! > > While I am hardly an expert here, the changes look reasonable. Cool. > One feature request though. I think it would be nice to get > --no-kexec for guix-deploy as well :) Good point. I=E2=80=99m not sure where to put it though. In ? Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 05:58:22 2025 Received: (at 75402) by debbugs.gnu.org; 7 Jan 2025 10:58:22 +0000 Received: from localhost ([127.0.0.1]:41892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tV7Ht-0008Uh-Ry for submit@debbugs.gnu.org; Tue, 07 Jan 2025 05:58:22 -0500 Received: from wolfsden.cz ([37.205.8.62]:40528) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tV7Ho-0008UQ-8I for 75402@debbugs.gnu.org; Tue, 07 Jan 2025 05:58:17 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 620DA35C17B; Tue, 7 Jan 2025 10:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1736247490; bh=qp2fylb35WolnGBDcXnr9SNjyJtinPEF94B6DekWAcA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=YJulGNnw59JkbnbrVqoUl67Z3ctMZOLKEgfOqcVNXCvQaDShtGgCRuf4EVTvONWOL 9z8YmcK2J0YPx3EObotM8tNTXwAmo6S/8XLvRH5ESxsdR0OG6WWAG8k1UoNtPIIzpU kK5r/YgQpQJLUKE5LbBGUmr9F5zGhzgko7qYPfBEWbyiasIa0Xv+qatkZMvL6fT+T3 ibMmVTx/DMGoOYpXiZrR+NAumDhTIqk6N0gAGvwrXxtBe5E/Brh0gc11j8lfMwVg4t DIvpK/O1yiv+2wqgyvfXmfKev8eSIp4WsCdTrTd+DmTCGy/q4SG6LPAm+FDvrVteTT 15TpcVcWN7XSkP0/7a8Sap5jboFkQpZV+JJVYkLO80LFC6YrqnLx6Nnn1l1kM6F2zl vAW6b9in8PzqoBUNEQFUD5q+0q0GJHZkFlcv99Bjwz/t9dgtuyrf88KXAQctV/M9+3 ZIggtmqcOfhOs+GPpWlQMgz+OyaY/HtLPZLLE8yLxKUNKqz9SlE9/hApthjFWRhh13 A6sT33d86kPEpd7VtH/xTCqH2oCejfAjwmRtK1fUYHmW5QUOCP82IOqh9yjqyjt3Zo AysqEALAIakxrI/NtIOVQY4ZvucpkwxtGrlAbHtUbcrx1LwHXSfwgcO9l0aufSxvXs 75leBl5L8ufIPKZLW5PM2IyE= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [193.32.127.135]) by wolfsden.cz (Postfix) with ESMTPSA id 5485C35CBDF; Tue, 7 Jan 2025 10:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1736247484; bh=qp2fylb35WolnGBDcXnr9SNjyJtinPEF94B6DekWAcA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ds7V3ixItlbW5G9cGMzk9idi1wZiXf9IgnIG8A3/k91MCLwcAsKqy+OvmHfzcCfE2 xR1NCAyMVBxn839Vt3fUqsiDWd7O9Ia/4ZUBNyucBb2T/D6bJLbtkFb0meevJXK5j6 AuehWmE7d3qJsaa/SQzFpOg1nMMONpLaHhRn/E+R06+DxRqS2mytYTxyS639mHoWjZ kg7k/SnkZbangkmjn8xKn7ivMrIoJ/X2vdE9NaBePPQhznwLs6iLBvUfp8AKCfLuKu jnGjrl59BzFMHJ4QFQFmhA6wguxvvdr35RGqMf0xcZ00z/BBmCJ7xbvzoVxnMKZILn t0HSBMXkXokJ4qLqxeaHXumO8rXSqbME2jU6Pg0v5J+5+qPkPNFTgnwUR6Kf8Il4J5 vlGjozrzH31BtbAWh48zflEG/AwG2UTZgtm2gqqnkQQm/VWJuZhp+OKBIDXBJ3mfov m9+t4jH+MMTTMnnJHI7YodGL8sMzGK5sad8kNsPljFj0YiOnoPyEJ2fP0p0rWlJdMH k+GKAvPFsAHIm+uC8HZCy4sxaVnqauIESMhk27GEp2ShWuGVnhol9JLx9hVmrYuPHJ u+oXINZI/Ov0dP1rMDmw3cE4g2qcPrLVH9e8PL5eh73c+zqQsZmThSLjRUhnvM6pUZ CuhqrqB5WKRhyjg6WdzCtZl0= From: Tomas Volf <~@wolfsden.cz> To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#75402] [PATCH 0/3] Assorted kexec fixes In-Reply-To: <87r05e293h.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 07 Jan 2025 11:48:18 +0100") References: <87cygyucrc.fsf@wolfsden.cz> <87r05e293h.fsf@gnu.org> Date: Tue, 07 Jan 2025 11:58:02 +0100 Message-ID: <874j2auc05.fsf@wolfsden.cz> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75402 Cc: Josselin Poiret , Simon Tournier , 75402@debbugs.gnu.org, Tobias Geerinckx-Rice , Mathieu Othacehe , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Tomas Volf <~@wolfsden.cz> skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Hello, >>> >>> Here=E2=80=99s a bunch of kexec-related fixes for bugs that have been r= eported >>> over the past week. >>> >>> I checked the =E2=80=98kexec_file_load=E2=80=99 binding on i686 and aar= ch64 this time: >>> it=E2=80=99s definitely missing on i686, and alright on aarch64. >>> >>> I=E2=80=99d like to commit it within a couple of days at most. Feedback >>> welcome! >> >> While I am hardly an expert here, the changes look reasonable. > > Cool. > >> One feature request though. I think it would be nice to get >> --no-kexec for guix-deploy as well :) > > Good point. I=E2=80=99m not sure where to put it though. In > ? I am asking for a command line argument. Not sure if that does answer the question. I am not familiar enough with this part to suggest how to wire the option through the program flow. On a separate note, if we would want to disable the kexec in the definition, I feel like operating-system would be the most fitting place. Reason being that either I want to kexec the specific system or I do not want to kexec it. But I would expect that to rarely correlate with the deployment method. Sometimes I reconfigure the system via guix-deploy, sometimes (when I break the networking) via guix-system-reconfigure from USB drive, and it would seem to make sense to have kexec behave the same way for both of the approaches. > > Thanks! > > Ludo=E2=80=99. =2D-=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmd9CLoOHH5Ad29sZnNk ZW4uY3oACgkQL7/ufbZ/wamTuRAAs/D2aRXocKxWM25vuf2kUMiJb4Xx5Y7WVG5N lfSpqYM9GgaPS/+e4/HIGc0K+TFYv211WjgyDuuqfMJ4iEg5xRPhpa27qQmdl2qt UdDQCuyKnUGwossviuyQlrLogsXi3qDefrPumPU6zzqTZVoCK6UtUlHBWk8Secb4 UjPhirDRHLJu/cvCHbFhz3d2EG6GsGAlnqjGv4OmD5pnL0BJp8hkakOIE1sAL0pu vQwmzRpRbmbVxEnWC2qjj2g/1920b9h/2qA8eSBlByYtZm28EIq4mNmC+Q9cluSd oH8anS/BfAPbDTPxki5OZWOclqFfqwd5o+PRJ9nFy2uWNAQveXMk7/pMEgyYELOl RgyO5ucdPxkXtkeZftXQXwQXzyyBe9BPrbmwrFb0mGwnhMD17fIQfBIC9jda3mF0 uzSOFPTpGqZI6ZTveJz8cJ6M3RyoDWkWnUcnhBp1y2gtssL2Fhj/WTjYhvOCAdJE 06SQYeF3ZXpR+Ftx72pTCpik2SoyVkVIcxNHd5JC6TdGdO/MP0GbUnUcnDOl6byP 4ISKqQn9Vo11j085rkFdV2KwRda19tp5MFFPzcAi/ZjAJjnw2q4+l9pd+SDFKqKN K44WmJ0uAlsm0WioF4041c9tYWxAYCZAqm0se4UNvqLwEmxjtE+t5Td9BdVB1Lj2 SCKWCsE= =b23K -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 13:08:41 2025 Received: (at 75402-done) by debbugs.gnu.org; 7 Jan 2025 18:08:41 +0000 Received: from localhost ([127.0.0.1]:44556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVE0O-00058Q-MR for submit@debbugs.gnu.org; Tue, 07 Jan 2025 13:08:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41206) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVE0M-00057y-UR for 75402-done@debbugs.gnu.org; Tue, 07 Jan 2025 13:08:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVE0H-0007Ee-8A; Tue, 07 Jan 2025 13:08:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=LPep49fUUzKN1huwSZFCyMmg1i0MNiURG+6BZMnwjcs=; b=Qf0P5O4A2pakbS/z3utj tQsAOplX0WVPtPiKlaFsNdK1p+QTNcGKJh43tKpwYxWjImekNmJpLBR291iNIyHM8GivUtPGI2Yk2 D/4GtMNR7YAUjtilApYmTCe2ZCl0dsfRrp61EG/6lU269rcKZ5PsEJKDlUaMIr+0NiOcBRpM1YdGa qjGukMpZJ/vm6Cqt435dItcltSo6nlG2l5gle4EWHNN5O31kUE44iIX/RpndJiX6RTf1EmoDi2AMT v3LhuM+x8sm3L67QuFw54EM6lT0d2pqbmuJhXVGHLU37txqTKz5gu26t7C255P6WoslmER2rUjLVO lvx9siDMPA/ejA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tomas Volf <~@wolfsden.cz> Subject: Re: [bug#75402] [PATCH 0/3] Assorted kexec fixes In-Reply-To: <87r05e293h.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 07 Jan 2025 11:48:18 +0100") References: <87cygyucrc.fsf@wolfsden.cz> <87r05e293h.fsf@gnu.org> Date: Tue, 07 Jan 2025 19:08:29 +0100 Message-ID: <875xmqzeci.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75402-done Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Christopher Baines , 75402-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pushed: a6642650a7 * reconfigure: Make =E2=80=98load-system-for-kexec=E2=80=99 er= rors non-fatal. 410a359d4a * syscalls: Remove wrong syscall ID for =E2=80=98kexec_load_fi= le=E2=80=99 on i686. d8b7259197 * reconfigure: Do not pass KEXEC_FILE_DEBUG. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 13:12:58 2025 Received: (at 75402) by debbugs.gnu.org; 7 Jan 2025 18:12:58 +0000 Received: from localhost ([127.0.0.1]:44573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVE4Y-0005Q6-0s for submit@debbugs.gnu.org; Tue, 07 Jan 2025 13:12:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37086) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVE4V-0005Pk-Aj for 75402@debbugs.gnu.org; Tue, 07 Jan 2025 13:12:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVE4P-0007mt-2G; Tue, 07 Jan 2025 13:12:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rAhJn8iI1HYpFAN1amiwSnRbzY+1aH/fTKVwHBFXv7w=; b=aTdVemoK75Ul8FGyYbtO W49DTeapQaqDRiD6IoRxuw8L1XXGareS3NqVUvX0LShtax1Vqgxo/1dCZsEJdAYFj60a1PA03yzb1 Fm033L+PgldorDpgpAxd7yk+cqGutQxYzu2QqGoBjazOD5a9pOojzSnqRUv+YZg60cJxd0gVks3GV Xag4QO/rpnejHuhg/7lkrE0jVXqrQFB6bZbnxaTtP/lV2k4WAt0N30oUKBneRXSNw6dRn4JwEfJfL ecDqmrMCbar0zKeMNjMIVNF6lNk4fczTrsCF51QnNwZtrETvUBDl6tpZH4CNWCVocZFb7YkAgWcd3 jXdkHe3ooaQe6g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tomas Volf <~@wolfsden.cz> Subject: Re: [bug#75402] [PATCH 0/3] Assorted kexec fixes In-Reply-To: <874j2auc05.fsf@wolfsden.cz> (Tomas Volf's message of "Tue, 07 Jan 2025 11:58:02 +0100") References: <87cygyucrc.fsf@wolfsden.cz> <87r05e293h.fsf@gnu.org> <874j2auc05.fsf@wolfsden.cz> Date: Tue, 07 Jan 2025 19:12:43 +0100 Message-ID: <87v7uqxzl0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75402 Cc: Josselin Poiret , Simon Tournier , 75402@debbugs.gnu.org, Tobias Geerinckx-Rice , Mathieu Othacehe , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Tomas Volf <~@wolfsden.cz> skribis: >>> One feature request though. I think it would be nice to get >>> --no-kexec for guix-deploy as well :) >> >> Good point. I=E2=80=99m not sure where to put it though. In >> ? > > I am asking for a command line argument. Not sure if that does answer > the question. I am not familiar enough with this part to suggest how to > wire the option through the program flow. The reason I was suggesting this is that authorize?, allow-downgrades?, safety-checks? are already part of . These cannot really be a command-line option=E2=80=A6 for reasons that escape me = right now. :-) But anyway, I thought we=E2=80=99d be in the same situation here. > On a separate note, if we would want to disable the kexec in the > definition, I feel like operating-system would be the most fitting > place. Reason being that either I want to kexec the specific system or > I do not want to kexec it. But I would expect that to rarely correlate > with the deployment method. Sometimes I reconfigure the system via > guix-deploy, sometimes (when I break the networking) via > guix-system-reconfigure from USB drive, and it would seem to make sense > to have kexec behave the same way for both of the approaches. Hmm I see. The way I saw it, kexec loading is a bonus that doesn=E2=80=99t= cost much, which is why it=E2=80=99s opt-out. It didn=E2=80=99t occur to me tha= t one would really want to control that to the level you describe. Ludo=E2=80=99. From unknown Fri Jun 20 19:54:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Feb 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator