Subject: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list

From: Yuan Fu <[email-masked]>
Date: Thu, 9 Jan 2025 19:11:14 -0800

> On Jan 8, 2025, at 11:10 PM, Eli Zaretskii <[email-masked]> wrote:
> 
>> Date: Wed, 08 Jan 2025 13:20:19 +0000
>> From: Randy Taylor <[email-masked]>
>> Cc: Yuan Fu <[email-masked]>, [email-masked], [email-masked]
>> 
>> On Wednesday, January 8th, 2025 at 08:02, Eli Zaretskii <[email-masked]> wrote:
>>> 
>>> 
>>>> Cc: [email-masked], Roi Martin [email-masked]
>>> 
>>>> From: Yuan Fu [email-masked]
>>>> Date: Tue, 7 Jan 2025 22:18:53 -0800
>>>> 
>>>>> The attached patch fixes it for me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch>
>>>> 
>>>> Thanks Randy. Eli, should we apply this to emacs-30.
>>> 
>>> 
>>> Is this backward-compatible to older grammars? If yes, it's okay to
>>> install on emacs-30. If it is not compatible, I'd like to see how a
>>> compatible patch will look before I decide.
>> 
>> Yes, it's backward-compatible.
> 
> OK, then, Yuan, please feel free to install on emacs-30.

Installed.

As for cmake-ts-mode’s fix, it’s in 4def541bbfe67b1a492e8a3b6041a1d8f76d680b

Basically, tree-sitter-cmake gives up on parsing cmake generator expressions. According to the commit message:

> feat!: remove parsing generator expressions
> 
> Parsing generator expressions statically is impossible since whether an argument is interpreted as a generator expression or not depends on the function itself. Hence, the parsing for it is removed.
> 

Which makes sense to me. The fix is backward-compatible too, since we’re just removing fontification for angle brackets.

Yuan