From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 12:46:24 2025 Received: (at submit) by debbugs.gnu.org; 4 Jan 2025 17:46:24 +0000 Received: from localhost ([127.0.0.1]:57143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU8EA-0004Ed-S4 for submit@debbugs.gnu.org; Sat, 04 Jan 2025 12:46:23 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36266) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU6GX-0006rK-Na for submit@debbugs.gnu.org; Sat, 04 Jan 2025 10:40:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU6GL-0002EV-C5 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 10:40:29 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU6GJ-0000AR-AH for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 10:40:29 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4364a37a1d7so137369755e9.3 for ; Sat, 04 Jan 2025 07:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736005225; x=1736610025; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=5OcqN3Sx5aODpHAtDFDZW2inZDeC6/W9yypkutoNCj4=; b=Pv62D6rr5bmnzXVGZoXNh7h/66NTfxGtI4R/QNH3Eu/Bz0sneZdhWTVzqFw9fl4UrR CBX3W/2EsCUWEqHUCVvA832QEMaIZr4NjeFiRqCTsH8GLjG79BPl1mGjYpoAyKUrDolX JDDeCpvB6rhi5ql/+wso/ugwMjh7flnfOjNPL61/Z2GSGLpSZBqoZ2c29lUB6SvRZAqI EFRxYpvOd91hohN+E5CYYWE3e4gy1HkwhF01ZhrDFm/8qhBD90hBMTqyaEXzvZLE60QM UPG1VhAd1kj3nXOvEXtz9iOfpnOz6csDt1Q1kD7vR18EutxryEwaTdpqxpFHf+Y0qH2f YMjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736005225; x=1736610025; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5OcqN3Sx5aODpHAtDFDZW2inZDeC6/W9yypkutoNCj4=; b=Vl97lfe5gC+nMTXRxAgift/nmOBSTBANspywDRtVbfIprNk3LA0dOzqm4kQgRZyIPe nZitM4XF4mngTge8+gqQELKOORiQ9c2Rq00imUSWh41SwGp9QNOn5UbJNqOJosPxO5Sp 2yYsWJxwsNpE+2+1F6ytarf5U27JjFPZGotd7bTBDLSr3F3NkXSVf9IQS1L5OBH7+Gu+ +7jfsVKzNUBXKdKST+ZZO35437An7YlolJP7v9Pi2+1jvH4hJYdvvQWb93jxseThJZ6W P9HyULPehzuHl1S9BGC/ydPZOqnEkKpx3+MQRDBcYO9I19ECOaYwRSpekGFEKIXnp1jr dRJw== X-Gm-Message-State: AOJu0YzLarB2ph5jLZ1WE7FKg8hwpHihKyrufrw5qH9i/+O5btJEzIZq xf1J1FcdlOsT/ph4H4DVdIIoT9LJCPO+uhhV8EX+xmPEJBFQ0n7uCunXUw== X-Gm-Gg: ASbGncsauB2LtGnsXWiNTB8fg7lbLQfZm53j6AhZ55rLyPiqTuqAtYASANzYZhSFcDt moQ1NSFErVbKV48cOOL+HQQ2GUhPA7cTNshjgOp870eXrr7aQD3w92PV5m8gMIOoI4zwRUl6Fzm UWVsreo92vO846oWSpa88yhyKlDvSDCZ4B2/Vs7HW+BM0KeTxM6rMuFdPjnTIT1mCABWaZyqfEO ILwcOTWhUwkUbb3lyUigPWtCiXE7C4/ACj+5h9iz91tzeMeSDtsXjNpbFY/5YYZE910397uyNE+ h2QyGf5lFa7fVuGRonAuoQ== X-Google-Smtp-Source: AGHT+IHvbTayXd1I+RHI07RRugFQdnoLTYPNElev2S8ljMlDydZDy0vYQuwtoHBP4xWpW+qGNWT9wg== X-Received: by 2002:a05:600c:4f11:b0:435:9ed3:5698 with SMTP id 5b1f17b1804b1-43668b5e09bmr408403545e9.24.1736005225187; Sat, 04 Jan 2025 07:40:25 -0800 (PST) Received: from localhost (149.red-83-37-56.dynamicip.rima-tde.net. [83.37.56.149]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e140sm44369151f8f.79.2025.01.04.07.40.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 07:40:24 -0800 (PST) From: Roi Martin To: bug-gnu-emacs@gnu.org Subject: 29.4; go-ts-mode.el: wrong indentation inside var list Date: Sat, 04 Jan 2025 16:40:18 +0100 Message-ID: <87h66e8u59.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=jroi.martin@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 04 Jan 2025 12:46:21 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) When using the Go tree-sitter grammar v0.23.4 from https://github.com/tree-sitter/tree-sitter-go.git, indentation inside var lists does not work correctly. For instance, the following code is indented as: ``` var ( one = 1 ) ``` Instead of: ``` var ( one = 1 ) ``` Just in case it can help, I think this stopped working with grammar version `v0.21.1`, that introduced `var_spec_list`: https://github.com/tree-sitter/tree-sitter-go/compare/v0.21.0...v0.21.1 Please, take it with a pinch of salt because I'm not very familiar with tree-sitter. In GNU Emacs 29.4 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-10-10 built on 4825182c94fc4195b65c80c30f523a16 System Description: Fedora Linux 41 (Workstation Edition) Configured using: 'configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --runstatedir=/run --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-cairo --with-dbus --with-gif --with-gpm=no --with-harfbuzz --with-jpeg --with-json --with-modules --with-native-compilation=aot --with-pgtk --with-png --with-rsvg --with-sqlite3 --with-tiff --with-tree-sitter --with-webp --with-xpm build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu CC=gcc 'CFLAGS=-DMAIL_USE_LOCKF -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer ' 'LDFLAGS=-Wl,-z,relro -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes ' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig CXX=g++ 'CXXFLAGS=-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer '' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Go Minor modes in effect: eglot--managed-mode: t flymake-mode: t denote-menu-bar-mode: t server-mode: t icomplete-mode: t fido-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/n/.emacs.d/elpa/transient-20250103.1731/transient hides /usr/share/emacs/29.4/lisp/transient Features: (shadow sort mail-extr emacsbug message puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils yank-media markdown-mode color noutline outline time-date files-x find-dired grep eglot external-completion array filenotify jsonrpc ert ewoc debug backtrace find-func flymake-proc flymake thingatpt compile text-property-search comint ansi-osc ansi-color imenu go-ts-mode treesit dired-aux denote xref project ring comp comp-cstr warnings cl-extra help-mode server rx dired dired-loaddefs icomplete cus-edit pp cus-load icons wid-edit easy-mmode clang-rename clang-include-fixer let-alist clang-format xml denote-autoloads elfeed-autoloads forge-autoloads closql-autoloads emacsql-autoloads geiser-chez-autoloads geiser-guile-autoloads geiser-autoloads ghub-autoloads htmlize-autoloads magit-autoloads pcase magit-section-autoloads dash-autoloads markdown-mode-autoloads racket-mode-autoloads tmr-autoloads transient-autoloads treepy-autoloads with-editor-autoloads info compat-autoloads yaml-autoloads zig-mode-autoloads reformatter-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 198588 19413) (symbols 48 16484 6) (strings 32 50057 3480) (string-bytes 1 1645981) (vectors 16 31794) (vector-slots 8 605866 18429) (floats 8 196 642) (intervals 56 753 136) (buffers 984 20)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 17:05:26 2025 Received: (at 75362) by debbugs.gnu.org; 5 Jan 2025 22:05:26 +0000 Received: from localhost ([127.0.0.1]:35684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUYkQ-0006fp-DA for submit@debbugs.gnu.org; Sun, 05 Jan 2025 17:05:26 -0500 Received: from mail-4022.proton.ch ([185.70.40.22]:35613) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUYkM-0006dv-UB for 75362@debbugs.gnu.org; Sun, 05 Jan 2025 17:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1736114715; x=1736373915; bh=xnXl87MC3Lbg+fNQoXhhvKAm3si5JVhj/DdIR1DbjyA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=l+J3qdszxUtbnXDA5aCwW7IC7NFJq5fxlgpIBpZ0LkkavP+uPJA5uxeJ2+vJJ/w94 VGqVlOS1t2fqb0brIbi/7OCLkAhFKnvJZGmeeHx/CzbxDECGL8c8REeMTJuwNVUM+L iD+IsXotx/eomFmN97ai9RJYlw7PiepDeK7vKkxN+Rocth/kf7LmUOw/2TNnny0+Dq m2ITGF02DggC/7IACPdbzQdOg4fSulCNxmSWehTrYJjOx+VNahPUAxrZr1YrTRiLid lgQ7T+css3NRiAzXtSyd24CrD0vX9wUeE1FdzJo8gg0UaySn6eb0Wt5acEqhbw+vD2 gIEvlmxXzNwrA== Date: Sun, 05 Jan 2025 22:05:09 +0000 To: Roi Martin From: Randy Taylor Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list Message-ID: In-Reply-To: <87h66e8u59.fsf@gmail.com> References: <87h66e8u59.fsf@gmail.com> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 164f0a62f82a11dc1225254269186de2197f94da MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1=_wzzwfNmEbjgtsozcj4iDjvp9WYvnPJCt5zWSRxFf6Zo" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75362 Cc: 75362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --b1=_wzzwfNmEbjgtsozcj4iDjvp9WYvnPJCt5zWSRxFf6Zo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Saturday, January 4th, 2025 at 10:40, Roi Martin = wrote: >=20 > When using the Go tree-sitter grammar v0.23.4 from > https://github.com/tree-sitter/tree-sitter-go.git, indentation inside > var lists does not work correctly. >=20 > For instance, the following code is indented as: >=20 > `var ( one =3D 1 )` >=20 > Instead of: >=20 > `var ( one =3D 1 )` >=20 > Just in case it can help, I think this stopped working with grammar > version `v0.21.1`, that introduced `var_spec_list`: >=20 > https://github.com/tree-sitter/tree-sitter-go/compare/v0.21.0...v0.21.1 >=20 > Please, take it with a pinch of salt because I'm not very familiar with > tree-sitter. >=20 > [...] >=20 Thanks for the report. The attached patch fixes it for me. --b1=_wzzwfNmEbjgtsozcj4iDjvp9WYvnPJCt5zWSRxFf6Zo Content-Type: text/x-patch; name=0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch RnJvbSBlY2I4MGI4NDljM2JjNDkwMDg1YTQxNDZiOGY4ZDQ5OTk0OTIyMGMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBTdW4s IDUgSmFuIDIwMjUgMTY6NDg6MDAgLTA1MDAKU3ViamVjdDogW1BBVENIXSBGaXggZ28tdHMtbW9k ZSB2YXIgc3BlYyBpbmRlbnRhdGlvbiAoQnVnIzc1MzYyKQoKdjAuMjEuMSBhbmQgb253YXJkcyBj aGFuZ2VkIGhvdyB0aGlzIHdhcyBpbmRlbnRlZC4KCiogbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9k ZS5lbCAoZ28tdHMtbW9kZS0taW5kZW50LXJ1bGVzKToKQWRkIHJ1bGUgZm9yIHZhcl9zcGVjX2xp c3QuCi0tLQogbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCB8IDEgKwogMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9k ZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKaW5kZXggNzQ3YmY5YTlkYTguLmNj ZmRjYjkwOWU1IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCisrKyBi L2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKQEAgLTEwNiw2ICsxMDYsNyBAQCBnby10cy1t b2RlLS1pbmRlbnQtcnVsZXMKICAgICAgKChwYXJlbnQtaXMgInR5cGVfc3BlYyIpIHBhcmVudC1i b2wgZ28tdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAoKHBhcmVudC1pcyAidHlwZV9zd2l0 Y2hfc3RhdGVtZW50IikgcGFyZW50LWJvbCAwKQogICAgICAoKHBhcmVudC1pcyAidmFyX2RlY2xh cmF0aW9uIikgcGFyZW50LWJvbCBnby10cy1tb2RlLWluZGVudC1vZmZzZXQpCisgICAgICgocGFy ZW50LWlzICJ2YXJfc3BlY19saXN0IikgcGFyZW50LWJvbCBnby10cy1tb2RlLWluZGVudC1vZmZz ZXQpCiAgICAgIChuby1ub2RlIHBhcmVudC1ib2wgMCkpKQogICAiVHJlZS1zaXR0ZXIgaW5kZW50 IHJ1bGVzIGZvciBgZ28tdHMtbW9kZScuIikKIAotLSAKMi40Ny4xCgo= --b1=_wzzwfNmEbjgtsozcj4iDjvp9WYvnPJCt5zWSRxFf6Zo-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 01:19:12 2025 Received: (at 75362) by debbugs.gnu.org; 8 Jan 2025 06:19:12 +0000 Received: from localhost ([127.0.0.1]:45727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVPPM-0008Bp-AE for submit@debbugs.gnu.org; Wed, 08 Jan 2025 01:19:12 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:49344) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVPPL-0008BX-BY for 75362@debbugs.gnu.org; Wed, 08 Jan 2025 01:19:11 -0500 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-21634338cfdso29288925ad.2 for <75362@debbugs.gnu.org>; Tue, 07 Jan 2025 22:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736317145; x=1736921945; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/c2zCtuPOCoTrOPrO8Aj57P1aNh7xdhFONwkoO//Ogc=; b=KuHAZ3vrSBZWIYhYsd0ANyWIjh8ke0beitYjAZTQEqc6Xns5Y5eyLPCxg7W/+dDQfV JrUhqu6JjSxJC+EF62f0aPbt6uDtLFSTYSmXz1LwJhH1Yv7socU0QNin3et+hhK3FJNI rgj0ra/Uj1CkfIIrVzry14YbVZCao0DbhPF4VEc1Y4bt5Cp6pgzp/pFhvo0wkecajgC9 3maCxEoqp1/yyp5WUEyxWubo8eq0566OkqlciqBb9vC1tHgFVmVW7fdf1n6sT5FKwDTN qiq+FDAbe5fnFT5eZcscsgQT5Jtx1doluHWbETeF8AUR12nfGV43eOq2BLKXEZn9EZUo lwcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736317145; x=1736921945; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/c2zCtuPOCoTrOPrO8Aj57P1aNh7xdhFONwkoO//Ogc=; b=qZKttWLdtrZlwU3AHLztU07k+ONuwNRQDNcz1GgDoS51ahGUm83P9s7KPa0u6KNUiN ULcHzIwterSRpSpZ3b9UjR/MmrHfyNvl1e7O7kbEbMGqmwk4DzJYXimSctyh/aEU4Frm asjhGI2G0wrWl1VrPtAfQYWXf/aovzMVLLHPTr3VvWDQw0q+OrrLLW6bxcqBI4I61jpi iup8JeqHqF/tRht5GhdGKwoI6R3webdjO7/JcRHD9JeGpmEr8sp6guyql13KkxJ0Rcpc pX55suFYfmcstc1M1lZjG5X5uT3Pi8Nsn6M8l9uubLE5YkLGUII1lStzo2xzWZRkP18x ghrA== X-Forwarded-Encrypted: i=1; AJvYcCVC3TVV0x4Nwv6IDoRmE966g0BdwA9/YU7PAuUBWoP6H2R/CoWs4CF816NBkzE4mUXFMTk29w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyqwjtdQba7WCe/ZXL8AGjSHZIaKuY7cBW4Dqs6RAhSaqt+KnBS dBjwDwmZQeJxjWTPP51AIQgBrM6ClSYr9eMfWZ7cR1LnJ8uwTpm9XO0M9Q== X-Gm-Gg: ASbGncs392jBMmPrF3e5/A5sWU/aNG1R38KCJuR2WSc1Ol1lDuei/RnYqH/MIjo74mO wLsd+kjuWPOLXklx3kL91lFj4sr6otrexiAamNHakf6J+jKrfQvbSf1TwMZQ0d0MdL7QkESA64/ W8/3iKDvccRddYvqEp4Fbs+eJuBWwnlC4eeQ1zs1uQqyO+pAf0pdRtgQgPsWKgLgru3cwGTrUUI qxgIEM0A7IQzTrPEaNtdHkguObyCSfskUoT8dIyYgl29bcuLbfq4WaTHSpfJJq1WiamsZnfeIhI +85r X-Google-Smtp-Source: AGHT+IHdLsI71kUfD5K8hRAe+JioKQQfzhaXgPb44ip+V5NAYd1d61aRsW15ToNLgHNKpq4Xvf3DcA== X-Received: by 2002:a05:6a20:7350:b0:1e0:cc4a:caab with SMTP id adf61e73a8af0-1e88d12c1e2mr3048509637.19.1736317145149; Tue, 07 Jan 2025 22:19:05 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:715c:1de9:341d:f41d]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e414dbbasm26798123a12.82.2025.01.07.22.19.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2025 22:19:04 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list From: Yuan Fu In-Reply-To: Date: Tue, 7 Jan 2025 22:18:53 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> References: <87h66e8u59.fsf@gmail.com> To: Randy Taylor X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75362 Cc: 75362@debbugs.gnu.org, Roi Martin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 5, 2025, at 2:05=E2=80=AFPM, Randy Taylor wrote: >=20 > On Saturday, January 4th, 2025 at 10:40, Roi Martin = wrote: >>=20 >> When using the Go tree-sitter grammar v0.23.4 from >> https://github.com/tree-sitter/tree-sitter-go.git, indentation inside >> var lists does not work correctly. >>=20 >> For instance, the following code is indented as: >>=20 >> `var ( one =3D 1 )` >>=20 >> Instead of: >>=20 >> `var ( one =3D 1 )` >>=20 >> Just in case it can help, I think this stopped working with grammar >> version `v0.21.1`, that introduced `var_spec_list`: >>=20 >> = https://github.com/tree-sitter/tree-sitter-go/compare/v0.21.0...v0.21.1 >>=20 >> Please, take it with a pinch of salt because I'm not very familiar = with >> tree-sitter. >>=20 >> [...] >>=20 >=20 > Thanks for the report. >=20 > The attached patch fixes it for = me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch> Thanks Randy. Eli, should we apply this to emacs-30. Also, what=E2=80=99s the general situation of grammar fixes on emacs-30? = I=E2=80=99m asking because I fixed a grammar compatibility issue for = cmake-ts-mode on master. I was going to back port it for 30.2, but it = seems that simple fixes are ok for emacs-30? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 08:02:26 2025 Received: (at 75362) by debbugs.gnu.org; 8 Jan 2025 13:02:26 +0000 Received: from localhost ([127.0.0.1]:46406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVVhZ-0001g6-NA for submit@debbugs.gnu.org; Wed, 08 Jan 2025 08:02:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39782) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVVhY-0001ft-Ag for 75362@debbugs.gnu.org; Wed, 08 Jan 2025 08:02:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVVhS-0001Ai-J9; Wed, 08 Jan 2025 08:02:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=25OUl3bMEx3rm/o6RBzHfhsBSgA+5sRV/OC6UryN6ZU=; b=eP6ZCxLLnACUd8x1EpqH p/m+6qX5P5LtJVLiHZ2xKvdXoO0FHWGMS3JmNe/3zDdkTmwdpBbo1Ots+8rOPuRovFB3wXBXqTkxC UCuSGQsGc+17unmZ/mPpQX8c97aNBy2CpVoie3GAN37QJ6BBoxGbCpUtPnbe0NR4GCgATklNY8vi1 X6Lq8zwevjejn+3++nMQvAya+dhFt3H1wtAf70KQHVwVQJmQcsEq1X2GbyzqilWjjN74+lQqO7A16 CLlTzjot5gAf7xI8sHL/SLltJ6yUDsGHZRItewNvLzisMMhC+DL+eWGUrGQpRmqA3CyujMWk8/rBA 3772Mjh9yD0l6Q==; Date: Wed, 08 Jan 2025 15:02:11 +0200 Message-Id: <864j294fxo.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> (message from Yuan Fu on Tue, 7 Jan 2025 22:18:53 -0800) Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list References: <87h66e8u59.fsf@gmail.com> <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75362 Cc: 75362@debbugs.gnu.org, dev@rjt.dev, jroi.martin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 75362@debbugs.gnu.org, Roi Martin > From: Yuan Fu > Date: Tue, 7 Jan 2025 22:18:53 -0800 > > > The attached patch fixes it for me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch> > > Thanks Randy. Eli, should we apply this to emacs-30. Is this backward-compatible to older grammars? If yes, it's okay to install on emacs-30. If it is not compatible, I'd like to see how a compatible patch will look before I decide. > Also, what’s the general situation of grammar fixes on emacs-30? I’m asking because I fixed a grammar compatibility issue for cmake-ts-mode on master. I was going to back port it for 30.2, but it seems that simple fixes are ok for emacs-30? Please tell the commit, and I will look at it. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 08:20:33 2025 Received: (at 75362) by debbugs.gnu.org; 8 Jan 2025 13:20:33 +0000 Received: from localhost ([127.0.0.1]:46469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVVz6-0002Zj-KD for submit@debbugs.gnu.org; Wed, 08 Jan 2025 08:20:32 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:48983) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVVz3-0002ZU-Kw for 75362@debbugs.gnu.org; Wed, 08 Jan 2025 08:20:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1736342423; x=1736601623; bh=jAul5i2i1qK/JpSmJZ7DKHM+bHSB+/4lw/xDB99xLUU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=Knpuf+7d0HdnaNlcKuAq1z5+k/nKAs+RY1E/t7lFkY3iBL+K4imG+8izPtGockpk8 jf3OpuW+kH5eVGIC6jbI7ZveylQdw2ai6mxAzgMHHMOXvyv0xQj+L2XJ5LO88pQPK3 VaBi16Y7GZqXJ/CpPdUnJA1gBS1MF4m2W5rJfYJ92ISMslAkoSUH/yh/eZtedEqTID FRZxeqm9lBU/1r/z6NjmUh8fnnrV4PTmVNhChxG9P9huO4jWego/r6U9nbi9LYhSVq /shpPZSqKaoJQ9GmRZBUEIcPpUSWXz81FG3XhWfUGFxmwT8FmI4UMRHYdVSkt4KJI3 JgGGs2Wt2TiKA== Date: Wed, 08 Jan 2025 13:20:19 +0000 To: Eli Zaretskii From: Randy Taylor Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list Message-ID: In-Reply-To: <864j294fxo.fsf@gnu.org> References: <87h66e8u59.fsf@gmail.com> <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> <864j294fxo.fsf@gnu.org> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 2af6088e51433a7e32acd5cdfa0297db602ec91a MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75362 Cc: 75362@debbugs.gnu.org, Yuan Fu , jroi.martin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wednesday, January 8th, 2025 at 08:02, Eli Zaretskii wrot= e: >=20 >=20 > > Cc: 75362@debbugs.gnu.org, Roi Martin jroi.martin@gmail.com >=20 > > From: Yuan Fu casouri@gmail.com > > Date: Tue, 7 Jan 2025 22:18:53 -0800 > >=20 > > > The attached patch fixes it for me.<0001-Fix-go-ts-mode-var-spec-inde= ntation-Bug-75362.patch> > >=20 > > Thanks Randy. Eli, should we apply this to emacs-30. >=20 >=20 > Is this backward-compatible to older grammars? If yes, it's okay to > install on emacs-30. If it is not compatible, I'd like to see how a > compatible patch will look before I decide. Yes, it's backward-compatible. >=20 > > Also, what=E2=80=99s the general situation of grammar fixes on emacs-30= ? I=E2=80=99m asking because I fixed a grammar compatibility issue for cmak= e-ts-mode on master. I was going to back port it for 30.2, but it seems tha= t simple fixes are ok for emacs-30? >=20 >=20 > Please tell the commit, and I will look at it. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 09 02:10:51 2025 Received: (at 75362) by debbugs.gnu.org; 9 Jan 2025 07:10:52 +0000 Received: from localhost ([127.0.0.1]:50174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVmgt-00069A-IE for submit@debbugs.gnu.org; Thu, 09 Jan 2025 02:10:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41346) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVmgs-00068w-4L for 75362@debbugs.gnu.org; Thu, 09 Jan 2025 02:10:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVmgm-0003Je-P9; Thu, 09 Jan 2025 02:10:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=isvcFoBfTxfaMtUQzopQHwoSTkNmalIjAmHsTioDgoQ=; b=jQE3YWPeJ4M3 CKCCLFtjyOOQuioJxXD0WhDzr4P0EHkmX8HSZYVSlWQ2vogfuyzL2qW/Dr65t5bUW0eWmVG2YLzhk LYk6fB5I8UOJebLAHw5ASRd7aJu/MlBKixNXacI8pWmd89YWlczFwlc5yXxtK0tfb+yuWTUIgCBT4 qCS1x6WEenMwR9tYr8PDd5q0F4eIU+8Vpn5wltaVs9bjOONwpoi0WMMmlP9rSf1g9jry0ZlBFMxhO sCWFBaPwX1FqPwRp1b0s9+Z0azGOmMlccUBjRAhMsOww036TpLQKSinF8mh7vjtSo+Sjc23r4Yo6y zn2AM9SiVo9vlM2S8Ka5FQ==; Date: Thu, 09 Jan 2025 09:10:41 +0200 Message-Id: <86cygw31ji.fsf@gnu.org> From: Eli Zaretskii To: Randy Taylor In-Reply-To: (message from Randy Taylor on Wed, 08 Jan 2025 13:20:19 +0000) Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list References: <87h66e8u59.fsf@gmail.com> <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> <864j294fxo.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75362 Cc: 75362@debbugs.gnu.org, casouri@gmail.com, jroi.martin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 08 Jan 2025 13:20:19 +0000 > From: Randy Taylor > Cc: Yuan Fu , 75362@debbugs.gnu.org, jroi.martin@gmail.com > > On Wednesday, January 8th, 2025 at 08:02, Eli Zaretskii wrote: > > > > > > > Cc: 75362@debbugs.gnu.org, Roi Martin jroi.martin@gmail.com > > > > > From: Yuan Fu casouri@gmail.com > > > Date: Tue, 7 Jan 2025 22:18:53 -0800 > > > > > > > The attached patch fixes it for me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch> > > > > > > Thanks Randy. Eli, should we apply this to emacs-30. > > > > > > Is this backward-compatible to older grammars? If yes, it's okay to > > install on emacs-30. If it is not compatible, I'd like to see how a > > compatible patch will look before I decide. > > Yes, it's backward-compatible. OK, then, Yuan, please feel free to install on emacs-30. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 09 22:11:37 2025 Received: (at 75362) by debbugs.gnu.org; 10 Jan 2025 03:11:37 +0000 Received: from localhost ([127.0.0.1]:55928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tW5Qv-0006ey-0c for submit@debbugs.gnu.org; Thu, 09 Jan 2025 22:11:37 -0500 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:47425) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tW5Qr-0006ej-3e for 75362@debbugs.gnu.org; Thu, 09 Jan 2025 22:11:34 -0500 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2f441791e40so2153991a91.3 for <75362@debbugs.gnu.org>; Thu, 09 Jan 2025 19:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736478687; x=1737083487; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1S/ntj8Nqd1srZNXN4gIAdzJ0YmwhJvVI60DT5LsgN8=; b=RvoLxqAuQ+HkdcNb8/jR7ZVok+g64CjaGE2OONaACaev4UrK3yQHyiMDvRnFl4P9mB CP0nuHHAr0vKtWZH/WJ3LXTPW3EjYLXEovtaGo0yhVRPuYQfpZ6y721hJ1HLcv/yOiWe cWT99FlRJVrhnsIjqsCi0onlwrgvPt1s7AEgSHNtCxOeltjyIQldvB9a90TEfnigbCxA 8grENYaRUEhKagy+h781Sf5qpmgdneRtf1s+tSbODU4tO1q9dlr90QqekwHGOlc+Z8if Leo/yRj3Wu4KCsg0VnHCYf3nVbwpRmEh/B83UffcijhCcEkxbwVqggvOSpnb9HJ/eDU8 GfGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736478687; x=1737083487; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1S/ntj8Nqd1srZNXN4gIAdzJ0YmwhJvVI60DT5LsgN8=; b=bXIAif6lRz6hYypEEVF9Z57ZtXpy0cA8WFzFwhiDSvU73pmOZ+dbJNxSrIfhaYqrYq Z7zqBEJQ/oXTDGanwu65/4WUx0anLnzVelx2RcoJPudGqoNlHYpH2018uyDkfNNbPxw0 uv1FsDlu6ijI1OXrT5IMeONQuLeVZYdShnnRqFH5l9/FoShLYwks3RcefUFE+ZsQ4j7i cM+eMkWXogOcOQ34rpnnd+foIFPBpTjv2Jk44PA3SUV7HD0p6wJj/PWG/0lP98vX5sRD WuEgFnXmUMQ4So31mrfO853fQ/EajPbyXDf0mmJrDYl7tbS2211IdBS04gJkqip7QUYj SscA== X-Forwarded-Encrypted: i=1; AJvYcCUCatb1Wid5qRxot/uPxyCVJDPgnXN+emTWdbVCzooWXr+NnmhUoY5xfkAKgt3+rte1HrzbKw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzOuwlSIdwrMU0bhiwTGOKwcLJ5ieYfFM/lboYsrb7W8h5syIJE TPiKwiwXQwBbXRRgBggfYEquQiFAIcb/5Z93ke7IZIcm2rpd7wEg X-Gm-Gg: ASbGncsxz3tTqt9ewdJozUHHwRIKnaomDxz5gUkuBzHv2ftTtK2mrh1qZdyCzPeSffI JhzNE7GeWmrt1OCzc8hJ9ZBbO6PFQz2q2fsDNwjb+1QZbXc4tAXlyu7T0iOaznFukTdZg191orG 5tFqa6T7UG3S/aPhzNh1cquIJqBygV1CV5fj+8MzzQmq/a8+0cIPQ8p+lJrSM3AQ2Ij2q7rKcRR 3Fd2+T6uklaS/eDlmL2PJT6QyH04Cd4st8vf6BcniAA4ca4ZUORCi7dxMM+EV5zt/0Wnn5dHGX4 KG4S X-Google-Smtp-Source: AGHT+IFtENuZ78sv2Xsr8szDae/Dmyd4X5fqek+FA+UK8Y3q+gE6vCQkb5/TeEkH6xJooxrzyaydZw== X-Received: by 2002:a17:90b:6d0:b0:2ee:889b:b11e with SMTP id 98e67ed59e1d1-2f5490bd257mr13521803a91.30.1736478686953; Thu, 09 Jan 2025 19:11:26 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:d801:ab3e:9baf:5ef1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f26aab9sm4769065ad.256.2025.01.09.19.11.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jan 2025 19:11:26 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list From: Yuan Fu In-Reply-To: <86cygw31ji.fsf@gnu.org> Date: Thu, 9 Jan 2025 19:11:14 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <661D61B6-CE81-4DA2-9BF3-6D638448798E@gmail.com> References: <87h66e8u59.fsf@gmail.com> <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> <864j294fxo.fsf@gnu.org> <86cygw31ji.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 75362 Cc: 75362@debbugs.gnu.org, Randy Taylor , jroi.martin@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 8, 2025, at 11:10=E2=80=AFPM, Eli Zaretskii = wrote: >=20 >> Date: Wed, 08 Jan 2025 13:20:19 +0000 >> From: Randy Taylor >> Cc: Yuan Fu , 75362@debbugs.gnu.org, = jroi.martin@gmail.com >>=20 >> On Wednesday, January 8th, 2025 at 08:02, Eli Zaretskii = wrote: >>>=20 >>>=20 >>>> Cc: 75362@debbugs.gnu.org, Roi Martin jroi.martin@gmail.com >>>=20 >>>> From: Yuan Fu casouri@gmail.com >>>> Date: Tue, 7 Jan 2025 22:18:53 -0800 >>>>=20 >>>>> The attached patch fixes it for = me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch> >>>>=20 >>>> Thanks Randy. Eli, should we apply this to emacs-30. >>>=20 >>>=20 >>> Is this backward-compatible to older grammars? If yes, it's okay to >>> install on emacs-30. If it is not compatible, I'd like to see how a >>> compatible patch will look before I decide. >>=20 >> Yes, it's backward-compatible. >=20 > OK, then, Yuan, please feel free to install on emacs-30. Installed. As for cmake-ts-mode=E2=80=99s fix, it=E2=80=99s in = 4def541bbfe67b1a492e8a3b6041a1d8f76d680b Basically, tree-sitter-cmake gives up on parsing cmake generator = expressions. According to the commit message: > feat!: remove parsing generator expressions >=20 > Parsing generator expressions statically is impossible since whether = an argument is interpreted as a generator expression or not depends on = the function itself. Hence, the parsing for it is removed. >=20 Which makes sense to me. The fix is backward-compatible too, since = we=E2=80=99re just removing fontification for angle brackets. Yuan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 13 01:35:55 2025 Received: (at 75362-done) by debbugs.gnu.org; 13 Jan 2025 06:35:55 +0000 Received: from localhost ([127.0.0.1]:49931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXE3H-0001wA-Bc for submit@debbugs.gnu.org; Mon, 13 Jan 2025 01:35:55 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:47234) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tXE3F-0001vu-1n for 75362-done@debbugs.gnu.org; Mon, 13 Jan 2025 01:35:53 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-21680814d42so54747215ad.2 for <75362-done@debbugs.gnu.org>; Sun, 12 Jan 2025 22:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736750147; x=1737354947; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b8AM2LcQBfbGcyNhHnGAklmNZ7cnYjvhaH9zcNGpPQk=; b=QiGKEf8+/NXcxAndFFlbll3l8SkEEKsXPQ1003+Ic0W093/NtPWbsw76/nzMfwZW3k XffsFJMMHo2p44y7CVPI078HaOhuvEDC8gqf2J2xck07tUv/IVCymf6q5QmUJeGXfskA oJpeS3guc6oychn69N4cC2cSbzHzCdjGIjlKzxHBnUdtA52CTBOrQcGcmdzTWrWZHwbg J7NI8Cqho1+5TgOVuteys/UwpubfEpgh6fR5yUAH2m0Ydk4096VpHFqRLill3icae+LI mLdqRn143xl/xAwA+dDrgLcxfPb4+yKGVqRQcOoYJYcYEFDxLpLW6RakGmx/qsLkkcxt nqEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736750147; x=1737354947; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b8AM2LcQBfbGcyNhHnGAklmNZ7cnYjvhaH9zcNGpPQk=; b=adcDibDcn+xnG9Zx0ehghQfcueErCSJ/Uzpywm7GoW4cWcGN70g0ELjMOF/GlJ4wfj Ks1l44jCKpYcHR5gvPFD7rAwowiiXyif8LxnvW7jVyp42nwDZvUJbVwjJ3CAQG+V7mq1 AltvEm5X1N/M0UtQ97B9Qk5YuCK6Jjg/JZXFfcxqruQNerlZBYavDU8XpV828/uamtHD C9l8yKNhWwZ/Nr+5M/L19h29ebt3lLZKut2vJXOBH21CxjM/y/lTPlEkN+ySxDpHfo+f Wk6Tahmg8mGfuNIdtonhKft+UHs/vAcTxRCajykDTGeZ1v8jtnwribRy17WhgzhMZ/5L cssw== X-Gm-Message-State: AOJu0YxBIEAR7VTRZNPDxA0D6Vz0FFWNc09YfjNzYzo07o5OCYx52D45 t4QKLsZRlUgSE4UkQBfbXtvfSAdsYhSBCGB/9uIRpdngf1OsjVCO X-Gm-Gg: ASbGnct01j31p3VaQzXGoL11gy0pUH+5yJSbw4JbJxrmM5ODb0osWmUYp8UOKaV17pZ xdSIp/J3JztF0QibFX/i+T+69RcRBaMn6Sixz+OA0kJPtE21q5l5VKuaMFPmPRp8zrHmm8bzWpm seO7O27KuBiAAygJuc04Pw84mPHe4crF99qFfKf8vqYwKIRiXXg2tWt/4vohIOkmQEMiAcOud9F GhvMB+ZKG7sDEBRqiq9amaSi3L66KLbRTuUKxOnfT6Hp5wmtEdRkqhpF3k6WpkMZau9dpcEWe9m qPUB X-Google-Smtp-Source: AGHT+IH663kRHt/dqRLwv0PD3IRjEyNtiBXUyKlvLrnb1oe2zc6szod8KFLIEZBGpKK0GIftMVDXnw== X-Received: by 2002:a17:902:da8d:b0:216:2abc:195c with SMTP id d9443c01a7336-21a83f429ecmr270734815ad.7.1736750146970; Sun, 12 Jan 2025 22:35:46 -0800 (PST) Received: from smtpclient.apple ([2601:646:8f81:6120:c04e:a612:3dd1:a163]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f10f035sm46749335ad.30.2025.01.12.22.35.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jan 2025 22:35:46 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list From: Yuan Fu In-Reply-To: <87h66e8u59.fsf@gmail.com> Date: Sun, 12 Jan 2025 22:35:35 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <877E7FAB-CA09-48E6-AD66-DE0C025E2F0E@gmail.com> References: <87h66e8u59.fsf@gmail.com> To: Roi Martin X-Mailer: Apple Mail (2.3776.700.51) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75362-done Cc: 75362-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 4, 2025, at 7:40=E2=80=AFAM, Roi Martin = wrote: >=20 > When using the Go tree-sitter grammar v0.23.4 from > https://github.com/tree-sitter/tree-sitter-go.git, indentation inside > var lists does not work correctly. >=20 > For instance, the following code is indented as: >=20 > ``` > var ( > one =3D 1 > ) > ``` >=20 > Instead of: >=20 > ``` > var ( > one =3D 1 > ) > ``` >=20 > Just in case it can help, I think this stopped working with grammar > version `v0.21.1`, that introduced `var_spec_list`: >=20 > = https://github.com/tree-sitter/tree-sitter-go/compare/v0.21.0...v0.21.1 >=20 > Please, take it with a pinch of salt because I'm not very familiar = with > tree-sitter. Thanks Roi, and especially thanks for finding the change in grammar! The good news is, I just checked and it=E2=80=99s fixed in Emacs 30. = Before then, something like this should fix it for you: (add-hook 'go-ts-mode-hook #'fix-go-ts-mode-indentation) (defun fix-go-ts-mode-indentation () (setf (alist-get 'go treesit-simple-indent-rules) (append (alist-get 'go treesit-simple-indent-rules) '(((parent-is "var_spec_list") parent-bol = go-ts-mode-indent-offset))))) Yuan= From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 14 00:28:01 2025 Received: (at 75362-done) by debbugs.gnu.org; 14 Jan 2025 05:28:01 +0000 Received: from localhost ([127.0.0.1]:53620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tXZT6-0003NA-Hv for submit@debbugs.gnu.org; Tue, 14 Jan 2025 00:28:01 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:48296) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tXRfh-0005q9-0t for 75362-done@debbugs.gnu.org; Mon, 13 Jan 2025 16:08:29 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3862b40a6e0so2588992f8f.0 for <75362-done@debbugs.gnu.org>; Mon, 13 Jan 2025 13:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736802503; x=1737407303; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rGGcaeWa+Cd2QLmFtuJ1RF6yj3G0IV+zKL9jmspXwG0=; b=g/wYNoZMbbmuaqQ8fFsS8pF5wCQJ7DSqYUD8gk2gSnlL+0x/opvFTBvsSB8m+CzPrL 4HnKge6uvcwpDzGQMgs6V3rFWcjvv62rtc1AX09iOuJ68D69i3ha/IRUwyvoSoeheI1A 1g1a7IeqH9SBnHnYq/IjW6I+F2jXvefRnpKkahddfNTZMd9B2zBHbqIsX01h6XF/FNva vtX+Z8upigpyZ0tNY858iw4Qo/9XsSgwlyBgiZeFTyi/USgpg+1yjk7Dok7h1nhZpURw chscxJcX0VWdfVeaWNjG+dBW/lg9Do4n2Q3PJAlP4m2OQumEPLTQ+EfuPF9NAGqm6hZb R2Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736802503; x=1737407303; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rGGcaeWa+Cd2QLmFtuJ1RF6yj3G0IV+zKL9jmspXwG0=; b=jLMlGfH2KApL3FMvQK+Sehem2R09DF2qj4RGU6zrbHby3xkLcfoz/aXkcJwftjSG1H 98mqleaKdFFpTWDM5z9U+nuUJmRK+4mpZ3bORSfYmQtFI3uZK0O34XkbIqcTLmSgTdMb UApDs9aQ1bGP6T1NOTHMKCMOxWbBMcBUryYoJOlhiPpZF49bAJM+2reusllnVL0/mFiB xEFOW7+cOFbPf0atcOlLkrrw7TD+qZYGEVSMrmZXQezslJ1Og8VrwJFIlM5YwAlLr5m1 wVpfgEcF7a2xFNkF/T0wmqSEWOM78HUxOyulvn00Vd6V7nDbnj1Fg6xxSQYyVXfn4KTn iZLw== X-Gm-Message-State: AOJu0YxsePg7Bi4nWecMeVsIj3ffi3g2ZxbX8ljPpnL+v9f3iigbPu5s mgwdPW/S1ZJZeTxHUlgtAbLvOt7xduxFUHZB4J53yzVvJhoP8PgZ X-Gm-Gg: ASbGncuF5etCWKOb1DmyBh3vMQ0yTU5+j5pOuiymFhlKXStgOkgJQNQhZT4ukmaby6T p1Qzx+reRlekS7WORsBQvtdlWKk8g3904T2TSgPAS9c8pCsRVixE6/GbAdOOZtNk9nD+QL2KVeA KQyEcyZo2xEnvaku7xQukg8QJr8hW/9mpGclWopYFLX8BQpH4kP+40/x+YwNBO27nvDi+/GEeJ0 mdjC1a+Jkhw8c9CAWIKrfS557dp6ggbAX/mnl6oB64JTR3X/O4+R+0= X-Google-Smtp-Source: AGHT+IF3FVumWsgEz/C2o2O/GapQI4L3CAN4URmxmuMYzWtkwZHCJoL7Jd94dKj61V1H3rt3Z4VA4g== X-Received: by 2002:a5d:6d8a:0:b0:386:4034:f9a8 with SMTP id ffacd0b85a97d-38a8733693fmr22429688f8f.38.1736802502448; Mon, 13 Jan 2025 13:08:22 -0800 (PST) Received: from localhost ([84.79.205.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4b80besm12829478f8f.83.2025.01.13.13.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 13:08:22 -0800 (PST) From: Roi Martin To: Yuan Fu Subject: Re: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list In-Reply-To: <877E7FAB-CA09-48E6-AD66-DE0C025E2F0E@gmail.com> References: <87h66e8u59.fsf@gmail.com> <877E7FAB-CA09-48E6-AD66-DE0C025E2F0E@gmail.com> Date: Mon, 13 Jan 2025 22:08:20 +0100 Message-ID: <875xmifmm3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75362-done X-Mailman-Approved-At: Tue, 14 Jan 2025 00:27:59 -0500 Cc: 75362-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > Thanks Roi, and especially thanks for finding the change in grammar! > > The good news is, I just checked and it’s fixed in Emacs 30. Before then, something like this should fix it for you: > > (add-hook 'go-ts-mode-hook #'fix-go-ts-mode-indentation) > (defun fix-go-ts-mode-indentation () > (setf (alist-get 'go treesit-simple-indent-rules) > (append (alist-get 'go treesit-simple-indent-rules) > '(((parent-is "var_spec_list") parent-bol go-ts-mode-indent-offset))))) Great! Thanks a lot for landing a fix and providing a workaround! Roi From unknown Sat Sep 06 21:07:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 11 Feb 2025 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator