From unknown Mon Aug 11 19:50:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75345: 29.4; 'insert' doc string still mentions 'string-as-multibyte' Resent-From: Ulrich =?UTF-8?Q?M=C3=BCller?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 09:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 75345@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173598422524512 (code B ref -1); Sat, 04 Jan 2025 09:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2025 09:50:25 +0000 Received: from localhost ([127.0.0.1]:53404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU0nY-0006NF-Bh for submit@debbugs.gnu.org; Sat, 04 Jan 2025 04:50:24 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60830) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU0nU-0006KO-Tk for submit@debbugs.gnu.org; Sat, 04 Jan 2025 04:50:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU0nP-0003cS-Gj for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 04:50:15 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1tU0nN-0005Z2-E2 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 04:50:15 -0500 From: Ulrich =?UTF-8?Q?M=C3=BCller?= Date: Sat, 04 Jan 2025 10:50:04 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=140.211.166.183; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable C-h f insert RET insert is a built-in function in =E2=80=98src/editfns.c=E2=80=99. [...] When operating on binary data, it may be necessary to preserve the original bytes of a unibyte string when inserting it into a multibyte buffer; to accomplish this, apply =E2=80=98string-as-multibyte=E2=80=99 = to the string and insert the result. C-h f string-as-multibyte RET string-as-multibyte is a built-in function in =E2=80=98src/fns.c=E2=80= =99. This function is obsolete since 26.1; use `decode-coding-string'. [...] This looks inconsistent, presumably 'insert' shouldn't mention 'string-as-multibyte'. Attached patch updates the doc string. Also, the elisp manual still mentions functions string-as-unibyte and string-as-multibyte in section "(elisp) Top > Non-ASCII Characters > Selecting a Representation". Should these be removed from the manual, or at least be labelled as obsolete? --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=0001-Update-insert-doc-string.patch >From 858f94f942cb40481ac8bc83a36ae5555066c1bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Sat, 4 Jan 2025 10:37:59 +0100 Subject: [PATCH] Update 'insert' doc string * src/editfns.c (Finsert): Mention 'decode-coding-string' instead of the obsolete 'string-as-multibyte' in doc string. --- src/editfns.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/editfns.c b/src/editfns.c index 581bd03798e..8a5fb673fe7 100644 --- a/src/editfns.c +++ b/src/editfns.c @@ -1363,8 +1363,8 @@ DEFUN ("insert", Finsert, Sinsert, 0, MANY, 0, When operating on binary data, it may be necessary to preserve the original bytes of a unibyte string when inserting it into a multibyte -buffer; to accomplish this, apply `string-as-multibyte' to the string -and insert the result. +buffer; to accomplish this, apply `decode-coding-string' with the +`no-conversion' coding system to the string and insert the result. usage: (insert &rest ARGS) */) (ptrdiff_t nargs, Lisp_Object *args) -- 2.47.1 --=-=-=-- From unknown Mon Aug 11 19:50:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ulrich =?UTF-8?Q?M=C3=BCller?= Subject: bug#75345: closed (Re: bug#75345: 29.4; 'insert' doc string still mentions 'string-as-multibyte') Message-ID: References: <86msg6d7qs.fsf@gnu.org> X-Gnu-PR-Message: they-closed 75345 X-Gnu-PR-Package: emacs Reply-To: 75345@debbugs.gnu.org Date: Sat, 04 Jan 2025 13:34:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1735997642-32102-1" This is a multi-part message in MIME format... ------------=_1735997642-32102-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75345: 29.4; 'insert' doc string still mentions 'string-as-multibyte' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75345@debbugs.gnu.org. --=20 75345: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75345 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1735997642-32102-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75345-done) by debbugs.gnu.org; 4 Jan 2025 13:33:11 +0000 Received: from localhost ([127.0.0.1]:53917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU4H8-0008Kh-Hy for submit@debbugs.gnu.org; Sat, 04 Jan 2025 08:33:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49926) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU4H6-0008KU-2i for 75345-done@debbugs.gnu.org; Sat, 04 Jan 2025 08:33:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU4H0-0002QG-Lt; Sat, 04 Jan 2025 08:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MwX14PMjLbG1k5gOKAx4JZpvfPJX1ubDwwJ2pS/gtXY=; b=jjN8x1PhZvpdHc/STZ6p VRzvuTo1vyDMRAAJigPxhmqsNQBrJTQ7G1XxzgAJHsZU59Pv30Q4OoqAbFIFC7JKxJoww2XeX1t9B hW2e6RQWHABfD8HGRKYDJW8Jss2Do3X9jFr9MzKKZwfdI6C7PghCdxUTJEv334X1esLtwT1bJJfVz +ao6Of209sQKk8ER17FwA5YteJ+sru+BCBs/sCVtkLR2OQ5kw7lzJ6WV5tsM+3CT9GjAu1HLjH0lW wasf22Y9kVdKViajYycXUBbllpsYyJdudP58YEXK1nxpDXvCu/RNJmkycdKr1vzrtz7PRLaA7xoDh DF61cv2llk8XVg==; Date: Sat, 04 Jan 2025 15:32:59 +0200 Message-Id: <86msg6d7qs.fsf@gnu.org> From: Eli Zaretskii To: Ulrich =?utf-8?Q?M=C3=BCller?= In-Reply-To: (message from Ulrich =?utf-8?Q?M=C3=BC?= =?utf-8?Q?ller?= on Sat, 04 Jan 2025 10:50:04 +0100) Subject: Re: bug#75345: 29.4; 'insert' doc string still mentions 'string-as-multibyte' References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75345-done Cc: 75345-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Müller > Date: Sat, 04 Jan 2025 10:50:04 +0100 > > C-h f insert RET > > insert is a built-in function in ‘src/editfns.c’. > > [...] > > When operating on binary data, it may be necessary to preserve the > original bytes of a unibyte string when inserting it into a multibyte > buffer; to accomplish this, apply ‘string-as-multibyte’ to the string > and insert the result. > > C-h f string-as-multibyte RET > > string-as-multibyte is a built-in function in ‘src/fns.c’. > > This function is obsolete since 26.1; use `decode-coding-string'. > > [...] > > This looks inconsistent, presumably 'insert' shouldn't mention > 'string-as-multibyte'. Attached patch updates the doc string. Thanks, installed on emacs-30, and closing the bug. > Also, the elisp manual still mentions functions string-as-unibyte and > string-as-multibyte in section "(elisp) Top > Non-ASCII Characters > > Selecting a Representation". Should these be removed from the manual, > or at least be labelled as obsolete? I'm not yet convinced these functions should be removed from the manual. ------------=_1735997642-32102-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jan 2025 09:50:25 +0000 Received: from localhost ([127.0.0.1]:53404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU0nY-0006NF-Bh for submit@debbugs.gnu.org; Sat, 04 Jan 2025 04:50:24 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60830) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU0nU-0006KO-Tk for submit@debbugs.gnu.org; Sat, 04 Jan 2025 04:50:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU0nP-0003cS-Gj for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 04:50:15 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1tU0nN-0005Z2-E2 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 04:50:15 -0500 From: =?utf-8?Q?Ulrich_M=C3=BCller?= To: bug-gnu-emacs@gnu.org Subject: 29.4; 'insert' doc string still mentions 'string-as-multibyte' Date: Sat, 04 Jan 2025 10:50:04 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=140.211.166.183; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable C-h f insert RET insert is a built-in function in =E2=80=98src/editfns.c=E2=80=99. [...] When operating on binary data, it may be necessary to preserve the original bytes of a unibyte string when inserting it into a multibyte buffer; to accomplish this, apply =E2=80=98string-as-multibyte=E2=80=99 = to the string and insert the result. C-h f string-as-multibyte RET string-as-multibyte is a built-in function in =E2=80=98src/fns.c=E2=80= =99. This function is obsolete since 26.1; use `decode-coding-string'. [...] This looks inconsistent, presumably 'insert' shouldn't mention 'string-as-multibyte'. Attached patch updates the doc string. Also, the elisp manual still mentions functions string-as-unibyte and string-as-multibyte in section "(elisp) Top > Non-ASCII Characters > Selecting a Representation". Should these be removed from the manual, or at least be labelled as obsolete? --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=0001-Update-insert-doc-string.patch >From 858f94f942cb40481ac8bc83a36ae5555066c1bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Sat, 4 Jan 2025 10:37:59 +0100 Subject: [PATCH] Update 'insert' doc string * src/editfns.c (Finsert): Mention 'decode-coding-string' instead of the obsolete 'string-as-multibyte' in doc string. --- src/editfns.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/editfns.c b/src/editfns.c index 581bd03798e..8a5fb673fe7 100644 --- a/src/editfns.c +++ b/src/editfns.c @@ -1363,8 +1363,8 @@ DEFUN ("insert", Finsert, Sinsert, 0, MANY, 0, When operating on binary data, it may be necessary to preserve the original bytes of a unibyte string when inserting it into a multibyte -buffer; to accomplish this, apply `string-as-multibyte' to the string -and insert the result. +buffer; to accomplish this, apply `decode-coding-string' with the +`no-conversion' coding system to the string and insert the result. usage: (insert &rest ARGS) */) (ptrdiff_t nargs, Lisp_Object *args) -- 2.47.1 --=-=-=-- ------------=_1735997642-32102-1--