From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 13:31:02 2010 Received: (at submit) by debbugs.gnu.org; 2 Dec 2010 18:31:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PODvq-0002Wc-27 for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:31:02 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PODvo-0002W9-Ci for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:31:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POE1J-0004GP-Pk for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:36:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:52338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POE1J-0004GC-LC for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:36:41 -0500 Received: from [140.186.70.92] (port=36404 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POE1D-000173-D1 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:36:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POE1C-0004Dp-5X for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:36:35 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:34232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POE1B-0004Cv-U2 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:36:34 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oB2IaRiq001529 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Dec 2010 18:36:28 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oB2D2PZe009505 for ; Thu, 2 Dec 2010 18:36:25 GMT Received: from abhmt015.oracle.com by acsmt353.oracle.com with ESMTP id 821754871291314941; Thu, 02 Dec 2010 10:35:41 -0800 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Dec 2010 10:35:40 -0800 From: "Drew Adams" To: Subject: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 2 Dec 2010 10:35:41 -0800 Message-ID: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuST7jZ+vG5eHSuQGaLE6rmmo1WQQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) This is another one of those annoyances that come from not testing with non-nil `pop-up-frames' (just a guess). emacs -Q M-x set-variable RET pop-up-frames RET t RET In Dired, flag several files for deletion, then hit `x'. Answer `yes' or `no'. When you hit `x' buffer *Deletions* pops up in its own frame, as it should. When you type `yes' or `no', the frame should disappear. It should be deleted. The last part of `dired-mark-pop-up' should be something like this: (save-window-excursion (dired-pop-to-buffer bufname) (apply function args) (if (one-window-p) (delete-frame) (delete-window))) ; <===== NEW If you don't think the `delete-window' is needed, then just use (when (one-window-p) (delete-frame)). The important thing, for me, is that the frame that was created just to show the files that will be deleted (or whatever) goes away. It should be only a _temporary_ frame because its only raison d'etre is as part of the deletion etc. _dialog_. [Martin will explain that a different test from `one-window-p' is more appropriate. ;-) IIRC, he generally prefers something like this to (one-window-p win): (eq win (frame-root-window (window-frame win))).] In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-11-30 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 13:59:45 2010 Received: (at 7533) by debbugs.gnu.org; 2 Dec 2010 18:59:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POENd-0003MN-Bg for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:59:45 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1POENa-0003M0-7A for 7533@debbugs.gnu.org; Thu, 02 Dec 2010 13:59:43 -0500 Received: (qmail invoked by alias); 02 Dec 2010 19:05:23 -0000 Received: from 62-47-51-60.adsl.highway.telekom.at (EHLO [62.47.51.60]) [62.47.51.60] by mail.gmx.net (mp068) with SMTP; 02 Dec 2010 20:05:23 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+02CFQrti01LZEUo6oY7DMFis+UdGNTtDBbcUkj2 mmZIRZ83v690As Message-ID: <4CF7EDED.5090500@gmx.at> Date: Thu, 02 Dec 2010 20:05:17 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> In-Reply-To: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > (save-window-excursion > (dired-pop-to-buffer bufname) > (apply function args) > (if (one-window-p) (delete-frame) (delete-window))) ; <===== NEW This would be funny when `pop-up-frames' is nil and a window gets reused for showing the *Deletions* buffer. In particular if that window is the only window on its frame ;-) BTW the `save-window-excursion' is completely useless when you pop up a new frame. > The important thing, for me, is that the frame that was created just to > show the files that will be deleted (or whatever) goes away. It should > be only a _temporary_ frame because its only raison d'etre is as part of > the deletion etc. _dialog_. Here I have a simple function called `quit-restore-window' which does exactly that. > [Martin will explain that a different test from `one-window-p' is more > appropriate. ;-) IIRC, he generally prefers something like this to > (one-window-p win): (eq win (frame-root-window (window-frame win))).] Because `one-window-p' calls `next-window' which I don't like. See the recent discussion about `loop' endlessly cycling over windows. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 14:17:08 2010 Received: (at 7533) by debbugs.gnu.org; 2 Dec 2010 19:17:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POEeR-0003y3-Kd for submit@debbugs.gnu.org; Thu, 02 Dec 2010 14:17:07 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POEeQ-0003xN-74 for 7533@debbugs.gnu.org; Thu, 02 Dec 2010 14:17:06 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oB2JMe8W026565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 2 Dec 2010 19:22:42 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oB28Ofoq024228; Thu, 2 Dec 2010 19:22:38 GMT Received: from abhmt018.oracle.com by acsmt355.oracle.com with ESMTP id 821860081291317730; Thu, 02 Dec 2010 11:22:10 -0800 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Dec 2010 11:22:10 -0800 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 2 Dec 2010 11:22:11 -0800 Message-ID: <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4CF7EDED.5090500@gmx.at> Thread-Index: AcuSU+FMDb7mFhguRVqKcIvJHqTY/gAAPDbg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > This would be funny when `pop-up-frames' is nil and a window > gets reused for showing the *Deletions* buffer. In particular > if that window is the only window on its frame ;-) Agreed. But what's the right test? It is _not_ `pop-up-frames' non-nil, because users can do other things than that to cause a new frame to be created for this dialog. What's needed is a test of whether a frame was newly created for this dialog buffer. What's the code for that test? > BTW the `save-window-excursion' is completely useless when > you pop up a new frame. Yes, I know. It was already there, and I left it. It seems benign in this case AFAICT, but feel free to fix this as it really should be fixed. The bug report is about the annoyance of not deleting a new frame that was created (using whatever mechanism, including non-nil `pop-up-frames') for dialog purposes. When the dialog is finished, such a new frame should disappear. Users should not need to manually delete it. How the bug gets fixed is up to you. I'm reporting the problem, not a particular fix. > > The important thing, for me, is that the frame that was > > created just to show the files that will be deleted (or whatever) > > goes away. It should be only a _temporary_ frame because its only > > raison d'etre is as part of the deletion etc. _dialog_. > > Here I have a simple function called `quit-restore-window' which does > exactly that. If that does what's needed, fine; go for it. I have no objection. > > [Martin will explain that a different test from > > `one-window-p' is more appropriate. ;-) IIRC, he generally > > prefers something like this to (one-window-p win): > > (eq win (frame-root-window (window-frame win))).] > > Because `one-window-p' calls `next-window' which I don't > like. See the recent discussion about `loop' endlessly cycling > over windows. As I said, "Martin will explain...". That's fine with me, as long as the bug gets fixed. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 03:12:15 2010 Received: (at 7533) by debbugs.gnu.org; 3 Dec 2010 08:12:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POQkZ-0003DB-MH for submit@debbugs.gnu.org; Fri, 03 Dec 2010 03:12:15 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1POQkW-0003Cd-Qk for 7533@debbugs.gnu.org; Fri, 03 Dec 2010 03:12:14 -0500 Received: (qmail invoked by alias); 03 Dec 2010 08:17:54 -0000 Received: from 62-47-44-37.adsl.highway.telekom.at (EHLO [62.47.44.37]) [62.47.44.37] by mail.gmx.net (mp026) with SMTP; 03 Dec 2010 09:17:54 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/jdzVquXDjj2KRauiCV9aYzEdxUVRIvaILt9qh5+ 0yJqPPJsuVuNKU Message-ID: <4CF8A7B2.5080306@gmx.at> Date: Fri, 03 Dec 2010 09:17:54 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> In-Reply-To: <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > Agreed. But what's the right test? It is _not_ `pop-up-frames' non-nil, > because users can do other things than that to cause a new frame to be created > for this dialog. What's needed is a test of whether a frame was newly created > for this dialog buffer. What's the code for that test? In the past, routines usually tested the settings of variables like `pop-up-windows' or `pop-up-frames' to guess the expected behavior of `display-buffer'. In most cases the guesses were correct. In a few corner cases they failed and the example you cite above is one of them. Here I have two things: A window parameter that tells for each window whether the current buffer is the first buffer shown in it and a separate global variable which gives some rudimentary information about what the last `display-buffer' invocation did to find a suitable window. The former exists independently of `display-buffer' so it also works for a "manually" constructed or reused window or frame. The latter is `display-buffer' specific and is mainly used for providing some feedback about the change of the entire window configuration. >> BTW the `save-window-excursion' is completely useless when >> you pop up a new frame. > > Yes, I know. It was already there, and I left it. It seems benign in this case > AFAICT, but feel free to fix this as it really should be fixed. `save-window-excursion' is hardly ever benign. Whenever you find a `display-buffer' wrapped in a `save-window-excursion' you can be 100% sure that the code fails with popped up frames. > The bug report is about the annoyance of not deleting a new frame that was > created (using whatever mechanism, including non-nil `pop-up-frames') for dialog > purposes. When the dialog is finished, such a new frame should disappear. > Users should not need to manually delete it. There's no formal definition of "dialog purpose" in Emacs and it's not easy to do that in general. The major problem to address is whether and how such a dialog can be disrupted by other activities and how to resume it at a later time. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 11:17:18 2010 Received: (at 7533) by debbugs.gnu.org; 3 Dec 2010 16:17:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POYJx-0003co-KB for submit@debbugs.gnu.org; Fri, 03 Dec 2010 11:17:18 -0500 Received: from rcsinet11.oracle.com ([148.87.113.123]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POYJu-0003cZ-Ao for 7533@debbugs.gnu.org; Fri, 03 Dec 2010 11:17:15 -0500 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet11.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oB3GMvVd029214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Dec 2010 16:22:58 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oB36otkF025383; Fri, 3 Dec 2010 16:22:56 GMT Received: from abhmt021.oracle.com by acsmt355.oracle.com with ESMTP id 841948351291393373; Fri, 03 Dec 2010 08:22:53 -0800 Received: from dradamslap1 (/10.159.244.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 03 Dec 2010 08:22:52 -0800 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> <4CF8A7B2.5080306@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 3 Dec 2010 08:22:51 -0800 Message-ID: <1880532436F6447B97DC61F6050FF29F@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuSwpfmCfbU1kWsRN2WxvFkVRkclwAQFafQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 In-Reply-To: <4CF8A7B2.5080306@gmx.at> X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > But what's the right test? It is _not_ `pop-up-frames' non-nil, > > because users can do other things than that to cause a new > > frame to be created for this dialog. What's needed is a test of > > whether a frame was newly created for this dialog buffer. > > What's the code for that test? > > In the past, routines usually tested the settings of variables like > `pop-up-windows' or `pop-up-frames' to guess the expected behavior of > `display-buffer'. In most cases the guesses were correct. In a few > corner cases they failed and the example you cite above is > one of them. What do you mean by "in the past"? In the past I saw no such problem as that reported in this bug. (On the contrary - this annoyance was introduced in Emacs 23 - see below.) > Here I have two things: A window parameter that tells for each window > whether the current buffer is the first buffer shown in it and a > separate global variable which gives some rudimentary > information about what the last `display-buffer' invocation did to find a > suitable window. The former exists independently of `display-buffer' so it > also works for a "manually" constructed or reused window or frame. The latter is > `display-buffer' specific and is mainly used for providing some feedback > about the change of the entire window configuration. Please be specific. What window parameter? What global variable? Just what are you trying to say? I can't even tell whether you're saying that you _have_ a solution or there _is no_ solution. I repeat: "what's the right test?" What's the solution? > > The bug report is about the annoyance of not deleting a > > new frame that was created (using whatever mechanism, including non-nil > > `pop-up-frames') for dialog purposes. When the dialog is finished, > > such a new frame should disappear. Users should not need to > > manually delete it. > > There's no formal definition of "dialog purpose" in Emacs and it's not > easy to do that in general. No one's asking for a "formal definition" of anything. The *Deletions* (or whatever) window that lists the files that will be acted on if you type `yes' is supplementary help for answering the prompt - nothing more. Its only reason for being displayed ends as soon as you've answered the prompt. I call that a dialog: ask a question and pop up some help for understanding the question, then remove the displayed help when the question is answered. You can call it anything you want. No "formal definition" is needed here, AFAICS. If for some reason we cannot fix this, with all of the fancy artillary we have in Emacs 24, then please at least regress to the sane behavior of older releases. Until Emacs 23, the help buffer here (e.g. *Marked Files*, *Deletions*, whatever) was always popped up as a window, not as a frame, even if you had non-nil `pop-up-frames'. And that window was (naturally) deleted when you type yes/no. That behavior was fine (IMO). We've "progressed" to a PITA (introduced in 23). If you can obtain similar behavior for a popup frame, fine. If not, then please restore the pre-23.2 design for such dialogs. > The major problem to address is whether and > how such a dialog can be disrupted by other activities and > how to resume it at a later time. If it's a major problem and you will end up complicating things further in order to solve it, then I vote for a return to the simple behavior of the past. That at least was not annoying and did not force users to manually close frames. Thx. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 13:11:16 2010 Received: (at 7533) by debbugs.gnu.org; 3 Dec 2010 18:11:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POa6G-0006od-3X for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:11:16 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1POa6D-0006oO-I5 for 7533@debbugs.gnu.org; Fri, 03 Dec 2010 13:11:14 -0500 Received: (qmail invoked by alias); 03 Dec 2010 18:16:56 -0000 Received: from 62-47-55-94.adsl.highway.telekom.at (EHLO [62.47.55.94]) [62.47.55.94] by mail.gmx.net (mp006) with SMTP; 03 Dec 2010 19:16:56 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18vYapo15wvhbIADnLiIWJFBTD01Sl98NibyWCUqa YOaq56yD80Gj1k Message-ID: <4CF93418.9090405@gmx.at> Date: Fri, 03 Dec 2010 19:16:56 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> <4CF8A7B2.5080306@gmx.at> <1880532436F6447B97DC61F6050FF29F@us.oracle.com> In-Reply-To: <1880532436F6447B97DC61F6050FF29F@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > What do you mean by "in the past"? I wanted to express my hope that this will change in the future. > Please be specific. What window parameter? What global variable? Just what > are you trying to say? I can't even tell whether you're saying that you _have_ > a solution or there _is no_ solution. If you're really interested have a look at the window-pub branch. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 13:29:09 2010 Received: (at 7533) by debbugs.gnu.org; 3 Dec 2010 18:29:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POaNZ-0007DS-I3 for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:29:09 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POaNX-0007DG-Lj for 7533@debbugs.gnu.org; Fri, 03 Dec 2010 13:29:08 -0500 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oB3IYoi4012013 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Dec 2010 18:34:51 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oB3ELYFo010843; Fri, 3 Dec 2010 18:34:48 GMT Received: from abhmt007.oracle.com by acsmt353.oracle.com with ESMTP id 824868211291401186; Fri, 03 Dec 2010 10:33:06 -0800 Received: from dradamslap1 (/10.159.244.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 03 Dec 2010 10:33:06 -0800 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> <4CF8A7B2.5080306@gmx.at> <1880532436F6447B97DC61F6050FF29F@us.oracle.com> <4CF93418.9090405@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 3 Dec 2010 10:33:06 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuTFkgyvSukpwiDQqSppnid5c1svQAAcACA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 In-Reply-To: <4CF93418.9090405@gmx.at> X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > Please be specific. What window parameter? What global > > variable? Just what are you trying to say? I can't even > > tell whether you're saying that you _have_ a solution or > > there _is no_ solution. > > If you're really interested have a look at the window-pub branch. Oh, so you were referring to something that is not (yet) in Emacs. That wasn't clear from what you wrote. What I'm interested in is a fix for this bug - in the next Emacs release. How that's done I don't much care. Whether the fix comes from the "window-pub" branch (whatever that is) or from somewhere else doesn't matter to me. It's the user-visible behavior in the next Emacs release that I'm concerned about. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 13:36:03 2010 Received: (at 7533) by debbugs.gnu.org; 3 Dec 2010 18:36:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POaUE-0007N4-P1 for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:36:02 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1POaUC-0007Ma-T7 for 7533@debbugs.gnu.org; Fri, 03 Dec 2010 13:36:02 -0500 Received: (qmail invoked by alias); 03 Dec 2010 18:41:44 -0000 Received: from 62-47-55-94.adsl.highway.telekom.at (EHLO [62.47.55.94]) [62.47.55.94] by mail.gmx.net (mp016) with SMTP; 03 Dec 2010 19:41:44 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18I6C5z53gIYFfSkHd+KpYeFtU5YJ7OlfTWFNgUp7 uc8jkcbOl5aosU Message-ID: <4CF939E7.6030603@gmx.at> Date: Fri, 03 Dec 2010 19:41:43 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> <4CF8A7B2.5080306@gmx.at> <1880532436F6447B97DC61F6050FF29F@us.oracle.com> <4CF93418.9090405@gmx.at> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050701040502010406080005" X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7533 Cc: Chong Yidong , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) This is a multi-part message in MIME format. --------------050701040502010406080005 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > What I'm interested in is a fix for this bug - in the next Emacs release. Meanwhile we should restore the old behavior. Chong could you please apply the attached patch. martin --------------050701040502010406080005 Content-Type: text/plain; name="dired.el.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dired.el.diff" *** /lisp/dired.el 2010-11-10 10:58:50.000000000 +0100 --- /lisp/dired.el 2010-12-03 19:31:02.234375000 +0100 *************** *** 2757,2763 **** ;; that's possible. (Bug#1806) (split-window-vertically)) ;; Otherwise, try to split WINDOW sensibly. ! (split-window-sensibly window))))) (pop-to-buffer (get-buffer-create buf))) ;; If dired-shrink-to-fit is t, make its window fit its contents. (when dired-shrink-to-fit --- 2757,2764 ---- ;; that's possible. (Bug#1806) (split-window-vertically)) ;; Otherwise, try to split WINDOW sensibly. ! (split-window-sensibly window)))) ! pop-up-frames) (pop-to-buffer (get-buffer-create buf))) ;; If dired-shrink-to-fit is t, make its window fit its contents. (when dired-shrink-to-fit --------------050701040502010406080005-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 15:21:33 2010 Received: (at 7533) by debbugs.gnu.org; 3 Dec 2010 20:21:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POc8L-0001R9-1H for submit@debbugs.gnu.org; Fri, 03 Dec 2010 15:21:33 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POc8J-0001Qs-F2 for 7533@debbugs.gnu.org; Fri, 03 Dec 2010 15:21:32 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oB3KREpC022133; Fri, 3 Dec 2010 15:27:14 -0500 Received: by pastel.home (Postfix, from userid 20848) id AA280A8364; Fri, 3 Dec 2010 15:27:09 -0500 (EST) From: Stefan Monnier To: martin rudalics Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Message-ID: References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> <4CF8A7B2.5080306@gmx.at> Date: Fri, 03 Dec 2010 15:27:09 -0500 In-Reply-To: <4CF8A7B2.5080306@gmx.at> (martin rudalics's message of "Fri, 03 Dec 2010 09:17:54 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3698=0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Here I have two things: A window parameter that tells for each window > whether the current buffer is the first buffer shown in it and a > separate global variable which gives some rudimentary information about > what the last `display-buffer' invocation did to find a suitable window. Indeed. We currently have display-buffer-mark-dedicated which goes in this direction, but uses dedicatedness, which is not always desired, apparently. I think that adding a "buffer for which this window was created" window parameter and always set it in display-buffer (regardless of display-buffer-mark-dedicated) should allow correct handling of such situations. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 17:38:15 2010 Received: (at 7533) by debbugs.gnu.org; 4 Dec 2010 22:38:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0kB-0008Dv-5X for submit@debbugs.gnu.org; Sat, 04 Dec 2010 17:38:15 -0500 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0k8-0008Dg-TA for 7533@debbugs.gnu.org; Sat, 04 Dec 2010 17:38:13 -0500 Received: from furball (dhcp128036014248.central.yale.edu [128.36.14.248]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB4Mi07G009312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 4 Dec 2010 17:44:00 -0500 Received: by furball (Postfix, from userid 1000) id 6A9F616059F; Sat, 4 Dec 2010 17:44:00 -0500 (EST) From: Chong Yidong To: martin rudalics Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> <4CF8A7B2.5080306@gmx.at> <1880532436F6447B97DC61F6050FF29F@us.oracle.com> <4CF93418.9090405@gmx.at> <4CF939E7.6030603@gmx.at> Date: Sat, 04 Dec 2010 17:44:00 -0500 In-Reply-To: <4CF939E7.6030603@gmx.at> (martin rudalics's message of "Fri, 03 Dec 2010 19:41:43 +0100") Message-ID: <87zkslw43z.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) martin rudalics writes: > Meanwhile we should restore the old behavior. Chong could > you please apply the attached patch. Done. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 16 13:24:22 2010 Received: (at 7533) by debbugs.gnu.org; 16 Dec 2010 18:24:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTIV4-0007yD-5S for submit@debbugs.gnu.org; Thu, 16 Dec 2010 13:24:22 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTIV2-0007y2-Oq for 7533@debbugs.gnu.org; Thu, 16 Dec 2010 13:24:21 -0500 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBGIUc8A031573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Dec 2010 18:30:39 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBGIUQgH027735; Thu, 16 Dec 2010 18:30:37 GMT Received: from abhmt015.oracle.com by acsmt354.oracle.com with ESMTP id 881612011292524069; Thu, 16 Dec 2010 10:27:49 -0800 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 16 Dec 2010 10:27:49 -0800 From: "Drew Adams" To: "'Chong Yidong'" , "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><1880532436F6447B97DC61F6050FF29F@us.oracle.com><4CF93418.9090405@gmx.at><4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 16 Dec 2010 10:27:48 -0800 Message-ID: <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuUBMSji4UDtO6SSS+1BaNJ35jDTgJRn36A In-Reply-To: <87zkslw43z.fsf@stupidchicken.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > Meanwhile we should restore the old behavior. Chong could > > you please apply the attached patch. > > Done. FWIW, I still see the problem in the latest Windows binary: In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-12-13 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' Martin's patch fixes the problem only for non-nil `pop-up-frames'. (So strictly speaking it responds to the Subject line of the bug. But it does not respond fully to what I meant in the bug report.) It does not fix the problem if the buffer (e.g. `*Marked Files*') is popped up in a separate frame for some other reason, for example, via `special-display-popup-frame'. To reproduce: emacs -Q M-x set-variable RET special-display-regexps RET ("[ ]?[*][^*]+[*]") RET The bug needs to be fixed so that _whenever_ the buffer is shown in a separate frame that frame gets deleted when the dialog is finished (e.g. when the Dired command to copy/delete/... is finished). If you think a full fix is too complicated for now for some reason, then at least bind `q' in that popped up buffer so that `q' invokes `quit-window' (_not_ `View-quit'), which will delete the frame. IOW, as a workaround, at least give it the behavior of *Buffer List*, where hitting `q' deletes the frame, Obliging the user to hit `q' is not the real solution. It just provides a temporary workaround and should be considered only if you conclude that implementing a good solution is too hard for the moment. Alternatively, restore the behavior in Emacs 22, where even if `special-display-regexps' would normally cause the buffer to be displayed in a separate frame it is not: it is popped up in a window of the current frame. That overrides the user's setting, but at least it is not annoying. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 01:25:56 2010 Received: (at 7533) by debbugs.gnu.org; 17 Dec 2010 06:25:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTTlL-0007wm-Jf for submit@debbugs.gnu.org; Fri, 17 Dec 2010 01:25:55 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PTTlJ-0007wa-1i for 7533@debbugs.gnu.org; Fri, 17 Dec 2010 01:25:54 -0500 Received: (qmail invoked by alias); 17 Dec 2010 06:32:13 -0000 Received: from 62-47-60-151.adsl.highway.telekom.at (EHLO [62.47.60.151]) [62.47.60.151] by mail.gmx.net (mp038) with SMTP; 17 Dec 2010 07:32:13 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19o3R5zcPpooZv5rGmQth/DtkPuPO6KRvIovbibKm jdE9Uf/4vLmIsU Message-ID: <4D0B03EB.4050706@gmx.at> Date: Fri, 17 Dec 2010 07:32:11 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><1880532436F6447B97DC61F6050FF29F@us.oracle.com><4CF93418.9090405@gmx.at><4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> In-Reply-To: <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7533 Cc: 'Chong Yidong' , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > M-x set-variable RET > special-display-regexps RET > ("[ ]?[*][^*]+[*]") RET You shouldn't include the buffer in `special-display-regexps' in the first place. Or, write a separate entry for such buffers. > Alternatively, restore the behavior in Emacs 22, where even if > `special-display-regexps' would normally cause the buffer to be displayed in a > separate frame it is not: it is popped up in a window of the current frame. Not necessarily: Try customizing `dired-shrink-to-fit' to nil. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 10:26:23 2010 Received: (at 7533) by debbugs.gnu.org; 17 Dec 2010 15:26:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTcCM-0007go-FR for submit@debbugs.gnu.org; Fri, 17 Dec 2010 10:26:22 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTcCJ-0007gb-Nc for 7533@debbugs.gnu.org; Fri, 17 Dec 2010 10:26:20 -0500 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBHFWdSf004994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Dec 2010 15:32:40 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBHFWcu6011831; Fri, 17 Dec 2010 15:32:38 GMT Received: from abhmt010.oracle.com by acsmt353.oracle.com with ESMTP id 863317541292599952; Fri, 17 Dec 2010 07:32:32 -0800 Received: from dradamslap1 (/10.159.231.83) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 17 Dec 2010 07:32:32 -0800 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><1880532436F6447B97DC61F6050FF29F@us.oracle.com><4CF93418.9090405@gmx.at><4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> <4D0B03EB.4050706@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 17 Dec 2010 07:32:27 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4D0B03EB.4050706@gmx.at> Thread-Index: AcudtCWPhA4eb4WfTfaxQqwEySNbUQAQ7nkg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: 'Chong Yidong' , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > M-x set-variable RET > > special-display-regexps RET > > ("[ ]?[*][^*]+[*]") RET > > You shouldn't include the buffer in `special-display-regexps' in the > first place. Or, write a separate entry for such buffers. That, my friend, is utterly ridiculous. Why not just tell me I shouldn't use Emacs because it inconveniences you? That's why we have option `special-display-regexps'. I _want_ such buffers to be displayed in a separate frame whenever they are displayed. And no, I do not want to be obliged to specify separately the name of each buffer that Emacs might decide to use in a temporary dialog to provide info for a dialog question. That's just silly. That you would even bring it up, let alone proclaim it as a rule ("you shouldn't") suggests bad faith. The fact that when using `C', `x', etc. in Dired Emacs cannot tell that the temporary display of a pop-up buffer is no longer needed after you hit RET, and that Emacs does not remove such a frame like it removes a temporary pop-up window, is a failing on Emacs's part. The word "brain-dead" comes to mind (for Emacs, not for you). The world's best editor was not built to act like this. From a user perspective this is a regression since Emacs 22. Until release 23 Emacs was completely sane in this respect - since Day One. I've mentioned a couple of possible workarounds, the best of which is to just return to the Emacs 22 behavior. But ideally the code should be fixed to remove the frame when the Dired command interaction is finished. There is no reason to show the buffer after the operation is done. That buffer is a list of objects that _will_ be acted on _if_ you confirm. After you confirm (or deny) its display has no raison d'etre. Apparently you think that the proper fix of removing the frame is too hard to implement for some reason. In that case I request that we return to the sane behavior of Emacs 22. > > Alternatively, restore the behavior in Emacs 22, where even if > > `special-display-regexps' would normally cause the buffer > > to be displayed in a separate frame it is not: it is popped > > up in a window of the current frame. > > Not necessarily: Try customizing `dired-shrink-to-fit' to nil. emacs -Q in Emacs 22 does exactly what I described: it pops up a window, not a frame, and it removes the window when the user dialog is finished. (And `dired-shrink-to-fit' should simply be removed. The only reason it ever existed was for people on connections less than 1200 baud (300, 900). See Richard's comment in the source code.) Sounds like you are just _searching_ for reasons to defend this regression and not fix this bug. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 11:06:04 2010 Received: (at 7533) by debbugs.gnu.org; 17 Dec 2010 16:06:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTcol-0000AA-S3 for submit@debbugs.gnu.org; Fri, 17 Dec 2010 11:06:04 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PTcoj-00009g-BM for 7533@debbugs.gnu.org; Fri, 17 Dec 2010 11:06:02 -0500 Received: (qmail invoked by alias); 17 Dec 2010 16:12:20 -0000 Received: from 62-47-57-88.adsl.highway.telekom.at (EHLO [62.47.57.88]) [62.47.57.88] by mail.gmx.net (mp014) with SMTP; 17 Dec 2010 17:12:20 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX189HSgOE4A96bo06gj7ACyQuajjE95wLoaXHr5MHf qmShdqc6h3/uCT Message-ID: <4D0B8BE4.2050401@gmx.at> Date: Fri, 17 Dec 2010 17:12:20 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><1880532436F6447B97DC61F6050FF29F@us.oracle.com><4CF93418.9090405@gmx.at><4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> <4D0B03EB.4050706@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7533 Cc: 'Chong Yidong' , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > Apparently you think that the proper fix of removing the frame is too hard to > implement for some reason. In that case I request that we return to the sane > behavior of Emacs 22. You can get the "sane" behavior if you don't include such buffers in `special-display-regexps'. > emacs -Q in Emacs 22 does exactly what I described: it pops up a window, not a > frame, and it removes the window when the user dialog is finished. emacs -Q in Emacs 23 does the same. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 11:50:48 2010 Received: (at 7533) by debbugs.gnu.org; 17 Dec 2010 16:50:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTdW4-0001Bj-I3 for submit@debbugs.gnu.org; Fri, 17 Dec 2010 11:50:48 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTdW2-0001BS-5T for 7533@debbugs.gnu.org; Fri, 17 Dec 2010 11:50:46 -0500 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBHGv4T6028442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Dec 2010 16:57:05 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBHGqVOj005378; Fri, 17 Dec 2010 16:56:43 GMT Received: from abhmt012.oracle.com by acsmt355.oracle.com with ESMTP id 885341071292604943; Fri, 17 Dec 2010 08:55:43 -0800 Received: from dradamslap1 (/10.159.229.142) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 17 Dec 2010 08:55:43 -0800 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><1880532436F6447B97DC61F6050FF29F@us.oracle.com><4CF93418.9090405@gmx.at><4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> <4D0B03EB.4050706@gmx.at> <4D0B8BE4.2050401@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 17 Dec 2010 08:55:40 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4D0B8BE4.2050401@gmx.at> Thread-Index: AcueBTFWDWz0EahgRwGb7PsNC2jfwgABNwDQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: 'Chong Yidong' , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > Apparently you think that the proper fix of removing the > > frame is too hard to implement for some reason. In that > > case I request that we return to the sane behavior of Emacs 22. > > You can get the "sane" behavior if you don't include such buffers in > `special-display-regexps'. > > > emacs -Q in Emacs 22 does exactly what I described: it > > pops up a window, not a frame, and it removes the window > > when the user dialog is finished. > > emacs -Q in Emacs 23 does the same. Not at all. The context you omitted makes it clear that (a) you are reaching for straws by bringing in `dired-shrink-to-fit' and (b) Emacs 22 does not suffer the bug: it removes the temporary display when done. You are showing nothing but bad faith. Why did you even make the partial fix, wrt `pop-up-frames'? Why don't you just tell users they can get the "sane" behavior by setting `pop-up-frames' to nil? This is a sorry state indeed. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 13:02:47 2010 Received: (at 7533) by debbugs.gnu.org; 17 Dec 2010 18:02:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTedj-0002qM-Ez for submit@debbugs.gnu.org; Fri, 17 Dec 2010 13:02:47 -0500 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PTedg-0002q8-P3 for 7533@debbugs.gnu.org; Fri, 17 Dec 2010 13:02:46 -0500 Received: (qmail invoked by alias); 17 Dec 2010 18:09:05 -0000 Received: from 62-47-57-88.adsl.highway.telekom.at (EHLO [62.47.57.88]) [62.47.57.88] by mail.gmx.net (mp071) with SMTP; 17 Dec 2010 19:09:05 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/SiSUD1CTS2fjU5E+fG/iWES+kBzlqLpdvAmyfPH N24MyY7zFrCJLu Message-ID: <4D0BA741.2080606@gmx.at> Date: Fri, 17 Dec 2010 19:09:05 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><1880532436F6447B97DC61F6050FF29F@us.oracle.com><4CF93418.9090405@gmx.at><4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> <4D0B03EB.4050706@gmx.at> <4D0B8BE4.2050401@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7533 Cc: 'Chong Yidong' , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > You are showing nothing but bad faith. Why did you even make the partial fix, > wrt `pop-up-frames'? Why don't you just tell users they can get the "sane" > behavior by setting `pop-up-frames' to nil? This is a sorry state indeed. `pop-up-frames' expresses a general preference so I asked Chong to make that change. `special-display-regexps' expresses a special preference. But if nobody objects we can bind things like `special-display-regexps' and `special-display-buffer-names' to nil here too. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 13:34:31 2010 Received: (at 7533) by debbugs.gnu.org; 17 Dec 2010 18:34:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTf8R-0003az-Bv for submit@debbugs.gnu.org; Fri, 17 Dec 2010 13:34:31 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTf8G-0003af-VN for 7533@debbugs.gnu.org; Fri, 17 Dec 2010 13:34:30 -0500 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBHIeemX010010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Dec 2010 18:40:42 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBHIcK2B029699; Fri, 17 Dec 2010 18:40:40 GMT Received: from abhmt020.oracle.com by acsmt355.oracle.com with ESMTP id 863837671292611238; Fri, 17 Dec 2010 10:40:38 -0800 Received: from dradamslap1 (/10.159.229.142) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 17 Dec 2010 10:40:38 -0800 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><1880532436F6447B97DC61F6050FF29F@us.oracle.com><4CF93418.9090405@gmx.at><4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> <4D0B03EB.4050706@gmx.at> <4D0B8BE4.2050401@gmx.at> <4D0BA741.2080606@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 17 Dec 2010 10:40:36 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4D0BA741.2080606@gmx.at> Thread-Index: AcueFX9zEhRnc7dwR/ichx1cWjbxtwAAuLEw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: 'Chong Yidong' , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > `pop-up-frames' expresses a general preference so I asked > Chong to make that change. `special-display-regexps' > expresses a special preference. But if nobody objects we > can bind things like `special-display-regexps' > and `special-display-buffer-names' to nil here too. That's better than nothing, IMO. It recognizes that this buffer display, whether in a frame or window, is only temporary, for the duration of the confirmation interaction: there is no reason to show the buffer after the command is done. However, the right fix is to (a) respect a user's preference to show such buffers in a special frame and then (b) delete the frame. It is especially not very kosher to override `special-display-buffer-names', because that option can let users specify not only a buffer name but a specific function to display it. IOW, the most important thing in this context is to remove the buffer display when done. But it is also important to do what the user wants. So showing such a buffer in a window instead of a frame should be seen as only a temporary workaround, since it violates a user preference of using a frame. It is a temporary expedient, to obviate the annoyance of not properly handling a frame in this context. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 01:42:08 2010 Received: (at 7533) by debbugs.gnu.org; 21 Dec 2010 06:42:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUvvD-00052e-3t for submit@debbugs.gnu.org; Tue, 21 Dec 2010 01:42:07 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUvvC-00052C-0j for 7533@debbugs.gnu.org; Tue, 21 Dec 2010 01:42:06 -0500 Received: from furball (bb116-14-228-227.singnet.com.sg [116.14.228.227]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBL6mXbu009755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 21 Dec 2010 01:48:36 -0500 Received: by furball (Postfix, from userid 1000) id 3C7C5161C19; Tue, 21 Dec 2010 14:48:32 +0800 (SGT) From: Chong Yidong To: "Drew Adams" Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> <4CF8A7B2.5080306@gmx.at> <1880532436F6447B97DC61F6050FF29F@us.oracle.com> <4CF93418.9090405@gmx.at> <4CF939E7.6030603@gmx.at> <87zkslw43z.fsf@stupidchicken.com> <9FA3601ABD5C49E79DDAF60EAFFCD7F0@us.oracle.com> <4D0B03EB.4050706@gmx.at> <4D0B8BE4.2050401@gmx.at> Date: Tue, 21 Dec 2010 14:48:32 +0800 In-Reply-To: (Drew Adams's message of "Fri, 17 Dec 2010 08:55:40 -0800") Message-ID: <877hf3vcxr.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7533 Cc: 'martin rudalics' , 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) "Drew Adams" writes: > You are showing nothing but bad faith. That's an incredibly rude and arrogant way to treat a volunteer developer. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 18 17:08:17 2011 Received: (at 7533) by debbugs.gnu.org; 18 Jan 2011 22:08:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PfJir-0003ED-9g for submit@debbugs.gnu.org; Tue, 18 Jan 2011 17:08:17 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PfJiq-0003E2-D0 for 7533@debbugs.gnu.org; Tue, 18 Jan 2011 17:08:16 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p0IMFxlG032008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Jan 2011 22:16:01 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p0IMFwsL017790; Tue, 18 Jan 2011 22:15:58 GMT Received: from abhmt012.oracle.com by acsmt355.oracle.com with ESMTP id 970580361295388843; Tue, 18 Jan 2011 14:14:03 -0800 Received: from dradamslap1 (/10.159.222.234) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 18 Jan 2011 14:14:02 -0800 From: "Drew Adams" To: Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Tue, 18 Jan 2011 14:14:05 -0800 Message-ID: <311FF40203334D82A3D462354AF79AB6@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcueFX9zEhRnc7dwR/ichx1cWjbxtwZQ2HdQAAD8vEA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7533 Cc: cyd@stupidchicken.com, 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > From: martin rudalics Sent: Friday, December 17, 2010 10:09 AM > > if nobody objects we can bind things like `special-display-regexps' > and `special-display-buffer-names' to nil here too. Please do. That would presumably restore the behavior of Emacs 22: pop-up window (deleted afterward), not frame (left undeleted). From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 05 16:24:33 2012 Received: (at 7533) by debbugs.gnu.org; 5 Apr 2012 20:24:33 +0000 Received: from localhost ([127.0.0.1]:41794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SFtEP-0002tX-1k for submit@debbugs.gnu.org; Thu, 05 Apr 2012 16:24:33 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:20584) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SFtEI-0002tL-SN for 7533@debbugs.gnu.org; Thu, 05 Apr 2012 16:24:31 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q35KNomx007253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Apr 2012 20:23:51 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q35KNn34006097 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Apr 2012 20:23:49 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q35KNmko008283; Thu, 5 Apr 2012 15:23:49 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Apr 2012 13:23:48 -0700 From: "Drew Adams" To: "'Stefan Monnier'" , "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 5 Apr 2012 13:23:46 -0700 Message-ID: <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcuTKIM9NH7qQWvFQN22AddijPhIpmAP3c6A X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090205.4F7DFF57.0060,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > From: Stefan Monnier Sent: Friday, December 03, 2010 12:27 PM > > Here I have two things: A window parameter that tells for > > each window whether the current buffer is the first buffer > > shown in it and a separate global variable which gives some > > rudimentary information about what the last `display-buffer' > > invocation did to find a suitable window. > > Indeed. We currently have display-buffer-mark-dedicated which goes in > this direction, but uses dedicatedness, which is not always > desired, apparently. > > I think that adding a "buffer for which this window was > created" window parameter and always set it in display-buffer > (regardless of display-buffer-mark-dedicated) should allow > correct handling of such situations. This regression is still not fixed. There was a lot of dancing around and singing about new ways of handling buffer display and windows (vs old-fashioned `pop-up-frames' etc.). But the new ways were added to Emacs and this regression still remains. emacs -Q (setq special-display-regexps '("[ ]?[*][^*]+[*]")) (setq pop-up-frame t) C-x d whatever-dir Mark 4 files for deletion. Hit `x'. Answer `yes'. The *Deletions* frame remains displayed. At the beginning of this thread I offered some code that at least handles this case fine, AFAICT. Actually, I forgot a prog1. Here it is again... The only difference from what is in Emacs is the last two lines, which delete the frame when done. That's all I'm asking for: please delete the frame that you pop up. (defun dired-mark-pop-up (bufname op-symbol files function &rest args) "..." (or bufname (setq bufname " *Marked Files*")) (if (or (eq dired-no-confirm t) (memq op-symbol dired-no-confirm) ;; If FILES defaulted to the current line's file. (= (length files) 1)) (apply function args) (with-current-buffer (get-buffer-create bufname) (erase-buffer) ;; Handle (t FILE) just like (FILE), here. ;; That value is used (only in some cases), to mean just one ;; file that was marked, rather than the current line file. (dired-format-columns-of-files (if (eq (car files) t) (cdr files) files)) (remove-text-properties (point-min) (point-max) '(mouse-face nil help-echo nil))) (save-window-excursion (dired-pop-to-buffer bufname) (prog1 (apply function args) (if (one-window-p) (delete-frame) (delete-window)))))) Yes, it is no doubt true that `save-window-excursion' is inappropriate when used with code displaying a buffer, as Martin pointed. Yes, there might be other things inappropriate or inelegant here. But it works for the use case of the bug report at least, and Emacs 24 -Q does not work for that case. Again, I do not really care how this bug is fixed. But please fix it. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 10:03:40 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 14:03:40 +0000 Received: from localhost ([127.0.0.1]:42689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SG9lK-0002Mp-MQ for submit@debbugs.gnu.org; Fri, 06 Apr 2012 10:03:40 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:51147) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SG9lE-0002MZ-EK for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 10:03:37 -0400 Received: (qmail invoked by alias); 06 Apr 2012 14:02:47 -0000 Received: from 62-47-43-205.adsl.highway.telekom.at (EHLO [62.47.43.205]) [62.47.43.205] by mail.gmx.net (mp028) with SMTP; 06 Apr 2012 16:02:47 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX197EkUeUk57dgAy4aqsjESs2U/eLfORcWphyn6i/f PXndq5Z45BnF9j Message-ID: <4F7EF782.6020103@gmx.at> Date: Fri, 06 Apr 2012 16:02:42 +0200 From: martin rudalics MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> In-Reply-To: <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> Content-Type: multipart/mixed; boundary="------------090602020900010307020204" X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) This is a multi-part message in MIME format. --------------090602020900010307020204 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > emacs -Q > > (setq special-display-regexps '("[ ]?[*][^*]+[*]")) > (setq pop-up-frame t) I suppose you mean (setq pop-up-frames t) but apparently this variable is no more supported by `display-buffer' (I'm not sure whether that's by design). > C-x d whatever-dir > > Mark 4 files for deletion. Hit `x'. Answer `yes'. > > The *Deletions* frame remains displayed. Would the attached patch fix it? This is NOT a generic fix - it might fail miserably if the buffer in question is shown in two windows simultaneously. Apparently this is no great issue in the case at hand since `dired-pop-to-buffer' already calls `get-buffer-window'. I earlier provided a variable called `display-buffer-window' for this and related issues but Stefan didn't like it. martin --------------090602020900010307020204 Content-Type: text/plain; name="dired.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dired.diff" bzr diff === modified file 'lisp/dired.el' --- lisp/dired.el 2012-04-01 02:44:24 +0000 +++ lisp/dired.el 2012-04-06 13:35:09 +0000 @@ -2950,8 +2950,7 @@ ;; that's possible. (Bug#1806) (split-window-below)) ;; Otherwise, try to split WINDOW sensibly. - (split-window-sensibly window)))) - pop-up-frames) + (split-window-sensibly window))))) (pop-to-buffer (get-buffer-create buf))) ;; If dired-shrink-to-fit is t, make its window fit its contents. (when dired-shrink-to-fit @@ -2993,17 +2992,21 @@ ;; If FILES defaulted to the current line's file. (= (length files) 1)) (apply function args) - (with-current-buffer (get-buffer-create bufname) - (erase-buffer) - ;; Handle (t FILE) just like (FILE), here. - ;; That value is used (only in some cases), to mean - ;; just one file that was marked, rather than the current line file. - (dired-format-columns-of-files (if (eq (car files) t) (cdr files) files)) - (remove-text-properties (point-min) (point-max) - '(mouse-face nil help-echo nil))) - (save-window-excursion - (dired-pop-to-buffer bufname) - (apply function args)))) + (let ((buffer (get-buffer-create bufname))) + (with-current-buffer buffer + (erase-buffer) + ;; Handle (t FILE) just like (FILE), here. + ;; That value is used (only in some cases), to mean + ;; just one file that was marked, rather than the current line file. + (dired-format-columns-of-files (if (eq (car files) t) (cdr files) files)) + (remove-text-properties (point-min) (point-max) + '(mouse-face nil help-echo nil)) + (dired-pop-to-buffer buffer) + (let ((window (get-buffer-window buffer))) + (prog1 + (apply function args) + (when (and window (eq (window-buffer window) buffer)) + (quit-window nil window)))))))) (defun dired-format-columns-of-files (files) (let ((beg (point))) --------------090602020900010307020204-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 10:45:03 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 14:45:04 +0000 Received: from localhost ([127.0.0.1]:42700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGAPN-0003Jp-PL for submit@debbugs.gnu.org; Fri, 06 Apr 2012 10:45:03 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:44620) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGAPH-0003JD-O9 for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 10:45:00 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q36EiD0v019457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Apr 2012 14:44:14 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q36EiCov026780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Apr 2012 14:44:13 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q36EiBY4016526; Fri, 6 Apr 2012 09:44:12 -0500 Received: from dradamslap1 (/10.159.49.156) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 06 Apr 2012 07:44:11 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 6 Apr 2012 07:44:08 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 In-Reply-To: <4F7EF782.6020103@gmx.at> Thread-Index: Ac0T/fTmKOK2NZpjRFeVD09z6fUZLQAAWgYg X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090206.4F7F013F.0001,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > emacs -Q > > (setq special-display-regexps '("[ ]?[*][^*]+[*]")) > > (setq pop-up-frame t) > > I suppose you mean (setq pop-up-frames t) Yes. > but apparently this variable is no more supported by `display-buffer' > (I'm not sure whether that's by design). I don't know what you mean by that. Dunno whether it is supported by `display-buffer, but I do still use `pop-up-frames' and it works fine in general (apart from this bug, AFAIK). And I thought you took care to ensure that it did, for Emacs 24. > > C-x d whatever-dir > > Mark 4 files for deletion. Hit `x'. Answer `yes'. > > The *Deletions* frame remains displayed. > > Would the attached patch fix it? For my own complete setup, yes. But that's no doubt because I take other measures elsewhere. For the recipe I gave, however (see above), no. The separate `*Deletions*' frame popped up just becomes iconified. It is still available as a frame (and as a buffer). It is still in the list of frames, and it is thus shown in the MS Windows task bar. And on Windows at least, iconification is quite distracting. The frame does not simply disappear (and simultaneously get added to the task bar). The frame zooms down to the task bar in an animated fashion. Quite annoying. There is no need for either the frame or the window - or the buffer for that matter, after the deletions are done (or the copies or whatever `dired-mark-pop-up' was used for). By Occam's razor, no need means Emacs should not keep these things around vestigially - especially not so that users encounter them. > This is NOT a generic fix - it might fail miserably if the buffer in > question is shown in two windows simultaneously. Apparently > this is no great issue in the case at hand since > `dired-pop-to-buffer' already calls `get-buffer-window'. > I earlier provided a variable called `display-buffer-window' > for this and related issues but Stefan didn't like it. FWIW, the fix I sent still works. Perhaps it can be improved upon to satisfy whatever other needs you see that it does not quite satisfy? One way or another, the regression needs to be fixed. Things were OK back in Emacs 22. There should be no reason why we cannot make them OK again in this regard. In Emacs 22 the buffer was not shown in a separate frame, disrespecting `special-display-regexps'. I prefer (slightly) that the latter be respected, so that the buffer is shown in a separate frame. But only if the frame, like a pop-up window, is completely removed when done. Given the choice between your fix and the Emacs 22 behavior, I vastly prefer the latter: no distraction, simple, over and done with, never see `*Deletions*' or whatever again. Thanks for trying to fix this, Martin. I hope we can find a solution that is satisfactory. The fix I sent is good enough for me, but I understand if it is not good enough for you. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 10:54:54 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 14:54:54 +0000 Received: from localhost ([127.0.0.1]:42704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGAYv-0003Wt-Jl for submit@debbugs.gnu.org; Fri, 06 Apr 2012 10:54:54 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:54541) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SGAYr-0003Wd-Rr for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 10:54:52 -0400 Received: (qmail invoked by alias); 06 Apr 2012 14:54:03 -0000 Received: from 62-47-43-205.adsl.highway.telekom.at (EHLO [62.47.43.205]) [62.47.43.205] by mail.gmx.net (mp040) with SMTP; 06 Apr 2012 16:54:03 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19KMbxKJr1KXQSOLC7P569SC8RejsnUiAQDMMRckm vVUpOApE+sneP6 Message-ID: <4F7F0386.6030909@gmx.at> Date: Fri, 06 Apr 2012 16:53:58 +0200 From: martin rudalics MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> but apparently this variable is no more supported by `display-buffer' >> (I'm not sure whether that's by design). > > I don't know what you mean by that. Dunno whether it is supported by > `display-buffer, but I do still use `pop-up-frames' and it works fine in general > (apart from this bug, AFAIK). And I thought you took care to ensure that it > did, for Emacs 24. It was disabled by `dired-pop-to-buffer'. Already fixed in my patch. >> Would the attached patch fix it? > > For my own complete setup, yes. But that's no doubt because I take other > measures elsewhere. > > For the recipe I gave, however (see above), no. The separate `*Deletions*' > frame popped up just becomes iconified. It is still available as a frame (and > as a buffer). It is still in the list of frames, and it is thus shown in the MS > Windows task bar. Have you set `frame-auto-hide-function' to `delete-frame'? > In Emacs 22 the buffer was not shown in a separate frame, disrespecting > `special-display-regexps'. I prefer (slightly) that the latter be respected, so > that the buffer is shown in a separate frame. But only if the frame, like a > pop-up window, is completely removed when done. The current handling of `special-display-regexps' seems to override the way Emacs 22 behaved in this regard. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 11:36:05 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 15:36:05 +0000 Received: from localhost ([127.0.0.1]:42714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGBCm-0005F9-70 for submit@debbugs.gnu.org; Fri, 06 Apr 2012 11:36:04 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:39827) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGBCR-0005Eq-4t for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 11:35:54 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q36FZ1ae031315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Apr 2012 15:35:02 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q36FZ0XF018568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Apr 2012 15:35:00 GMT Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q36FZ0Vg015798; Fri, 6 Apr 2012 10:35:00 -0500 Received: from dradamslap1 (/10.159.49.156) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 06 Apr 2012 08:34:59 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> <4F7F0386.6030909@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 6 Apr 2012 08:34:56 -0700 Message-ID: <7F573FD9970448A282AF763F35489AA3@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 In-Reply-To: <4F7F0386.6030909@gmx.at> Thread-Index: Ac0UBR2+FN5JvXdoT7eorFFO+974DgABCJ4g X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-CT-RefId: str=0001.0A090208.4F7F0D26.00EB,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > It was disabled by `dired-pop-to-buffer'. Already fixed in my patch. I see. > >> Would the attached patch fix it? > > > > For my own complete setup, yes. But that's no doubt > > because I take other measures elsewhere. > > > > For the recipe I gave, however (see above), no. The > > separate `*Deletions*' frame popped up just becomes > > iconified. It is still available as a frame (and > > as a buffer). It is still in the list of frames, and > > it is thus shown in the MS Windows task bar. > > Have you set `frame-auto-hide-function' to `delete-frame'? In my own setup, yes. No doubt that is why I don't have a problem with it. But that's not a reason that users with just the two settings I mentioned should see this problem. Whatever the cause (and various user configs can lead to this), if the buffer is displayed in a separate frame there is _no_ reason, ever, to keep this frame (or its window or its buffer). Occam says delete it - don't just "hide" it. This is part of the logic of this particular user interaction. And yes, I realize that there is no general definition of such a "dialog" interaction in Emacs (yet). But in handling this particular interaction it is clear to the code and its designers that the frame+window+buffer have no further use. Knowing that, the code should DTRT. Iconifying here makes no sense, even if a user might choose iconifying in general as his preference for `frame-auto-hide-function'. That option is about hiding a frame. There is no reason to hide this frame. There is no reason to keep this frame (or its window or buffer). That's the point. It is not about `frame-auto-hide-function', which is a user preference about hiding frames. It is about the logic of this particular user interaction and the raison d'etre for this buffer/window/frame. When they no longer have any reason for existing they should be deleted - regardless of the value of `frame-auto-hide-function'. > The current handling of `special-display-regexps' seems to > override the way Emacs 22 behaved in this regard. It is good in general that `special-display-regexps' be respected. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 11:48:09 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 15:48:10 +0000 Received: from localhost ([127.0.0.1]:42744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGBOP-0005WZ-4e for submit@debbugs.gnu.org; Fri, 06 Apr 2012 11:48:09 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:51445) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SGBOB-0005Vy-EY for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 11:48:03 -0400 Received: (qmail invoked by alias); 06 Apr 2012 15:47:10 -0000 Received: from 62-47-43-205.adsl.highway.telekom.at (EHLO [62.47.43.205]) [62.47.43.205] by mail.gmx.net (mp072) with SMTP; 06 Apr 2012 17:47:10 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+eUtVGdf6e+rHJvlDjpfWh7r3y9Fx8+VX2d5n8qf 8zNsUC262dhy4C Message-ID: <4F7F0FF8.7090401@gmx.at> Date: Fri, 06 Apr 2012 17:47:04 +0200 From: martin rudalics MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> <4F7F0386.6030909@gmx.at> <7F573FD9970448A282AF763F35489AA3@us.oracle.com> In-Reply-To: <7F573FD9970448A282AF763F35489AA3@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> Have you set `frame-auto-hide-function' to `delete-frame'? > > In my own setup, yes. No doubt that is why I don't have a problem with it. So it worked without my patch? martin From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 12:11:27 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 16:11:27 +0000 Received: from localhost ([127.0.0.1]:42771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGBl1-00063h-GC for submit@debbugs.gnu.org; Fri, 06 Apr 2012 12:11:27 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:28858) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGBky-00063Y-Kb for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 12:11:26 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q36GAhUq030736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Apr 2012 16:10:44 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q36GAg0I028775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Apr 2012 16:10:42 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q36GAgEm008002; Fri, 6 Apr 2012 11:10:42 -0500 Received: from dradamslap1 (/10.159.49.156) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 06 Apr 2012 09:10:41 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> <4F7F0386.6030909@gmx.at> <7F573FD9970448A282AF763F35489AA3@us.oracle.com> <4F7F0FF8.7090401@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 6 Apr 2012 09:10:38 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 In-Reply-To: <4F7F0FF8.7090401@gmx.at> Thread-Index: Ac0UDInwWqvxegEDSW6RbERnip7rqAAAK2zQ X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-CT-RefId: str=0001.0A090201.4F7F1584.006F,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > >> Have you set `frame-auto-hide-function' to `delete-frame'? > > > > In my own setup, yes. No doubt that is why I don't have a > > problem with it. > > So it worked without my patch? Sorry. I forgot that my setup includes the fix I proposed, as well as `delete-frame' as the value of `frame-auto-hide-function'. Without my fix and without your patch, just having `delete-frame' as the value of `frame-auto-hide-function' was not adequate. Same behavior as `iconify-frame'. Without my fix and with your patch, even having `iconify-frame' as the value of `frame-auto-hide-function' was adequate. So I probably have some other code that takes care of the iconify/delete thing somewhere. In sum, your patch (or mine), plus `delete-frame' as the value of `frame-auto-hide-function', is adequate. Without one of those patches, no value of `frame-auto-hide-function' makes a difference. For emacs -Q: Without my fix and with your patch the frame is iconified, without changing `frame-auto-hide-function'. Without my fix and with your patch the frame is deleted, if `frame-auto-hide-function' is `delete-frame'. My point was that users should not have to customize this option just to fix this regression. It is reasonable for a user to prefer iconifying for frames that s?he wants to keep, but still, naturally, want this frame to be deleted, as it has no reason for being anymore. If you were not averse to binding a user option for a local use, perhaps you could just bind `frame-auto-hide-function' to `delete-frame' for the duration of the command. That should DTRT, and such a temporary binding should not bother anyone (IMHO). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 12:57:28 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 16:57:28 +0000 Received: from localhost ([127.0.0.1]:42786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGCTX-00077t-H0 for submit@debbugs.gnu.org; Fri, 06 Apr 2012 12:57:27 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:53771) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SGCTO-00077U-7M for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 12:57:20 -0400 Received: (qmail invoked by alias); 06 Apr 2012 16:56:37 -0000 Received: from 62-47-43-205.adsl.highway.telekom.at (EHLO [62.47.43.205]) [62.47.43.205] by mail.gmx.net (mp032) with SMTP; 06 Apr 2012 18:56:37 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19JTTh1qKRJeYeMcGvTQVnO9+5j8lPgjsuTY+3e/L 61VJ/q1JgsC6aB Message-ID: <4F7F203F.90101@gmx.at> Date: Fri, 06 Apr 2012 18:56:31 +0200 From: martin rudalics MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> <4F7F0386.6030909@gmx.at> <7F573FD9970448A282AF763F35489AA3@us.oracle.com> <4F7F0FF8.7090401@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > In sum, your patch (or mine), plus `delete-frame' as the value of > `frame-auto-hide-function', is adequate. IIUC your patch works regardless of the value of `frame-auto-hide-function'. The problem of your patch is that in (if (one-window-p) (delete-frame) (delete-window)) the window for showing the buffer may have been _reused_ in which case deleting is certainly the wrong solution. > For emacs -Q: > > Without my fix and with your patch the frame is iconified, without changing > `frame-auto-hide-function'. > > Without my fix and with your patch the frame is deleted, if > `frame-auto-hide-function' is `delete-frame'. That's what this option has been meant for. I can't judge what it should default to because I hardly ever use multiple frames and never use `dired'. > My point was that users should not have to customize this option just to fix > this regression. It is reasonable for a user to prefer iconifying for frames > that s?he wants to keep, but still, naturally, want this frame to be deleted, as > it has no reason for being anymore. We can consider adding a third value for `frame-auto-hide-function'. > If you were not averse to binding a user option for a local use, perhaps you > could just bind `frame-auto-hide-function' to `delete-frame' for the duration of > the command. That should DTRT, and such a temporary binding should not bother > anyone (IMHO). If we decide that deleting the frame is the correct solution in this particular case, the most simple option is to call `quit-window' with both arguments t, thus killing the buffer as well. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 13:09:41 2012 Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 17:09:41 +0000 Received: from localhost ([127.0.0.1]:42794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGCfM-0007PQ-VR for submit@debbugs.gnu.org; Fri, 06 Apr 2012 13:09:41 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:51997) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGCfJ-0007PI-SW for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 13:09:39 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q36H8rE9002268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Apr 2012 17:08:54 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q36H8q9d009013 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Apr 2012 17:08:53 GMT Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q36H8q77000793; Fri, 6 Apr 2012 12:08:52 -0500 Received: from dradamslap1 (/10.159.49.156) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 06 Apr 2012 10:08:52 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> <4F7F0386.6030909@gmx.at> <7F573FD9970448A282AF763F35489AA3@us.oracle.com> <4F7F0FF8.7090401@gmx.at> <4F7F203F.90101@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 6 Apr 2012 10:08:48 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 In-Reply-To: <4F7F203F.90101@gmx.at> Thread-Index: Ac0UFj2qaRw7C3nMROWxAJlDHizgWQAAM7FA X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090204.4F7F2329.0065,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org, 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > For emacs -Q: > > > > Without my fix and with your patch the frame is iconified, > > without changing `frame-auto-hide-function'. > > > > Without my fix and with your patch the frame is deleted, if > > `frame-auto-hide-function' is `delete-frame'. > > That's what this option has been meant for. Yes, in the general case. It is a general user option. IMO, it does not apply here, that is, it should not govern the behavior here. > > I can't judge what it should default to because I hardly ever > > use multiple frames and never use `dired'. We've been around the default-value barn several times already. Stefan wants iconifying as the default. I'm happy if users can at least customize it to get deletion. > > My point was that users should not have to customize this > > option just to fix this regression. It is reasonable for > > a user to prefer iconifying for frames that s?he wants to > > keep, but still, naturally, want this frame to be deleted, as > > it has no reason for being anymore. > > We can consider adding a third value for `frame-auto-hide-function'. I think that's blowing things out of proportion. There is no need for a user option for this. A user option is for general behavior. Unless, that is, you can characterize such behavior as a general class that is recognizable. But I thought that was the problem: no "dialog" thingy exists. IMO, the proper fix here is specific to this command. And to any others that we run into that pop up a frame only temporarily, for the duration of some well defined (recognizable) user interaction. > > If you were not averse to binding a user option for a > > local use, perhaps you could just bind `frame-auto-hide-function' > > to `delete-frame' for the duration of the command. That should > > DTRT, and such a temporary binding should not bother > > anyone (IMHO). > > If we decide that deleting the frame is the correct solution in this > particular case, the most simple option is to call `quit-window' with > both arguments t, thus killing the buffer as well. Sounds good to me, IIUC. Does anyone claim that deleting the frame (& window & buffer) is not the correct solution in this situation? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 18 10:33:20 2012 Received: (at 7533) by debbugs.gnu.org; 18 Apr 2012 14:33:20 +0000 Received: from localhost ([127.0.0.1]:40012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SKVwd-00051Z-FT for submit@debbugs.gnu.org; Wed, 18 Apr 2012 10:33:20 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:31257) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SKVwX-00051H-DB for 7533@debbugs.gnu.org; Wed, 18 Apr 2012 10:33:17 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3IEWqhh010629 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Apr 2012 14:32:53 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3IEWpwm006971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Apr 2012 14:32:52 GMT Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3IEWpTn016865; Wed, 18 Apr 2012 09:32:51 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 18 Apr 2012 07:32:51 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com><4F7EF782.6020103@gmx.at><4F7F0386.6030909@gmx.at><7F573FD9970448A282AF763F35489AA3@us.oracle.com><4F7F0FF8.7090401@gmx.at><4F7F203F.90101@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Wed, 18 Apr 2012 07:32:50 -0700 Message-ID: <19CE4DF0C5AC4DFE86074D71C7FC3985@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac0UFj2qaRw7C3nMROWxAJlDHizgWQAAM7FAAlZBkiA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-CT-RefId: str=0001.0A090203.4F8ED095.00BA,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) ping From debbugs-submit-bounces@debbugs.gnu.org Fri May 25 16:53:39 2012 Received: (at 7533) by debbugs.gnu.org; 25 May 2012 20:53:39 +0000 Received: from localhost ([127.0.0.1]:43629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SY1Vz-0007Ku-BB for submit@debbugs.gnu.org; Fri, 25 May 2012 16:53:39 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:47191) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SY1Vx-0007Ki-VB for 7533@debbugs.gnu.org; Fri, 25 May 2012 16:53:38 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4PKqSsv003937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 May 2012 20:52:29 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4PKqS6M024080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 May 2012 20:52:28 GMT Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4PKqRWO017382; Fri, 25 May 2012 15:52:27 -0500 Received: from dradamslap1 (/10.159.219.153) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 25 May 2012 13:52:27 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com><4F7EF782.6020103@gmx.at><4F7F0386.6030909@gmx.at><7F573FD9970448A282AF763F35489AA3@us.oracle.com><4F7F0FF8.7090401@gmx.at><4F7F203F.90101@gmx.at> <19CE4DF0C5AC4DFE86074D71C7FC3985@us.oracle.com> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 25 May 2012 13:52:23 -0700 Message-ID: <0F6E005543DB4891A01F42BEA11DE520@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <19CE4DF0C5AC4DFE86074D71C7FC3985@us.oracle.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 thread-index: Ac0UFj2qaRw7C3nMROWxAJlDHizgWQAAM7FAAlZBkiAHUfEKQA== X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) ping again. This is a regression. It has a simple fix. Can this please be fixed? From debbugs-submit-bounces@debbugs.gnu.org Sat May 26 13:57:28 2012 Received: (at 7533) by debbugs.gnu.org; 26 May 2012 17:57:28 +0000 Received: from localhost ([127.0.0.1]:44439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYLF1-0002m4-Lf for submit@debbugs.gnu.org; Sat, 26 May 2012 13:57:27 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:29825) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYLEg-0002ky-QM for 7533@debbugs.gnu.org; Sat, 26 May 2012 13:57:26 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4QHtpqZ018251 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 26 May 2012 17:55:52 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4QHtpIw027968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 26 May 2012 17:55:51 GMT Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4QHtoGd007692; Sat, 26 May 2012 12:55:50 -0500 Received: from dradamslap1 (/10.159.171.147) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 26 May 2012 10:55:50 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com><4F7EF782.6020103@gmx.at><4F7F0386.6030909@gmx.at><7F573FD9970448A282AF763F35489AA3@us.oracle.com><4F7F0FF8.7090401@gmx.at><4F7F203F.90101@gmx.at><19CE4DF0C5AC4DFE86074D71C7FC3985@us.oracle.com> <0F6E005543DB4891A01F42BEA11DE520@us.oracle.com> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' [PATCH] Date: Sat, 26 May 2012 10:55:42 -0700 Message-ID: <7783B19C74CD4DFAA1E6410A507A69C8@us.oracle.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_004C_01CD3B2E.1929B2F0" X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <0F6E005543DB4891A01F42BEA11DE520@us.oracle.com> Thread-Index: Ac0UFj2qaRw7C3nMROWxAJlDHizgWQAAM7FAAlZBkiAHUfEKQAAprUeg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is a multi-part message in MIME format. ------=_NextPart_000_004C_01CD3B2E.1929B2F0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Martin wrote: > IIUC your patch works regardless of the value of > `frame-auto-hide-function'. The problem of your patch is that in > (if (one-window-p) (delete-frame) (delete-window)) > the window for showing the buffer may have been _reused_ in which case > deleting is certainly the wrong solution. I do not understand how/why that window would or should be reused. Especially between the time it becomes displayed and the end of the calling function. The window is only for the user interaction of confirming (or not) the operation on the marked files. The existing code seems to reflect this aim in that it uses `save-window-excursion'. What is still missing is (a) deletion of the window or frame (if `one-window-p') and (b) burial of the buffer. And this should happen always, regardless of what the user does, including `C-g'. If the buffer is not shown in a separate frame then the `save-window-excursion' alone seems to remove/hide the window - great. And that is why more people are not complaining about this regression, IMO. But if the buffer is shown in a separate frame (e.g. due to `special-buffer-regexps') then `save-window-excursion' is simply not sufficient. The frame remains displayed after the user interaction, regardless of what the user does during the interaction (including `C-g'). Attached is a patch against the latest source code. AFAIK it DTRT. Can anyone point to a reasonable situation where it does not DTRT - IOW, where what it does is inappropriate? If not, can this please be installed for Emacs 24.1, to eliminate this regression? Thx. Here is a change-log entry for the patch: 2012-05-26 Drew Adams * dired.el (dired-mark-pop-up): Delete the marked-files window/frame and bury its buffer. ------=_NextPart_000_004C_01CD3B2E.1929B2F0 Content-Type: application/octet-stream; name="dired-2012-05-26.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="dired-2012-05-26.patch" diff -c dired.el dired-patched-2012-05-26.el=0A= *** dired.el Sat May 26 09:48:52 2012=0A= --- dired-patched-2012-05-26.el Sat May 26 10:43:26 2012=0A= ***************=0A= *** 2988,3009 ****=0A= in the case of one marked file, to distinguish that from using=0A= just the current file."=0A= (or bufname (setq bufname " *Marked Files*"))=0A= ! (if (or (eq dired-no-confirm t)=0A= ! (memq op-symbol dired-no-confirm)=0A= ! ;; If FILES defaulted to the current line's file.=0A= ! (=3D (length files) 1))=0A= ! (apply function args)=0A= ! (with-current-buffer (get-buffer-create bufname)=0A= ! (erase-buffer)=0A= ! ;; Handle (t FILE) just like (FILE), here.=0A= ! ;; That value is used (only in some cases), to mean=0A= ! ;; just one file that was marked, rather than the current line = file.=0A= ! (dired-format-columns-of-files (if (eq (car files) t) (cdr = files) files))=0A= ! (remove-text-properties (point-min) (point-max)=0A= ! '(mouse-face nil help-echo nil)))=0A= ! (save-window-excursion=0A= ! (dired-pop-to-buffer bufname)=0A= ! (apply function args))))=0A= =0A= (defun dired-format-columns-of-files (files)=0A= (let ((beg (point)))=0A= --- 2988,3016 ----=0A= in the case of one marked file, to distinguish that from using=0A= just the current file."=0A= (or bufname (setq bufname " *Marked Files*"))=0A= ! (let (result)=0A= ! (if (or (eq dired-no-confirm t)=0A= ! (memq op-symbol dired-no-confirm)=0A= ! ;; If FILES defaulted to the current line's file.=0A= ! (=3D (length files) 1))=0A= ! (setq result (apply function args))=0A= ! (with-current-buffer (get-buffer-create bufname)=0A= ! (erase-buffer)=0A= ! ;; Handle (t FILE) just like (FILE), here.=0A= ! ;; That value is used (only in some cases), to mean=0A= ! ;; just one file that was marked, rather than the current line = file.=0A= ! (dired-format-columns-of-files (if (eq (car files) t) (cdr = files) files))=0A= ! (remove-text-properties (point-min) (point-max)=0A= ! '(mouse-face nil help-echo nil)))=0A= ! (unwind-protect=0A= ! (save-window-excursion=0A= ! (dired-pop-to-buffer bufname)=0A= ! (setq result (apply function args)))=0A= ! (ignore-errors=0A= ! (select-window (get-buffer-window bufname 0))=0A= ! (if (one-window-p) (delete-frame) (delete-window)))=0A= ! (bury-buffer bufname)))=0A= ! result))=0A= =0A= (defun dired-format-columns-of-files (files)=0A= (let ((beg (point)))=0A= =0A= Diff finished. Sat May 26 10:48:28 2012=0A= ------=_NextPart_000_004C_01CD3B2E.1929B2F0-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 27 09:22:35 2012 Received: (at 7533) by debbugs.gnu.org; 27 May 2012 13:22:35 +0000 Received: from localhost ([127.0.0.1]:45350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYdQZ-0005aP-BM for submit@debbugs.gnu.org; Sun, 27 May 2012 09:22:35 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:39902) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SYdQW-0005aC-8Q for 7533@debbugs.gnu.org; Sun, 27 May 2012 09:22:33 -0400 Received: (qmail invoked by alias); 27 May 2012 13:21:14 -0000 Received: from 62-47-61-97.adsl.highway.telekom.at (EHLO [62.47.61.97]) [62.47.61.97] by mail.gmx.net (mp034) with SMTP; 27 May 2012 15:21:14 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX198DKtcMWZ8SP1uI9NZcrPoDfPKojywijlK0KBz4U pPBT8qX+Fcb2J6 Message-ID: <4FC22A52.8050908@gmx.at> Date: Sun, 27 May 2012 15:21:22 +0200 From: martin rudalics MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50;`dired-mark-pop-up': delete frame afterwards if `pop-up-frames' [PATCH] References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com><4F7EF782.6020103@gmx.at><4F7F0386.6030909@gmx.at><7F573FD9970448A282AF763F35489AA3@us.oracle.com><4F7F0FF8.7090401@gmx.at><4F7F203F.90101@gmx.at><19CE4DF0C5AC4DFE86074D71C7FC3985@us.oracle.com> <0F6E005543DB4891A01F42BEA11DE520@us.oracle.com> <7783B19C74CD4DFAA1E6410A507A69C8@us.oracle.com> In-Reply-To: <7783B19C74CD4DFAA1E6410A507A69C8@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> IIUC your patch works regardless of the value of >> `frame-auto-hide-function'. The problem of your patch is that in >> (if (one-window-p) (delete-frame) (delete-window)) >> the window for showing the buffer may have been _reused_ in which case >> deleting is certainly the wrong solution. > > I do not understand how/why that window would or should be reused. When a user sets both `pop-up-frames' and `pop-up-windows' to nil, usually a window gets reused. If this is the only window on its frame and there are no other frames, the `delete-frame' call causes an error because it's within the scope of the `save-window-excursion'. > Especially between the time it becomes displayed and the end of the calling > function. The window is only for the user interaction of confirming (or not) > the operation on the marked files. > > The existing code seems to reflect this aim in that it uses > `save-window-excursion'. What is still missing is (a) deletion of the window or > frame (if `one-window-p') and (b) burial of the buffer. And this should happen > always, regardless of what the user does, including `C-g'. If the window was reused, the previous buffer should be shown. In practice, this is handled by the `save-window-excursion' unless a window on another frame gets reused. > If the buffer is not shown in a separate frame then the `save-window-excursion' > alone seems to remove/hide the window - great. And that is why more people are > not complaining about this regression, IMO. > > But if the buffer is shown in a separate frame (e.g. due to > `special-buffer-regexps') then `save-window-excursion' is simply not sufficient. > The frame remains displayed after the user interaction, regardless of what the > user does during the interaction (including `C-g'). > > Attached is a patch against the latest source code. AFAIK it DTRT. Can anyone > point to a reasonable situation where it does not DTRT - IOW, where what it does > is inappropriate? If not, can this please be installed for Emacs 24.1, to > eliminate this regression? Thx. Your new patch is better since it moves the frame deletion out of the scope of the window excursion. It's still not OK when a window on another frame gets reused but I think that use case can be ignored at the moment (it's neither provided by any of the stock buffer display functions nor is it handled by the present code anyway). martin From debbugs-submit-bounces@debbugs.gnu.org Sun May 27 10:35:31 2012 Received: (at 7533) by debbugs.gnu.org; 27 May 2012 14:35:31 +0000 Received: from localhost ([127.0.0.1]:45607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYeZ8-0007Ed-PA for submit@debbugs.gnu.org; Sun, 27 May 2012 10:35:31 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:37344) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYeYo-0007E8-7g for 7533@debbugs.gnu.org; Sun, 27 May 2012 10:35:29 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4REXoKh028055 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 27 May 2012 14:33:51 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4REXnIt023056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 27 May 2012 14:33:50 GMT Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4REXnX5019524; Sun, 27 May 2012 09:33:49 -0500 Received: from dradamslap1 (/10.159.190.91) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 27 May 2012 07:33:49 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at><6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com><4F7EF782.6020103@gmx.at><4F7F0386.6030909@gmx.at><7F573FD9970448A282AF763F35489AA3@us.oracle.com><4F7F0FF8.7090401@gmx.at><4F7F203F.90101@gmx.at><19CE4DF0C5AC4DFE86074D71C7FC3985@us.oracle.com> <0F6E005543DB4891A01F42BEA11DE520@us.oracle.com> <7783B19C74CD4DFAA1E6410A507A69C8@us.oracle.com> <4FC22A52.8050908@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' [PATCH] Date: Sun, 27 May 2012 07:33:39 -0700 Message-ID: <6B32A99A15614D68ADFB2BA6D12DF653@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac08C5jUyg4RlSKrSkamIudJPMH/9wACdzLw In-Reply-To: <4FC22A52.8050908@gmx.at> X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Thanks for the explanation (snipped). > > Attached is a patch against the latest source code. AFAIK > > it DTRT. Can anyone point to a reasonable situation where > > it does not DTRT - IOW, where what it does is inappropriate? > > If not, can this please be installed for Emacs 24.1, to > > eliminate this regression? Thx. > > Your new patch is better since it moves the frame deletion out of the > scope of the window excursion. It's still not OK when a window on > another frame gets reused but I think that use case can be ignored at > the moment (it's neither provided by any of the stock buffer display > functions nor is it handled by the present code anyway). Great. I hope someone will please install it (for 24.1?), while we look for something even better. Thx. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 05 10:29:36 2012 Received: (at 7533) by debbugs.gnu.org; 5 Sep 2012 14:29:36 +0000 Received: from localhost ([127.0.0.1]:40425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9Gbn-00014p-QN for submit@debbugs.gnu.org; Wed, 05 Sep 2012 10:29:36 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:42303) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1T9Gbl-00014e-Fj for 7533@debbugs.gnu.org; Wed, 05 Sep 2012 10:29:34 -0400 Received: (qmail invoked by alias); 05 Sep 2012 14:29:25 -0000 Received: from 62-47-54-51.adsl.highway.telekom.at (EHLO [62.47.54.51]) [62.47.54.51] by mail.gmx.net (mp024) with SMTP; 05 Sep 2012 16:29:25 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX195dsoYKPR5ErKQwGS00a9vnQjuW9voOfniSZ9EA8 FDjhN81RoAPL4V Message-ID: <504761FB.2040200@gmx.at> Date: Wed, 05 Sep 2012 16:30:19 +0200 From: martin rudalics MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> In-Reply-To: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.3 (/) > This is another one of those annoyances that come from not testing with > non-nil `pop-up-frames' (just a guess). > > emacs -Q > > M-x set-variable RET pop-up-frames RET t RET > > In Dired, flag several files for deletion, then hit `x'. > Answer `yes' or `no'. [...] > The important thing, for me, is that the frame that was created just to > show the files that will be deleted (or whatever) goes away. It should > be only a _temporary_ frame because its only raison d'etre is as part of > the deletion etc. _dialog_. This should have been fixed in revision 109863 on Emacs trunk. Please check as soon as you get new binaries. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 05 10:34:12 2012 Received: (at 7533) by debbugs.gnu.org; 5 Sep 2012 14:34:12 +0000 Received: from localhost ([127.0.0.1]:40443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9GgG-0001D5-2f for submit@debbugs.gnu.org; Wed, 05 Sep 2012 10:34:12 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:22869) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9GgD-0001Cx-T1 for 7533@debbugs.gnu.org; Wed, 05 Sep 2012 10:34:10 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q85EY0GM030577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Sep 2012 14:34:01 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q85EY0j9001569 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 5 Sep 2012 14:34:00 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q85EY088030411; Wed, 5 Sep 2012 09:34:00 -0500 Received: from dradamslap1 (/130.35.178.248) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 05 Sep 2012 07:33:59 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <504761FB.2040200@gmx.at> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Wed, 5 Sep 2012 07:33:59 -0700 Message-ID: <1B949133DF0F4D3095E18B2CF1DB9ADC@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <504761FB.2040200@gmx.at> Thread-Index: Ac2Lctr6zRsH2bMrQwm1VEskTosQAgAAI8sQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > This should have been fixed in revision 109863 on Emacs trunk. > Please check as soon as you get new binaries. > > Thanks, martin Excellent; will do. Thanks, Martin. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 05:12:20 2012 Received: (at 7533-done) by debbugs.gnu.org; 3 Oct 2012 09:12:20 +0000 Received: from localhost ([127.0.0.1]:38598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJL08-0001mX-7a for submit@debbugs.gnu.org; Wed, 03 Oct 2012 05:12:20 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:39631) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1TJL06-0001mO-1T for 7533-done@debbugs.gnu.org; Wed, 03 Oct 2012 05:12:19 -0400 Received: (qmail invoked by alias); 03 Oct 2012 09:11:39 -0000 Received: from 62-47-56-28.adsl.highway.telekom.at (EHLO [62.47.56.28]) [62.47.56.28] by mail.gmx.net (mp028) with SMTP; 03 Oct 2012 11:11:39 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/zlTEW5iXz9eB9ac9HAMVpuCJutyySKRHTJRQ+e+ KYiLMvDQ45u/rt Message-ID: <506C0158.6040001@gmx.at> Date: Wed, 03 Oct 2012 11:11:52 +0200 From: martin rudalics MIME-Version: 1.0 To: 7533-done@debbugs.gnu.org Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <504761FB.2040200@gmx.at> <1B949133DF0F4D3095E18B2CF1DB9ADC@us.oracle.com> In-Reply-To: <1B949133DF0F4D3095E18B2CF1DB9ADC@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 7533-done Cc: Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) >> This should have been fixed in revision 109863 on Emacs trunk. Bug closed. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 11:53:31 2012 Received: (at 7533) by debbugs.gnu.org; 3 Oct 2012 15:53:31 +0000 Received: from localhost ([127.0.0.1]:39691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJRGN-0004Nf-Au for submit@debbugs.gnu.org; Wed, 03 Oct 2012 11:53:31 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:51418) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJRGL-0004NX-4u for 7533@debbugs.gnu.org; Wed, 03 Oct 2012 11:53:30 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q93FqmrT007586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 3 Oct 2012 15:52:48 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q93Fql4O027585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Oct 2012 15:52:47 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q93Fqlw2016987; Wed, 3 Oct 2012 10:52:47 -0500 Received: from dradamslap1 (/130.35.178.248) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Oct 2012 08:52:47 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><504761FB.2040200@gmx.at> <1B949133DF0F4D3095E18B2CF1DB9ADC@us.oracle.com> Subject: RE: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Wed, 3 Oct 2012 08:52:45 -0700 Message-ID: <2B32DF6CBEAE4E3B9BD333203DB3CF53@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <1B949133DF0F4D3095E18B2CF1DB9ADC@us.oracle.com> Thread-Index: Ac2Lctr6zRsH2bMrQwm1VEskTosQAgAAI8sQBYLgeCA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7533 Cc: 7533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) > Sent: Wednesday, September 05, 2012 7:34 AM > > > This should have been fixed in revision 109863 on Emacs trunk. > > Please check as soon as you get new binaries. > > > > Thanks, martin > > Excellent; will do. Thanks, Martin. Finally got a Windows binary that I could check this with. There was a lot in this thread. Not sure that everything discussed was addressed, but the latest emacs -Q recipe I posted in the thread works OK now. Thx. From unknown Fri Sep 05 17:59:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 01 Nov 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator