Subject: bug#75321: closed (Re: [bug#75321] [PATCH rust-team] build: cargo-build-system: Use Cargo checksum stubs.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 05 Jan 2025 11:05:05 +0000

Your bug report

#75321: [PATCH rust-team] build: cargo-build-system: Use Cargo checksum stubs.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
75321: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75321
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#75321] [PATCH rust-team] build: cargo-build-system: Use Cargo checksum stubs.
From: Efraim Flashner <[email-masked]>
To: Herman Rimm <[email-masked]>
Cc: [email-masked]
Date: Sun, 5 Jan 2025 13:03:56 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

This saves an incredible amount of time especially on slower machines
(aka aarch64 and riscv64), and was on my TODO list for years.  Thanks!

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH rust-team] build: cargo-build-system: Use Cargo checksum stubs.
From: Herman Rimm <[email-masked]>
To: [email-masked]
Date: Fri, 3 Jan 2025 17:07:23 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Commit 5b08b8fe1019147fe489db17a9a8ae7ebe97f9e9 of Cargo makes the
package field optional.  This is the case since Rust 1.22.0.

* guix/build/cargo-build-system.scm (patch-cargo-checksums): Create
.cargo-checksum.json stubs.

Change-Id: I474e8f73b6048e53f22a8d899a8e3e50b5332f60
---
 guix/build/cargo-build-system.scm | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm
index 480134402f2..bbb79a7331b 100644
--- a/guix/build/cargo-build-system.scm
+++ b/guix/build/cargo-build-system.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2020 Jakub Kądziołka <[email-masked]>
 ;;; Copyright © 2020 Marius Bakke <[email-masked]>
 ;;; Copyright © 2024 Maxim Cournoyer <[email-masked]>
+;;; Copyright © 2025 Herman Rimm <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,7 +27,6 @@ (define-module (guix build cargo-build-system)
   #:use-module ((guix build gnu-build-system) #:prefix gnu:)
   #:use-module (guix build json)
   #:use-module ((guix build utils) #:hide (delete))
-  #:use-module (guix build cargo-utils)
   #:use-module (ice-9 popen)
   #:use-module (ice-9 rdelim)
   #:use-module (ice-9 ftw)
@@ -222,13 +222,19 @@ (define* (configure #:key inputs
   (when (file-exists? "Cargo.lock")
     (delete-file "Cargo.lock")))
 
-;; After the 'patch-generated-file-shebangs phase any vendored crates who have
-;; their shebangs patched will have a mismatch on their checksum.
+;; See: https://github.com/rust-lang/cargo/issues/11063.
 (define* (patch-cargo-checksums #:key
                                 (vendor-dir "guix-vendor")
                                 #:allow-other-keys)
-  "Patch the checksums of the vendored crates after patching their shebangs."
-  (generate-all-checksums vendor-dir))
+  "Add a stub checksum to each crate in VENDOR-DIR."
+  (with-directory-excursion vendor-dir
+    (call-with-output-file ".cargo-checksum.json"
+      (cut display "{\"files\":{}}" <>))
+    (for-each (lambda (dir)
+                (copy-file ".cargo-checksum.json"
+                           (string-append dir "/.cargo-checksum.json")))
+              (drop (scandir ".") 3))
+    (delete-file ".cargo-checksum.json")))
 
 (define* (build #:key
                 parallel-build?

base-commit: 5f92f009a19c1a5a8b7df5a7bcb1e1f283a953f8
-- 
2.45.2