Subject: Re: [bug#75285] [PATCH v2] gnu: Add xmlpatch.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 27 Jan 2025 14:13:34 +0100

Hi Lars,

Lars Bilke <[email-masked]> skribis:

> * gnu/packages/xml.scm (xmlpatch): New variable.
>
> Change-Id: I557f2dfbaadfef11c8ca592bb03ec829782fcb4e

I think we at least need the changes below.

Looking at ‘xml-patch.spec.in’, it seems that the RPM package also
installs the ‘xml-patch’ and ‘xml-diff’ programs, which are not
installed here.

Could you take a look?

Thanks,
Ludo’.

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 3ef045fc03..7cd1b4d4af 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -2051,6 +2051,7 @@ (define-public xmlpatch
        (uri (git-reference
              (url "https://github.com/ufz/xmlpatch")
              (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
         (base32 "120r0hm83nwvybjprmjaiilz5yj1qb46c9klawg61kqby6wsnaa8"))))
     (build-system cmake-build-system)
@@ -2060,5 +2061,6 @@ (define-public xmlpatch
     (home-page "https://xmlpatch.sourceforge.net")
     (synopsis "XML patch library")
     (description
-     "A C++ library for patching XML files with XPath expressions.")
-    (license license:lgpl2.1)))
+     "XML Patch is a C++ library for patching XML files with XPath
+expressions.")
+    (license license:lgpl2.1+)))