Subject: Re: [PATCH v2] gnu: Add tclap.

From: Liliana Marie Prikler <[email-masked]>
Date: Mon, 13 Jan 2025 18:40:52 +0100

Am Freitag, dem 03.01.2025 um 08:18 +0100 schrieb Lars Bilke:
> * gnu/packages/cpp.scm (tclap): New variable.
> 
> Change-Id: I21e0eb623abe0b5add59647dec5606c706063e00
> ---
Note: when revising patches, don't forget to CC your reviewer :)

>  gnu/packages/cpp.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index d3a8223a9c..c9afb60c16 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -3531,3 +3531,35 @@ (define-public cpp-ada-url-parser
>       "Ada is a fast and spec-compliant URL parser written in C++.
>  Specification for URL parser can be found from the WHATWG website.")
>      (license license:gpl3+)))
> +
> +(define-public tclap
> +  (package
> +    (name "tclap")
> +    (version "1.4.0-1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.code.sf.net/p/tclap/code")
> +             (commit "81b3d2a0c47895c22e9bb8c577f5ab521f76e5d2")))
We have a mirror://sourceforge syntax for url-fetch.  I assume you want
to package 1.4.0-rc1?  
> +       (sha256
> +        (base32
> "0w06phgcjjnskxl9f0vmy5lgx5y2irbx14j9c2k8fis8a9sdiq51"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     (list
> +      #:phases #~(modify-phases %standard-phases
> +                   (replace 'check
> +                     (lambda* (#:key tests? parallel-tests? #:allow-
> other-keys)
> +                       (if tests?
> +                           (invoke "ctest" "-j"
> +                                   (if parallel-tests?
> +                                       (number->string (parallel-
> job-count))
> +                                       "1"))
> +                           (format #t "test suite not run~%")))))))
Shouldn't cmake default to using ctest for testing?
> +    (native-inputs (list python))
> +    (home-page "https://sourceforge.net/p/tclap/discussion/")
> +    (synopsis "Templatized Command Line Argument Parser")
> +    (description
> +     "This is a simple C++ library that facilitates parsing command
> line
> +arguments in a type independent manner.")
> +    (license license:expat)))
Cheers