GNU bug report logs - #75270
[PATCH 0/3] services: greetd: Improve greeter configurations.

Previous Next

Full log

Message #173 received at 75270 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: muradm <mail <at> muradm.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 75270 <at> debbugs.gnu.org
Subject: Re: [bug#75270] [PATCH v6 3/3] services: greetd: Add new gtkgreet
 greeter.
Date: Thu, 06 Feb 2025 22:25:37 +0900

Hi,

muradm <mail <at> muradm.net> writes:

> * gnu/services/base.scm (<greetd-gtkgreet-sway-session>): New record,
> represents 'gtkgreet' greeter session configuration.
> * doc/guix.texi (Base Services): Document new 'gtkgreet' greeter.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

I'll merge it shortly.  I took the liberty to make the following
stylistic edits:

--8<---------------cut here---------------start------------->8---
1 file changed, 10 insertions(+), 8 deletions(-)
doc/guix.texi | 18 ++++++++++--------

modified   doc/guix.texi
@@ -20600,8 +20600,9 @@ Base Services
 The user to use for running the greeter.
 
 @item @code{default-session-command} (default: @code{(greetd-agreety-session)})
-Can be either @code{greetd-agreety-session}, @code{greetd-wlgreet-sway-session},
-@code{greetd-gtkgreet-sway-session} or file-like object to use as greeter.
+Can be either @code{greetd-agreety-session},
+@code{greetd-wlgreet-sway-session}, @code{greetd-gtkgreet-sway-session}
+or a file-like object to use as greeter.
 
 @end table
 @end deftp
@@ -20729,8 +20730,8 @@ Base Services
 @end deftp
 
 @deftp {Data Type} greetd-gtkgreet-sway-session
-Configuration record for the gtkgreet greetd greeter.  Can be used as
-following:
+Configuration record for the gtkgreet greetd greeter.  It can be used as
+follows:
 
 @lisp
   (greetd-configuration
@@ -20738,7 +20739,7 @@ Base Services
    (greeter-supplementary-groups (list "video" "input" "seat"))
    (terminals
     (list (greetd-terminal-configuration
-           ;; Sway requires seatd service.
+           ;; Sway requires the seatd service.
            (shepherd-requirement '(seatd))
            (terminal-vt "1")
            (terminal-switch #t)
@@ -20746,7 +20747,8 @@ Base Services
             (greetd-gtkgreet-sway-session
              (command
               (greetd-user-session
-               ;; Optionally signal to .bashrc that we want wayland compositor.
+               ;; Optionally signal to .bashrc that we want the Wayland
+               ;; compositor.
                (xdg-session-type "wayland")))))))))
 @end lisp
 
@@ -20759,13 +20761,13 @@ Base Services
 the greeter.
 
 @item @code{gtkgreet} (default: @code{gtkgreet})
-The package with @command{gtkgreet} command.
+The package providing the @command{gtkgreet} command.
 
 @item @code{gtkgreet-style} (default: @code{#f})
 Extra file-like CSS stylesheet to customize the GTK look.
 
 @item @code{command} (default: @code{(greetd-user-session)})
-Command to be started by @command{gtkgreet} on successful login, an
+The command to be started by @command{gtkgreet} on successful login, an
 instance of @code{greetd-user-session}.
 
 @end table
--8<---------------cut here---------------end--------------->8---


Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.