GNU bug report logs - #75270
[PATCH 0/3] services: greetd: Improve greeter configurations.

Previous Next

Full log

Message #137 received at 75270 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: ludo <at> gnu.org, 75270 <at> debbugs.gnu.org, pelzflorian <at> pelzflorian.de
Subject: Re: [bug#75270] [PATCH v4 3/3] services: greetd: Add new gtkgreet
 greeter.
Date: Mon, 03 Feb 2025 02:46:18 +0300

[Message part 1 (text/plain, inline)]

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

>> +(define-gexp-compiler (greetd-gtkgreet-sway-session-compiler
>> +                       (session 
>> <greetd-gtkgreet-sway-session>)
>> +                       system target)
>> +  (match-record session <greetd-gtkgreet-sway-session>
>> +    (sway)
>> +    (lower-object
>> +     (make-greetd-sway-greeter-command
>> +      sway
>> +      (make-greetd-gtkgreet-sway-session-sway-config 
>> session)))))
>> +
>
> I wonder if we could use define-configuration and avoid the 
> lower-level
> define-gexp-compiler glue code.

gnu/services/base.scm do not import `(gnu services 
configuration)`.  IMHO,
`define-configuration` is good for serializing record-like 
configuration
to custom formats.  Here we actually need and configure executable
programs.  I was not the one who introduced them, but currently I 
find
them more useful here.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.