Subject: Re: [bug#75270] [PATCH v3 1/3] services: greetd: Improve greeter configurations.

From: muradm <[email-masked]>
Date: Sun, 26 Jan 2025 17:31:12 +0300

Hi,

Fixed in v4.

P.S. Sorry 75862, 75863, 75864 and 75865 was my bad due to missing 
headers. But 75866, 75867, 75868 and 75869 should not happen. 
[email-masked] was included in CC. WHat do you suggest to 
do with them?

--
Thanks in advance,
muradm

Ludovic Courtès <[email-masked]> writes:

> Hi,
>
> muradm <[email-masked]> skribis:
>
>> "pelzflorian (Florian Pelz)" <[email-masked]> 
>> writes:
>>
>>>> -@item @code{sway-configuration} (default: #f)
>>>> -File-like object providing an additional Sway configuration 
>>>> file
>>>> to be
>>>> -prepended to the mandatory part of the configuration.
>>>> +@item @code{sway-config} (default: @code{(plain-file
>>>> "greetd-wlgreet-sway-config" "")})
>>>> +Extra configuration for sway to be included before executing
>>>> greeter.
>>>
>>> Could you retain the name of the existing field 
>>> sway-configuration?
>>> Using abbreviations is uncommon in Guix, I think,
>>> [...]
>>> Also sway-configuration is used in many examples in the Guix
>>> manual.
>>
>> I'm not sure if it is so strict, there are a lot of places 
>> where
>> 'config' is used. Is there a guideline for naming?
>
> It is rather strict, yes.  The guideline here would be:
>
>   https://guix.gnu.org/manual/devel/en/html_node/Formatting-Code.html
>
> Specifically Riastradh's Lisp Style Rules.
>
> As for changing the name of configuration fields: this is 
> something to
> avoid because it breaks user configurations.  See the guidelines 
> under
> “Services” at:
>
>   https://guix.gnu.org/manual/devel/en/html_node/Deprecation-Policy.html
>
> HTH!
>
> Ludo’.