Subject: Re: [PATCH v5 3/3] services: greetd: Add new gtkgreet greeter.

From: Maxim Cournoyer <[email-masked]>
Date: Wed, 05 Feb 2025 14:34:08 +0900

Hi,

muradm <[email-masked]> writes:

> * gnu/services/base.scm (<greetd-gtkgreet-sway-session>): New record,
> represents `gtkgreet` greeter session configuration.
> * doc/guix.texi (Base Services): Document new `gtkgreet` greeter.

Nitpick: I'd use straight quote in GNU Change Log messages; back quotes
are very much Markdown :-).

[...]

> +(define make-greetd-gtkgreet-sway-session-sway-config
> +  (match-lambda
> +    (($ <greetd-gtkgreet-sway-session>

You should use a regular lambda + the Guix-provided 'match-record'
syntax.

> +        sway sway-config gtkgreet gtkgreet-style command)
> +     (let ((gtkgreet-bin (file-append gtkgreet "/bin/gtkgreet"))
> +           (swaymsg-bin (file-append sway "/bin/swaymsg")))
> +       (mixed-text-file
> +        "gtkgreet-sway-config"
> +        (if sway-config "include " "")
> +        (if sway-config sway-config "")
> +        (if sway-config "\n" "")

Seems these if block can be grouped as one.

> +        "xwayland disable\n"
> +        "exec \"" gtkgreet-bin " -l"
> +        (if gtkgreet-style " -s " "")
> +        (if gtkgreet-style gtkgreet-style "")

Likewise.

The rest LGTM.

Could you send a v6 revision of the whole series?

-- 
Thanks,
Maxim