GNU bug report logs - #75268
[PATCH emacs-team 0/2] Apply native-comp grafts to emacs-next as well

Previous Next

Full log

View this message in rfc822 format

From: Ian Eure <ian <at> retrospec.tv>
To: 75268 <at> debbugs.gnu.org
Cc: liliana.prikler <at> gmail.com
Subject: [bug#75268] [PATCH emacs-team 0/2] Apply native-comp grafts to emacs-next as well
Date: Tue, 07 Jan 2025 20:48:19 -0800

Hi Liliana,

(Sorry if this reply is weird, I’m still ironing out some issues 
in my workflow)

This all looks good to me.  I compared the emacs and emacs-next 
versions of -native-comp-fix-filenames.patch, and your changes 
seem straightforward and minimal.

While I was reading your patches, I noticed this typo in 
emacs-disable-jit-compilation.patch:

> +Notably, Guix removes the hashes that prevent inadvertent 
> shadowing
> +frm the file names of compiled libraries in order to facilitate 
> grafts.

If you think it’s worth including in you patch series, it’d be 
nice to fix, but if you’re rather not, that’s also fine.

Thanks,
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.