GNU bug report logs - #75249
[PATCH 01/71] gnu: Add asdf-build-system/clasp.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Wed, 1 Jan 2025 19:08:03 UTC

Severity: normal

Tags: easy, patch

Full log


Message #176 received at 75249 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: jgart <jgart <at> dismail.de>
Cc: 75249 <at> debbugs.gnu.org
Subject: Re: [bug#75249] [PATCH 01/71] gnu: Add asdf-build-system/clasp.
Date: Fri, 14 Feb 2025 18:03:28 +0000
[Message part 1 (text/plain, inline)]
jgart via Guix-patches via <guix-patches <at> gnu.org> skribis:

> Hi,
>
> This patch series adds a build system for clasp:
>
> https://clasp-developers.github.io/
>
> Everything build successfully and I've tested clasp-lorem-ipsum at the
> clasp REPL.
>
> Currently, the asdf-build-system assumes that the package-name is also
> the name of the executable.
>
> If I pass it the name clasp-cl it fails to build clasp packages.
>
> I've currently resolved the above issue by renaming clasp-cl to clasp
> and clasp to potassco-clasp.
>
> This approach is simpler than having to refactor the asdf-build-system.
>
> Will this rename be an issue as per our deprecation policy?
>
> I am proposing to prefer the simpler solution here of just renaming the
> clasp package to potassco-clasp.
>
> What do people think?

Hi.

Maybe patches 2, 3 and 4 for the renaming could be merged into just one
patch.

But more importantly, the potassco clasp has a binary and not just
a library and some users probably have it installed in their profiles,
so you should add a news entry to indicate to these users that they have
to update their package lists, manifests or home configurations.

I have not had the time to tests the whole patch series yet, but from
a quick visual review, it looks ok.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 67 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.