GNU bug report logs - #75243
[PATCH] gnu: Add emacs-binder.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 75243 <at> debbugs.gnu.org
Cc: divya <at> subvertising.org
Subject: [bug#75243] [PATCH] gnu: Add emacs-binder.
Date: Wed, 01 Jan 2025 17:40:27 +0100

Hello,

Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.

Thank you. Some comments follow.

> +(define-public emacs-binder
> +  (package
> +    (name "emacs-binder")
> +    (version "20241023.1154")

Version should be "0.5.0", as set in "binder.el".

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))

Guix does not use MELPA as upstream because tarballs are not reliable.
Please use Codeberg repository instead.

> +       (sha256
> +        (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://codeberg.org/divyaranjan/binder")
> +    (synopsis
> +     "Binder is a global minor mode to facilitate working on multiple files")
> +    (description "Primarily, Binder provides a global minor mode
> binder-mode.

"binder-mode" -> "Binder mode".

> +This allows working with files in the current
> binder-project-directory.

"binder-project-directory" -> "@code{binder-project-directory}".

> +Data concerning these files is saved in a .binder.el file in the
> project directory.")

I don’t think the last sentence is useful in the description as it
merely describes the internals of the package. I suggest to remove it.
If you absolutely want to keep it, I suggest to apply proper markup:
".binder.el" -> "@file{.binder.el}".

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.