GNU bug report logs - #75243
[PATCH] gnu: Add emacs-binder.

Previous Next

Full log

View this message in rfc822 format

From: Divya Ranjan <divya <at> subvertising.org>
To: 75243 <at> debbugs.gnu.org
Cc: mail <at> nicolasgoaziou.fr
Subject: [bug#75243] [PATCH] gnu: Add emacs-binder.
Date: Thu, 02 Jan 2025 04:59:30 +0000

Also, Nicholas I forgot to include the Copyright signature in my patch, could you just include it yourself? "Divya Ranjan Pattanaik <divya <at> subvertising.org>".

Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org> writes:

> Hello,
>
> Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-binder
>> +  (package
>> +    (name "emacs-binder")
>> +    (version "20241023.1154")
>
> Version should be "0.5.0", as set in "binder.el".
>
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
>
> Guix does not use MELPA as upstream because tarballs are not reliable.
> Please use Codeberg repository instead.
>
>> +       (sha256
>> +        (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://codeberg.org/divyaranjan/binder")
>> +    (synopsis
>> +     "Binder is a global minor mode to facilitate working on multiple files")
>> +    (description "Primarily, Binder provides a global minor mode
>> binder-mode.
>
> "binder-mode" -> "Binder mode".
>
>> +This allows working with files in the current
>> binder-project-directory.
>
> "binder-project-directory" -> "@code{binder-project-directory}".
>
>> +Data concerning these files is saved in a .binder.el file in the
>> project directory.")
>
> I don’t think the last sentence is useful in the description as it
> merely describes the internals of the package. I suggest to remove it.
> If you absolutely want to keep it, I suggest to apply proper markup:
> ".binder.el" -> "@file{.binder.el}".
>
> Could you send an updated patch?
>
> Regards,

-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

PGP Fingerprint: F0B3 1A69 8006 8FB8 096A  2F12 B245 10C6 108C 8D4A

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.