From unknown Sat Jun 21 10:33:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7518 <7518@debbugs.gnu.org> To: bug#7518 <7518@debbugs.gnu.org> Subject: Status: image-dired defcustom'd paths Reply-To: bug#7518 <7518@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:33:04 +0000 retitle 7518 image-dired defcustom'd paths reassign 7518 emacs submitter 7518 MON KEY severity 7518 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 19:35:49 2010 Received: (at submit) by debbugs.gnu.org; 30 Nov 2010 00:35:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNECC-0002To-28 for submit@debbugs.gnu.org; Mon, 29 Nov 2010 19:35:48 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNECB-0002Td-23 for submit@debbugs.gnu.org; Mon, 29 Nov 2010 19:35:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNEHY-0007zj-RJ for submit@debbugs.gnu.org; Mon, 29 Nov 2010 19:41:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:60572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNEHY-0007ze-PL for submit@debbugs.gnu.org; Mon, 29 Nov 2010 19:41:20 -0500 Received: from [140.186.70.92] (port=46875 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNEHX-00064Y-SV for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 19:41:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNEHV-0007zM-Ql for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 19:41:19 -0500 Received: from mail-ww0-f41.google.com ([74.125.82.41]:36156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNEHV-0007z6-Ml for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 19:41:17 -0500 Received: by wwb28 with SMTP id 28so638366wwb.0 for ; Mon, 29 Nov 2010 16:41:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.173.81 with SMTP id u59mr1137567wel.58.1291077659542; Mon, 29 Nov 2010 16:40:59 -0800 (PST) Received: by 10.216.70.212 with HTTP; Mon, 29 Nov 2010 16:40:59 -0800 (PST) Date: Mon, 29 Nov 2010 19:40:59 -0500 X-Google-Sender-Auth: oNJOnIUC26NS29QjGhT_agTciM8 Message-ID: Subject: image-dired defcustom'd paths From: MON KEY To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) current through bzr revision 102504 Now that ImageMagick libs are accessble to Emacs24 maybe more users will be using image-dired. The defcustom form for variables `image-dired-dir', `image-dired-db-file', `image-dired-temp-image-file', `image-dired-gallery-dir' `image-dired-temp-rotate-image-file', each evaluate `locate-user-emacs-file' when binding their default path values. There is something wrong about this. AFAIK `image-dired' isn't loaded by default. Why should _each_ of these variables elevate to creation of a `user-emacs-directory' if/when one doesn't already exit? By the time (require 'image-dired) gets evaluated shouldnt' `user-emacs-directory' already be well established? At best only `image-dired-dir' should need to to this and even then it is suspect. Maybe the rest of the do somethign more like: (make-directory (expand-file-name "some/path-for/image-dired-var" image-dired-dir)) or, respectively: (make-directory (expand-file-name "some/path-for/image-dired-var" image-dired-dir) t) Also, w/re those of the above variables which bind directory paths for a temporary files, e.g.: `image-dired-temp-image-file' and `image-dired-temp-rotate-image-file' Why not just use `temporary-file-directory' and/or `small-temporary-file-directory' as the base paths? -- /s_P\ From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 19:59:19 2010 Received: (at 7518) by debbugs.gnu.org; 5 Dec 2010 00:59:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP2wg-0005hU-WF for submit@debbugs.gnu.org; Sat, 04 Dec 2010 19:59:19 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP2wf-0005hJ-Q5 for 7518@debbugs.gnu.org; Sat, 04 Dec 2010 19:59:18 -0500 Received: from furball (dhcp128036014248.central.yale.edu [128.36.14.248]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB5155Gu012141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 4 Dec 2010 20:05:05 -0500 Received: by furball (Postfix, from userid 1000) id 348F716059F; Sat, 4 Dec 2010 20:05:05 -0500 (EST) From: Chong Yidong To: MON KEY Subject: Re: bug#7518: image-dired defcustom'd paths References: Date: Sat, 04 Dec 2010 20:05:05 -0500 In-Reply-To: (MON KEY's message of "Mon, 29 Nov 2010 19:40:59 -0500") Message-ID: <8762v9jagu.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7518 Cc: 7518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) MON KEY writes: > `image-dired-dir', `image-dired-db-file', > `image-dired-temp-image-file', `image-dired-gallery-dir' > `image-dired-temp-rotate-image-file', > > each evaluate `locate-user-emacs-file' when binding their default path > values. > > There is something wrong about this. > > AFAIK `image-dired' isn't loaded by default. Why should _each_ of > these variables elevate to creation of a `user-emacs-directory' > if/when one doesn't already exit? This sentence does not parse. The usage of locate-user-emacs-file in image-dired is correct, as far as I can tell. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 05 19:50:48 2010 Received: (at 7518) by debbugs.gnu.org; 6 Dec 2010 00:50:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPPI0-00069o-8p for submit@debbugs.gnu.org; Sun, 05 Dec 2010 19:50:48 -0500 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPPHy-00069c-ME for 7518@debbugs.gnu.org; Sun, 05 Dec 2010 19:50:47 -0500 Received: by wyf23 with SMTP id 23so10795978wyf.3 for <7518@debbugs.gnu.org>; Sun, 05 Dec 2010 16:56:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.181.76 with SMTP id k54mr1768091wem.58.1291596996856; Sun, 05 Dec 2010 16:56:36 -0800 (PST) Received: by 10.216.70.212 with HTTP; Sun, 5 Dec 2010 16:56:36 -0800 (PST) In-Reply-To: <8762v9jagu.fsf@stupidchicken.com> References: <8762v9jagu.fsf@stupidchicken.com> Date: Sun, 5 Dec 2010 19:56:36 -0500 X-Google-Sender-Auth: iiLzHTA4q9W0wcjoipfPaSrD_Z8 Message-ID: Subject: Re: bug#7518: image-dired defcustom'd paths From: MON KEY To: Chong Yidong Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 7518 Cc: 7518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) On Sat, Dec 4, 2010 at 8:05 PM, Chong Yidong wrote: > MON KEY writes: >> AFAIK `image-dired' isn't loaded by default. Why should _each_ of >> these variables elevate to creation of a `user-emacs-directory' >> if/when one doesn't already exit? > > This sentence does not parse. > >> Why should _each_ of these variables elevate to creation of a >> `user-emacs-directory' if/when one doesn't already exit? > `image-dired-dir' is the "top-level" defcustom from which other related `image-dired-*' vars derive their path default values. As such, only `image-dired-dir' need evaluate a form containing `locate-user-emacs-file' any other of the paths which "inherit" from `image-dired-dir' will either find an existing directoy already available or will incorrectly create one which may otherwise be separate from a user paths specified the in some other `image-dired-*' var. IOW, "hands of my directory tree image-dired!" Moreover, I would argue that none of the `image-dired-*' vars should be hardwired by default to `user-home-directory' not only is this non-transparently intrusive but it is potentially error prone on w32. Let the user explicitly specify a path for these instead if this is what is wanted. As an aside, none of the `image-dired-*' path customizations have :type specializations more specific than string so at the very least it isn't immediately clear that these vars are creat. > > The usage of locate-user-emacs-file in image-dired is correct, as far as > I can tell. > Maybe not. :) Most other packages don't operate this way to they? -- /s_P\ From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 14:41:11 2010 Received: (at 7518) by debbugs.gnu.org; 6 Dec 2010 19:41:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPgvv-00020z-ER for submit@debbugs.gnu.org; Mon, 06 Dec 2010 14:41:11 -0500 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPgvt-00020l-CS for 7518@debbugs.gnu.org; Mon, 06 Dec 2010 14:41:10 -0500 Received: from furball (dhcp128036014234.central.yale.edu [128.36.14.234]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB6Jl1bX021932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 6 Dec 2010 14:47:01 -0500 Received: by furball (Postfix, from userid 1000) id 6C7A9160C98; Mon, 6 Dec 2010 14:47:01 -0500 (EST) From: Chong Yidong To: MON KEY Subject: Re: bug#7518: image-dired defcustom'd paths References: <8762v9jagu.fsf@stupidchicken.com> Date: Mon, 06 Dec 2010 14:47:01 -0500 In-Reply-To: (MON KEY's message of "Sun, 5 Dec 2010 19:56:36 -0500") Message-ID: <87pqtek7ka.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7518 Cc: 7518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) MON KEY writes: > `image-dired-dir' is the "top-level" defcustom from which other related > `image-dired-*' vars derive their path default values. As such, only > `image-dired-dir' need evaluate a form containing `locate-user-emacs-file' > any other of the paths which "inherit" from `image-dired-dir' will either find > an existing directoy already available or will incorrectly create one which > may otherwise be separate from a user paths specified the in some other > `image-dired-*' var. If you mean that the other image-dired-* variables should use the value of image-dired-dir, that would be fine, and a little cleaner. I've committed such a change. Thanks. > Moreover, I would argue that none of the `image-dired-*' vars should > be hardwired by default to `user-home-directory' not only is this > non-transparently intrusive but it is potentially error prone on w32. If you encounter a problem with locate-user-emacs-dir on w32, report a different bug. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 14:42:09 2010 Received: (at control) by debbugs.gnu.org; 6 Dec 2010 19:42:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPgwr-00022X-Lf for submit@debbugs.gnu.org; Mon, 06 Dec 2010 14:42:09 -0500 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPgwp-00022B-Bx for control@debbugs.gnu.org; Mon, 06 Dec 2010 14:42:07 -0500 Received: from furball (dhcp128036014234.central.yale.edu [128.36.14.234]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB6Jm0k2017172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 6 Dec 2010 14:48:00 -0500 Received: by furball (Postfix, from userid 1000) id 46CCE160C98; Mon, 6 Dec 2010 14:48:00 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 7518 Date: Mon, 06 Dec 2010 14:48:00 -0500 Message-ID: <87lj42isy7.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 7518 thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 21:43:53 2010 Received: (at 7518) by debbugs.gnu.org; 7 Dec 2010 02:43:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPnWz-0006OO-Aw for submit@debbugs.gnu.org; Mon, 06 Dec 2010 21:43:53 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPnWx-0006OD-OB for 7518@debbugs.gnu.org; Mon, 06 Dec 2010 21:43:52 -0500 Received: by wwj40 with SMTP id 40so6321522wwj.15 for <7518@debbugs.gnu.org>; Mon, 06 Dec 2010 18:49:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.238.130 with SMTP id a2mr5843602wer.28.1291690184902; Mon, 06 Dec 2010 18:49:44 -0800 (PST) Received: by 10.216.70.212 with HTTP; Mon, 6 Dec 2010 18:49:44 -0800 (PST) In-Reply-To: <87pqtek7ka.fsf@stupidchicken.com> References: <8762v9jagu.fsf@stupidchicken.com> <87pqtek7ka.fsf@stupidchicken.com> Date: Mon, 6 Dec 2010 21:49:44 -0500 X-Google-Sender-Auth: 34MHCFpj4z0YOzBNbt-WbvXRMFA Message-ID: Subject: Re: bug#7518: image-dired defcustom'd paths From: MON KEY To: Chong Yidong Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 7518 Cc: 7518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) On Mon, Dec 6, 2010 at 2:47 PM, Chong Yidong wrote: > MON KEY writes: > If you mean that the other image-dired-* variables should use the value > of image-dired-dir, that would be fine, and a little cleaner. =C2=A0I've > committed such a change. =C2=A0Thanks. > Yes, this is what I was trying to get at. Thanks for taking the time to interpret Mon-ish. > > If you encounter a problem with locate-user-emacs-dir on w32, report a > different bug. > I'll keep an eye open once 24 rolls out (which is when I suspect it will rear its head again [-: ) -- /s_P\ From unknown Sat Jun 21 10:33:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator